René's URL Explorer Experiment


Title: fix signed overflow when multiplying array dimensions by Nussu06 · Pull Request #9027 · cppcheck-opensource/cppcheck · GitHub

Open Graph Title: fix signed overflow when multiplying array dimensions by Nussu06 · Pull Request #9027 · cppcheck-opensource/cppcheck

X Title: fix signed overflow when multiplying array dimensions by Nussu06 · Pull Request #9027 · cppcheck-opensource/cppcheck

Description: static analysis of C/C++ code. Contribute to cppcheck-opensource/cppcheck development by creating an account on GitHub.

Open Graph Description: CheckBufferOverrunImpl::getBufferSize, accumulateStructMembers (used by ValueType::getSizeOf) and setValues in clangimport multiply the array dimensions of a variable in MathLib::bigint without an ...

X Description: CheckBufferOverrunImpl::getBufferSize, accumulateStructMembers (used by ValueType::getSizeOf) and setValues in clangimport multiply the array dimensions of a variable in MathLib::bigint without an ...

Opengraph URL: https://github.com/cppcheck-opensource/cppcheck/pull/9027

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:563a7c78-5f5f-63e8-fba8-c375ab2c10b5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CCA:F7D6E:1B6300:2799AE:6AFC4ABA
html-safe-noncebb5630670465951224ecc3ff8fda6920d2aafdede4a619ea3ced3e885506e593
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0NBOkY3RDZFOjFCNjMwMDoyNzk5QUU6NkFGQzRBQkEiLCJ2aXNpdG9yX2lkIjoiMTQwMDg0NDE2ODUzMTI5OTAwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace2c7abebdf106575bf2dbc383be88f00ec1f1d0dfcef514dc4f3849687938db6
hovercard-subject-tagpull_request:5308112231
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/cppcheck-opensource/cppcheck/9027/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c706a2e8dd435caba008e579daa96cd33a9054b87a27283e3263a400b350bdfd/cppcheck-opensource/cppcheck/pull/9027
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c706a2e8dd435caba008e579daa96cd33a9054b87a27283e3263a400b350bdfd/cppcheck-opensource/cppcheck/pull/9027
og:image:altCheckBufferOverrunImpl::getBufferSize, accumulateStructMembers (used by ValueType::getSizeOf) and setValues in clangimport multiply the array dimensions of a variable in MathLib::bigint without an ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameNussu06
hostnamegithub.com
expected-hostnamegithub.com
None20dfdada12bc00bbf8065dc10dfe3ff3711b85db5cc117f83296f8074e861960
turbo-cache-controlno-cache
go-importgithub.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git
octolytics-dimension-user_id278097703
octolytics-dimension-user_logincppcheck-opensource
octolytics-dimension-repository_id143131
octolytics-dimension-repository_nwocppcheck-opensource/cppcheck
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143131
octolytics-dimension-repository_network_root_nwocppcheck-opensource/cppcheck
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release041909865f220ab51714e7efdc276dd349a99ade
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/cppcheck-opensource/cppcheck/pull/9027#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F9027
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F9027
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=cppcheck-opensource%2Fcppcheck
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/9027
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/9027
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/9027
cppcheck-opensourcehttps://github.com/cppcheck-opensource
cppcheckhttps://github.com/cppcheck-opensource/cppcheck
Codehttps://github.com/cppcheck-opensource/cppcheck
Pull requests222 (222)https://github.com/cppcheck-opensource/cppcheck/pulls
Actionshttps://github.com/cppcheck-opensource/cppcheck/actions
Security and qualityhttps://github.com/cppcheck-opensource/cppcheck/security
Insightshttps://github.com/cppcheck-opensource/cppcheck/pulse
https://github.com/cppcheck-opensource/cppcheck
Nussu06https://github.com/Nussu06
cppcheck-opensource:mainhttps://github.com/cppcheck-opensource/cppcheck/tree/main
Nussu06:array-dimensions-overflowhttps://github.com/Nussu06/cppcheck/tree/array-dimensions-overflow
Conversationhttps://github.com/cppcheck-opensource/cppcheck/pull/9027
Commits2 (2)https://github.com/cppcheck-opensource/cppcheck/pull/9027/commits
Checkshttps://github.com/cppcheck-opensource/cppcheck/pull/9027/checks
Files changedhttps://github.com/cppcheck-opensource/cppcheck/pull/9027/files
fix signed overflow when multiplying array dimensionshttps://github.com/cppcheck-opensource/cppcheck/pull/9027#top
Nussu06https://github.com/Nussu06
cppcheck-opensource:mainhttps://github.com/cppcheck-opensource/cppcheck/tree/main
Nussu06:array-dimensions-overflowhttps://github.com/Nussu06/cppcheck/tree/array-dimensions-overflow
https://github.com/Nussu06
Nussu06https://github.com/Nussu06
Nov 14, 2026https://github.com/cppcheck-opensource/cppcheck/pull/9027#issue-6386205579
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9027
https://github.com/Nussu06
fix signed overflow when multiplying array dimensionshttps://github.com/cppcheck-opensource/cppcheck/pull/9027/commits/e208afcd492977b8d9e71ba99e4549a09802aadd
e208afchttps://github.com/cppcheck-opensource/cppcheck/pull/9027/commits/e208afcd492977b8d9e71ba99e4549a09802aadd
https://github.com/dmcppcheck
dmcppcheckhttps://github.com/dmcppcheck
Nov 14, 2026https://github.com/cppcheck-opensource/cppcheck/pull/9027#issuecomment-6873491077
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9027
https://github.com/Nussu06
Nussu06https://github.com/Nussu06
Nov 14, 2026https://github.com/cppcheck-opensource/cppcheck/pull/9027#issuecomment-6880658973
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9027
https://github.com/dmcppcheck
dmcppcheckhttps://github.com/dmcppcheck
Nov 14, 2026 https://github.com/cppcheck-opensource/cppcheck/pull/9027#pullrequestreview-5907367551
View reviewed changes https://github.com/cppcheck-opensource/cppcheck/pull/9027/files/e208afcd492977b8d9e71ba99e4549a09802aadd
dmcppcheckhttps://github.com/dmcppcheck
https://github.com/cppcheck-opensource/cppcheck/pull/9027#pullrequestreview-5907367551
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
e208afchttps://github.com/cppcheck-opensource/cppcheck/commit/e208afcd492977b8d9e71ba99e4549a09802aadd
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9027
lib/checkbufferoverrun.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/9027/files/e208afcd492977b8d9e71ba99e4549a09802aadd#diff-d584d9f2aa837baffb3919d3638820a0642225a96cfa8f8766cba5b6e21a8182
dmcppcheckhttps://github.com/dmcppcheck
Nov 14, 2026https://github.com/cppcheck-opensource/cppcheck/pull/9027#discussion_r4575830186
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9027
lib/symboldatabase.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/9027/files/e208afcd492977b8d9e71ba99e4549a09802aadd#diff-304f15dd3a4d25ecfae37990291a91ca66aecd56342bcf2979c102afa4da262d
dmcppcheckhttps://github.com/dmcppcheck
Nov 14, 2026https://github.com/cppcheck-opensource/cppcheck/pull/9027#discussion_r4575830190
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9027
lib/clangimport.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/9027/files/e208afcd492977b8d9e71ba99e4549a09802aadd#diff-dabf979b8bb2c063fa6c677f577d1384c0fa514681ed04d80a44e1f8ea5ba3fd
dmcppcheckhttps://github.com/dmcppcheck
Nov 14, 2026https://github.com/cppcheck-opensource/cppcheck/pull/9027#discussion_r4575830194
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9027
https://github.com/dmcppcheck
dmcppcheckhttps://github.com/dmcppcheck
Nov 15, 2026https://github.com/cppcheck-opensource/cppcheck/pull/9027#issuecomment-6890123586
e208afchttps://github.com/cppcheck-opensource/cppcheck/commit/e208afcd492977b8d9e71ba99e4549a09802aadd
http://ec2-16-170-140-253.eu-north-1.compute.amazonaws.com/pr-9027/http://ec2-16-170-140-253.eu-north-1.compute.amazonaws.com/pr-9027/
http://ec2-16-170-140-253.eu-north-1.compute.amazonaws.com/pr-9027/2026-11-14_06-15-12-e208afcd4929_timing.htmlhttp://ec2-16-170-140-253.eu-north-1.compute.amazonaws.com/pr-9027/2026-11-14_06-15-12-e208afcd4929_timing.html
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9027
https://github.com/Nussu06
check the array byte size for overflow too and share mulOverflowshttps://github.com/cppcheck-opensource/cppcheck/pull/9027/commits/1906bfaf48e6da6a7244ff8df9f1b482a4ed9860
1906bfahttps://github.com/cppcheck-opensource/cppcheck/pull/9027/commits/1906bfaf48e6da6a7244ff8df9f1b482a4ed9860
https://github.com/Nussu06
Nussu06https://github.com/Nussu06
Nov 15, 2026https://github.com/cppcheck-opensource/cppcheck/pull/9027#issuecomment-6897812087
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9027
https://github.com/dmcppcheck
dmcppcheckhttps://github.com/dmcppcheck
Nov 16, 2026https://github.com/cppcheck-opensource/cppcheck/pull/9027#issuecomment-6923336368
1906bfahttps://github.com/cppcheck-opensource/cppcheck/commit/1906bfaf48e6da6a7244ff8df9f1b482a4ed9860
http://ec2-16-170-140-253.eu-north-1.compute.amazonaws.com/pr-9027/http://ec2-16-170-140-253.eu-north-1.compute.amazonaws.com/pr-9027/
http://ec2-16-170-140-253.eu-north-1.compute.amazonaws.com/pr-9027/2026-11-15_16-41-39-1906bfaf48e6_timing.htmlhttp://ec2-16-170-140-253.eu-north-1.compute.amazonaws.com/pr-9027/2026-11-15_16-41-39-1906bfaf48e6_timing.html
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9027
https://github.com/dmcppcheck
dmcppcheckhttps://github.com/dmcppcheck
Nov 16, 2026 https://github.com/cppcheck-opensource/cppcheck/pull/9027#pullrequestreview-5924587789
View reviewed changes https://github.com/cppcheck-opensource/cppcheck/pull/9027/files/1906bfaf48e6da6a7244ff8df9f1b482a4ed9860
dmcppcheckhttps://github.com/dmcppcheck
https://github.com/cppcheck-opensource/cppcheck/pull/9027#pullrequestreview-5924587789
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
PR needs a trac ticket and the title should reference ithttps://github.com/cppcheck-opensource/cppcheck/pull/9027#issuecomment-6873491077
@dmcppcheckhttps://github.com/dmcppcheck
Byte size (count * element size) can still wrap, so false positives remain for int elementshttps://github.com/cppcheck-opensource/cppcheck/pull/9027#pullrequestreview-5907367551
New overflow check duplicates the existing mulOverflows()https://github.com/cppcheck-opensource/cppcheck/pull/9027#pullrequestreview-5907367551
getBufferSize: (dim - index) * typeSize is not checked for overflowhttps://github.com/cppcheck-opensource/cppcheck/pull/9027#discussion_r4575830186
accHelper n *= dim can wrap; sizeof(struct U {int m[...]}) is folded to 4https://github.com/cppcheck-opensource/cppcheck/pull/9027#discussion_r4575830190
clangimport: mul * getSizeOf and += into typeSize are not checkedhttps://github.com/cppcheck-opensource/cppcheck/pull/9027#discussion_r4575830194
@Nussu06https://github.com/Nussu06
1906bfahttps://github.com/cppcheck-opensource/cppcheck/commit/1906bfaf48e6da6a7244ff8df9f1b482a4ed9860
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9027
lib/symboldatabase.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/9027/files/1906bfaf48e6da6a7244ff8df9f1b482a4ed9860#diff-304f15dd3a4d25ecfae37990291a91ca66aecd56342bcf2979c102afa4da262d
dmcppcheckhttps://github.com/dmcppcheck
Nov 16, 2026https://github.com/cppcheck-opensource/cppcheck/pull/9027#discussion_r4589262346
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9027
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F9027
https://github.com/dmcppcheck
dmcppcheck https://github.com/dmcppcheck
https://github.com/cppcheck-opensource/cppcheck/pull/9027/files/1906bfaf48e6da6a7244ff8df9f1b482a4ed9860
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9027
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/9027
https://github.com/Nussu06
https://github.com/dmcppcheck
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.