Title: Fix #12266 (Performance: valueFlowCondition slowdown) by danmar · Pull Request #5837 · cppcheck-opensource/cppcheck · GitHub
Open Graph Title: Fix #12266 (Performance: valueFlowCondition slowdown) by danmar · Pull Request #5837 · cppcheck-opensource/cppcheck
X Title: Fix #12266 (Performance: valueFlowCondition slowdown) by danmar · Pull Request #5837 · cppcheck-opensource/cppcheck
Description: I have executed test-my-pr.py on 532 packages number of "main" warnings: egrep -v valueFlow my_check_diff.log | egrep "^main " | wc -l 277 number of "your" warnings (genomicepidemiology-kma timed out without these changes): egrep -v valueFlow my_check_diff.log | egrep "^your " | egrep -v genomicepidemiology-kma | wc -l 90 => There are some false negatives. But it's rougly ~ 190 in 532 packages.. so it's not a major problem imho. I can see a speedup. For the packages that took more than 1 second to analyze the timing factor was: $ egrep -v " 0.[0-9][0-9] " my_check_diff_timing.log | sed 's/.* //' | egrep -v Factor | sort 0.04 0.08 0.10 0.10 0.13 0.18 0.19 0.20 0.21 0.21 0.23 0.24 0.25 0.26 0.26 0.27 0.28 0.28 0.29 0.31 0.31 0.31 0.31 0.31 0.32 0.33 0.34 0.35 0.35 0.35 0.37 0.37 0.38 0.39 0.39 0.40 0.42 0.42 0.43 0.43 0.44 0.44 0.44 0.45 0.46 0.46 0.46 0.46 0.46 0.47 0.48 0.49 0.49 0.50 0.50 0.50 0.50 0.50 0.51 0.51 0.51 0.52 0.52 0.52 0.52 0.54 0.54 0.54 0.54 0.54 0.55 0.56 0.56 0.56 0.56 0.56 0.57 0.57 0.57 0.57 0.58 0.58 0.58 0.59 0.59 0.59 0.60 0.61 0.61 0.61 0.62 0.62 0.62 0.62 0.63 0.63 0.63 0.63 0.63 0.64 0.65 0.65 0.65 0.65 0.65 0.65 0.65 0.65 0.65 0.65 0.66 0.66 0.66 0.67 0.67 0.67 0.67 0.68 0.68 0.69 0.69 0.69 0.69 0.69 0.70 0.70 0.70 0.70 0.70 0.71 0.71 0.71 0.72 0.73 0.73 0.73 0.73 0.73 0.73 0.73 0.74 0.75 0.75 0.75 0.75 0.75 0.75 0.75 0.75 0.75 0.75 0.76 0.76 0.76 0.76 0.76 0.77 0.77 0.77 0.77 0.78 0.78 0.78 0.78 0.79 0.79 0.79 0.80 0.80 0.80 0.80 0.80 0.80 0.80 0.80 0.81 0.81 0.82 0.82 0.82 0.82 0.82 0.83 0.83 0.83 0.84 0.84 0.84 0.84 0.85 0.85 0.85 0.85 0.86 0.86 0.86 0.86 0.86 0.86 0.86 0.86 0.87 0.88 0.88 0.88 0.89 0.89 0.89 0.90 0.90 0.90 0.90 0.90 0.90 0.90 0.90 0.91 0.91 0.92 0.92 0.92 0.93 0.93 0.93 0.93 0.94 0.94 0.95 0.95 0.96 0.96 0.96 0.96 0.97 0.97 0.97 0.97 0.99 0.99 0.99 1.00 1.00 1.00 1.01
Open Graph Description: I have executed test-my-pr.py on 532 packages number of "main" warnings: egrep -v valueFlow my_check_diff.log | egrep "^main " | wc -l 277 number of "your" warnings (...
X Description: I have executed test-my-pr.py on 532 packages number of "main" warnings: egrep -v valueFlow my_check_diff.log | egrep "^main " | wc -l 277 number of "y...
Opengraph URL: https://github.com/cppcheck-opensource/cppcheck/pull/5837
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f9b27b82-20c0-d7cb-bf78-6cdba920b430 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A54C:B97C3:3568CFD:4980E2F:6A4F317B |
| html-safe-nonce | a0588423396f4b7a9fbe2cf8702f55c0a2bc5ed0fc506f3d141a8fa8232cd0cb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTRDOkI5N0MzOjM1NjhDRkQ6NDk4MEUyRjo2QTRGMzE3QiIsInZpc2l0b3JfaWQiOiIyNzkzNzE5NDQwMDUwNDM0NDI3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9253c864292a1ab1468b4fa173687cd27feca82f52a03efd9158e1cbe4db78fd |
| hovercard-subject-tag | pull_request:1666039468 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/cppcheck-opensource/cppcheck/pull/5837/files |
| twitter:image | https://avatars.githubusercontent.com/u/60195?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/60195?s=400&v=4 |
| og:image:alt | I have executed test-my-pr.py on 532 packages number of "main" warnings: egrep -v valueFlow my_check_diff.log | egrep "^main " | wc -l 277 number of "your" warnings (... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git |
| octolytics-dimension-user_id | 278097703 |
| octolytics-dimension-user_login | cppcheck-opensource |
| octolytics-dimension-repository_id | 143131 |
| octolytics-dimension-repository_nwo | cppcheck-opensource/cppcheck |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143131 |
| octolytics-dimension-repository_network_root_nwo | cppcheck-opensource/cppcheck |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width