René's URL Explorer Experiment


Title: Do not crash on GUI shutdown by ntfshard · Pull Request #5288 · cppcheck-opensource/cppcheck · GitHub

Open Graph Title: Do not crash on GUI shutdown by ntfshard · Pull Request #5288 · cppcheck-opensource/cppcheck

X Title: Do not crash on GUI shutdown by ntfshard · Pull Request #5288 · cppcheck-opensource/cppcheck

Description: Seems current code for worker threads termination is too brutal which leads to crash on termination: QThread::start: Thread termination error: No such process Segmentation fault (core dumped) Seems better to use quit() and wait(), like in an example: https://doc.qt.io/qt-6/qthread.html#details tested: Ubuntu Linux 20

Open Graph Description: Seems current code for worker threads termination is too brutal which leads to crash on termination: QThread::start: Thread termination error: No such process Segmentation fault (core dumped) Seem...

X Description: Seems current code for worker threads termination is too brutal which leads to crash on termination: QThread::start: Thread termination error: No such process Segmentation fault (core dumped) Seem...

Opengraph URL: https://github.com/cppcheck-opensource/cppcheck/pull/5288

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3ff87513-728e-0e20-d323-772e31362adc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8ABE:FDB96:5F3A51:7F0005:6A518F3D
html-safe-nonce67615c63f44bedee15ea16eacff100174e3f074d808a1476405a6b751d81dceb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUJFOkZEQjk2OjVGM0E1MTo3RjAwMDU6NkE1MThGM0QiLCJ2aXNpdG9yX2lkIjoiODg1MzA3MTk3OTk5MDg0NzI5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac90089827ff4dd17d0322751c657c576e9e77311b0e339d1757a9e0621339db66
hovercard-subject-tagpull_request:1459675058
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/cppcheck-opensource/cppcheck/pull/5288/files
twitter:imagehttps://avatars.githubusercontent.com/u/4844306?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4844306?s=400&v=4
og:image:altSeems current code for worker threads termination is too brutal which leads to crash on termination: QThread::start: Thread termination error: No such process Segmentation fault (core dumped) Seem...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git
octolytics-dimension-user_id278097703
octolytics-dimension-user_logincppcheck-opensource
octolytics-dimension-repository_id143131
octolytics-dimension-repository_nwocppcheck-opensource/cppcheck
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143131
octolytics-dimension-repository_network_root_nwocppcheck-opensource/cppcheck
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/cppcheck-opensource/cppcheck/pull/5288/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F5288%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F5288%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=cppcheck-opensource%2Fcppcheck
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/5288/files
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/5288/files
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/5288/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/5288/files
cppcheck-opensource https://github.com/cppcheck-opensource
cppcheckhttps://github.com/cppcheck-opensource/cppcheck
Notifications https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Fork 1.6k https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Star 6.7k https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Code https://github.com/cppcheck-opensource/cppcheck
Pull requests 204 https://github.com/cppcheck-opensource/cppcheck/pulls
Actions https://github.com/cppcheck-opensource/cppcheck/actions
Security and quality 0 https://github.com/cppcheck-opensource/cppcheck/security
Insights https://github.com/cppcheck-opensource/cppcheck/pulse
Code https://github.com/cppcheck-opensource/cppcheck
Pull requests https://github.com/cppcheck-opensource/cppcheck/pulls
Actions https://github.com/cppcheck-opensource/cppcheck/actions
Security and quality https://github.com/cppcheck-opensource/cppcheck/security
Insights https://github.com/cppcheck-opensource/cppcheck/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fcppcheck-opensource%2Fcppcheck%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck%2Fissues%2Fnew%2Fchoose
chrchr-githubhttps://github.com/chrchr-github
cppcheck-opensource:mainhttps://github.com/cppcheck-opensource/cppcheck/tree/main
ntfshard:md/guigracefulthreadshutdownhttps://github.com/ntfshard/cppcheck/tree/md/guigracefulthreadshutdown
Conversation 10 https://github.com/cppcheck-opensource/cppcheck/pull/5288
Commits 2 https://github.com/cppcheck-opensource/cppcheck/pull/5288/commits
Checks 0 https://github.com/cppcheck-opensource/cppcheck/pull/5288/checks
Files changed https://github.com/cppcheck-opensource/cppcheck/pull/5288/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/5288/files
Do not crash on GUI shutdown https://github.com/cppcheck-opensource/cppcheck/pull/5288/files#top
Show all changes 2 commits https://github.com/cppcheck-opensource/cppcheck/pull/5288/files
b36cd3d Graceful thread shutdown in GUI ntfshard Aug 2, 2023 https://github.com/cppcheck-opensource/cppcheck/pull/5288/commits/b36cd3db4bd6650a76215d721720ae8c56359956
fbc3a79 Review iteration ntfshard Aug 2, 2023 https://github.com/cppcheck-opensource/cppcheck/pull/5288/commits/fbc3a79c4408d6455376fffbad0a2afbe2a27398
Clear filters https://github.com/cppcheck-opensource/cppcheck/pull/5288/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/5288/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/5288/files
checkthread.h https://github.com/cppcheck-opensource/cppcheck/pull/5288/files#diff-4a4d75de5f77cfd94117c00517c5429ee8074a84c344a13a8301ff723484eca2
threadhandler.cpp https://github.com/cppcheck-opensource/cppcheck/pull/5288/files#diff-ff6b460bdc046c9da63fefbb1fb9556ec6dbbd88ed82302947002d74b8a938bf
gui/checkthread.hhttps://github.com/cppcheck-opensource/cppcheck/pull/5288/files#diff-4a4d75de5f77cfd94117c00517c5429ee8074a84c344a13a8301ff723484eca2
View file https://github.com/ntfshard/cppcheck/blob/fbc3a79c4408d6455376fffbad0a2afbe2a27398/gui/checkthread.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/5288/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/5288/files#diff-4a4d75de5f77cfd94117c00517c5429ee8074a84c344a13a8301ff723484eca2
https://github.com/cppcheck-opensource/cppcheck/pull/5288/files#diff-4a4d75de5f77cfd94117c00517c5429ee8074a84c344a13a8301ff723484eca2
https://github.com/cppcheck-opensource/cppcheck/pull/5288/files#diff-4a4d75de5f77cfd94117c00517c5429ee8074a84c344a13a8301ff723484eca2
https://github.com/cppcheck-opensource/cppcheck/pull/5288/files#diff-4a4d75de5f77cfd94117c00517c5429ee8074a84c344a13a8301ff723484eca2
gui/threadhandler.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/5288/files#diff-ff6b460bdc046c9da63fefbb1fb9556ec6dbbd88ed82302947002d74b8a938bf
View file https://github.com/ntfshard/cppcheck/blob/fbc3a79c4408d6455376fffbad0a2afbe2a27398/gui/threadhandler.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/5288/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/5288/files#diff-ff6b460bdc046c9da63fefbb1fb9556ec6dbbd88ed82302947002d74b8a938bf
https://github.com/cppcheck-opensource/cppcheck/pull/5288/files#diff-ff6b460bdc046c9da63fefbb1fb9556ec6dbbd88ed82302947002d74b8a938bf
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.