René's URL Explorer Experiment


Title: report `internalError` when command execution returns errorcode / also some related cleanups and tests by firewave · Pull Request #5037 · cppcheck-opensource/cppcheck · GitHub

Open Graph Title: report `internalError` when command execution returns errorcode / also some related cleanups and tests by firewave · Pull Request #5037 · cppcheck-opensource/cppcheck

X Title: report `internalError` when command execution returns errorcode / also some related cleanups and tests by firewave · Pull Request #5037 · cppcheck-opensource/cppcheck

Description: Encountered while investigating https://trac.cppcheck.net/ticket/11708. This has been like this since the introduction of internalError in b6bcdf2 (almost ten years ago to the day). Logging internal errors which bail out(!) of the analysis simply to std::cout for them possibly never to be seen (and also not affected the exitcode) is pretty bad IMO. They should always be visible. I also removed the filename from the message as it is already available (and thus redundant) and its existence should be defined by the template.

Open Graph Description: Encountered while investigating https://trac.cppcheck.net/ticket/11708. This has been like this since the introduction of internalError in b6bcdf2 (almost ten years ago to the day). Logging interna...

X Description: Encountered while investigating https://trac.cppcheck.net/ticket/11708. This has been like this since the introduction of internalError in b6bcdf2 (almost ten years ago to the day). Logging interna...

Opengraph URL: https://github.com/cppcheck-opensource/cppcheck/pull/5037

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:deb141dc-8587-5882-92ed-f11413946f9a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA442:203A29:EAEB7D:13F95A8:6A5200F9
html-safe-nonce612a175596385a0fe0654758660443cdc4fd26334c104590cc4b1c10737e33ea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDQyOjIwM0EyOTpFQUVCN0Q6MTNGOTVBODo2QTUyMDBGOSIsInZpc2l0b3JfaWQiOiIyODU4NDg2MTIwOTQ1MTU2MzQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4f9d8955aba2e83b1c79984588f64c1a163e9282ac71e03bbe47ec457c972f91
hovercard-subject-tagpull_request:1338998168
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/cppcheck-opensource/cppcheck/pull/5037/files
twitter:imagehttps://avatars.githubusercontent.com/u/242857?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/242857?s=400&v=4
og:image:altEncountered while investigating https://trac.cppcheck.net/ticket/11708. This has been like this since the introduction of internalError in b6bcdf2 (almost ten years ago to the day). Logging interna...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git
octolytics-dimension-user_id278097703
octolytics-dimension-user_logincppcheck-opensource
octolytics-dimension-repository_id143131
octolytics-dimension-repository_nwocppcheck-opensource/cppcheck
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143131
octolytics-dimension-repository_network_root_nwocppcheck-opensource/cppcheck
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/cppcheck-opensource/cppcheck/pull/5037/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F5037%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F5037%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=cppcheck-opensource%2Fcppcheck
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/5037/files
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/5037/files
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/5037/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/5037/files
cppcheck-opensource https://github.com/cppcheck-opensource
cppcheckhttps://github.com/cppcheck-opensource/cppcheck
Notifications https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Fork 1.6k https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Star 6.7k https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Code https://github.com/cppcheck-opensource/cppcheck
Pull requests 204 https://github.com/cppcheck-opensource/cppcheck/pulls
Actions https://github.com/cppcheck-opensource/cppcheck/actions
Security and quality 0 https://github.com/cppcheck-opensource/cppcheck/security
Insights https://github.com/cppcheck-opensource/cppcheck/pulse
Code https://github.com/cppcheck-opensource/cppcheck
Pull requests https://github.com/cppcheck-opensource/cppcheck/pulls
Actions https://github.com/cppcheck-opensource/cppcheck/actions
Security and quality https://github.com/cppcheck-opensource/cppcheck/security
Insights https://github.com/cppcheck-opensource/cppcheck/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fcppcheck-opensource%2Fcppcheck%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck%2Fissues%2Fnew%2Fchoose
danmarhttps://github.com/danmar
cppcheck-opensource:mainhttps://github.com/cppcheck-opensource/cppcheck/tree/main
firewave:internalerrorhttps://github.com/firewave/cppcheck/tree/internalerror
Conversation 7 https://github.com/cppcheck-opensource/cppcheck/pull/5037
Commits 8 https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits
Checks 0 https://github.com/cppcheck-opensource/cppcheck/pull/5037/checks
Files changed https://github.com/cppcheck-opensource/cppcheck/pull/5037/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/5037/files
report internalError when command execution returns errorcode / also some related cleanups and tests https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#top
Show all changes 8 commits https://github.com/cppcheck-opensource/cppcheck/pull/5037/files
9b26f95 do not arbitrarily decide if an `internalError` should fail the analysis firewave May 4, 2023 https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/9b26f957cb9739d13a3a9f2d6a976d0f774ae060
952ffc1 cleaned up `internalError` messages firewave May 4, 2023 https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/952ffc11c11b797cd2ee36dc2d6d1323c507bee0
29d4ba1 extracted creation of `ErrorMessage` from `InternalError` to `ErrorMe… firewave May 4, 2023 https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/29d4ba164519db3180949d0e93bc861e1f3ba452
2897633 test/cli/testutils.py: added `env` parameter to `cppcheck()` firewave May 6, 2023 https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/2897633fa78a691bb7747675ca4e77e5a32cf227
c7fd7ab test/cli/test-other.py: added some tests to test addon execution failure firewave May 6, 2023 https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/c7fd7ab9b7600f9e63788812b1d6e61a92c5e46d
b18f25f test/cli/test-other.py: added a test for `internalError` firewave May 6, 2023 https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/b18f25ff986b46b8cd935d0ddd0650c65553d8cb
0dc4aeb CppCheck: added hack to Python auto-detection to avoid debug assertio… firewave Aug 29, 2023 https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/0dc4aeb053bb9e45af87bb0c7050b23cdcda142e
2e2c453 CppCheckExecutor: get rid of unnecessary RAII cleanup in `executeComm… firewave Aug 29, 2023 https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/2e2c453af8e1848a7e508233f4f939b3ad21b1ce
Clear filters https://github.com/cppcheck-opensource/cppcheck/pull/5037/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/5037/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/5037/files
cppcheckexecutor.cpp https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-f4d43c3baf8c85745069cdf61a4022d74c2ef7775edf71106faf22f718644fed
cppcheck.cpp https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-925c3b2fbb05c80e182f2b91beeddbec52d71b834acdff75f1e08c54ef47bfff
errorlogger.cpp https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-7efe3f6cfedd044c82abaa7d7595b3be1a501c18211cfd9273016c713eb115c6
errorlogger.h https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-d662d3e5b25ed18893dc7fbcfeceea530e06f3b202e54d47bf99f13cdb2fafe8
releasenotes.txt https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-60116afb0cb9bf1c0d7b20af08977561b4cf54fc176dfa33adaf9c042b0dca42
test-other.py https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-9be7d6b6f27c18eb47eb630bb487dd0dfc942272b62c7d31ed4fbe81743d5cd7
testutils.py https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-c7b0e102abffee906c164a0921798ab028d935ba997b34d551f03a15bee70ff6
cli/cppcheckexecutor.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-f4d43c3baf8c85745069cdf61a4022d74c2ef7775edf71106faf22f718644fed
View file https://github.com/firewave/cppcheck/blob/2e2c453af8e1848a7e508233f4f939b3ad21b1ce/cli/cppcheckexecutor.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/5037/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-f4d43c3baf8c85745069cdf61a4022d74c2ef7775edf71106faf22f718644fed
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-f4d43c3baf8c85745069cdf61a4022d74c2ef7775edf71106faf22f718644fed
lib/cppcheck.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-925c3b2fbb05c80e182f2b91beeddbec52d71b834acdff75f1e08c54ef47bfff
View file https://github.com/firewave/cppcheck/blob/2e2c453af8e1848a7e508233f4f939b3ad21b1ce/lib/cppcheck.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/5037/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-925c3b2fbb05c80e182f2b91beeddbec52d71b834acdff75f1e08c54ef47bfff
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-925c3b2fbb05c80e182f2b91beeddbec52d71b834acdff75f1e08c54ef47bfff
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-925c3b2fbb05c80e182f2b91beeddbec52d71b834acdff75f1e08c54ef47bfff
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-925c3b2fbb05c80e182f2b91beeddbec52d71b834acdff75f1e08c54ef47bfff
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-925c3b2fbb05c80e182f2b91beeddbec52d71b834acdff75f1e08c54ef47bfff
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-925c3b2fbb05c80e182f2b91beeddbec52d71b834acdff75f1e08c54ef47bfff
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-925c3b2fbb05c80e182f2b91beeddbec52d71b834acdff75f1e08c54ef47bfff
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-925c3b2fbb05c80e182f2b91beeddbec52d71b834acdff75f1e08c54ef47bfff
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-925c3b2fbb05c80e182f2b91beeddbec52d71b834acdff75f1e08c54ef47bfff
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-925c3b2fbb05c80e182f2b91beeddbec52d71b834acdff75f1e08c54ef47bfff
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-925c3b2fbb05c80e182f2b91beeddbec52d71b834acdff75f1e08c54ef47bfff
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-925c3b2fbb05c80e182f2b91beeddbec52d71b834acdff75f1e08c54ef47bfff
lib/errorlogger.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-7efe3f6cfedd044c82abaa7d7595b3be1a501c18211cfd9273016c713eb115c6
View file https://github.com/firewave/cppcheck/blob/2e2c453af8e1848a7e508233f4f939b3ad21b1ce/lib/errorlogger.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/5037/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-7efe3f6cfedd044c82abaa7d7595b3be1a501c18211cfd9273016c713eb115c6
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-7efe3f6cfedd044c82abaa7d7595b3be1a501c18211cfd9273016c713eb115c6
lib/errorlogger.hhttps://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-d662d3e5b25ed18893dc7fbcfeceea530e06f3b202e54d47bf99f13cdb2fafe8
View file https://github.com/firewave/cppcheck/blob/2e2c453af8e1848a7e508233f4f939b3ad21b1ce/lib/errorlogger.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/5037/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-d662d3e5b25ed18893dc7fbcfeceea530e06f3b202e54d47bf99f13cdb2fafe8
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-d662d3e5b25ed18893dc7fbcfeceea530e06f3b202e54d47bf99f13cdb2fafe8
releasenotes.txthttps://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-60116afb0cb9bf1c0d7b20af08977561b4cf54fc176dfa33adaf9c042b0dca42
View file https://github.com/firewave/cppcheck/blob/2e2c453af8e1848a7e508233f4f939b3ad21b1ce/releasenotes.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/5037/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-60116afb0cb9bf1c0d7b20af08977561b4cf54fc176dfa33adaf9c042b0dca42
test/cli/test-other.pyhttps://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-9be7d6b6f27c18eb47eb630bb487dd0dfc942272b62c7d31ed4fbe81743d5cd7
View file https://github.com/firewave/cppcheck/blob/2e2c453af8e1848a7e508233f4f939b3ad21b1ce/test/cli/test-other.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/5037/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-9be7d6b6f27c18eb47eb630bb487dd0dfc942272b62c7d31ed4fbe81743d5cd7
test/cli/testutils.pyhttps://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-c7b0e102abffee906c164a0921798ab028d935ba997b34d551f03a15bee70ff6
View file https://github.com/firewave/cppcheck/blob/2e2c453af8e1848a7e508233f4f939b3ad21b1ce/test/cli/testutils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/5037/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-c7b0e102abffee906c164a0921798ab028d935ba997b34d551f03a15bee70ff6
https://github.com/cppcheck-opensource/cppcheck/pull/5037/files#diff-c7b0e102abffee906c164a0921798ab028d935ba997b34d551f03a15bee70ff6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.