René's URL Explorer Experiment


Title: report `internalError` when command execution returns errorcode / also some related cleanups and tests by firewave · Pull Request #5037 · cppcheck-opensource/cppcheck · GitHub

Open Graph Title: report `internalError` when command execution returns errorcode / also some related cleanups and tests by firewave · Pull Request #5037 · cppcheck-opensource/cppcheck

X Title: report `internalError` when command execution returns errorcode / also some related cleanups and tests by firewave · Pull Request #5037 · cppcheck-opensource/cppcheck

Description: static analysis of C/C++ code. Contribute to cppcheck-opensource/cppcheck development by creating an account on GitHub.

Open Graph Description: Encountered while investigating https://trac.cppcheck.net/ticket/11708. This has been like this since the introduction of internalError in b6bcdf2 (almost ten years ago to the day). Logging interna...

X Description: Encountered while investigating https://trac.cppcheck.net/ticket/11708. This has been like this since the introduction of internalError in b6bcdf2 (almost ten years ago to the day). Logging interna...

Opengraph URL: https://github.com/cppcheck-opensource/cppcheck/pull/5037

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:2b8d5548-1bd0-086e-25fe-312baf5b72da
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD526:9B27A:239BE13:2F458D5:6A520559
html-safe-nonceef6a8f1a0d0bbfe4676935e57f43cca6fe4085299c94bda845f941d0e3593aa9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTI2OjlCMjdBOjIzOUJFMTM6MkY0NThENTo2QTUyMDU1OSIsInZpc2l0b3JfaWQiOiIxNTgyNjQzNTM3MDkwMDUzNDY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac60abd307b08a4919321344d0fb475ce5a0a4bbb7654cf8e43d03531ad70b76f3
hovercard-subject-tagpull_request:1338998168
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits
twitter:imagehttps://opengraph.githubassets.com/39b3d9caa56150942792dd48fa3de158214ac0c1c2e7ab89a1bc33b2b48a52c9/cppcheck-opensource/cppcheck/pull/5037
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/39b3d9caa56150942792dd48fa3de158214ac0c1c2e7ab89a1bc33b2b48a52c9/cppcheck-opensource/cppcheck/pull/5037
og:image:altEncountered while investigating https://trac.cppcheck.net/ticket/11708. This has been like this since the introduction of internalError in b6bcdf2 (almost ten years ago to the day). Logging interna...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefirewave
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git
octolytics-dimension-user_id278097703
octolytics-dimension-user_logincppcheck-opensource
octolytics-dimension-repository_id143131
octolytics-dimension-repository_nwocppcheck-opensource/cppcheck
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143131
octolytics-dimension-repository_network_root_nwocppcheck-opensource/cppcheck
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/cppcheck-opensource/cppcheck/pull/5037/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F5037%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F5037%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=cppcheck-opensource%2Fcppcheck
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/5037/commits
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/5037/commits
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/5037/commits
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/5037/commits
cppcheck-opensource https://github.com/cppcheck-opensource
cppcheckhttps://github.com/cppcheck-opensource/cppcheck
Notifications https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Fork 1.6k https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Star 6.7k https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Code https://github.com/cppcheck-opensource/cppcheck
Pull requests 204 https://github.com/cppcheck-opensource/cppcheck/pulls
Actions https://github.com/cppcheck-opensource/cppcheck/actions
Security and quality 0 https://github.com/cppcheck-opensource/cppcheck/security
Insights https://github.com/cppcheck-opensource/cppcheck/pulse
Code https://github.com/cppcheck-opensource/cppcheck
Pull requests https://github.com/cppcheck-opensource/cppcheck/pulls
Actions https://github.com/cppcheck-opensource/cppcheck/actions
Security and quality https://github.com/cppcheck-opensource/cppcheck/security
Insights https://github.com/cppcheck-opensource/cppcheck/pulse
danmarhttps://github.com/danmar
cppcheck-opensource:mainhttps://github.com/cppcheck-opensource/cppcheck/tree/main
firewave:internalerrorhttps://github.com/firewave/cppcheck/tree/internalerror
Conversationhttps://github.com/cppcheck-opensource/cppcheck/pull/5037
Commits8 (8)https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits
Checkshttps://github.com/cppcheck-opensource/cppcheck/pull/5037/checks
Files changedhttps://github.com/cppcheck-opensource/cppcheck/pull/5037/files
report internalError when command execution returns errorcode / also some related cleanups and testshttps://github.com/cppcheck-opensource/cppcheck/pull/5037/commits#top
danmarhttps://github.com/danmar
cppcheck-opensource:mainhttps://github.com/cppcheck-opensource/cppcheck/tree/main
firewave:internalerrorhttps://github.com/firewave/cppcheck/tree/internalerror
do not arbitrarily decide if an `internalError` should fail the analysishttps://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/9b26f957cb9739d13a3a9f2d6a976d0f774ae060
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
9b26f95https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/9b26f957cb9739d13a3a9f2d6a976d0f774ae060
https://github.com/cppcheck-opensource/cppcheck/tree/9b26f957cb9739d13a3a9f2d6a976d0f774ae060
cleaned up `internalError` messageshttps://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/952ffc11c11b797cd2ee36dc2d6d1323c507bee0
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
952ffc1https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/952ffc11c11b797cd2ee36dc2d6d1323c507bee0
https://github.com/cppcheck-opensource/cppcheck/tree/952ffc11c11b797cd2ee36dc2d6d1323c507bee0
extracted creation of `ErrorMessage` from `InternalError` to `ErrorMessage::fromInternalError()`https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/29d4ba164519db3180949d0e93bc861e1f3ba452
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
29d4ba1https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/29d4ba164519db3180949d0e93bc861e1f3ba452
https://github.com/cppcheck-opensource/cppcheck/tree/29d4ba164519db3180949d0e93bc861e1f3ba452
test/cli/testutils.py: added `env` parameter to `cppcheck()`https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/2897633fa78a691bb7747675ca4e77e5a32cf227
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
2897633https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/2897633fa78a691bb7747675ca4e77e5a32cf227
https://github.com/cppcheck-opensource/cppcheck/tree/2897633fa78a691bb7747675ca4e77e5a32cf227
test/cli/test-other.py: added some tests to test addon execution failurehttps://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/c7fd7ab9b7600f9e63788812b1d6e61a92c5e46d
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
c7fd7abhttps://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/c7fd7ab9b7600f9e63788812b1d6e61a92c5e46d
https://github.com/cppcheck-opensource/cppcheck/tree/c7fd7ab9b7600f9e63788812b1d6e61a92c5e46d
test/cli/test-other.py: added a test for `internalError`https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/b18f25ff986b46b8cd935d0ddd0650c65553d8cb
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
b18f25fhttps://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/b18f25ff986b46b8cd935d0ddd0650c65553d8cb
https://github.com/cppcheck-opensource/cppcheck/tree/b18f25ff986b46b8cd935d0ddd0650c65553d8cb
CppCheck: added hack to Python auto-detection to avoid debug assertion with Visual Studio caused by missing commandhttps://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/0dc4aeb053bb9e45af87bb0c7050b23cdcda142e
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
0dc4aebhttps://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/0dc4aeb053bb9e45af87bb0c7050b23cdcda142e
https://github.com/cppcheck-opensource/cppcheck/tree/0dc4aeb053bb9e45af87bb0c7050b23cdcda142e
CppCheckExecutor: get rid of unnecessary RAII cleanup in `executeCommand()` and actually fail when the command returns an exitcode / also refactored code a bit and added TODOshttps://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/2e2c453af8e1848a7e508233f4f939b3ad21b1ce
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
2e2c453https://github.com/cppcheck-opensource/cppcheck/pull/5037/commits/2e2c453af8e1848a7e508233f4f939b3ad21b1ce
https://github.com/cppcheck-opensource/cppcheck/tree/2e2c453af8e1848a7e508233f4f939b3ad21b1ce
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.