| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:496d3ce5-eed5-6206-ee55-cf110643899d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B816:35149:BA58:EF7D:6A51210D |
| html-safe-nonce | d5196eb14eb30e886d3546ee93a377fe5ffdf81ea601df79af95517bca28ea60 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODE2OjM1MTQ5OkJBNTg6RUY3RDo2QTUxMjEwRCIsInZpc2l0b3JfaWQiOiIzNDg4NTEzMDA5NTc5NTMyNTU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 44f2cfa7548fb2916f50953488560b3bee2b7555290b1258782e40b9f78196e6 |
| hovercard-subject-tag | pull_request:1319749572 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/cppcheck-opensource/cppcheck/4985/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b87fadce6acf4018879175eae4e2af72605b5dd62dc661b6d589283d8feab914/cppcheck-opensource/cppcheck/pull/4985 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b87fadce6acf4018879175eae4e2af72605b5dd62dc661b6d589283d8feab914/cppcheck-opensource/cppcheck/pull/4985 |
| og:image:alt | This starts to untangle the ErrorLogger implementation in CppcheckExecutor which handles three different cases and makes things unnecessarily complicated. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | firewave |
| hostname | github.com |
| expected-hostname | github.com |
| None | 689b683944b0d7f015d0e776452c970832fa81b82dc15284469b556ecced715b |
| turbo-cache-control | no-cache |
| go-import | github.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git |
| octolytics-dimension-user_id | 278097703 |
| octolytics-dimension-user_login | cppcheck-opensource |
| octolytics-dimension-repository_id | 143131 |
| octolytics-dimension-repository_nwo | cppcheck-opensource/cppcheck |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143131 |
| octolytics-dimension-repository_network_root_nwo | cppcheck-opensource/cppcheck |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 942b51ed3bd5feee3d5e2719f890a5fe286edbbb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/cppcheck-opensource/cppcheck/pull/4985#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F4985 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F4985 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=cppcheck-opensource%2Fcppcheck |
| Reload | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| Reload | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| Reload | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
|
cppcheck-opensource
| https://github.com/cppcheck-opensource |
| cppcheck | https://github.com/cppcheck-opensource/cppcheck |
|
Notifications
| https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck |
|
Fork
1.6k
| https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck |
|
Star
6.7k
| https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck |
|
Code
| https://github.com/cppcheck-opensource/cppcheck |
|
Pull requests
205
| https://github.com/cppcheck-opensource/cppcheck/pulls |
|
Actions
| https://github.com/cppcheck-opensource/cppcheck/actions |
|
Security and quality
0
| https://github.com/cppcheck-opensource/cppcheck/security |
|
Insights
| https://github.com/cppcheck-opensource/cppcheck/pulse |
|
Code
| https://github.com/cppcheck-opensource/cppcheck |
|
Pull requests
| https://github.com/cppcheck-opensource/cppcheck/pulls |
|
Actions
| https://github.com/cppcheck-opensource/cppcheck/actions |
|
Security and quality
| https://github.com/cppcheck-opensource/cppcheck/security |
|
Insights
| https://github.com/cppcheck-opensource/cppcheck/pulse |
| firewave | https://github.com/firewave |
| cppcheck-opensource:main | https://github.com/cppcheck-opensource/cppcheck/tree/main |
| firewave:cppcheckex-xml | https://github.com/firewave/cppcheck/tree/cppcheckex-xml |
| Conversation | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| Commits1 (1) | https://github.com/cppcheck-opensource/cppcheck/pull/4985/commits |
| Checks | https://github.com/cppcheck-opensource/cppcheck/pull/4985/checks |
| Files changed | https://github.com/cppcheck-opensource/cppcheck/pull/4985/files |
| CppcheckExecutor: use dedicated ErrorLogger for printing error messages XML | https://github.com/cppcheck-opensource/cppcheck/pull/4985#top |
| firewave | https://github.com/firewave |
| cppcheck-opensource:main | https://github.com/cppcheck-opensource/cppcheck/tree/main |
| firewave:cppcheckex-xml | https://github.com/firewave/cppcheck/tree/cppcheckex-xml |
|
| https://github.com/firewave |
| firewave | https://github.com/firewave |
| Apr 19, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4985#issue-1674731583 |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| https://github.com/firewave |
| firewave | https://github.com/firewave |
| Apr 19, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4985#event-9045611176 |
| https://github.com/firewave |
| firewave | https://github.com/firewave |
|
Apr 19, 2023
| https://github.com/cppcheck-opensource/cppcheck/pull/4985#pullrequestreview-1392868884 |
|
View reviewed changes
| https://github.com/cppcheck-opensource/cppcheck/pull/4985/files |
| cli/cppcheckexecutor.cpp | https://github.com/cppcheck-opensource/cppcheck/pull/4985/files#diff-f4d43c3baf8c85745069cdf61a4022d74c2ef7775edf71106faf22f718644fed |
| firewave | https://github.com/firewave |
| Apr 19, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4985#discussion_r1171846635 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @danmar | https://github.com/danmar |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| danmar | https://github.com/danmar |
| Aug 7, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4985#discussion_r1285754419 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| danmar | https://github.com/danmar |
| Aug 7, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4985#discussion_r1285755841 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| firewave | https://github.com/firewave |
| Aug 7, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4985#discussion_r1286138708 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #5269 | https://github.com/cppcheck-opensource/cppcheck/pull/5269 |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| https://github.com/firewave |
| firewave | https://github.com/firewave |
| Jul 26, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4985#issuecomment-1652545441 |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| https://github.com/firewave |
| firewave | https://github.com/firewave |
|
Jul 26, 2023
| https://github.com/cppcheck-opensource/cppcheck/pull/4985#ref-pullrequest-1823246895 |
|
removed ErrorLogger::reportProgress() and command-line option --report-progress
#5269
| https://github.com/cppcheck-opensource/cppcheck/pull/5269 |
| https://github.com/danmar |
| danmar | https://github.com/danmar |
|
Aug 7, 2023
| https://github.com/cppcheck-opensource/cppcheck/pull/4985#pullrequestreview-1565151208 |
|
View reviewed changes
| https://github.com/cppcheck-opensource/cppcheck/pull/4985/files |
| cli/cppcheckexecutor.cpp | https://github.com/cppcheck-opensource/cppcheck/pull/4985/files#diff-f4d43c3baf8c85745069cdf61a4022d74c2ef7775edf71106faf22f718644fed |
| danmar | https://github.com/danmar |
| Aug 7, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4985#discussion_r1285756838 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| firewave | https://github.com/firewave |
| Aug 7, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4985#discussion_r1286137888 |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| danmar | https://github.com/danmar |
| Aug 7, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4985#discussion_r1286275656 |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| firewave | https://github.com/firewave |
| Aug 7, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4985#discussion_r1286291461 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
| https://github.com/firewave |
| firewave | https://github.com/firewave |
| force-pushed | https://github.com/cppcheck-opensource/cppcheck/compare/a23a00eef17b128d85f8bcb2e8e42a4f022c3635..020401367539842011dee5fb288687b0af70f19f |
| a23a00e | https://github.com/cppcheck-opensource/cppcheck/commit/a23a00eef17b128d85f8bcb2e8e42a4f022c3635 |
| 0204013 | https://github.com/cppcheck-opensource/cppcheck/commit/020401367539842011dee5fb288687b0af70f19f |
|
Compare
| https://github.com/cppcheck-opensource/cppcheck/compare/a23a00eef17b128d85f8bcb2e8e42a4f022c3635..020401367539842011dee5fb288687b0af70f19f |
| August 7, 2023 19:14 | https://github.com/cppcheck-opensource/cppcheck/pull/4985#event-10027883843 |
| https://github.com/danmar |
| danmar | https://github.com/danmar |
|
Aug 8, 2023
| https://github.com/cppcheck-opensource/cppcheck/pull/4985#pullrequestreview-1568100720 |
|
View reviewed changes
| https://github.com/cppcheck-opensource/cppcheck/pull/4985/files |
|
| https://github.com/firewave |
| CppcheckExecutor: use dedicated ErrorLogger printing error messages XML | https://github.com/cppcheck-opensource/cppcheck/pull/4985/commits/82c55b57a65b031a0a2cdabaac888922e32f7d72 |
| 82c55b5 | https://github.com/cppcheck-opensource/cppcheck/pull/4985/commits/82c55b57a65b031a0a2cdabaac888922e32f7d72 |
| https://github.com/firewave |
| firewave | https://github.com/firewave |
| force-pushed | https://github.com/cppcheck-opensource/cppcheck/compare/020401367539842011dee5fb288687b0af70f19f..82c55b57a65b031a0a2cdabaac888922e32f7d72 |
| 0204013 | https://github.com/cppcheck-opensource/cppcheck/commit/020401367539842011dee5fb288687b0af70f19f |
| 82c55b5 | https://github.com/cppcheck-opensource/cppcheck/commit/82c55b57a65b031a0a2cdabaac888922e32f7d72 |
|
Compare
| https://github.com/cppcheck-opensource/cppcheck/compare/020401367539842011dee5fb288687b0af70f19f..82c55b57a65b031a0a2cdabaac888922e32f7d72 |
| August 8, 2023 20:15 | https://github.com/cppcheck-opensource/cppcheck/pull/4985#event-10039730334 |
| https://github.com/firewave |
| firewave | https://github.com/firewave |
| f1749ab | https://github.com/cppcheck-opensource/cppcheck/commit/f1749ab7adb5653d37cafa5bf59d11c1cc858447 |
| Aug 8, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4985#event-10040066330 |
| https://github.com/firewave |
| firewave | https://github.com/firewave |
| August 8, 2023 20:58 | https://github.com/cppcheck-opensource/cppcheck/pull/4985#event-10040066670 |
| https://github.com/firewave |
| firewave | https://github.com/firewave |
|
Aug 13, 2023
| https://github.com/cppcheck-opensource/cppcheck/pull/4985#ref-pullrequest-1848699267 |
|
renamed Check::reportError(const ErrorMessage&) to writeToErrorList() to reflect its actual behavior
#5322
| https://github.com/cppcheck-opensource/cppcheck/pull/5322 |
| https://github.co/hiddenchars |
| https://github.com/cppcheck-opensource/cppcheck/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F4985 |
|
| https://github.com/danmar |
|
danmar
| https://github.com/danmar |
|
| https://github.com/cppcheck-opensource/cppcheck/pull/4985/files/020401367539842011dee5fb288687b0af70f19f |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4985 |
|
| https://github.com/firewave |
|
| https://github.com/danmar |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |