Title: some `Tokenizer` construction and related other cleanups by firewave · Pull Request #4799 · cppcheck-opensource/cppcheck · GitHub
Open Graph Title: some `Tokenizer` construction and related other cleanups by firewave · Pull Request #4799 · cppcheck-opensource/cppcheck
X Title: some `Tokenizer` construction and related other cleanups by firewave · Pull Request #4799 · cppcheck-opensource/cppcheck
Description: When Preprocessor was not set in Tokenizer it was bypassing some logic. We should not be doing that as it might cause tests to behave differently than production code. The static Settings are dangerous as the objects are mutable. #4798 will start to address that. TestType was also using the settings quite inconsistently. There's obviously some room for cleanups.
Open Graph Description: When Preprocessor was not set in Tokenizer it was bypassing some logic. We should not be doing that as it might cause tests to behave differently than production code. The static Settings are dange...
X Description: When Preprocessor was not set in Tokenizer it was bypassing some logic. We should not be doing that as it might cause tests to behave differently than production code. The static Settings are dange...
Opengraph URL: https://github.com/cppcheck-opensource/cppcheck/pull/4799
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b78133d5-5689-1d20-7704-3a4c71d9d22f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8814:33E8BE:51EF10:7788BD:6A4E0AC7 |
| html-safe-nonce | 033731c67e2f471e05df9ccbbc3fc9c49ac17cced0530579c26d999cb91f0e8b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODE0OjMzRThCRTo1MUVGMTA6Nzc4OEJEOjZBNEUwQUM3IiwidmlzaXRvcl9pZCI6IjQyMzkyOTE2NTI3NzY5NDY2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5116d38fb6d3c4c33b96450215c06e5ec6f5373247a10a9fb3ab2c5bb4415173 |
| hovercard-subject-tag | pull_request:1243641525 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/cppcheck-opensource/cppcheck/pull/4799/files |
| twitter:image | https://avatars.githubusercontent.com/u/242857?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/242857?s=400&v=4 |
| og:image:alt | When Preprocessor was not set in Tokenizer it was bypassing some logic. We should not be doing that as it might cause tests to behave differently than production code. The static Settings are dange... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | df0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git |
| octolytics-dimension-user_id | 278097703 |
| octolytics-dimension-user_login | cppcheck-opensource |
| octolytics-dimension-repository_id | 143131 |
| octolytics-dimension-repository_nwo | cppcheck-opensource/cppcheck |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143131 |
| octolytics-dimension-repository_network_root_nwo | cppcheck-opensource/cppcheck |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 51470c353b8a1f52a88d3e3cc2014b17ab8cc1ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width