| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:dded5839-d0b3-67b2-a37b-e608b0b377c3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A4CE:3AEA09:CFE04E:11DF136:6A4DE9CC |
| html-safe-nonce | 522c63e157fea062417d0de132851b3197c8eb030d6ca64ccaa1783870dcd08c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNENFOjNBRUEwOTpDRkUwNEU6MTFERjEzNjo2QTRERTlDQyIsInZpc2l0b3JfaWQiOiIyMDY3NTA1MjA0MDQzODM1ODUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 24b2c12329697a339d24792fa9a3cda502ddc1855478aede099e084a7a0ac0ef |
| hovercard-subject-tag | pull_request:1243641525 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/cppcheck-opensource/cppcheck/4799/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1e2dc621126bbc5775b01a5905a35ee929157df0a8f84ee76a0d26586ed9f358/cppcheck-opensource/cppcheck/pull/4799 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1e2dc621126bbc5775b01a5905a35ee929157df0a8f84ee76a0d26586ed9f358/cppcheck-opensource/cppcheck/pull/4799 |
| og:image:alt | When Preprocessor was not set in Tokenizer it was bypassing some logic. We should not be doing that as it might cause tests to behave differently than production code.
The static Settings are dange... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | firewave |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git |
| octolytics-dimension-user_id | 278097703 |
| octolytics-dimension-user_login | cppcheck-opensource |
| octolytics-dimension-repository_id | 143131 |
| octolytics-dimension-repository_nwo | cppcheck-opensource/cppcheck |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143131 |
| octolytics-dimension-repository_network_root_nwo | cppcheck-opensource/cppcheck |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/cppcheck-opensource/cppcheck/pull/4799#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F4799 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F4799 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=cppcheck-opensource%2Fcppcheck |
| Reload | https://github.com/cppcheck-opensource/cppcheck/pull/4799 |
| Reload | https://github.com/cppcheck-opensource/cppcheck/pull/4799 |
| Reload | https://github.com/cppcheck-opensource/cppcheck/pull/4799 |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4799 |
|
cppcheck-opensource
| https://github.com/cppcheck-opensource |
| cppcheck | https://github.com/cppcheck-opensource/cppcheck |
|
Notifications
| https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck |
|
Fork
1.6k
| https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck |
|
Star
6.7k
| https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck |
|
Code
| https://github.com/cppcheck-opensource/cppcheck |
|
Pull requests
206
| https://github.com/cppcheck-opensource/cppcheck/pulls |
|
Actions
| https://github.com/cppcheck-opensource/cppcheck/actions |
|
Security and quality
0
| https://github.com/cppcheck-opensource/cppcheck/security |
|
Insights
| https://github.com/cppcheck-opensource/cppcheck/pulse |
|
Code
| https://github.com/cppcheck-opensource/cppcheck |
|
Pull requests
| https://github.com/cppcheck-opensource/cppcheck/pulls |
|
Actions
| https://github.com/cppcheck-opensource/cppcheck/actions |
|
Security and quality
| https://github.com/cppcheck-opensource/cppcheck/security |
|
Insights
| https://github.com/cppcheck-opensource/cppcheck/pulse |
| danmar | https://github.com/danmar |
| cppcheck-opensource:main | https://github.com/cppcheck-opensource/cppcheck/tree/main |
| firewave:tokenize | https://github.com/firewave/cppcheck/tree/tokenize |
| Conversation | https://github.com/cppcheck-opensource/cppcheck/pull/4799 |
| Commits6 (6) | https://github.com/cppcheck-opensource/cppcheck/pull/4799/commits |
| Checks | https://github.com/cppcheck-opensource/cppcheck/pull/4799/checks |
| Files changed | https://github.com/cppcheck-opensource/cppcheck/pull/4799/files |
| some Tokenizer construction and related other cleanups | https://github.com/cppcheck-opensource/cppcheck/pull/4799#top |
| danmar | https://github.com/danmar |
| cppcheck-opensource:main | https://github.com/cppcheck-opensource/cppcheck/tree/main |
| firewave:tokenize | https://github.com/firewave/cppcheck/tree/tokenize |
|
| https://github.com/firewave |
| firewave | https://github.com/firewave |
| Feb 16, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4799#issue-1587616994 |
| #4798 | https://github.com/cppcheck-opensource/cppcheck/pull/4798 |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4799 |
| firewave | https://github.com/firewave |
| February 16, 2023 14:42 | https://github.com/cppcheck-opensource/cppcheck/pull/4799#commits-pushed-3da042e |
|
| https://github.com/firewave |
| Tokenizer: small construction cleanup | https://github.com/cppcheck-opensource/cppcheck/pull/4799/commits/3da042ecb89be139be3ac27d308f172a3f5e11a4 |
| 3da042e | https://github.com/cppcheck-opensource/cppcheck/pull/4799/commits/3da042ecb89be139be3ac27d308f172a3f5e11a4 |
|
| https://github.com/firewave |
| cppcheck.cpp: small refactoring in checkFile() | https://github.com/cppcheck-opensource/cppcheck/pull/4799/commits/68229e7ca7619e146424efd0fae5852cc9290d71 |
| 68229e7 | https://github.com/cppcheck-opensource/cppcheck/pull/4799/commits/68229e7ca7619e146424efd0fae5852cc9290d71 |
|
| https://github.com/firewave |
| removed usage of static Settings object from tests | https://github.com/cppcheck-opensource/cppcheck/pull/4799/commits/0d3146c17f55fc73ab0d23babaa20151d06c4b14 |
| 0d3146c | https://github.com/cppcheck-opensource/cppcheck/pull/4799/commits/0d3146c17f55fc73ab0d23babaa20151d06c4b14 |
|
| https://github.com/firewave |
| only provide Preprocessor in tests if necessary | https://github.com/cppcheck-opensource/cppcheck/pull/4799/commits/5cacd023108798c40a7d1424359ba1c2a130108c |
| 5cacd02 | https://github.com/cppcheck-opensource/cppcheck/pull/4799/commits/5cacd023108798c40a7d1424359ba1c2a130108c |
| https://github.com/firewave |
| firewave | https://github.com/firewave |
| force-pushed | https://github.com/cppcheck-opensource/cppcheck/compare/777afffde92b8793df148a21668ded2fd6b4cdb5..5cacd023108798c40a7d1424359ba1c2a130108c |
| 777afff | https://github.com/cppcheck-opensource/cppcheck/commit/777afffde92b8793df148a21668ded2fd6b4cdb5 |
| 5cacd02 | https://github.com/cppcheck-opensource/cppcheck/commit/5cacd023108798c40a7d1424359ba1c2a130108c |
|
Compare
| https://github.com/cppcheck-opensource/cppcheck/compare/777afffde92b8793df148a21668ded2fd6b4cdb5..5cacd023108798c40a7d1424359ba1c2a130108c |
| February 16, 2023 13:42 | https://github.com/cppcheck-opensource/cppcheck/pull/4799#event-8537053323 |
| firewave | https://github.com/firewave |
| February 16, 2023 16:33 | https://github.com/cppcheck-opensource/cppcheck/pull/4799#commits-pushed-1f478ee |
|
| https://github.com/firewave |
| CppCheckExecutor: fixed unusedFunction selfcheck warning | https://github.com/cppcheck-opensource/cppcheck/pull/4799/commits/1f478eea00b38c58630961e12c01d040bf3a59a8 |
| 1f478ee | https://github.com/cppcheck-opensource/cppcheck/pull/4799/commits/1f478eea00b38c58630961e12c01d040bf3a59a8 |
|
| https://github.com/firewave |
| CppCheckExecutor: cleaned up usage of mSettings | https://github.com/cppcheck-opensource/cppcheck/pull/4799/commits/7ec1eb67d8e292dccdee299f5fc9b54123f4584d |
| 7ec1eb6 | https://github.com/cppcheck-opensource/cppcheck/pull/4799/commits/7ec1eb67d8e292dccdee299f5fc9b54123f4584d |
| https://github.com/firewave |
| firewave | https://github.com/firewave |
| Feb 16, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4799#event-8538396213 |
| https://github.com/danmar |
| danmar | https://github.com/danmar |
|
Feb 24, 2023
| https://github.com/cppcheck-opensource/cppcheck/pull/4799#pullrequestreview-1312554758 |
|
View reviewed changes
| https://github.com/cppcheck-opensource/cppcheck/pull/4799/files/7ec1eb67d8e292dccdee299f5fc9b54123f4584d |
| test/testclass.cpp | https://github.com/cppcheck-opensource/cppcheck/pull/4799/files/7ec1eb67d8e292dccdee299f5fc9b54123f4584d#diff-34df0cdbc990ef7e9bc843936b21581703d79afa595d8e8a4b5bad40fa0f8157 |
| danmar | https://github.com/danmar |
| Feb 24, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4799#discussion_r1116538165 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4799 |
| firewave | https://github.com/firewave |
| Feb 24, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4799#discussion_r1116821935 |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4799 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #4798 | https://github.com/cppcheck-opensource/cppcheck/pull/4798 |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4799 |
| danmar | https://github.com/danmar |
| Feb 24, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4799#discussion_r1117594289 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4799 |
| firewave | https://github.com/firewave |
| Feb 24, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4799#discussion_r1117633817 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4799 |
| https://github.com/danmar |
| danmar | https://github.com/danmar |
| 8f5f06a | https://github.com/cppcheck-opensource/cppcheck/commit/8f5f06add7989c08ba63b6ac5f18288ea8691e11 |
| Mar 2, 2023 | https://github.com/cppcheck-opensource/cppcheck/pull/4799#event-8653572966 |
| https://github.com/firewave |
| firewave | https://github.com/firewave |
| March 2, 2023 20:51 | https://github.com/cppcheck-opensource/cppcheck/pull/4799#event-8653598160 |
| https://github.co/hiddenchars |
| https://github.com/cppcheck-opensource/cppcheck/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F4799 |
|
| https://github.com/danmar |
|
danmar
| https://github.com/danmar |
|
| https://github.com/cppcheck-opensource/cppcheck/pull/4799/files/7ec1eb67d8e292dccdee299f5fc9b54123f4584d |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/4799 |
|
| https://github.com/firewave |
|
| https://github.com/danmar |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |