Title: added `Path::identify()`/`Path::isHeader2()` and deprecated flawed `Path::isCPP()`, `Path::isC()` and `Path::isHeader()` by firewave · Pull Request #4681 · cppcheck-opensource/cppcheck · GitHub
Open Graph Title: added `Path::identify()`/`Path::isHeader2()` and deprecated flawed `Path::isCPP()`, `Path::isC()` and `Path::isHeader()` by firewave · Pull Request #4681 · cppcheck-opensource/cppcheck
X Title: added `Path::identify()`/`Path::isHeader2()` and deprecated flawed `Path::isCPP()`, `Path::isC()` and `Path::isHeader()` by firewave · Pull Request #4681 · cppcheck-opensource/cppcheck
Description: None of the Path::is*() function is working as expected or consistent (detailed via additional unit tests and deprecation comments). I tried to fix them but that would have made made cases with headers quite awkward to implement so I opted to generate a new function. This also optimized Path::acceptFile() a file. I am not 100% happy with including settings.h but I didn't see a place to move this to. If #3774 gets merged we might be able to move the enum into keywords.h (that could also be renamed). I kept the old function in case somebody else is using these (they are in the API after all) and will remove them after the next release.
Open Graph Description: None of the Path::is*() function is working as expected or consistent (detailed via additional unit tests and deprecation comments). I tried to fix them but that would have made made cases with hea...
X Description: None of the Path::is*() function is working as expected or consistent (detailed via additional unit tests and deprecation comments). I tried to fix them but that would have made made cases with hea...
Opengraph URL: https://github.com/cppcheck-opensource/cppcheck/pull/4681
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:287f5972-9a10-5912-257b-39aa5b408a5c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C586:18E6A9:18807:1FDB7:6A52BAD1 |
| html-safe-nonce | da496f4ceed1a92b306be4f576a2dc9f2be24ad67ef1cac31ad4fcb4417e8fac |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTg2OjE4RTZBOToxODgwNzoxRkRCNzo2QTUyQkFEMSIsInZpc2l0b3JfaWQiOiI0MTMyODg2NzgxMTk5ODI1NjE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7141f5b412df4a5b91b6c1030943ade467ef05912c4536e6e0fbe5d14cde42db |
| hovercard-subject-tag | pull_request:1184089600 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/cppcheck-opensource/cppcheck/pull/4681/files |
| twitter:image | https://avatars.githubusercontent.com/u/242857?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/242857?s=400&v=4 |
| og:image:alt | None of the Path::is*() function is working as expected or consistent (detailed via additional unit tests and deprecation comments). I tried to fix them but that would have made made cases with hea... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git |
| octolytics-dimension-user_id | 278097703 |
| octolytics-dimension-user_login | cppcheck-opensource |
| octolytics-dimension-repository_id | 143131 |
| octolytics-dimension-repository_nwo | cppcheck-opensource/cppcheck |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143131 |
| octolytics-dimension-repository_network_root_nwo | cppcheck-opensource/cppcheck |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width