René's URL Explorer Experiment


Title: improved `MathLib::to{ULong|Long|Double}Number()` and increased test coverage / added CMake option `USE_LIBCXX` / fixed #10695 by firewave · Pull Request #4611 · cppcheck-opensource/cppcheck · GitHub

Open Graph Title: improved `MathLib::to{ULong|Long|Double}Number()` and increased test coverage / added CMake option `USE_LIBCXX` / fixed #10695 by firewave · Pull Request #4611 · cppcheck-opensource/cppcheck

Description: static analysis of C/C++ code. Contribute to cppcheck-opensource/cppcheck development by creating an account on GitHub.

Opengraph URL: https://github.com/cppcheck-opensource/cppcheck/pull/4611

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8599efbb-ea09-183c-e3c8-089f0df938ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA61E:19F60D:B8041E:F360D8:6A518EA2
html-safe-noncef4666ba5e8e3ac50346a0e60261718963596f1b0e4c2f7727c349b470d61c145
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjFFOjE5RjYwRDpCODA0MUU6RjM2MEQ4OjZBNTE4RUEyIiwidmlzaXRvcl9pZCI6IjY1MjE1MTcxMjMyODk4NDU0MTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1aa81d10a02abc5bea410d8434a15b968d80b3714346e0dfd638066c4203bf9a
hovercard-subject-tagpull_request:1145476126
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/cppcheck-opensource/cppcheck/pull/4611/files
og:imagehttps://avatars.githubusercontent.com/u/242857?s=400&v=4
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git
octolytics-dimension-user_id278097703
octolytics-dimension-user_logincppcheck-opensource
octolytics-dimension-repository_id143131
octolytics-dimension-repository_nwocppcheck-opensource/cppcheck
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143131
octolytics-dimension-repository_network_root_nwocppcheck-opensource/cppcheck
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/cppcheck-opensource/cppcheck/pull/4611/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F4611%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F4611%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=cppcheck-opensource%2Fcppcheck
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/4611/files
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/4611/files
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/4611/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/4611/files
cppcheck-opensource https://github.com/cppcheck-opensource
cppcheckhttps://github.com/cppcheck-opensource/cppcheck
Notifications https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Fork 1.6k https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Star 6.7k https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Code https://github.com/cppcheck-opensource/cppcheck
Pull requests 204 https://github.com/cppcheck-opensource/cppcheck/pulls
Actions https://github.com/cppcheck-opensource/cppcheck/actions
Security and quality 0 https://github.com/cppcheck-opensource/cppcheck/security
Insights https://github.com/cppcheck-opensource/cppcheck/pulse
Code https://github.com/cppcheck-opensource/cppcheck
Pull requests https://github.com/cppcheck-opensource/cppcheck/pulls
Actions https://github.com/cppcheck-opensource/cppcheck/actions
Security and quality https://github.com/cppcheck-opensource/cppcheck/security
Insights https://github.com/cppcheck-opensource/cppcheck/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fcppcheck-opensource%2Fcppcheck%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck%2Fissues%2Fnew%2Fchoose
danmarhttps://github.com/danmar
cppcheck-opensource:mainhttps://github.com/cppcheck-opensource/cppcheck/tree/main
firewave:mathlib-stohttps://github.com/firewave/cppcheck/tree/mathlib-sto
Conversation 0 https://github.com/cppcheck-opensource/cppcheck/pull/4611
Commits 17 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits
Checks 0 https://github.com/cppcheck-opensource/cppcheck/pull/4611/checks
Files changed https://github.com/cppcheck-opensource/cppcheck/pull/4611/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/4611/files
improved MathLib::to{ULong|Long|Double}Number() and increased test coverage / added CMake option USE_LIBCXX / fixed #10695 https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#top
Show all changes 17 commits https://github.com/cppcheck-opensource/cppcheck/pull/4611/files
74d554e testmathlib.cpp: split `toULongNumber` into separate test case firewave Dec 4, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/74d554e32a1a5479550b9f336ad0e99ec4651841
d71e86d testmathlib.cpp: aligned tests in `toLongNumber` and `toULongNumber` firewave Dec 4, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/d71e86d34bb92cb5660e67eca044adeea4adbbf2
32bcbc8 mathlib.cpp: fixed handling of negative binary numbers in `toULongNum… firewave Dec 4, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/32bcbc82b41c6c1c1025020b796f5741f39c3c13
1eff4f1 mathlib.cpp: added handling of `std::invalid_argument` to `std::stoul… firewave Dec 4, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/1eff4f1571257b6b11c75c754b3246e1370e6bd7
5b3ff5e mathlib.cpp: added missing handling of char literals to `toULongNumbe… firewave Dec 4, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/5b3ff5ef17e1e007fe665653d7f26c15c0ff866d
1114b90 testmathlib.cpp: check exception messages firewave Dec 4, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/1114b90f289ec8143bde02aacd57673eb12a5bcd
2dd2dfa testmathlib.cpp: added tests which produce `std::invalid_argument` ex… firewave Dec 4, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/2dd2dfa832c1956c1c486e5e39e2f0d5cbf9c2cb
e7edc7b MathLib: removed pointless info from `to{U}LongNumber()` exception me… firewave Dec 5, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/e7edc7bc42003bb55728add09c2885cc7aab35db
5553908 fixed #10695 - make sure the whole input is being consumed in `MathLi… firewave Dec 5, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/5553908e863ec64edd99918f03f4c5e3839b28e8
f40781b mathlib.cpp: use `toDoubleNumber()` in `toULongNumber()` as well firewave Dec 5, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/f40781b093bc191ff065defa0754a65c3f9f2ab7
708162a MathLib: improved handling of invalid input in `toDoubleNumber()` / i… firewave Dec 5, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/708162a9aca29b3a1dd1555208c01c8f3575dd6b
42bc53b ubsan.yml: added `report_error_type=1` to `UBSAN_OPTIONS` firewave Dec 5, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/42bc53b8423562e8e27abb49f8496d7f28872de6
80522d9 mathlib.cpp: fixed UBSAN warning about negative double being out-of-r… firewave Dec 5, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/80522d9d41fd8d6ac9882c44013aa5c60a3ee37b
1c36cde MathLib: fixed incorrect `toString()` result if it contains an exponent firewave Dec 5, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/1c36cde29147e7df04fcecadf1d7fd9173ecb240
91b1233 mathlib.cpp: avoid unnecessary copies in `toString()` firewave Dec 5, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/91b12335f580c878f0bccfc14382fe71bc813cd3
0927ad4 added CMake option `USE_LIBCXX` to use `libc++` instead of `libstdc++… firewave Dec 5, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/0927ad40301389a6e6f249c05b801138d8e24fce
7912e26 testmathlib.cpp: adjustments for `libc++` firewave Dec 5, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/7912e261251199ace85426c91984b5bdb18787ec
Clear filters https://github.com/cppcheck-opensource/cppcheck/pull/4611/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/4611/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/4611/files
ubsan.yml https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-ef9de27d04d8933c1c2f91dc95799dc90ff84e5218fcfb25390650929db85bc5
compilerDefinitions.cmake https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-176dd923cb09a32bacb623f2c49f53a2a4f9977ea8b628462c694e58a0a5433b
compileroptions.cmake https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-723b8a9fe2c97ab7ffbc6ee70821a87b3f7c8cfc528a948ec9c213272d495be7
options.cmake https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-e8bc1b52c7618188b02120d369a4664f177556455e9a3c705d82b2cfd098d9c8
printInfo.cmake https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-699313ed2ae41fae12e16008923ac2691facb069a331f3d1607ced8a615d7a26
mathlib.cpp https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-8a42f1c25b025b26f10aa71765ac7ad2a4df2da864719d8f6ac246c56fa2414c
testmathlib.cpp https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-0684d5590cb70e892e0a9bf5bb223a320742d5f5b4e9717df02fd1f28ef83760
.github/workflows/ubsan.ymlhttps://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-ef9de27d04d8933c1c2f91dc95799dc90ff84e5218fcfb25390650929db85bc5
View file https://github.com/firewave/cppcheck/blob/7912e261251199ace85426c91984b5bdb18787ec/.github/workflows/ubsan.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/4611/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-ef9de27d04d8933c1c2f91dc95799dc90ff84e5218fcfb25390650929db85bc5
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-ef9de27d04d8933c1c2f91dc95799dc90ff84e5218fcfb25390650929db85bc5
cmake/compilerDefinitions.cmakehttps://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-176dd923cb09a32bacb623f2c49f53a2a4f9977ea8b628462c694e58a0a5433b
View file https://github.com/firewave/cppcheck/blob/7912e261251199ace85426c91984b5bdb18787ec/cmake/compilerDefinitions.cmake
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/4611/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-176dd923cb09a32bacb623f2c49f53a2a4f9977ea8b628462c694e58a0a5433b
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-176dd923cb09a32bacb623f2c49f53a2a4f9977ea8b628462c694e58a0a5433b
cmake/compileroptions.cmakehttps://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-723b8a9fe2c97ab7ffbc6ee70821a87b3f7c8cfc528a948ec9c213272d495be7
View file https://github.com/firewave/cppcheck/blob/7912e261251199ace85426c91984b5bdb18787ec/cmake/compileroptions.cmake
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/4611/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-723b8a9fe2c97ab7ffbc6ee70821a87b3f7c8cfc528a948ec9c213272d495be7
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-723b8a9fe2c97ab7ffbc6ee70821a87b3f7c8cfc528a948ec9c213272d495be7
cmake/options.cmakehttps://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-e8bc1b52c7618188b02120d369a4664f177556455e9a3c705d82b2cfd098d9c8
View file https://github.com/firewave/cppcheck/blob/7912e261251199ace85426c91984b5bdb18787ec/cmake/options.cmake
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/4611/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-e8bc1b52c7618188b02120d369a4664f177556455e9a3c705d82b2cfd098d9c8
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-e8bc1b52c7618188b02120d369a4664f177556455e9a3c705d82b2cfd098d9c8
cmake/printInfo.cmakehttps://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-699313ed2ae41fae12e16008923ac2691facb069a331f3d1607ced8a615d7a26
View file https://github.com/firewave/cppcheck/blob/7912e261251199ace85426c91984b5bdb18787ec/cmake/printInfo.cmake
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/4611/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-699313ed2ae41fae12e16008923ac2691facb069a331f3d1607ced8a615d7a26
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-699313ed2ae41fae12e16008923ac2691facb069a331f3d1607ced8a615d7a26
lib/mathlib.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-8a42f1c25b025b26f10aa71765ac7ad2a4df2da864719d8f6ac246c56fa2414c
View file https://github.com/firewave/cppcheck/blob/7912e261251199ace85426c91984b5bdb18787ec/lib/mathlib.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/4611/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-8a42f1c25b025b26f10aa71765ac7ad2a4df2da864719d8f6ac246c56fa2414c
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-8a42f1c25b025b26f10aa71765ac7ad2a4df2da864719d8f6ac246c56fa2414c
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-8a42f1c25b025b26f10aa71765ac7ad2a4df2da864719d8f6ac246c56fa2414c
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-8a42f1c25b025b26f10aa71765ac7ad2a4df2da864719d8f6ac246c56fa2414c
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-8a42f1c25b025b26f10aa71765ac7ad2a4df2da864719d8f6ac246c56fa2414c
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-8a42f1c25b025b26f10aa71765ac7ad2a4df2da864719d8f6ac246c56fa2414c
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-8a42f1c25b025b26f10aa71765ac7ad2a4df2da864719d8f6ac246c56fa2414c
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-8a42f1c25b025b26f10aa71765ac7ad2a4df2da864719d8f6ac246c56fa2414c
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-8a42f1c25b025b26f10aa71765ac7ad2a4df2da864719d8f6ac246c56fa2414c
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-8a42f1c25b025b26f10aa71765ac7ad2a4df2da864719d8f6ac246c56fa2414c
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-8a42f1c25b025b26f10aa71765ac7ad2a4df2da864719d8f6ac246c56fa2414c
https://github.com/cppcheck-opensource/cppcheck/pull/4611/files#diff-8a42f1c25b025b26f10aa71765ac7ad2a4df2da864719d8f6ac246c56fa2414c
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/4611/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.