René's URL Explorer Experiment


Title: improved `MathLib::to{ULong|Long|Double}Number()` and increased test coverage / added CMake option `USE_LIBCXX` / fixed #10695 by firewave · Pull Request #4611 · cppcheck-opensource/cppcheck · GitHub

Open Graph Title: improved `MathLib::to{ULong|Long|Double}Number()` and increased test coverage / added CMake option `USE_LIBCXX` / fixed #10695 by firewave · Pull Request #4611 · cppcheck-opensource/cppcheck

X Title: improved `MathLib::to{ULong|Long|Double}Number()` and increased test coverage / added CMake option `USE_LIBCXX` / fixed #10695 by firewave · Pull Request #4611 · cppcheck-opensource/cppcheck

Description: static analysis of C/C++ code. Contribute to cppcheck-opensource/cppcheck development by creating an account on GitHub.

Opengraph URL: https://github.com/cppcheck-opensource/cppcheck/pull/4611

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:27f46a7c-3d21-a14c-670d-a516ff519174
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB78:620C2:4218A6:57A7B9:6A516E16
html-safe-nonced837b4b3f8b2fcb12d71f1a39acfd2f14e0911cf92a94b98a905dd8f1a32d8c9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjc4OjYyMEMyOjQyMThBNjo1N0E3Qjk6NkE1MTZFMTYiLCJ2aXNpdG9yX2lkIjoiNTY2NDcwNzgwNDE1NzMzMjcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac39f86557468ccca03fea4319b593b3bc643e0cee3d5e58d8a7113c6370398cb6
hovercard-subject-tagpull_request:1145476126
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits
twitter:imagehttps://opengraph.githubassets.com/50b6db305f49b52f4d40ce50d3398c3e4eedffbe6f43894b27dc692f4c444a22/cppcheck-opensource/cppcheck/pull/4611
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/50b6db305f49b52f4d40ce50d3398c3e4eedffbe6f43894b27dc692f4c444a22/cppcheck-opensource/cppcheck/pull/4611
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefirewave
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git
octolytics-dimension-user_id278097703
octolytics-dimension-user_logincppcheck-opensource
octolytics-dimension-repository_id143131
octolytics-dimension-repository_nwocppcheck-opensource/cppcheck
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143131
octolytics-dimension-repository_network_root_nwocppcheck-opensource/cppcheck
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release60eaaf6d4dbaa817031b556aebd8a0a7eeb81b97
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F4611%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F4611%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=cppcheck-opensource%2Fcppcheck
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits
cppcheck-opensource https://github.com/cppcheck-opensource
cppcheckhttps://github.com/cppcheck-opensource/cppcheck
Notifications https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Fork 1.6k https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Star 6.7k https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Code https://github.com/cppcheck-opensource/cppcheck
Pull requests 204 https://github.com/cppcheck-opensource/cppcheck/pulls
Actions https://github.com/cppcheck-opensource/cppcheck/actions
Security and quality 0 https://github.com/cppcheck-opensource/cppcheck/security
Insights https://github.com/cppcheck-opensource/cppcheck/pulse
Code https://github.com/cppcheck-opensource/cppcheck
Pull requests https://github.com/cppcheck-opensource/cppcheck/pulls
Actions https://github.com/cppcheck-opensource/cppcheck/actions
Security and quality https://github.com/cppcheck-opensource/cppcheck/security
Insights https://github.com/cppcheck-opensource/cppcheck/pulse
danmarhttps://github.com/danmar
cppcheck-opensource:mainhttps://github.com/cppcheck-opensource/cppcheck/tree/main
firewave:mathlib-stohttps://github.com/firewave/cppcheck/tree/mathlib-sto
Conversationhttps://github.com/cppcheck-opensource/cppcheck/pull/4611
Commits17 (17)https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits
Checkshttps://github.com/cppcheck-opensource/cppcheck/pull/4611/checks
Files changedhttps://github.com/cppcheck-opensource/cppcheck/pull/4611/files
improved MathLib::to{ULong|Long|Double}Number() and increased test coverage / added CMake option USE_LIBCXX / fixed #10695https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits#top
danmarhttps://github.com/danmar
cppcheck-opensource:mainhttps://github.com/cppcheck-opensource/cppcheck/tree/main
firewave:mathlib-stohttps://github.com/firewave/cppcheck/tree/mathlib-sto
testmathlib.cpp: split `toULongNumber` into separate test casehttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/74d554e32a1a5479550b9f336ad0e99ec4651841
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
74d554ehttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/74d554e32a1a5479550b9f336ad0e99ec4651841
https://github.com/cppcheck-opensource/cppcheck/tree/74d554e32a1a5479550b9f336ad0e99ec4651841
testmathlib.cpp: aligned tests in `toLongNumber` and `toULongNumber`https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/d71e86d34bb92cb5660e67eca044adeea4adbbf2
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
d71e86dhttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/d71e86d34bb92cb5660e67eca044adeea4adbbf2
https://github.com/cppcheck-opensource/cppcheck/tree/d71e86d34bb92cb5660e67eca044adeea4adbbf2
mathlib.cpp: fixed handling of negative binary numbers in `toULongNumber()`https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/32bcbc82b41c6c1c1025020b796f5741f39c3c13
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
32bcbc8https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/32bcbc82b41c6c1c1025020b796f5741f39c3c13
https://github.com/cppcheck-opensource/cppcheck/tree/32bcbc82b41c6c1c1025020b796f5741f39c3c13
mathlib.cpp: added handling of `std::invalid_argument` to `std::stoull()` callshttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/1eff4f1571257b6b11c75c754b3246e1370e6bd7
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
1eff4f1https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/1eff4f1571257b6b11c75c754b3246e1370e6bd7
https://github.com/cppcheck-opensource/cppcheck/tree/1eff4f1571257b6b11c75c754b3246e1370e6bd7
mathlib.cpp: added missing handling of char literals to `toULongNumber()`https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/5b3ff5ef17e1e007fe665653d7f26c15c0ff866d
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
5b3ff5ehttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/5b3ff5ef17e1e007fe665653d7f26c15c0ff866d
https://github.com/cppcheck-opensource/cppcheck/tree/5b3ff5ef17e1e007fe665653d7f26c15c0ff866d
testmathlib.cpp: check exception messageshttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/1114b90f289ec8143bde02aacd57673eb12a5bcd
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
1114b90https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/1114b90f289ec8143bde02aacd57673eb12a5bcd
https://github.com/cppcheck-opensource/cppcheck/tree/1114b90f289ec8143bde02aacd57673eb12a5bcd
testmathlib.cpp: added tests which produce `std::invalid_argument` exceptionhttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/2dd2dfa832c1956c1c486e5e39e2f0d5cbf9c2cb
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
2dd2dfahttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/2dd2dfa832c1956c1c486e5e39e2f0d5cbf9c2cb
https://github.com/cppcheck-opensource/cppcheck/tree/2dd2dfa832c1956c1c486e5e39e2f0d5cbf9c2cb
MathLib: removed pointless info from `to{U}LongNumber()` exception messageshttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/e7edc7bc42003bb55728add09c2885cc7aab35db
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
e7edc7bhttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/e7edc7bc42003bb55728add09c2885cc7aab35db
https://github.com/cppcheck-opensource/cppcheck/tree/e7edc7bc42003bb55728add09c2885cc7aab35db
fixed #10695 - make sure the whole input is being consumed in `MathLib::to{U}LongNumber()`https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/5553908e863ec64edd99918f03f4c5e3839b28e8
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
5553908https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/5553908e863ec64edd99918f03f4c5e3839b28e8
https://github.com/cppcheck-opensource/cppcheck/tree/5553908e863ec64edd99918f03f4c5e3839b28e8
mathlib.cpp: use `toDoubleNumber()` in `toULongNumber()` as wellhttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/f40781b093bc191ff065defa0754a65c3f9f2ab7
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
f40781bhttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/f40781b093bc191ff065defa0754a65c3f9f2ab7
https://github.com/cppcheck-opensource/cppcheck/tree/f40781b093bc191ff065defa0754a65c3f9f2ab7
MathLib: improved handling of invalid input in `toDoubleNumber()` / increased test coveragehttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/708162a9aca29b3a1dd1555208c01c8f3575dd6b
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
708162ahttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/708162a9aca29b3a1dd1555208c01c8f3575dd6b
https://github.com/cppcheck-opensource/cppcheck/tree/708162a9aca29b3a1dd1555208c01c8f3575dd6b
ubsan.yml: added `report_error_type=1` to `UBSAN_OPTIONS`https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/42bc53b8423562e8e27abb49f8496d7f28872de6
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
42bc53bhttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/42bc53b8423562e8e27abb49f8496d7f28872de6
https://github.com/cppcheck-opensource/cppcheck/tree/42bc53b8423562e8e27abb49f8496d7f28872de6
mathlib.cpp: fixed UBSAN warning about negative double being out-of-range in `toULongNumber()`https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/80522d9d41fd8d6ac9882c44013aa5c60a3ee37b
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
80522d9https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/80522d9d41fd8d6ac9882c44013aa5c60a3ee37b
https://github.com/cppcheck-opensource/cppcheck/tree/80522d9d41fd8d6ac9882c44013aa5c60a3ee37b
MathLib: fixed incorrect `toString()` result if it contains an exponenthttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/1c36cde29147e7df04fcecadf1d7fd9173ecb240
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
1c36cdehttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/1c36cde29147e7df04fcecadf1d7fd9173ecb240
https://github.com/cppcheck-opensource/cppcheck/tree/1c36cde29147e7df04fcecadf1d7fd9173ecb240
mathlib.cpp: avoid unnecessary copies in `toString()`https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/91b12335f580c878f0bccfc14382fe71bc813cd3
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
91b1233https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/91b12335f580c878f0bccfc14382fe71bc813cd3
https://github.com/cppcheck-opensource/cppcheck/tree/91b12335f580c878f0bccfc14382fe71bc813cd3
added CMake option `USE_LIBCXX` to use `libc++` instead of `libstdc++` and also set `LIBCXX_ENABLE_DEBUG_MODE` in `Debug` buildhttps://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/0927ad40301389a6e6f249c05b801138d8e24fce
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
0927ad4https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/0927ad40301389a6e6f249c05b801138d8e24fce
https://github.com/cppcheck-opensource/cppcheck/tree/0927ad40301389a6e6f249c05b801138d8e24fce
testmathlib.cpp: adjustments for `libc++`https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/7912e261251199ace85426c91984b5bdb18787ec
https://github.com/firewave
firewavehttps://github.com/cppcheck-opensource/cppcheck/commits?author=firewave
7912e26https://github.com/cppcheck-opensource/cppcheck/pull/4611/commits/7912e261251199ace85426c91984b5bdb18787ec
https://github.com/cppcheck-opensource/cppcheck/tree/7912e261251199ace85426c91984b5bdb18787ec
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.