René's URL Explorer Experiment


Title: smallvector.h: bake `reserve()` into the non-boost `SmallVector` implementation by firewave · Pull Request #4385 · cppcheck-opensource/cppcheck · GitHub

Open Graph Title: smallvector.h: bake `reserve()` into the non-boost `SmallVector` implementation by firewave · Pull Request #4385 · cppcheck-opensource/cppcheck

X Title: smallvector.h: bake `reserve()` into the non-boost `SmallVector` implementation by firewave · Pull Request #4385 · cppcheck-opensource/cppcheck

Description: This changes bakes the reserve() call into the non-boost implementation SmallVector construction as it would cause a performance regression with the boost::small_vector implementation (see #3919). I tested the build with Clang, GCC, MinGW and Visual Studio. Replacing the std::vector + resreve() appraoch with SmallVector in visitAstNodes() will now yield the same performance when using Clang. In case of GCC the code actually gets faster since (according to valgrind) it was previously using std::vector<>::reserve(unsigned long) whereas it now uses operator new(unsigned long) just like Clang does. Possibly another issue to report upstream. Clang 14 2,481,264,505 -> 2,481,270,375 GCC 12 2,388,141,113 -> 2,359,483,453 This patch does not replace the usage yet - that still requires a few more tests and is handled via #3919.

Open Graph Description: This changes bakes the reserve() call into the non-boost implementation SmallVector construction as it would cause a performance regression with the boost::small_vector implementation (see #3919). ...

X Description: This changes bakes the reserve() call into the non-boost implementation SmallVector construction as it would cause a performance regression with the boost::small_vector implementation (see #3919). ...

Opengraph URL: https://github.com/cppcheck-opensource/cppcheck/pull/4385

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:643261b1-2eed-bd27-b72d-93bbaaab8917
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id92EA:10F0C1:14DA1A7:1E580AF:6A4E46D1
html-safe-nonce1d053563ff1955344fe2e930a185a56022c9373e574081c45d57d80eda4f23c8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkVBOjEwRjBDMToxNERBMUE3OjFFNTgwQUY6NkE0RTQ2RDEiLCJ2aXNpdG9yX2lkIjoiNjgzOTQxMTQxMjYyNTY3MTg4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb931a007fc528f047e823bfe96254fcddb0bd2157af53850b3a067ad73eb7972
hovercard-subject-tagpull_request:1031207841
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/cppcheck-opensource/cppcheck/pull/4385/files
twitter:imagehttps://avatars.githubusercontent.com/u/242857?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/242857?s=400&v=4
og:image:altThis changes bakes the reserve() call into the non-boost implementation SmallVector construction as it would cause a performance regression with the boost::small_vector implementation (see #3919). ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git
octolytics-dimension-user_id278097703
octolytics-dimension-user_logincppcheck-opensource
octolytics-dimension-repository_id143131
octolytics-dimension-repository_nwocppcheck-opensource/cppcheck
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143131
octolytics-dimension-repository_network_root_nwocppcheck-opensource/cppcheck
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9fabff9b8b127e686a3ec86f91422e818056ca2c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/cppcheck-opensource/cppcheck/pull/4385/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F4385%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F4385%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=cppcheck-opensource%2Fcppcheck
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/4385/files
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/4385/files
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/4385/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/4385/files
cppcheck-opensource https://github.com/cppcheck-opensource
cppcheckhttps://github.com/cppcheck-opensource/cppcheck
Notifications https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Fork 1.6k https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Star 6.7k https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Code https://github.com/cppcheck-opensource/cppcheck
Pull requests 202 https://github.com/cppcheck-opensource/cppcheck/pulls
Actions https://github.com/cppcheck-opensource/cppcheck/actions
Security and quality 0 https://github.com/cppcheck-opensource/cppcheck/security
Insights https://github.com/cppcheck-opensource/cppcheck/pulse
Code https://github.com/cppcheck-opensource/cppcheck
Pull requests https://github.com/cppcheck-opensource/cppcheck/pulls
Actions https://github.com/cppcheck-opensource/cppcheck/actions
Security and quality https://github.com/cppcheck-opensource/cppcheck/security
Insights https://github.com/cppcheck-opensource/cppcheck/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fcppcheck-opensource%2Fcppcheck%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck%2Fissues%2Fnew%2Fchoose
danmarhttps://github.com/danmar
cppcheck-opensource:mainhttps://github.com/cppcheck-opensource/cppcheck/tree/main
firewave:smallvector-xhttps://github.com/firewave/cppcheck/tree/smallvector-x
Conversation 0 https://github.com/cppcheck-opensource/cppcheck/pull/4385
Commits 1 https://github.com/cppcheck-opensource/cppcheck/pull/4385/commits
Checks 0 https://github.com/cppcheck-opensource/cppcheck/pull/4385/checks
Files changed https://github.com/cppcheck-opensource/cppcheck/pull/4385/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/4385/files
smallvector.h: bake reserve() into the non-boost SmallVector implementation https://github.com/cppcheck-opensource/cppcheck/pull/4385/files#top
Show all changes 1 commit https://github.com/cppcheck-opensource/cppcheck/pull/4385/files
99d36fa smallvector.h: bake `reserve()` into the non-boost `SmallVector` impl… firewave Aug 19, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/4385/commits/99d36fa7c2863d3eb3320162968fe4fd6e32db10
Clear filters https://github.com/cppcheck-opensource/cppcheck/pull/4385/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/4385/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/4385/files
lib/smallvector.hhttps://github.com/cppcheck-opensource/cppcheck/pull/4385/files#diff-0c94fb6c712d9ac1f67460dd6d123e0ea2a87f122e131d81226390e610394653
View file https://github.com/firewave/cppcheck/blob/99d36fa7c2863d3eb3320162968fe4fd6e32db10/lib/smallvector.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/4385/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/4385/files#diff-0c94fb6c712d9ac1f67460dd6d123e0ea2a87f122e131d81226390e610394653
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.