René's URL Explorer Experiment


Title: Replace tinyxml2_LIBRARY with tinyxml2_LIBRARIES by gdsotirov · Pull Request #3897 · cppcheck-opensource/cppcheck · GitHub

Open Graph Title: Replace tinyxml2_LIBRARY with tinyxml2_LIBRARIES by gdsotirov · Pull Request #3897 · cppcheck-opensource/cppcheck

X Title: Replace tinyxml2_LIBRARY with tinyxml2_LIBRARIES by gdsotirov · Pull Request #3897 · cppcheck-opensource/cppcheck

Description: I was not able to report an issue, so I use this pull request to report the problem and hopefully solve it together. Building cppcheck 2.7 with system's tinyxml2 library (i.e. setting USE_BUNDLED_TINYXML2=OFF) fails with the following: CMake Error at gui/test/benchmark/simple/CMakeLists.txt:4 (add_executable): Error evaluating generator expression: $ Objects of target "tinyxml2_objs" referenced but no such target exists. I found and applied the changes from commit 974dd5d (which was made the day after 2.7 release BTW), but build still fails for "undefined symbols" from TinyXML2, because the library is not linked (no -ltinyxml2) to several targets. The reason for this seams to be that variable tinyxml2_LIBRARY is not defined (see cmake/findDependencies.cmake:51). I therefore simply replaced the variable just to be able to build. However, the correct solution should be to properly define tinyxml2_LIBRARY for which I think find_library(tinyxml2_LIBRARY tinyxml2) should be called also when tinyxml2 package is found. Let me know what you think and I'll update the PR.

Open Graph Description: I was not able to report an issue, so I use this pull request to report the problem and hopefully solve it together. Building cppcheck 2.7 with system's tinyxml2 library (i.e. setting USE_BUNDL...

X Description: I was not able to report an issue, so I use this pull request to report the problem and hopefully solve it together. Building cppcheck 2.7 with system's tinyxml2 library (i.e. setting USE_B...

Opengraph URL: https://github.com/cppcheck-opensource/cppcheck/pull/3897

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:27ca168c-9481-e937-a891-f69c30b157b0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8698:6B261:CDDA18:121A007:6A4CA507
html-safe-noncea90c4d1254ecc557bcb4aeb4c1d2e8bd6a510e79bed2ccc89a398fd10972a516
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Njk4OjZCMjYxOkNEREExODoxMjFBMDA3OjZBNENBNTA3IiwidmlzaXRvcl9pZCI6IjgzNjc0ODA1NjM3MzMxNDQ4MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf384fa058b01341d28cb33cc80e420b1b2c105a7bb013673ee4022abdc77e0a8
hovercard-subject-tagpull_request:878468460
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/cppcheck-opensource/cppcheck/pull/3897/files
twitter:imagehttps://avatars.githubusercontent.com/u/955033?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/955033?s=400&v=4
og:image:altI was not able to report an issue, so I use this pull request to report the problem and hopefully solve it together. Building cppcheck 2.7 with system's tinyxml2 library (i.e. setting USE_BUNDL...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git
octolytics-dimension-user_id278097703
octolytics-dimension-user_logincppcheck-opensource
octolytics-dimension-repository_id143131
octolytics-dimension-repository_nwocppcheck-opensource/cppcheck
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143131
octolytics-dimension-repository_network_root_nwocppcheck-opensource/cppcheck
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseae90d426644ca15e89bacceb72e51f4e9dbf85f7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/cppcheck-opensource/cppcheck/pull/3897/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F3897%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F3897%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=cppcheck-opensource%2Fcppcheck
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/3897/files
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/3897/files
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/3897/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/3897/files
cppcheck-opensource https://github.com/cppcheck-opensource
cppcheckhttps://github.com/cppcheck-opensource/cppcheck
Notifications https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Fork 1.6k https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Star 6.7k https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Code https://github.com/cppcheck-opensource/cppcheck
Pull requests 205 https://github.com/cppcheck-opensource/cppcheck/pulls
Actions https://github.com/cppcheck-opensource/cppcheck/actions
Security and quality 0 https://github.com/cppcheck-opensource/cppcheck/security
Insights https://github.com/cppcheck-opensource/cppcheck/pulse
Code https://github.com/cppcheck-opensource/cppcheck
Pull requests https://github.com/cppcheck-opensource/cppcheck/pulls
Actions https://github.com/cppcheck-opensource/cppcheck/actions
Security and quality https://github.com/cppcheck-opensource/cppcheck/security
Insights https://github.com/cppcheck-opensource/cppcheck/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fcppcheck-opensource%2Fcppcheck%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck%2Fissues%2Fnew%2Fchoose
firewavehttps://github.com/firewave
cppcheck-opensource:mainhttps://github.com/cppcheck-opensource/cppcheck/tree/main
gdsotirov:fix_tinyxml2_systemhttps://github.com/gdsotirov/cppcheck/tree/fix_tinyxml2_system
Conversation 16 https://github.com/cppcheck-opensource/cppcheck/pull/3897
Commits 4 https://github.com/cppcheck-opensource/cppcheck/pull/3897/commits
Checks 0 https://github.com/cppcheck-opensource/cppcheck/pull/3897/checks
Files changed https://github.com/cppcheck-opensource/cppcheck/pull/3897/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/3897/files
Replace tinyxml2_LIBRARY with tinyxml2_LIBRARIES https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#top
Show all changes 4 commits https://github.com/cppcheck-opensource/cppcheck/pull/3897/files
b8b3511 Do not use tinyxml2_LIBRARY as it is not defined gdsotirov Mar 13, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/3897/commits/b8b35112e205349a53732e5703ed5033c39a1cac
f245dd9 Replace tinyxml2_LIBRARY with tinyxml2_LIBRARIES gdsotirov Mar 14, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/3897/commits/f245dd91d8ae6778eddf04544c8feb23a3c550dc
056b558 Change variable name also in message text gdsotirov Mar 14, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/3897/commits/056b55865f4bbeb7d8483024ace02ed0f6b75537
e5c8d27 Rename tinyxml2_LIBRARY to tinyxml2_LIBRARIES gdsotirov Mar 15, 2022 https://github.com/cppcheck-opensource/cppcheck/pull/3897/commits/e5c8d275ac0ed5eb1a2e793fea0e60d0a510601e
Clear filters https://github.com/cppcheck-opensource/cppcheck/pull/3897/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/3897/files
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/3897/files
CMakeLists.txt https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-c5c3bdd00b56a091c6aed590eeb1ce30fc7709838595cb14d0e93135bd852640
findDependencies.cmake https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-33613d774c092c0a4923f1a0c0a17f88e932a0f839012dcf0ec17f1e1bfc5e87
printInfo.cmake https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-699313ed2ae41fae12e16008923ac2691facb069a331f3d1607ced8a615d7a26
CMakeLists.txt https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-c6a6d5a45a2ed1ea6787303875556a824d973664b51261d3555ecd6a6a8679f2
CMakeLists.txt https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-4bc09fba70c94a00234489d88f82b7ebd124db011137b5bd99b4a360102f7cc7
CMakeLists.txt https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-5654dec623e353a077e414bb7b7d7818b6947041100d5703e78aa493a2a4eaf1
CMakeLists.txt https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-c6c264ab475333b8ebde6a92d3452ab2c545e03228feef604b95b7d01d1e0c8f
CMakeLists.txt https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-33394812ba204689144fd2f80832db83853ba1cb32403edb4e15fe4893e675fd
cli/CMakeLists.txthttps://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-c5c3bdd00b56a091c6aed590eeb1ce30fc7709838595cb14d0e93135bd852640
View file https://github.com/gdsotirov/cppcheck/blob/e5c8d275ac0ed5eb1a2e793fea0e60d0a510601e/cli/CMakeLists.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/3897/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-c5c3bdd00b56a091c6aed590eeb1ce30fc7709838595cb14d0e93135bd852640
https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-c5c3bdd00b56a091c6aed590eeb1ce30fc7709838595cb14d0e93135bd852640
cmake/findDependencies.cmakehttps://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-33613d774c092c0a4923f1a0c0a17f88e932a0f839012dcf0ec17f1e1bfc5e87
View file https://github.com/gdsotirov/cppcheck/blob/e5c8d275ac0ed5eb1a2e793fea0e60d0a510601e/cmake/findDependencies.cmake
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/3897/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-33613d774c092c0a4923f1a0c0a17f88e932a0f839012dcf0ec17f1e1bfc5e87
https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-33613d774c092c0a4923f1a0c0a17f88e932a0f839012dcf0ec17f1e1bfc5e87
cmake/printInfo.cmakehttps://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-699313ed2ae41fae12e16008923ac2691facb069a331f3d1607ced8a615d7a26
View file https://github.com/gdsotirov/cppcheck/blob/e5c8d275ac0ed5eb1a2e793fea0e60d0a510601e/cmake/printInfo.cmake
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/3897/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-699313ed2ae41fae12e16008923ac2691facb069a331f3d1607ced8a615d7a26
https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-699313ed2ae41fae12e16008923ac2691facb069a331f3d1607ced8a615d7a26
gui/CMakeLists.txthttps://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-c6a6d5a45a2ed1ea6787303875556a824d973664b51261d3555ecd6a6a8679f2
View file https://github.com/gdsotirov/cppcheck/blob/e5c8d275ac0ed5eb1a2e793fea0e60d0a510601e/gui/CMakeLists.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/3897/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-c6a6d5a45a2ed1ea6787303875556a824d973664b51261d3555ecd6a6a8679f2
https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-c6a6d5a45a2ed1ea6787303875556a824d973664b51261d3555ecd6a6a8679f2
gui/test/benchmark/simple/CMakeLists.txthttps://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-4bc09fba70c94a00234489d88f82b7ebd124db011137b5bd99b4a360102f7cc7
View file https://github.com/gdsotirov/cppcheck/blob/e5c8d275ac0ed5eb1a2e793fea0e60d0a510601e/gui/test/benchmark/simple/CMakeLists.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/3897/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-4bc09fba70c94a00234489d88f82b7ebd124db011137b5bd99b4a360102f7cc7
https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-4bc09fba70c94a00234489d88f82b7ebd124db011137b5bd99b4a360102f7cc7
gui/test/xmlreportv2/CMakeLists.txthttps://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-5654dec623e353a077e414bb7b7d7818b6947041100d5703e78aa493a2a4eaf1
View file https://github.com/gdsotirov/cppcheck/blob/e5c8d275ac0ed5eb1a2e793fea0e60d0a510601e/gui/test/xmlreportv2/CMakeLists.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/3897/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-5654dec623e353a077e414bb7b7d7818b6947041100d5703e78aa493a2a4eaf1
oss-fuzz/CMakeLists.txthttps://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-c6c264ab475333b8ebde6a92d3452ab2c545e03228feef604b95b7d01d1e0c8f
View file https://github.com/gdsotirov/cppcheck/blob/e5c8d275ac0ed5eb1a2e793fea0e60d0a510601e/oss-fuzz/CMakeLists.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/3897/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-c6c264ab475333b8ebde6a92d3452ab2c545e03228feef604b95b7d01d1e0c8f
https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-c6c264ab475333b8ebde6a92d3452ab2c545e03228feef604b95b7d01d1e0c8f
test/CMakeLists.txthttps://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-33394812ba204689144fd2f80832db83853ba1cb32403edb4e15fe4893e675fd
View file https://github.com/gdsotirov/cppcheck/blob/e5c8d275ac0ed5eb1a2e793fea0e60d0a510601e/test/CMakeLists.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/3897/{{ revealButtonHref }}
https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-33394812ba204689144fd2f80832db83853ba1cb32403edb4e15fe4893e675fd
https://github.com/cppcheck-opensource/cppcheck/pull/3897/files#diff-33394812ba204689144fd2f80832db83853ba1cb32403edb4e15fe4893e675fd
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.