Title: Unify enabling style checks in Settings-class. by kimmov · Pull Request #30 · cppcheck-opensource/cppcheck · GitHub
Open Graph Title: Unify enabling style checks in Settings-class. by kimmov · Pull Request #30 · cppcheck-opensource/cppcheck
X Title: Unify enabling style checks in Settings-class. by kimmov · Pull Request #30 · cppcheck-opensource/cppcheck
Description: I noticed all other enable-options from CLI are handled as "enable-list" in Settings class. But style checks have their own boolean attribute. So instead of this: settings->_checkCodingStyle = true; settings->addEnabled("information"); it is cleaner and more consistent to have this: settings->addEnabled("style"); settings->addEnabled("information"); Admittedly this is very noisy change and not something everybody likes. Hence the pull request for others to comment..
Open Graph Description: I noticed all other enable-options from CLI are handled as "enable-list" in Settings class. But style checks have their own boolean attribute. So instead of this: settings->_checkCodin...
X Description: I noticed all other enable-options from CLI are handled as "enable-list" in Settings class. But style checks have their own boolean attribute. So instead of this: settings->...
Opengraph URL: https://github.com/cppcheck-opensource/cppcheck/pull/30
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:accee32e-2573-dd36-bb5e-6c139d4a6738 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB1A:162B2:74B1015:A401128:6A5026DE |
| html-safe-nonce | 9aa6a08dc3d0d74626cf9fa3a1c27ffd62944b84f9f2046159014637d912666e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjFBOjE2MkIyOjc0QjEwMTU6QTQwMTEyODo2QTUwMjZERSIsInZpc2l0b3JfaWQiOiI1MjQ1MjI3OTE0Mzc1NDcyODYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 3dd355af6d48136d4fe32e5c221a7dbf2317b775e2adda03a928912de46ddb7b |
| hovercard-subject-tag | pull_request:252793 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/cppcheck-opensource/cppcheck/pull/30/files |
| twitter:image | https://avatars.githubusercontent.com/u/60467?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/60467?s=400&v=4 |
| og:image:alt | I noticed all other enable-options from CLI are handled as "enable-list" in Settings class. But style checks have their own boolean attribute. So instead of this: settings->_checkCodin... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git |
| octolytics-dimension-user_id | 278097703 |
| octolytics-dimension-user_login | cppcheck-opensource |
| octolytics-dimension-repository_id | 143131 |
| octolytics-dimension-repository_nwo | cppcheck-opensource/cppcheck |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143131 |
| octolytics-dimension-repository_network_root_nwo | cppcheck-opensource/cppcheck |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d90666eaf032b7eb8975a378efe38e37f4ebb96c |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width