René's URL Explorer Experiment


Title: got rid of some implicit conversions to avoid UBSAN warnings by firewave · Pull Request #2990 · cppcheck-opensource/cppcheck · GitHub

Open Graph Title: got rid of some implicit conversions to avoid UBSAN warnings by firewave · Pull Request #2990 · cppcheck-opensource/cppcheck

X Title: got rid of some implicit conversions to avoid UBSAN warnings by firewave · Pull Request #2990 · cppcheck-opensource/cppcheck

Description: static analysis of C/C++ code. Contribute to cppcheck-opensource/cppcheck development by creating an account on GitHub.

Open Graph Description: Extracted from #2922 since that needs more work regarding older Visual Studio versions. There's probably some compiler warnings which would point these out at compile-time. But that's somet...

X Description: Extracted from #2922 since that needs more work regarding older Visual Studio versions. There's probably some compiler warnings which would point these out at compile-time. But that&#39...

Opengraph URL: https://github.com/cppcheck-opensource/cppcheck/pull/2990

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6603f273-6ff3-e9ef-3260-ec23d24cb13c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id88B6:12A1BB:C6D995:108F5DB:6A52C214
html-safe-nonce9c0acc5c410fc82b2be68ae93966c76e6c991cbd01de2d0cf58225542d67744c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OEI2OjEyQTFCQjpDNkQ5OTU6MTA4RjVEQjo2QTUyQzIxNCIsInZpc2l0b3JfaWQiOiIyMjc0MDc0MTY0NDA2MTc0MjI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9b0bb0ba5788e533698a7b1d7326360c5fa9cebbd53317f4066cfccc268158e1
hovercard-subject-tagpull_request:545804962
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/cppcheck-opensource/cppcheck/2990/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a7dbe3c8d5a5c551cfa245fd26a22cf315349074b3636ee01d0b0bc63a59497f/cppcheck-opensource/cppcheck/pull/2990
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a7dbe3c8d5a5c551cfa245fd26a22cf315349074b3636ee01d0b0bc63a59497f/cppcheck-opensource/cppcheck/pull/2990
og:image:altExtracted from #2922 since that needs more work regarding older Visual Studio versions. There's probably some compiler warnings which would point these out at compile-time. But that's somet...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefirewave
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git
octolytics-dimension-user_id278097703
octolytics-dimension-user_logincppcheck-opensource
octolytics-dimension-repository_id143131
octolytics-dimension-repository_nwocppcheck-opensource/cppcheck
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id143131
octolytics-dimension-repository_network_root_nwocppcheck-opensource/cppcheck
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/cppcheck-opensource/cppcheck/pull/2990#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F2990
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F2990
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=cppcheck-opensource%2Fcppcheck
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/2990
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/2990
Reloadhttps://github.com/cppcheck-opensource/cppcheck/pull/2990
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
cppcheck-opensource https://github.com/cppcheck-opensource
cppcheckhttps://github.com/cppcheck-opensource/cppcheck
Notifications https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Fork 1.6k https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Star 6.7k https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck
Code https://github.com/cppcheck-opensource/cppcheck
Pull requests 201 https://github.com/cppcheck-opensource/cppcheck/pulls
Actions https://github.com/cppcheck-opensource/cppcheck/actions
Security and quality 0 https://github.com/cppcheck-opensource/cppcheck/security
Insights https://github.com/cppcheck-opensource/cppcheck/pulse
Code https://github.com/cppcheck-opensource/cppcheck
Pull requests https://github.com/cppcheck-opensource/cppcheck/pulls
Actions https://github.com/cppcheck-opensource/cppcheck/actions
Security and quality https://github.com/cppcheck-opensource/cppcheck/security
Insights https://github.com/cppcheck-opensource/cppcheck/pulse
firewavehttps://github.com/firewave
cppcheck-opensource:mainhttps://github.com/cppcheck-opensource/cppcheck/tree/main
firewave:test-asserthttps://github.com/firewave/cppcheck/tree/test-assert
Conversationhttps://github.com/cppcheck-opensource/cppcheck/pull/2990
Commits2 (2)https://github.com/cppcheck-opensource/cppcheck/pull/2990/commits
Checkshttps://github.com/cppcheck-opensource/cppcheck/pull/2990/checks
Files changedhttps://github.com/cppcheck-opensource/cppcheck/pull/2990/files
got rid of some implicit conversions to avoid UBSAN warningshttps://github.com/cppcheck-opensource/cppcheck/pull/2990#top
firewavehttps://github.com/firewave
cppcheck-opensource:mainhttps://github.com/cppcheck-opensource/cppcheck/tree/main
firewave:test-asserthttps://github.com/firewave/cppcheck/tree/test-assert
https://github.com/firewave
firewavehttps://github.com/firewave
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#issue-775034403
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
#2922https://github.com/cppcheck-opensource/cppcheck/pull/2922
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
firewavehttps://github.com/firewave
December 27, 2020 14:56https://github.com/cppcheck-opensource/cppcheck/pull/2990#commits-pushed-f1d7d0f
https://github.com/firewave
adjusted ASSERT_EQUALS() checks so types are the same on both sideshttps://github.com/cppcheck-opensource/cppcheck/pull/2990/commits/f1d7d0f1d4335699879f70583bf383a390b1c537
f1d7d0fhttps://github.com/cppcheck-opensource/cppcheck/pull/2990/commits/f1d7d0f1d4335699879f70583bf383a390b1c537
https://github.com/firewave
made some conversions explicit to avoid UBSAN warningshttps://github.com/cppcheck-opensource/cppcheck/pull/2990/commits/045d06f0629e83b4273996d42dd18763941ab4a5
045d06fhttps://github.com/cppcheck-opensource/cppcheck/pull/2990/commits/045d06f0629e83b4273996d42dd18763941ab4a5
https://github.com/firewave
firewavehttps://github.com/firewave
force-pushedhttps://github.com/cppcheck-opensource/cppcheck/compare/8d03cd1d0660d0e30937822c1fc491026eb31987..045d06f0629e83b4273996d42dd18763941ab4a5
8d03cd1https://github.com/cppcheck-opensource/cppcheck/commit/8d03cd1d0660d0e30937822c1fc491026eb31987
045d06fhttps://github.com/cppcheck-opensource/cppcheck/commit/045d06f0629e83b4273996d42dd18763941ab4a5
Compare https://github.com/cppcheck-opensource/cppcheck/compare/8d03cd1d0660d0e30937822c1fc491026eb31987..045d06f0629e83b4273996d42dd18763941ab4a5
December 27, 2020 13:57https://github.com/cppcheck-opensource/cppcheck/pull/2990#event-4150309165
https://github.com/danmar
danmarhttps://github.com/danmar
Dec 27, 2020 https://github.com/cppcheck-opensource/cppcheck/pull/2990#pullrequestreview-558935982
View reviewed changes https://github.com/cppcheck-opensource/cppcheck/pull/2990/files/045d06f0629e83b4273996d42dd18763941ab4a5
cli/cmdlineparser.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/2990/files/045d06f0629e83b4273996d42dd18763941ab4a5#diff-52ae9cc3136ebba4f9e1106f8b87f002e9e620f0466da105d96ae5a6d0d86414
danmarhttps://github.com/danmar
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#discussion_r549124551
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
firewavehttps://github.com/firewave
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#discussion_r549128662
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
danmarhttps://github.com/danmar
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#discussion_r549138044
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
danmarhttps://github.com/danmar
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#discussion_r549158674
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
e7c462bhttps://github.com/cppcheck-opensource/cppcheck/commit/e7c462b8279428e9722e0d1a1b85b9d84308be2b
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
lib/mathlib.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/2990/files/045d06f0629e83b4273996d42dd18763941ab4a5#diff-8a42f1c25b025b26f10aa71765ac7ad2a4df2da864719d8f6ac246c56fa2414c
danmarhttps://github.com/danmar
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#discussion_r549124900
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
firewavehttps://github.com/firewave
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#discussion_r549128689
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
danmarhttps://github.com/danmar
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#discussion_r549138299
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
lib/valueflow.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/2990/files/045d06f0629e83b4273996d42dd18763941ab4a5#diff-16a9ec3ff1314646e106eb413234f5614e3a7f527fb82d0a369755bee65a7e31
danmarhttps://github.com/danmar
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#discussion_r549125456
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
firewavehttps://github.com/firewave
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#discussion_r549128701
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
danmarhttps://github.com/danmar
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#discussion_r549138775
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
lib/valueflow.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/2990/files/045d06f0629e83b4273996d42dd18763941ab4a5#diff-16a9ec3ff1314646e106eb413234f5614e3a7f527fb82d0a369755bee65a7e31
danmarhttps://github.com/danmar
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#discussion_r549125818
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
firewavehttps://github.com/firewave
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#discussion_r549128708
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
danmarhttps://github.com/danmar
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#discussion_r549141191
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
test/testclangimport.cpphttps://github.com/cppcheck-opensource/cppcheck/pull/2990/files/045d06f0629e83b4273996d42dd18763941ab4a5#diff-4508ea1c437be8ecb9251bb493f5b9a28c8e9c6d9b02cb2eea85725bea30f974
danmarhttps://github.com/danmar
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#discussion_r549126038
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
firewavehttps://github.com/firewave
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#discussion_r549128866
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
danmarhttps://github.com/danmar
Dec 27, 2020https://github.com/cppcheck-opensource/cppcheck/pull/2990#discussion_r549145182
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
https://github.com/firewave
firewavehttps://github.com/firewave
January 18, 2021 16:41https://github.com/cppcheck-opensource/cppcheck/pull/2990#event-4219046180
https://github.com/danmar
danmarhttps://github.com/danmar
May 5, 2021https://github.com/cppcheck-opensource/cppcheck/pull/2990#issuecomment-832426971
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
https://github.com/danmar
danmarhttps://github.com/danmar
May 5, 2021https://github.com/cppcheck-opensource/cppcheck/pull/2990#event-4686884973
https://github.co/hiddenchars
https://github.com/cppcheck-opensource/cppcheck/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F2990
https://github.com/danmar
danmar https://github.com/danmar
https://github.com/cppcheck-opensource/cppcheck/pull/2990/files/045d06f0629e83b4273996d42dd18763941ab4a5
Please reload this pagehttps://github.com/cppcheck-opensource/cppcheck/pull/2990
https://github.com/firewave
https://github.com/danmar
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.