| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:25a00ad7-25fc-1d5f-d4e2-d29cb69cf992 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E30C:1A12B5:1F70A9C:2B7CC3B:6A4ED453 |
| html-safe-nonce | 1e44f9c05c0dd0983102b40a6b49403d618173819001264ab02c5968cd3433eb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzBDOjFBMTJCNToxRjcwQTlDOjJCN0NDM0I6NkE0RUQ0NTMiLCJ2aXNpdG9yX2lkIjoiNjE4MTA1MjQyMzIwMjk0OTk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 15fac84480fdaf3081eb67c5eb79224434b5c105b9012a1aeb5f6c1f5f0d194c |
| hovercard-subject-tag | pull_request:538918971 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
| twitter:image | https://avatars.githubusercontent.com/u/38533734?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/38533734?s=400&v=4 |
| og:image:alt | Before this PR, any global variable found in function body marked this function as side-effect one. Analyzing global variables more precisely from now.
Any help with missed test cases will be highl... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/cppcheck-opensource/cppcheck git https://github.com/cppcheck-opensource/cppcheck.git |
| octolytics-dimension-user_id | 278097703 |
| octolytics-dimension-user_login | cppcheck-opensource |
| octolytics-dimension-repository_id | 143131 |
| octolytics-dimension-repository_nwo | cppcheck-opensource/cppcheck |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143131 |
| octolytics-dimension-repository_network_root_nwo | cppcheck-opensource/cppcheck |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F2944%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcppcheck-opensource%2Fcppcheck%2Fpull%2F2944%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=cppcheck-opensource%2Fcppcheck |
| Reload | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
| Reload | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
| Reload | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
|
cppcheck-opensource
| https://github.com/cppcheck-opensource |
| cppcheck | https://github.com/cppcheck-opensource/cppcheck |
|
Notifications
| https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck |
|
Fork
1.6k
| https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck |
|
Star
6.7k
| https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck |
|
Code
| https://github.com/cppcheck-opensource/cppcheck |
|
Pull requests
203
| https://github.com/cppcheck-opensource/cppcheck/pulls |
|
Actions
| https://github.com/cppcheck-opensource/cppcheck/actions |
|
Security and quality
0
| https://github.com/cppcheck-opensource/cppcheck/security |
|
Insights
| https://github.com/cppcheck-opensource/cppcheck/pulse |
|
Code
| https://github.com/cppcheck-opensource/cppcheck |
|
Pull requests
| https://github.com/cppcheck-opensource/cppcheck/pulls |
|
Actions
| https://github.com/cppcheck-opensource/cppcheck/actions |
|
Security and quality
| https://github.com/cppcheck-opensource/cppcheck/security |
|
Insights
| https://github.com/cppcheck-opensource/cppcheck/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fcppcheck-opensource%2Fcppcheck%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fcppcheck-opensource%2Fcppcheck%2Fissues%2Fnew%2Fchoose |
| danmar | https://github.com/danmar |
| cppcheck-opensource:main | https://github.com/cppcheck-opensource/cppcheck/tree/main |
| miltolstoy:globals_without_sideefect | https://github.com/miltolstoy/cppcheck/tree/globals_without_sideefect |
|
Conversation
17
| https://github.com/cppcheck-opensource/cppcheck/pull/2944 |
|
Commits
5
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/commits |
|
Checks
0
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/checks |
|
Files changed
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
|
feat(unused_var): analyze global variables inside function body
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#top |
|
Show all changes
5 commits
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
|
a71cd03
feat(unused_var): analyze global variables inside function body
miltolstoy Dec 13, 2020
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/commits/a71cd03e3b27b54322dd40cc0c4882475a6ae9c2 |
|
d352b15
self-check error fix
miltolstoy Dec 13, 2020
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/commits/d352b158fde7f06ccdff1e430698abf95e2ab850 |
|
4a6018f
change std::list to std::set for pointersToGlobals
miltolstoy Dec 15, 2020
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/commits/4a6018faa51acfa2d3008ddba8cf29de3d326522 |
|
b93f9f9
treat all operations with global pointers/arrays as side-effect
miltolstoy Dec 17, 2020
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/commits/b93f9f945ba0e4c94954a7575886f9ee6fe9d4ee |
|
14d0d32
update search in pointersToGlobals
miltolstoy Dec 17, 2020
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/commits/14d0d328dea18607dc3c9aec3bec8c9226047ad7 |
|
Clear filters
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
|
checkunusedvar.cpp
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#diff-274e511bea038ba56b2904546e03caed681aa491e5c62bb64c7ac35e953d9669 |
|
testunusedvar.cpp
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#diff-01b9f5f20a714a3c7b2604c1a3d539a46d669bfe30f50581dc83974cdb56f205 |
| lib/checkunusedvar.cpp | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#diff-274e511bea038ba56b2904546e03caed681aa491e5c62bb64c7ac35e953d9669 |
|
View file
| https://github.com/miltolstoy/cppcheck/blob/14d0d328dea18607dc3c9aec3bec8c9226047ad7/lib/checkunusedvar.cpp |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/{{ revealButtonHref }} |
|
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#diff-274e511bea038ba56b2904546e03caed681aa491e5c62bb64c7ac35e953d9669 |
| danmar | https://github.com/danmar |
| Dec 14, 2020 | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#r542569766 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
| miltolstoy | https://github.com/miltolstoy |
| Dec 15, 2020 | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#r543482964 |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
| danmar | https://github.com/danmar |
| Dec 15, 2020 | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#r543635688 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
| miltolstoy | https://github.com/miltolstoy |
| Dec 16, 2020 | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#r544511167 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
| danmar | https://github.com/danmar |
| Dec 16, 2020 | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#r544527071 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files |
|
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#diff-274e511bea038ba56b2904546e03caed681aa491e5c62bb64c7ac35e953d9669 |
| test/testunusedvar.cpp | https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#diff-01b9f5f20a714a3c7b2604c1a3d539a46d669bfe30f50581dc83974cdb56f205 |
|
View file
| https://github.com/miltolstoy/cppcheck/blob/14d0d328dea18607dc3c9aec3bec8c9226047ad7/test/testunusedvar.cpp |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/{{ revealButtonHref }} |
|
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#diff-01b9f5f20a714a3c7b2604c1a3d539a46d669bfe30f50581dc83974cdb56f205 |
|
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#diff-01b9f5f20a714a3c7b2604c1a3d539a46d669bfe30f50581dc83974cdb56f205 |
|
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#diff-01b9f5f20a714a3c7b2604c1a3d539a46d669bfe30f50581dc83974cdb56f205 |
|
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#diff-01b9f5f20a714a3c7b2604c1a3d539a46d669bfe30f50581dc83974cdb56f205 |
|
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#diff-01b9f5f20a714a3c7b2604c1a3d539a46d669bfe30f50581dc83974cdb56f205 |
|
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#diff-01b9f5f20a714a3c7b2604c1a3d539a46d669bfe30f50581dc83974cdb56f205 |
|
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#diff-01b9f5f20a714a3c7b2604c1a3d539a46d669bfe30f50581dc83974cdb56f205 |
|
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#diff-01b9f5f20a714a3c7b2604c1a3d539a46d669bfe30f50581dc83974cdb56f205 |
|
| https://github.com/cppcheck-opensource/cppcheck/pull/2944/files#diff-01b9f5f20a714a3c7b2604c1a3d539a46d669bfe30f50581dc83974cdb56f205 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |