René's URL Explorer Experiment

Title: Sorted instances of Check by ghewgill · Pull Request #12 · cppcheck-opensource/cppcheck · GitHub

Open Graph Title: Sorted instances of Check by ghewgill · Pull Request #12 · cppcheck-opensource/cppcheck

X Title: Sorted instances of Check by ghewgill · Pull Request #12 · cppcheck-opensource/cppcheck

Description: I noticed that the instances().sort() in Check::Check() doesn't actually sort anything. The first commit adds a test case to check whether the instances list really is sorted. This should fail. The second commit addresses a problem with the virtual name() function. If the sort() actually did something (see below), it would try to call the pure virtual name() function before the Check instance was fully constructed. This is likely to crash depending on the library's behaviour when pure virtual functions are called. Each derived class passes its name to the Check constructor(s) which stores it in a local instance variable so the sort has something to compare. The third commit addresses the sort operation itself. Sorting a list of pointers compares pointer values, not what they point to; the operator<(const Check *) never gets called. This commit specialises std::less and passes an instance of that to the sort() function as a comparator.

Open Graph Description: I noticed that the instances().sort() in Check::Check() doesn't actually sort anything. The first commit adds a test case to check whether the instances list really is sorted. This should fail....

X Description: I noticed that the instances().sort() in Check::Check() doesn&#39;t actually sort anything. The first commit adds a test case to check whether the instances list really is sorted. This should f...

Opengraph URL: https://github.com/cppcheck-opensource/cppcheck/pull/12

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width