| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7d2d5c20-cc0c-28ad-c306-8f8c9db50e0e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A2BC:B7C7C:1922CC:2360AB:696F7BA2 |
| html-safe-nonce | 4b637a1f563c99be763c9c9f6bfa19819fea14dfbf6d20438a5a879bb3564cf1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkJDOkI3QzdDOjE5MjJDQzoyMzYwQUI6Njk2RjdCQTIiLCJ2aXNpdG9yX2lkIjoiMjE1ODM3NjA2NDc4ODY5MTg3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 82376eddba1db07e19bb6c6c2d74ad57f7aad58100ae156e5d09e4985bf7c85b |
| hovercard-subject-tag | pull_request:85725316 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/cpp-netlib/cpp-netlib/684/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/13bfba7ad8b249c791c46d4e77fb1f9b060af9804cccc309170a294b9ad31efc/cpp-netlib/cpp-netlib/pull/684 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/13bfba7ad8b249c791c46d4e77fb1f9b060af9804cccc309170a294b9ad31efc/cpp-netlib/cpp-netlib/pull/684 |
| og:image:alt | This PR replaces std::promise and std::shared_future with boost equivalents.
This change fixes the compilation errors when the ready() wrapper is used.
I've added a test and a few words of docu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dvd0101 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 759c36b32159cc867ba926786bbd5ac69b0804c9cfc86536a67b3567e8bbbb5c |
| turbo-cache-control | no-preview |
| go-import | github.com/cpp-netlib/cpp-netlib git https://github.com/cpp-netlib/cpp-netlib.git |
| octolytics-dimension-user_id | 192422 |
| octolytics-dimension-user_login | cpp-netlib |
| octolytics-dimension-repository_id | 494068 |
| octolytics-dimension-repository_nwo | cpp-netlib/cpp-netlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 469399 |
| octolytics-dimension-repository_parent_nwo | glynos/cpp-netlib |
| octolytics-dimension-repository_network_root_id | 469399 |
| octolytics-dimension-repository_network_root_nwo | glynos/cpp-netlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 08632b85cc9aa97742e56978eb25cc43ca37e51b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/cpp-netlib/cpp-netlib/pull/684#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcpp-netlib%2Fcpp-netlib%2Fpull%2F684 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcpp-netlib%2Fcpp-netlib%2Fpull%2F684 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=cpp-netlib%2Fcpp-netlib |
| Reload | https://github.com/cpp-netlib/cpp-netlib/pull/684 |
| Reload | https://github.com/cpp-netlib/cpp-netlib/pull/684 |
| Reload | https://github.com/cpp-netlib/cpp-netlib/pull/684 |
|
cpp-netlib
| https://github.com/cpp-netlib |
| cpp-netlib | https://github.com/cpp-netlib/cpp-netlib |
| glynos/cpp-netlib | https://github.com/glynos/cpp-netlib |
|
Notifications
| https://github.com/login?return_to=%2Fcpp-netlib%2Fcpp-netlib |
|
Fork
425
| https://github.com/login?return_to=%2Fcpp-netlib%2Fcpp-netlib |
|
Star
2k
| https://github.com/login?return_to=%2Fcpp-netlib%2Fcpp-netlib |
|
Code
| https://github.com/cpp-netlib/cpp-netlib |
|
Issues
163
| https://github.com/cpp-netlib/cpp-netlib/issues |
|
Pull requests
8
| https://github.com/cpp-netlib/cpp-netlib/pulls |
|
Actions
| https://github.com/cpp-netlib/cpp-netlib/actions |
|
Projects
0
| https://github.com/cpp-netlib/cpp-netlib/projects |
|
Wiki
| https://github.com/cpp-netlib/cpp-netlib/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/cpp-netlib/cpp-netlib/security |
| Please reload this page | https://github.com/cpp-netlib/cpp-netlib/pull/684 |
|
Insights
| https://github.com/cpp-netlib/cpp-netlib/pulse |
|
Code
| https://github.com/cpp-netlib/cpp-netlib |
|
Issues
| https://github.com/cpp-netlib/cpp-netlib/issues |
|
Pull requests
| https://github.com/cpp-netlib/cpp-netlib/pulls |
|
Actions
| https://github.com/cpp-netlib/cpp-netlib/actions |
|
Projects
| https://github.com/cpp-netlib/cpp-netlib/projects |
|
Wiki
| https://github.com/cpp-netlib/cpp-netlib/wiki |
|
Security
| https://github.com/cpp-netlib/cpp-netlib/security |
|
Insights
| https://github.com/cpp-netlib/cpp-netlib/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fcpp-netlib%2Fcpp-netlib%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fcpp-netlib%2Fcpp-netlib%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/cpp-netlib/cpp-netlib/pull/684#issue-comment-box |
| glynos | https://github.com/glynos |
| cpp-netlib:0.13-release | https://github.com/cpp-netlib/cpp-netlib/tree/0.13-release |
| dvd0101:boost_future | https://github.com/dvd0101/cpp-netlib/tree/boost_future |
|
replace std::shared_future with boost::shared_future
| https://github.com/cpp-netlib/cpp-netlib/pull/684#top |
| glynos | https://github.com/glynos |
| cpp-netlib:0.13-release | https://github.com/cpp-netlib/cpp-netlib/tree/0.13-release |
| dvd0101:boost_future | https://github.com/dvd0101/cpp-netlib/tree/boost_future |
|
Conversation
7
| https://github.com/cpp-netlib/cpp-netlib/pull/684 |
|
Commits
4
| https://github.com/cpp-netlib/cpp-netlib/pull/684/commits |
|
Checks
0
| https://github.com/cpp-netlib/cpp-netlib/pull/684/checks |
|
Files changed
| https://github.com/cpp-netlib/cpp-netlib/pull/684/files |
| Please reload this page | https://github.com/cpp-netlib/cpp-netlib/pull/684 |
| https://github.co/hiddenchars |
| https://github.com/cpp-netlib/cpp-netlib/pull/{{ revealButtonHref }} |
|
| https://github.com/dvd0101 |
| dvd0101 | https://github.com/dvd0101 |
| Sep 18, 2016 | https://github.com/cpp-netlib/cpp-netlib/pull/684#issue-177681560 |
| #683 | https://github.com/cpp-netlib/cpp-netlib/issues/683 |
| #592 | https://github.com/cpp-netlib/cpp-netlib/issues/592 |
| Please reload this page | https://github.com/cpp-netlib/cpp-netlib/pull/684 |
| dvd0101 | https://github.com/dvd0101 |
| September 19, 2016 00:08 | https://github.com/cpp-netlib/cpp-netlib/pull/684#commits-pushed-d5df753 |
|
| https://github.com/dvd0101 |
| new test to cover the ready() wrapper | https://github.com/cpp-netlib/cpp-netlib/pull/684/commits/d5df753e415b954c92092145bd89c97a09d6a58d |
| d5df753 | https://github.com/cpp-netlib/cpp-netlib/pull/684/commits/d5df753e415b954c92092145bd89c97a09d6a58d |
|
| https://github.com/dvd0101 |
| replace std::promise/std::shared_future with boost equivalents | https://github.com/cpp-netlib/cpp-netlib/pull/684/commits/ecdae1ee72de81667ea04e60c46e0e1ec94800c1 |
| ecdae1e | https://github.com/cpp-netlib/cpp-netlib/pull/684/commits/ecdae1ee72de81667ea04e60c46e0e1ec94800c1 |
|
| https://github.com/dvd0101 |
| docs | https://github.com/cpp-netlib/cpp-netlib/pull/684/commits/db13ac30b51481582f3b339aa8666cb10d3b53ba |
| db13ac3 | https://github.com/cpp-netlib/cpp-netlib/pull/684/commits/db13ac30b51481582f3b339aa8666cb10d3b53ba |
| https://github.com/deanberris |
| deanberris | https://github.com/deanberris |
| glynos | https://github.com/glynos |
| Sep 19, 2016 | https://github.com/cpp-netlib/cpp-netlib/pull/684#event-793720884 |
| https://github.com/deanberris |
| deanberris | https://github.com/deanberris |
| Sep 19, 2016 | https://github.com/cpp-netlib/cpp-netlib/pull/684#issuecomment-247940257 |
| @cinghiale | https://github.com/cinghiale |
| Please reload this page | https://github.com/cpp-netlib/cpp-netlib/pull/684 |
| https://github.com/dvd0101 |
| dvd0101 | https://github.com/dvd0101 |
| Sep 19, 2016 | https://github.com/cpp-netlib/cpp-netlib/pull/684#issuecomment-247953127 |
| @deanberris | https://github.com/deanberris |
| Please reload this page | https://github.com/cpp-netlib/cpp-netlib/pull/684 |
|
| https://github.com/dvd0101 |
| trigger travis | https://github.com/cpp-netlib/cpp-netlib/pull/684/commits/9835d2499fa077381c9c0df16847c63e0ecef060 |
| 9835d24 | https://github.com/cpp-netlib/cpp-netlib/pull/684/commits/9835d2499fa077381c9c0df16847c63e0ecef060 |
| https://github.com/dvd0101 |
| dvd0101 | https://github.com/dvd0101 |
| Sep 19, 2016 | https://github.com/cpp-netlib/cpp-netlib/pull/684#issuecomment-248099301 |
| Please reload this page | https://github.com/cpp-netlib/cpp-netlib/pull/684 |
| https://github.com/deanberris |
| deanberris | https://github.com/deanberris |
| Sep 20, 2016 | https://github.com/cpp-netlib/cpp-netlib/pull/684#issuecomment-248308247 |
| @cinghiale | https://github.com/cinghiale |
| @glynos | https://github.com/glynos |
| Please reload this page | https://github.com/cpp-netlib/cpp-netlib/pull/684 |
| https://github.com/glynos |
| glynos | https://github.com/glynos |
| 9835d24 | https://github.com/cpp-netlib/cpp-netlib/commit/9835d2499fa077381c9c0df16847c63e0ecef060 |
| Sep 24, 2016 | https://github.com/cpp-netlib/cpp-netlib/pull/684#event-801194933 |
| https://github.com/glynos |
| glynos | https://github.com/glynos |
| Sep 24, 2016 | https://github.com/cpp-netlib/cpp-netlib/pull/684#issuecomment-249350518 |
| @cinghiale | https://github.com/cinghiale |
| Please reload this page | https://github.com/cpp-netlib/cpp-netlib/pull/684 |
| https://github.com/dvd0101 |
| dvd0101 | https://github.com/dvd0101 |
| Oct 9, 2016 | https://github.com/cpp-netlib/cpp-netlib/pull/684#issuecomment-252480651 |
| Please reload this page | https://github.com/cpp-netlib/cpp-netlib/pull/684 |
| https://github.com/deanberris |
| deanberris | https://github.com/deanberris |
| Oct 10, 2016 | https://github.com/cpp-netlib/cpp-netlib/pull/684#issuecomment-252566413 |
| @cinghiale | https://github.com/cinghiale |
| @glynos | https://github.com/glynos |
| Please reload this page | https://github.com/cpp-netlib/cpp-netlib/pull/684 |
| https://github.com/dvd0101 |
| dvd0101 | https://github.com/dvd0101 |
|
Oct 15, 2016
| https://github.com/cpp-netlib/cpp-netlib/pull/684#ref-pullrequest-183218794 |
|
Boost future master
#698
| https://github.com/cpp-netlib/cpp-netlib/pull/698 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcpp-netlib%2Fcpp-netlib%2Fpull%2F684 |
|
| https://github.com/glynos |
|
glynos
| https://github.com/glynos |
| Please reload this page | https://github.com/cpp-netlib/cpp-netlib/pull/684 |
|
| https://github.com/dvd0101 |
|
| https://github.com/deanberris |
|
| https://github.com/glynos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |