René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"UnhandledPromiseRejection thrown from within SDK","articleBody":"Greetings,\r\n\r\nIt appears that the SDK has the potential to cause an `UnhandledPromiseRejection` when the Contentstack REST API returns a non-well-formed JSON response (such as HTML).\r\n\r\nIn the future versions of Node.js, this will cause the process to crash, as suggested by the deprecation warning:\r\n\r\n\u003e [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.\r\n\r\n## Exception Example\r\n\r\n```\r\n$ node index.js\r\n(node:26048) UnhandledPromiseRejectionWarning: FetchError: invalid json response body at https://REDACTED:443/v3/content_types/REDACTED/entries/?locale=en-us\u0026include_count=true\u0026environment=REDACTED reason: Unexpected token \u003c in JSON at position 9\r\n    at eval (webpack://Contentstack/./node_modules/node-fetch/lib/index.mjs?:276:32)\r\n    at processTicksAndRejections (internal/process/task_queues.js:97:5)\r\n(node:26048) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)\r\n(node:26048) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.\r\n```\r\n\r\n## Minimal reproduction example\r\n\r\n```\r\nnpm install dotenv node-request-interceptor contentstack\r\n```\r\n\r\n```js\r\nrequire('dotenv').config()\r\n\r\nconst Contentstack = require('contentstack');\r\nconst { RequestInterceptor } = require('node-request-interceptor');\r\nconst { default: withDefaultInterceptors } = require('node-request-interceptor/lib/presets/default');\r\n\r\nconst interceptor = new RequestInterceptor(withDefaultInterceptors)\r\n\r\n// Log any outgoing requests to contentstack and return a mock HTML response\r\n// which will cause the SDK to throw an unhandled exception\r\ninterceptor.use((req) =\u003e {\r\n\r\n    console.log('%s %s', req.method, req.url.href);\r\n\r\n    return {\r\n        status: 401,\r\n        headers: {\r\n            'x-powered-by': 'node-request-interceptor',\r\n            'content-type': 'text/html'\r\n        },\r\n        body: `\r\n        \u003chtml\u003e\r\n        \u003chead\u003e\u003c/head\u003e\r\n        \u003cbody\u003e\r\n            \u003ch1\u003eUnauthorized\u003c/h1\u003e\r\n        \u003c/body\u003e\r\n        \u003c/html\u003e\r\n        `,\r\n    }\r\n});\r\n\r\nconst Stack = Contentstack.Stack(\r\n    process.env.CONTENTSTACK_API_KEY,\r\n    process.env.CONTENTSTACK_DELIVERY_TOKEN,\r\n    process.env.CONTENTSTACK_ENVIRONMENT,\r\n    process.env.CONTENTSTACK_DB_REGION || null,\r\n    { timeout: 5000 });\r\n\r\nStack.setHost(process.env.CONTENTSTACK_HOST);\r\n\r\nconst Query = Stack\r\n    .ContentType(process.env.CONTENTSTACK_CONTENT_TYPE)\r\n    .Query({})\r\n    .language(\"en-us\")\r\n    .includeCount();\r\n\r\n// Executing this async invocation cause an unhandled promise rejection\r\nQuery\r\n    .toJSON()\r\n    .find()\r\n    .then((res) =\u003e {\r\n        const [,count] = res;\r\n        console.log(`${count} total blogs.`);\r\n    }, function (err) {\r\n        // Error is not caught\r\n        console.error(err);\r\n    })\r\n    .catch((err) =\u003e {\r\n        // Error is not caught\r\n        console.error(err);\r\n    });\r\n\r\n```","author":{"url":"https://github.com/viglucci","@type":"Person","name":"viglucci"},"datePublished":"2021-01-20T00:37:36.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/41/contentstack-javascript/issues/41"}