René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"SyncStack.setJSON skips single item in \"items\" array","articleBody":"**Description:**\nThe [**SyncStack.setJSON** method ](https://github.com/contentstack/contentstack-java/blob/master/src/main/java/com/contentstack/sdk/SyncStack.java#L62C5-L86C10) is incorrectly handling scenarios where the \"**items**\" key in the provided JSONObject contains a single item.\nInstead of processing this single item, the current logic within the else block (when itemsObj is not a JSONArray) logs a warning and initializes an empty syncItems list, effectively skipping the data.\n\n**Code Snippet:**\n```java\nprotected synchronized void setJSON(@NotNull JSONObject jsonobject) {\n    if (jsonobject == null) {\n        throw new IllegalArgumentException(\"JSON object cannot be null.\");\n    }\n\n    this.receiveJson = jsonobject;\n\n    if (receiveJson.has(\"items\")) {\n        Object itemsObj = receiveJson.opt(\"items\");\n        if (itemsObj instanceof JSONArray) {\n            JSONArray jsonArray = (JSONArray) itemsObj;\n            syncItems = new ArrayList\u003c\u003e();\n            for (int i = 0; i \u003c jsonArray.length(); i++) {\n                JSONObject jsonItem = jsonArray.optJSONObject(i);\n                if (jsonItem != null) {\n                    syncItems.add(sanitizeJson(jsonItem));\n                }\n            }\n        } else {\n            logger.warning(\"'items' is not a valid list. Skipping processing.\"); // ✅ Prevent crashes\n            syncItems = new ArrayList\u003c\u003e();\n        }\n    } else {\n        syncItems = new ArrayList\u003c\u003e();\n    }\n}\n```\n\n**Observed Behavior:**\n\nWhen the \"items\" key in the receiveJson JSONObject contains a single JSON object (not a JSONArray of one element), the code enters the else block and skips processing this item. The syncItems list remains empty in this case.\n\n**Expected Behavior:**\n\nWhen the \"items\" key contains only a single JSON object, it should be treated as a single item to be processed and added to the syncItems list.\n\n**Suggested Solution:**\n\nThe else block should be modified to handle the case where itemsObj is a single JSONObject. A possible solution would be to check if itemsObj is an instance of JSONObject and, if so, create a new ArrayList, add the sanitized itemsObj to it, and assign it to syncItems.\n\n```java\n        } else {\n            if (itemsObj instanceof JSONObject) {\n                syncItems = new ArrayList\u003c\u003e();\n                syncItems.add(sanitizeJson((JSONObject) itemsObj));\n            } else {\n                logger.warning(\"'items' is not a valid list. Skipping processing.\"); // ✅ Prevent crashes\n                syncItems = new ArrayList\u003c\u003e();\n            }\n        }\n```\n\n**Impact:**\n\nThis issue leads to data loss or incomplete synchronization when the \"items\" payload from Contentstack contains a single entry. As there is any exception thrown, we consider the execution as completed, and we are updating the sync token, which leads to data loss.\n\n![Image](https://github.com/user-attachments/assets/877214da-5fcf-4ef4-86d7-52e9521725f7)","author":{"url":"https://github.com/victor-pariente-edo","@type":"Person","name":"victor-pariente-edo"},"datePublished":"2025-04-21T15:09:52.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/183/contentstack-java/issues/183"}