René's URL Explorer Experiment


Title: Reject link reference definitions with unbalanced parentheses in the destination by wleeaf · Pull Request #470 · commonmark/commonmark-java · GitHub

Open Graph Title: Reject link reference definitions with unbalanced parentheses in the destination by wleeaf · Pull Request #470 · commonmark/commonmark-java

X Title: Reject link reference definitions with unbalanced parentheses in the destination by wleeaf · Pull Request #470 · commonmark/commonmark-java

Description: A link destination may contain parentheses only if they are escaped or part of a balanced pair. LinkScanner.scanLinkDestinationWithBalancedParens checks the balance when it sees ), but returns success at a space, a control character (including the line ending) or the end of the input without checking that all opened parentheses were closed. For inline links the following ) check catches this. For link reference definitions it does not, so invalid definitions are accepted and their text disappears: Markdown cmark / commonmark.js commonmark-java [foo]: (

[foo]: (

(nothing) [foo]: (\nbar

[foo]: (\nbar

bar

[foo]: a(b\n\n[foo]

[foo]: a(b

\n

[foo]

foo

The three exits now also require parens == 0. Valid destinations such as a(b) and inline links are unaffected. Added SpecialInputTest.linkReferenceDefinitionWithUnbalancedParens; it fails before the change and passes after. mvn test passes, except that PathologicalTest.paragraphOfLinesThatTryBlockStarts hit its 3 s timeout once on a heavily loaded machine. That test is unrelated and passes when run on its own, on main as well as on this branch. spotless:check is clean. Found by differential testing against cmark.

Open Graph Description: A link destination may contain parentheses only if they are escaped or part of a balanced pair. LinkScanner.scanLinkDestinationWithBalancedParens checks the balance when it sees ), but returns succ...

X Description: A link destination may contain parentheses only if they are escaped or part of a balanced pair. LinkScanner.scanLinkDestinationWithBalancedParens checks the balance when it sees ), but returns succ...

Opengraph URL: https://github.com/commonmark/commonmark-java/pull/470

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:833602b0-4dc6-eae8-d1d7-53bd6fb91dba
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id89D8:39575D:2B914A:3A37D6:6AFBB87F
html-safe-nonce66da8c27c7fbe8623a49d8d4d98ae9659a74840b9c7e92efc42f7e5c90e1a4e0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUQ4OjM5NTc1RDoyQjkxNEE6M0EzN0Q2OjZBRkJCODdGIiwidmlzaXRvcl9pZCI6IjQwOTc0OTEwNzA5NjEzMDE2MzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7132973c45a525347d5acb3817bba63a07a3d89ed7258784368a84aedd9cdd23
hovercard-subject-tagpull_request:4996231068
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/commonmark/commonmark-java/pull/470/files
twitter:imagehttps://avatars.githubusercontent.com/u/179125857?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/179125857?s=400&v=4
og:image:altA link destination may contain parentheses only if they are escaped or part of a balanced pair. LinkScanner.scanLinkDestinationWithBalancedParens checks the balance when it sees ), but returns succ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/commonmark/commonmark-java git https://github.com/commonmark/commonmark-java.git
octolytics-dimension-user_id8661225
octolytics-dimension-user_logincommonmark
octolytics-dimension-repository_id39477878
octolytics-dimension-repository_nwocommonmark/commonmark-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id39477878
octolytics-dimension-repository_network_root_nwocommonmark/commonmark-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4cce0e99cf61481a318ff12c2e8580153a6c7c6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/commonmark/commonmark-java/pull/470/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcommonmark%2Fcommonmark-java%2Fpull%2F470%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcommonmark%2Fcommonmark-java%2Fpull%2F470%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=commonmark%2Fcommonmark-java
Reloadhttps://github.com/commonmark/commonmark-java/pull/470/files
Reloadhttps://github.com/commonmark/commonmark-java/pull/470/files
Reloadhttps://github.com/commonmark/commonmark-java/pull/470/files
commonmarkhttps://github.com/commonmark
commonmark-javahttps://github.com/commonmark/commonmark-java
Codehttps://github.com/commonmark/commonmark-java
Issues9 (9)https://github.com/commonmark/commonmark-java/issues
Pull requests4 (4)https://github.com/commonmark/commonmark-java/pulls
Actionshttps://github.com/commonmark/commonmark-java/actions
Wikihttps://github.com/commonmark/commonmark-java/wiki
Security and quality8 (8)https://github.com/commonmark/commonmark-java/security
Insightshttps://github.com/commonmark/commonmark-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fcommonmark%2Fcommonmark-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcommonmark%2Fcommonmark-java%2Fissues%2Fnew%2Fchoose
robinsthttps://github.com/robinst
commonmark:mainhttps://github.com/commonmark/commonmark-java/tree/main
wleeaf:fix-link-destination-unbalanced-parenshttps://github.com/wleeaf/commonmark-java/tree/fix-link-destination-unbalanced-parens
Conversation 2 https://github.com/commonmark/commonmark-java/pull/470
Commits 1 https://github.com/commonmark/commonmark-java/pull/470/commits
Checks 5 https://github.com/commonmark/commonmark-java/pull/470/checks
Files changed 2 https://github.com/commonmark/commonmark-java/pull/470/files
Reject link reference definitions with unbalanced parentheses in the destination https://github.com/commonmark/commonmark-java/pull/470/files#top
Show all changes 1 commit https://github.com/commonmark/commonmark-java/pull/470/files
ca6d2b4 Reject link reference definitions with unbalanced parentheses in the … wleeaf Oct 24, 2026 https://github.com/commonmark/commonmark-java/pull/470/commits/ca6d2b41a1a1558b31303c8582dd9f115b9966e3
Clear filters https://github.com/commonmark/commonmark-java/pull/470/files
Please reload this pagehttps://github.com/commonmark/commonmark-java/pull/470/files
Please reload this pagehttps://github.com/commonmark/commonmark-java/pull/470/files
LinkScanner.java https://github.com/commonmark/commonmark-java/pull/470/files#diff-40eb0bad761522ce6de410234c77ac2f81e9903dd97849c12d67025107e8c665
SpecialInputTest.java https://github.com/commonmark/commonmark-java/pull/470/files#diff-4a1de84f536f459e0b9249dda82d0152bf5867004b7b3edb33130aa6f3baf714
commonmark/src/main/java/org/commonmark/internal/util/LinkScanner.javahttps://github.com/commonmark/commonmark-java/pull/470/files#diff-40eb0bad761522ce6de410234c77ac2f81e9903dd97849c12d67025107e8c665
View file https://github.com/wleeaf/commonmark-java/blob/ca6d2b41a1a1558b31303c8582dd9f115b9966e3/commonmark/src/main/java/org/commonmark/internal/util/LinkScanner.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/commonmark/commonmark-java/pull/470/{{ revealButtonHref }}
https://github.com/commonmark/commonmark-java/pull/470/files#diff-40eb0bad761522ce6de410234c77ac2f81e9903dd97849c12d67025107e8c665
https://github.com/commonmark/commonmark-java/pull/470/files#diff-40eb0bad761522ce6de410234c77ac2f81e9903dd97849c12d67025107e8c665
https://github.com/commonmark/commonmark-java/pull/470/files#diff-40eb0bad761522ce6de410234c77ac2f81e9903dd97849c12d67025107e8c665
commonmark/src/test/java/org/commonmark/test/SpecialInputTest.javahttps://github.com/commonmark/commonmark-java/pull/470/files#diff-4a1de84f536f459e0b9249dda82d0152bf5867004b7b3edb33130aa6f3baf714
View file https://github.com/wleeaf/commonmark-java/blob/ca6d2b41a1a1558b31303c8582dd9f115b9966e3/commonmark/src/test/java/org/commonmark/test/SpecialInputTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/commonmark/commonmark-java/pull/470/{{ revealButtonHref }}
https://github.com/commonmark/commonmark-java/pull/470/files#diff-4a1de84f536f459e0b9249dda82d0152bf5867004b7b3edb33130aa6f3baf714
https://github.com/commonmark/commonmark-java/pull/470/files#diff-4a1de84f536f459e0b9249dda82d0152bf5867004b7b3edb33130aa6f3baf714
Please reload this pagehttps://github.com/commonmark/commonmark-java/pull/470/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.