Title: test: skip invalidCommand argparse fixture on Python 3.14.5+ by bearomorphism · Pull Request #1991 · commitizen-tools/commitizen · GitHub
Open Graph Title: test: skip invalidCommand argparse fixture on Python 3.14.5+ by bearomorphism · Pull Request #1991 · commitizen-tools/commitizen
X Title: test: skip invalidCommand argparse fixture on Python 3.14.5+ by bearomorphism · Pull Request #1991 · commitizen-tools/commitizen
Description: Description Partially addresses #1990 — short-term skip only; the longer-term normalization fix (option C in the issue) is still tracked there. Python 3.14.5 (released 2026-05-10) reverts the unquoted choose from format in argparse error messages via CPython gh-130750: Restore quoting of choices in argparse error messages for improved clarity and consistency with documentation. The checked-in fixture tests/test_cli/test_invalid_command_py_3_14_invalidCommand_.txt was generated against 3.14.0-3.14.4 (unquoted), so test_invalid_command[py_3.14-invalidCommand] fails as soon as the GitHub-hosted runner upgrades to 3.14.5. Master's last successful CI run was on 2026-05-09 (commit 1eb8cde6) on 3.14.4; runs on or after 2026-05-11 fail. This PR skips only the affected parametrization on 3.14.5+ via pytest.param(..., marks=pytest.mark.skipif(...)). The companion arg='--invalid-arg' case is unaffected (its fixture is the the following arguments are required: error, which uses the metavar, not the choice list). The longer-term normalization-based fix is intentionally left as a follow-up under #1990 so this PR stays narrowly scoped to unblocking CI. Checklist I have read the contributing guidelines Was generative AI tooling used to co-author this PR? Yes (please specify the tool below) Generated-by: GitHub Copilot CLI following the guidelines Code Changes Add test cases to all the changes you introduce Run uv run poe all locally to ensure this change passes linter check and tests Manually test the changes: Verify the feature/bug fix works as expected in real-world scenarios (skip activates on Python 3.14.5+; arg='invalidCommand' is skipped, arg='--invalid-arg' continues to run) Test edge cases and error conditions (predicate is (3, 14, 5) <= sys.version_info < (3, 15), so 3.14.4 and 3.15+ are unaffected) Ensure backward compatibility is maintained Document any manual testing steps performed (ran uv run pytest tests/test_cli.py::test_invalid_command -v on Python 3.14.4 — both parametrizations pass; Python 3.14.5 binary not yet available via uv on Windows, but CI runners will exercise it) Documentation Changes N/A. Expected Behavior On Python 3.14.5+, test_invalid_command[py_3.14-invalidCommand] is skipped with a clear reason pointing at #1990 and CPython gh-130750. On all other Python versions, behavior is unchanged. #1990 stays open for the normalization-based follow-up. Steps to Test This Pull Request Run uv run pytest tests/test_cli.py::test_invalid_command -v on Python >= 3.14.5 — the invalidCommand case is skipped, --invalid-arg passes. Run the same on Python 3.14.4 (or earlier 3.14.x) — both parametrizations pass. Additional Context CPython issue: python/cpython#130750 Python 3.14.5 changelog: https://docs.python.org/3.14/whatsnew/changelog.html#python-3-14-5-final Surfaced while working on #1846.
Open Graph Description: Description Partially addresses #1990 — short-term skip only; the longer-term normalization fix (option C in the issue) is still tracked there. Python 3.14.5 (released 2026-05-10) reverts the unquo...
X Description: Description Partially addresses #1990 — short-term skip only; the longer-term normalization fix (option C in the issue) is still tracked there. Python 3.14.5 (released 2026-05-10) reverts the unquo...
Opengraph URL: https://github.com/commitizen-tools/commitizen/pull/1991
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5f4310dd-8105-7a3e-82a5-4c17671d1c15 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 932C:23BC1B:10C87DB:178A53D:6A50A38B |
| html-safe-nonce | 9da3b61f210a8a41242f75f355a41e2b71ed18a6a613c9926c3ee5e0ff5727ec |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzJDOjIzQkMxQjoxMEM4N0RCOjE3OEE1M0Q6NkE1MEEzOEIiLCJ2aXNpdG9yX2lkIjoiODAyMzg5MDE0MjE5NTM5MzQxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e4d9dcfc0473a04c94ff36372538ba79612bbdd66bbad4c963fdaa78b23bb7b5 |
| hovercard-subject-tag | pull_request:3659150889 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/commitizen-tools/commitizen/pull/1991/files |
| twitter:image | https://avatars.githubusercontent.com/u/26526132?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/26526132?s=400&v=4 |
| og:image:alt | Description Partially addresses #1990 — short-term skip only; the longer-term normalization fix (option C in the issue) is still tracked there. Python 3.14.5 (released 2026-05-10) reverts the unquo... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/commitizen-tools/commitizen git https://github.com/commitizen-tools/commitizen.git |
| octolytics-dimension-user_id | 62252524 |
| octolytics-dimension-user_login | commitizen-tools |
| octolytics-dimension-repository_id | 106127589 |
| octolytics-dimension-repository_nwo | commitizen-tools/commitizen |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 106127589 |
| octolytics-dimension-repository_network_root_nwo | commitizen-tools/commitizen |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width