Title: fix(conventional_commits): add missing version bump notes for all change types by bearomorphism · Pull Request #1960 · commitizen-tools/commitizen · GitHub
Open Graph Title: fix(conventional_commits): add missing version bump notes for all change types by bearomorphism · Pull Request #1960 · commitizen-tools/commitizen
X Title: fix(conventional_commits): add missing version bump notes for all change types by bearomorphism · Pull Request #1960 · commitizen-tools/commitizen
Description: Description Closes #515 Adds explicit version-bump documentation for every Conventional Commit type, both in the interactive cz commit prompt and in the cz info output, so users can immediately see how each type affects semantic versioning under Commitizen's defaults. Also adds a "Recommended Reading on Versioning" docs section gathering the articles surfaced during the issue discussion. The first task in the issue (fixing the inaccurate "fix + everything else" rule in the bump docs) was already addressed by #1452. This PR completes the remaining tasks: Add notes in commit message instructions to identify what version bump occurs with all change types (e.g., Correlates with no version bump in SemVer) Add the recommended-reading articles raised in the issue thread, per discussion with @Lee-W What changed commitizen/cz/conventional_commits/conventional_commits.py — every prompt choice now spells out its version-bump impact, using the Correlates with X in SemVer phrasing already established by fix and feat: fix, feat (unchanged): already correlated with PATCH/MINOR refactor, perf: "Correlates with PATCH in SemVer" docs, style, test, build, ci: "Correlates with no version bump in SemVer" Reflects the actual default bump_map (per @woile's comment: "fix, refactor and perf are patch, not everything"), not the alternative spec-only mapping. commitizen/cz/conventional_commits/conventional_commits_info.txt — clarifies that, on top of the Conventional Commits spec, Commitizen's defaults bump PATCH for refactor and perf, and don't bump for docs/style/test/build/ci. Notes that this can be customized via bump_map/bump_pattern. docs/external_links.md — new "Recommended Reading on Versioning" section linking the articles cited by @adam-grant-hendry: Hynek's Semantic Versioning Will Not Save You, Brett Cannon's Why I don't like SemVer anymore, Donald Stufft's Versioning Software, Hyrum's Law, 0ver, CalVer, PEP 440, plus the Conventional Commits / SemVer specs. docs/commands/bump.md — adds a clarifying sentence under the Version Increment Rules table for non-bumping types, plus a tip admonition cross-linking to the new reading list. Checklist I have read the contributing guidelines Was generative AI tooling used to co-author this PR? Yes (please specify the tool below) Generated-by: GitHub Copilot CLI following the guidelines Code Changes Run uv run poe all locally to ensure this change passes linter check and tests poe lint (ruff + mypy): clean Targeted tests around commit prompts/info (test_cz_conventional_commits.py, test_cz_search_filter.py, test_check_command.py, test_commit_command.py, test_cz_customize.py): 161 passed Full test suite: 1274 passed; the 4 errors / 1 failure observed locally are pre-existing environmental issues (GPG keystore pollution and a Windows long-path flake), reproducible against master without these changes. Update the documentation for the changes Documentation Changes Run uv run poe doc locally to ensure the documentation pages renders correctly (mkdocs build clean) Check and fix any broken links (internal or external) — all 9 external links return HTTP 200; internal anchor external_links.md#recommended-reading-on-versioning verified in the rendered site. Expected Behavior Running cz commit shows the version-bump impact next to every change type, e.g.: ? Select the type of change you are committing > fix: A bug fix. Correlates with PATCH in SemVer feat: A new feature. Correlates with MINOR in SemVer docs: Documentation only changes. Correlates with no version bump in SemVer style: ... Correlates with no version bump in SemVer refactor: ... Correlates with PATCH in SemVer perf: ... Correlates with PATCH in SemVer test: ... Correlates with no version bump in SemVer build: ... Correlates with no version bump in SemVer ci: ... Correlates with no version bump in SemVer cz info now also calls out Commitizen's defaults explicitly. Steps to Test This Pull Request uv sync --frozen --group base --group test --group linters --group documentation uv run cz commit — observe the new version-bump notes in the change-type prompt. uv run cz info — observe the new paragraph clarifying Commitizen's defaults. uv run poe doc — visit external_links.md and commands/bump.md to verify the new section and cross-link render correctly. Additional Context Refs #515 Builds on #1452 (which fixed the inaccurate "fix + everything else" line in the bump docs).
Open Graph Description: Description Closes #515 Adds explicit version-bump documentation for every Conventional Commit type, both in the interactive cz commit prompt and in the cz info output, so users can immediately see...
X Description: Description Closes #515 Adds explicit version-bump documentation for every Conventional Commit type, both in the interactive cz commit prompt and in the cz info output, so users can immediately see...
Opengraph URL: https://github.com/commitizen-tools/commitizen/pull/1960
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b9419ff0-cb3f-4dbe-26eb-ac5e89ee15de |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 84CA:2CC0E1:604C48:885BDA:6A620CA2 |
| html-safe-nonce | cfde3a7c7a54fc2265590d6976321879418cbcb56744f92bf8b5153b75da8f2a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NENBOjJDQzBFMTo2MDRDNDg6ODg1QkRBOjZBNjIwQ0EyIiwidmlzaXRvcl9pZCI6IjExNjg4Mzg3NDEwODk5Nzk1NTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e6ece4fba1afceab14ee75fbd03fa1a5c242537bffe0000f18f1beafbcf9f15e |
| hovercard-subject-tag | pull_request:3654443035 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/commitizen-tools/commitizen/pull/1960/files |
| twitter:image | https://avatars.githubusercontent.com/u/26526132?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/26526132?s=400&v=4 |
| og:image:alt | Description Closes #515 Adds explicit version-bump documentation for every Conventional Commit type, both in the interactive cz commit prompt and in the cz info output, so users can immediately see... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | be9a4d9589756e22b427637ffbf1123a96e067050e57f5cec403e3080a650ca4 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/commitizen-tools/commitizen git https://github.com/commitizen-tools/commitizen.git |
| octolytics-dimension-user_id | 62252524 |
| octolytics-dimension-user_login | commitizen-tools |
| octolytics-dimension-repository_id | 106127589 |
| octolytics-dimension-repository_nwo | commitizen-tools/commitizen |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 106127589 |
| octolytics-dimension-repository_network_root_nwo | commitizen-tools/commitizen |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7b5509702f01f876c214a2cbb142690847de0019 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width