Title: Tests Fail Depending on `tomlkit` Version · Issue #628 · commitizen-tools/commitizen · GitHub
Open Graph Title: Tests Fail Depending on `tomlkit` Version · Issue #628 · commitizen-tools/commitizen
X Title: Tests Fail Depending on `tomlkit` Version · Issue #628 · commitizen-tools/commitizen
Description: Description PR #626 changed tests/commands/test_bump_command.py tests/commands/test_init_command.py tests/test_conf.py to accomodate changes to tomlkit from 0.11.5 to 0.11.6. However, the pyproject.toml still has the version set as tomlk...
Open Graph Description: Description PR #626 changed tests/commands/test_bump_command.py tests/commands/test_init_command.py tests/test_conf.py to accomodate changes to tomlkit from 0.11.5 to 0.11.6. However, the pyproject...
X Description: Description PR #626 changed tests/commands/test_bump_command.py tests/commands/test_init_command.py tests/test_conf.py to accomodate changes to tomlkit from 0.11.5 to 0.11.6. However, the pyproject...
Opengraph URL: https://github.com/commitizen-tools/commitizen/issues/628
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Tests Fail Depending on `tomlkit` Version","articleBody":"### Description\r\n\r\nPR #626 changed\r\n\r\n```\r\ntests/commands/test_bump_command.py\r\ntests/commands/test_init_command.py\r\ntests/test_conf.py\r\n```\r\n\r\nto accomodate changes to `tomlkit` from `0.11.5` to `0.11.6`. However, the `pyproject.toml` still has the version set as\r\n\r\n```\r\ntomlkit = \"\u003e=0.5.3,\u003c1.0.0\"\r\n```\r\n\r\nHence, tests fail for `tomlkit\u003c=0.11.5`.\r\n\r\n### Steps to reproduce\r\n\r\nRun `pytest` on `commitizen` repo with `tomlkit\u003c=0.11.5`.\r\n\r\n### Current behavior\r\n\r\nThe following 6 tests fail:\r\n\r\n[pytest_report.zip](https://github.com/commitizen-tools/commitizen/files/10145373/pytest_report.zip)\r\n\r\nwhen `tomlkit` is `\u003c= 0.11.5`, but pass when `tomlkit \u003e= 0.11.6`.\r\n\r\n### Desired behavior\r\n\r\nEither of the following, depending on what should be supported:\r\n\r\n1. Update `pyproject.toml` to specify\r\n\r\n ```\r\n tomlkit = \"\u003e=0.11.6,\u003c1.0.0\"\r\n ```\r\n\r\nor\r\n\r\n2. Add test cases for `tomlkit` `\u003c=0.11.5` separate from test cases for `tomlkit \u003e 0.11.5`.\r\n\r\n### Screenshots\r\n\r\n_No response_\r\n\r\n### Environment\r\n\r\n- commitizen version: `2.37.1`\r\n- python version: `3.8.10`\r\n- operating system: `Windows 10`","author":{"url":"https://github.com/adam-grant-hendry","@type":"Person","name":"adam-grant-hendry"},"datePublished":"2022-12-03T02:10:59.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":7},"url":"https://github.com/628/commitizen/issues/628"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f5351961-1491-ba77-d43d-bdbb7e366cac |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8AEE:2DB422:B14AB8:F2CFB8:6A4DC58D |
| html-safe-nonce | 6f356c3628776817955445568a4b09f25531d80e69706ba7eb99868df2de840b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUVFOjJEQjQyMjpCMTRBQjg6RjJDRkI4OjZBNERDNThEIiwidmlzaXRvcl9pZCI6IjY5OTk4MzAzNDM4MDE3NTA5MjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4faf528d5119fafebe6a242d696eb25bdbf72cf83ed9e7bf742a1eccb26ee7c8 |
| hovercard-subject-tag | issue:1473659887 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/commitizen-tools/commitizen/628/issue_layout |
| twitter:image | https://opengraph.githubassets.com/935465303de95e29c76f3ea346ed2f19df3936cfabd7995f18477afd4dd18681/commitizen-tools/commitizen/issues/628 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/935465303de95e29c76f3ea346ed2f19df3936cfabd7995f18477afd4dd18681/commitizen-tools/commitizen/issues/628 |
| og:image:alt | Description PR #626 changed tests/commands/test_bump_command.py tests/commands/test_init_command.py tests/test_conf.py to accomodate changes to tomlkit from 0.11.5 to 0.11.6. However, the pyproject... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | adam-grant-hendry |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| go-import | github.com/commitizen-tools/commitizen git https://github.com/commitizen-tools/commitizen.git |
| octolytics-dimension-user_id | 62252524 |
| octolytics-dimension-user_login | commitizen-tools |
| octolytics-dimension-repository_id | 106127589 |
| octolytics-dimension-repository_nwo | commitizen-tools/commitizen |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 106127589 |
| octolytics-dimension-repository_network_root_nwo | commitizen-tools/commitizen |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width