Title: [BUG]: Windows CI Tests False-Positive of Passing · Issue #604 · commitizen-tools/commitizen · GitHub
Open Graph Title: [BUG]: Windows CI Tests False-Positive of Passing · Issue #604 · commitizen-tools/commitizen
X Title: [BUG]: Windows CI Tests False-Positive of Passing · Issue #604 · commitizen-tools/commitizen
Description: Description After reviewing your Actions, it is clear tests are not running on Windows machines. On Windows, the linter and test script does not output any results and takes 0 or 1s to complete, whereas on Linux/MacOS they take >1 minute...
Open Graph Description: Description After reviewing your Actions, it is clear tests are not running on Windows machines. On Windows, the linter and test script does not output any results and takes 0 or 1s to complete, wh...
X Description: Description After reviewing your Actions, it is clear tests are not running on Windows machines. On Windows, the linter and test script does not output any results and takes 0 or 1s to complete, wh...
Opengraph URL: https://github.com/commitizen-tools/commitizen/issues/604
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[BUG]: Windows CI Tests False-Positive of Passing","articleBody":"### Description\r\n\r\nAfter reviewing your `Actions`, it is clear tests are not running on Windows machines. On Windows, the `linter and test` script does not output any results and takes 0 or 1s to complete, whereas on Linux/MacOS they take \u003e1 minute and output `pytest` results.\r\n\r\nYour `.github/workflows/pythonpackage.yml` worflow does not specify a shell to use in the `Run tests and linters` step. Hence, on Windows, it defaults to using Powershell. Thus, what is run ([which you can see in this example workflow](https://github.com/commitizen-tools/commitizen/actions/runs/3073641248/jobs/4965906704)) is simply:\r\n\r\n```pwsh\r\npwsh -Command ./scripts/test\r\n```\r\n\r\nThis does nothing more than ask Windows to attempt to open a file it does not know how to handle, which is easily repeated locally:\r\n\r\nhttps://user-images.githubusercontent.com/59346180/196010833-4f63b4b0-864a-496e-9ee9-cdaa490685bf.mp4\r\n\r\nCloning the repo, changing the shebang [to a portable variant](https://www.diskinternals.com/linux-reader/usr-bin-bash/), and running `pytest`, it is clear many tests are failing on Windows. This was first noticed in #602 \r\n\r\nhttps://github.com/commitizen-tools/commitizen/files/9790428/pytest_report.zip\r\n\r\n### Steps to reproduce\r\n\r\n1. Follow the [Contributing](https://commitizen-tools.github.io/commitizen/contributing/) steps to:\r\n (a) Fork the repo, install dependencies through poetry, and setup the pre-commit hooks\r\n2. Run pre-commit run --all\r\n\r\n### Current behavior\r\n\r\nTests are failing silently on GitHub Actions (i.e. CI), yielding false positives on prior commits. Tests fail explicitly when the repo is cloned and tested on Windows, which also prevents developers using Windows to contribute (`pre-commit` tests fail, preventing pushing to PRs).\r\n\r\n### Desired behavior\r\n\r\n1. Windows tests run on GitHub Actions\r\n2. Windows users can contribute to your repo\r\n\r\nIf you continue to package for Windows, you need to confirm that your tests are actually running and passing. Your tests are failing at this point.\r\n\r\n### Screenshots\r\n\r\nPlease see the `Description`.\r\n\r\n### Environment\r\n\r\nCommitizen Version: 2.35.0\r\nPython Version: 3.8.10 (tags/v3.8.10:3d8993a, May 3 2021, 11:48:03) [MSC v.1928 64 bit (AMD64)]\r\nOperating System: Windows\r\n\r\n### Local `pytest` Report\r\n\r\nAdding the `pytest` run on Windows, first referenced in #602 . This report was generated using the [`pytest-html` plugin](https://pypi.org/project/pytest-html/).\r\n\r\n[pytest_report.zip](https://github.com/commitizen-tools/commitizen/files/9801994/pytest_report.zip)","author":{"url":"https://github.com/adam-grant-hendry","@type":"Person","name":"adam-grant-hendry"},"datePublished":"2022-10-15T23:20:23.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/604/commitizen/issues/604"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a96e419f-d375-e398-da2f-387bfefb35e0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 909C:25BBB7:46129:61349:69789B54 |
| html-safe-nonce | b6389b75f2730afb7617f99f359d74d55f988acb156aa814ee2d06e4ce796890 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDlDOjI1QkJCNzo0NjEyOTo2MTM0OTo2OTc4OUI1NCIsInZpc2l0b3JfaWQiOiI5MTI0ODgwMDkzNDA1NTUxNDQ0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a41ed01baf39bd0eec9e7532c962b7daa3e1a1d709a4873fbd94f831cc42631e |
| hovercard-subject-tag | issue:1410316397 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/commitizen-tools/commitizen/604/issue_layout |
| twitter:image | https://opengraph.githubassets.com/2d608df44ada14effba0d48e5274540de316678accee06fe0fe2d402051548cb/commitizen-tools/commitizen/issues/604 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2d608df44ada14effba0d48e5274540de316678accee06fe0fe2d402051548cb/commitizen-tools/commitizen/issues/604 |
| og:image:alt | Description After reviewing your Actions, it is clear tests are not running on Windows machines. On Windows, the linter and test script does not output any results and takes 0 or 1s to complete, wh... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | adam-grant-hendry |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2981c597c945c1d90ac6fa355ce7929b2f413dfe7872ca5c435ee53a24a1de50 |
| turbo-cache-control | no-preview |
| go-import | github.com/commitizen-tools/commitizen git https://github.com/commitizen-tools/commitizen.git |
| octolytics-dimension-user_id | 62252524 |
| octolytics-dimension-user_login | commitizen-tools |
| octolytics-dimension-repository_id | 106127589 |
| octolytics-dimension-repository_nwo | commitizen-tools/commitizen |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 106127589 |
| octolytics-dimension-repository_network_root_nwo | commitizen-tools/commitizen |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 14920c7cb7d7c207b5e72684d0e6f23b65b849b3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width