Title: Bumping rule is wrongly documented · Issue #515 · commitizen-tools/commitizen · GitHub
Open Graph Title: Bumping rule is wrongly documented · Issue #515 · commitizen-tools/commitizen
X Title: Bumping rule is wrongly documented · Issue #515 · commitizen-tools/commitizen
Description: Type Content inaccurate URL https://commitizen-tools.github.io/commitizen/bump/ Description Problem The docs state "fix+everything else" bumps PATCH of the version string per the default commit_map. However, this is not the case: commiti...
Open Graph Description: Type Content inaccurate URL https://commitizen-tools.github.io/commitizen/bump/ Description Problem The docs state "fix+everything else" bumps PATCH of the version string per the default commit_map...
X Description: Type Content inaccurate URL https://commitizen-tools.github.io/commitizen/bump/ Description Problem The docs state "fix+everything else" bumps PATCH of the version string per the default ...
Opengraph URL: https://github.com/commitizen-tools/commitizen/issues/515
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bumping rule is wrongly documented","articleBody":"### Type\r\n\r\n- Content inaccurate\r\n\r\n### URL\r\n\r\nhttps://commitizen-tools.github.io/commitizen/bump/\r\n\r\n### Description\r\n\r\n## Problem\r\n\r\nThe docs state \"`fix`+everything else\" bumps `PATCH` of the version string per the default `commit_map`.\r\n\r\n\r\n\r\nHowever, this is not the case:\r\n\r\nhttps://github.com/commitizen-tools/commitizen/blob/79165119817cbd0aef25434a85dcbffa3a13acbb/commitizen/defaults.py#L78-L80\r\n\r\nOnly `fix`, `refactor`, and `perf` bump `PATCH`, leaving out `docs`, `style`, `test`, `build`, and `ci`, which don't bump any part of the version.\r\n\r\nNot only are the docs incorrect, but this is out of step with [Conventional Commits 1.0.0](https://www.conventionalcommits.org/en/v1.0.0/#summary). Additional commit types are permitted by the specification (e.g. `commitizen` appears to be using the [Angular Convention](https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#-commit-message-guidelines) by default), but no guidance on version bumping is given for these addition types. Where a commit type bumps or does not bump a version, this should be explicitly stated (e.g. the commit message instructions for `fix` has `Correlates with PATCH in SemVer`, but not `refactor` or `perf`, leaving one to believe these do nothing). \r\n\r\n## Recommendations:\r\n\r\n1. **(PREFERRED; Conventional Commit spec)**: Only `feature` and `fix` should be in the default `commit_map` per [Conventional Commits 1.0.0](https://www.conventionalcommits.org/en/v1.0.0/#summary). `refactor` and `perf` should not bump `PATCH`. The Angular types `refactor`, `perf`, `docs`, `style`, `test`, `build`, and `ci` should be removed from the default commit types.\r\n\r\n1. **(ALTERNATIVE; Angular Convention, but with explicit messaging)**: `refactor` and `perf` should not bump `PATCH`. The commit message instructions for `refactor`, `perf`, `docs`, `style`, `test`, `build`, and `ci` should add `Correlates with no version bump in SemVer`. In addition, the docs should clearly state the [Angular Convention](https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#-commit-message-guidelines) commit types are included in `cz c` by default.\r\n\r\n## Tasks:\r\n\r\n- [ ] Correct the documentation (state what change types bump versions and that commitizen includes Angular Convention types by default) \r\n- [ ] Add notes in commit message instructions to identify what version bump occurs with all change types (e.g. Correlates with no version bump in SemVer) ","author":{"url":"https://github.com/adam-grant-hendry","@type":"Person","name":"adam-grant-hendry"},"datePublished":"2022-05-21T18:54:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":14},"url":"https://github.com/515/commitizen/issues/515"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:bff015f0-2aea-597f-efff-a0a65ba58463 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DFD8:2B5926:66CCCD:893EFC:6A617EFC |
| html-safe-nonce | 1eb1770675a7defbffa6cdd978ef5283c2dbea5b6bb6c94509a50ea44356b71c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkQ4OjJCNTkyNjo2NkNDQ0Q6ODkzRUZDOjZBNjE3RUZDIiwidmlzaXRvcl9pZCI6IjIzMTY2MzcyMDQ0MTExNTQxNzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 94b423a7dbdf2e86a8093c2c7602b93a5968000b34f593d2e84fd4bddc9cff2a |
| hovercard-subject-tag | issue:1244057616 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/commitizen-tools/commitizen/515/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e31e07e2338f6fa749cb23a9887f8c5b8c204dd1b436fa6fb9db320d7f386d5c/commitizen-tools/commitizen/issues/515 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e31e07e2338f6fa749cb23a9887f8c5b8c204dd1b436fa6fb9db320d7f386d5c/commitizen-tools/commitizen/issues/515 |
| og:image:alt | Type Content inaccurate URL https://commitizen-tools.github.io/commitizen/bump/ Description Problem The docs state "fix+everything else" bumps PATCH of the version string per the default commit_map... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | adam-grant-hendry |
| hostname | github.com |
| expected-hostname | github.com |
| None | c28c2f6607f2aacbd934868d997038895c9780d08babfe918550d73773326f4c |
| turbo-cache-control | no-preview |
| go-import | github.com/commitizen-tools/commitizen git https://github.com/commitizen-tools/commitizen.git |
| octolytics-dimension-user_id | 62252524 |
| octolytics-dimension-user_login | commitizen-tools |
| octolytics-dimension-repository_id | 106127589 |
| octolytics-dimension-repository_nwo | commitizen-tools/commitizen |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 106127589 |
| octolytics-dimension-repository_network_root_nwo | commitizen-tools/commitizen |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cd05235d52ffb3318513d883a56c87a121015c8b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width