René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"version bump with breaking change, release candidate (rc0) didn't increment major version number","articleBody":"## Description\r\nA breaking change was introduced in commit [5f273ce23a331eaf11623207ec4aba8b856c14f0](https://gitlab.com/nofusscomputing/projects/gitlab-ci/-/commit/5f273ce23a331eaf11623207ec4aba8b856c14f0). Current version was `0.3.0rc1` on the next version increment the version only incremented to `0.3.0` when it should have incremented to `1.0.0`\r\n\r\nrepo link: \r\n\r\n- Gitlab: https://gitlab.com/nofusscomputing/projects/gitlab-ci/\r\n\r\n- Github: https://github.com/NoFussComputing/gitlab-ci/\r\n\r\n\u003cdetails\u003e\r\n\r\n\u003csummary\u003e Git log with the commits in question including tags\u003c/summary\u003e\r\n\r\n``` bash\r\n$ git log\r\ncommit 389bc08d7686153fb374aa83d440c35c9b4eac90 (HEAD -\u003e development, tag: v0.3.0)\r\nAuthor: NFC CI \u003cCI@nfc-gitlab\u003e\r\nDate:   Thu Aug 12 03:32:36 2021 +0000\r\n\r\n    build(version): bump version 0.3.0rc1 → 0.3.0\r\n\r\ncommit f455eb2e278eb3fd7f9dde693587393ea2783cff\r\nMerge: a629e39 3360a15\r\nAuthor: Jon\r\nDate:   Thu Aug 12 03:25:10 2021 +0000\r\n\r\n    Merge branch 'style-readme' into 'development'\r\n    \r\n    style(readme): fix badge table.\r\n    \r\n    See merge request nofusscomputing/projects/gitlab-ci!7\r\n\r\ncommit 3360a15fde12682edfd9044d2541dc819615b838\r\nAuthor: Jon\r\nDate:   Thu Aug 12 12:47:23 2021 +0930\r\n\r\n    fix(commit_message): fixed commit message check if there is only one commit to the branch\r\n    \r\n    !7\r\n\r\ncommit 2c61651d9c08f4cf364e45768e07f3ece34ec8c0\r\nAuthor: Jon\r\nDate:   Thu Aug 12 12:45:31 2021 +0930\r\n\r\n    style(readme): fix formatting of badge table\r\n    \r\n    The badge table did not render on github,\r\n    adjuested so that each row is on one line for github markdown to function\r\n    \r\n    !7\r\n\r\ncommit a629e39f59d865a6c2e86627d0a62146de0ea7ca\r\nMerge: f4ee55d 0653766\r\nAuthor: Jon\r\nDate:   Wed Aug 11 06:37:28 2021 +0000\r\n\r\n    Merge branch 'update-readme' into 'development'\r\n    \r\n    docs(readme): added how to use repo\r\n    \r\n    See merge request nofusscomputing/projects/gitlab-ci!5\r\n\r\ncommit 0653766c935cb117082bfe1481ae83e4a1b2bb5c\r\nAuthor: Jon\r\nDate:   Wed Aug 11 15:52:28 2021 +0930\r\n\r\n    docs(readme): Updated badges and intro\r\n    \r\n    !5\r\n\r\ncommit d61056243804728e059b99fce1644a8cc37230bb\r\nAuthor: Jon\r\nDate:   Wed Aug 11 14:17:29 2021 +0930\r\n\r\n    feat(python_linting): added ci job, python linting, code quality and scoring\r\n    \r\n    Added a job to lint python files and ouput a code quality report for gitlab MR.\r\n    \r\n    A html report is also available within the artifacts. if the badge is used,\r\n    the badge links to the html code quality report.\r\n    \r\n     Changes to be committed:\r\n            modified:   .gitlab-ci.yml\r\n            new file:   python/.gitlab-ci.yml\r\n            new file:   python/README.md\r\n            new file:   python/requirements.txt\r\n    \r\n    issue #1\r\n\r\ncommit def31ef562c0002713401652657d59320548ee85\r\nAuthor: Jon\r\nDate:   Wed Aug 11 13:47:34 2021 +0930\r\n\r\n    style(yaml_lint): fixed yaml lint errors\r\n    \r\n    yaml lint was producing linting errors. Amended affected lines.\r\n    \r\n    #1\r\n\r\ncommit d20a56fa0ca492e3fc2ad7c548fc891cc8ffc8ec\r\nAuthor: Jon\r\nDate:   Wed Aug 11 13:14:36 2021 +0930\r\n\r\n    feat(yaml_lint): Added job yaml lint for checking yaml files\r\n    \r\n    defaults to checking subfolder/.gitlab-ci.yml.\r\n    \r\n     Changes to be committed:\r\n            modified:   .gitlab-ci.yml\r\n            new file:   yaml_lint/.gitlab-ci.yml\r\n            new file:   yaml_lint/.yamllint.yaml\r\n            new file:   yaml_lint/README.md\r\n            new file:   yaml_lint/requirements.txt\r\n    \r\n    issue #1\r\n\r\ncommit 9f7a24c1ebc0bdb5a153977dcb1c53d7ec2fb140\r\nAuthor: Jon\r\nDate:   Wed Aug 11 12:44:22 2021 +0930\r\n\r\n    docs(gitlab_templates): added issue and merge request templates\r\n    \r\n    #1\r\n\r\ncommit da8eb5c3381379f6e405c3ebe14d9a883c52f41a\r\nAuthor: Jon\r\nDate:   Wed Aug 11 12:41:51 2021 +0930\r\n\r\n    docs(template): added template readme for CI job folders\r\n    \r\n    #1\r\n\r\ncommit ace7a03456861d59e2f904405f45409c53e831ab\r\nAuthor: Jon\r\nDate:   Wed Aug 11 12:40:30 2021 +0930\r\n\r\n    docs(readme): explain sync and using github to link gitlab-ci\r\n    \r\n    !5 #1\r\n\r\ncommit 8790917e7d959aa7b8305912bb443ba6b72200c6\r\nAuthor: Jon\r\nDate:   Wed Aug 11 12:30:30 2021 +0930\r\n\r\n    docs(readme): explain repo layout and versioning\r\n    \r\n    !5\r\n\r\ncommit 19900945e763249b6ef7a9e2e2cbcf11748b1eea\r\nAuthor: Jon\r\nDate:   Wed Aug 11 12:26:18 2021 +0930\r\n\r\n    docs(readme): added how to update gitlab-ci\r\n    \r\n    !5\r\n\r\ncommit 63af1efb4fd92a9f8755f766728a18d8f390b805\r\nAuthor: Jon\r\nDate:   Wed Aug 11 12:14:50 2021 +0930\r\n\r\n    fix(commit_footer_refs): Use the current git branch for comparison.\r\n    \r\n    dynamically select the current branch so that it can be compared to the dev branch\r\n    \r\n    !5 #1\r\n\r\ncommit 8a988ebf09015211f8f6566acc0ba71c1f00bee1\r\nAuthor: Jon\r\nDate:   Wed Aug 11 12:07:56 2021 +0930\r\n\r\n    docs(readme): Added how to use this repository\r\n    \r\n    !5\r\n\r\ncommit f4ee55daa58cb2b9bb494a2955956cd3af5861fb\r\nMerge: d929c1d dc13d4f\r\nAuthor: Jon\r\nDate:   Sun Aug 8 06:35:41 2021 +0000\r\n\r\n    Merge branch 'changelog-footer-toggle' into 'development'\r\n    \r\n    feat(changelog): be able to switch changelog references inclusion.\r\n    \r\n    See merge request nofusscomputing/projects/gitlab-ci!4\r\n\r\ncommit dc13d4f2841038c085dcf29dfb0b0c5d2f00f099\r\nAuthor: Jon\r\nDate:   Sun Aug 8 15:43:28 2021 +0930\r\n\r\n    docs(gitlab_release): Added user docs to fix errors from ci job 'commit footer refs'\r\n    \r\n    User documentation provided as it is linked from the junit test report in the gitlab interface.\r\n    \r\n    closes #3 closes #4\r\n\r\ncommit 22136f7dd22b9487d362a7ed63ca1b76e52b9cc7\r\nAuthor: Jon\r\nDate:   Sun Aug 8 15:28:00 2021 +0930\r\n\r\n    feat(gitlab_release): Toggle var added to enable switching changelog references.\r\n    \r\n    using var 'CHANGELOG_FOOTER_REFERENCES' set to False when generating a changelog\r\n    with 'cz' will not add the commit footer refrences to the changelog.\r\n    \r\n    issue #3\r\n\r\ncommit eb0bf4c1740dbd7a47ceb031c0d1c854899a1e40\r\nAuthor: Jon\r\nDate:   Sun Aug 8 15:15:06 2021 +0930\r\n\r\n    refactor(gitlab_release): file link to be in local repository for helping fix commit footer ref check failures\r\n    \r\n    issue #4\r\n\r\ncommit 81776223c5cb392c12c7ca63488a1df10290e9d1\r\nAuthor: Jon\r\nDate:   Sun Aug 8 15:04:06 2021 +0930\r\n\r\n    refactor(gitlab_release): use a name for failed test to denote the issue\r\n    \r\n    issue #4\r\n\r\ncommit 756b9406dde8cf0bf0030ac72855a054ece3a883\r\nAuthor: Jon\r\nDate:   Sun Aug 8 14:58:36 2021 +0930\r\n\r\n    feat(gitlab_release): be able to toggle commit footer check job\r\n    \r\n    if var CHANGELOG_FOOTER_REFERENCES=False, dont conduct validation job.\r\n    \r\n    issue #4\r\n\r\ncommit 7cb676eb98a7de30d47a6b49a87067116684cfd2\r\nAuthor: Jon\r\nDate:   Sun Aug 8 14:51:57 2021 +0930\r\n\r\n    ci(gitlab_release): Add a validation job to check if commit messages contain a gitlab reference in the footer\r\n    \r\n    #4\r\n\r\ncommit 11e156619d0d820e534897bafd5f39e6f9defcbf\r\nAuthor: Jon\r\nDate:   Sun Aug 8 14:50:34 2021 +0930\r\n\r\n    feat(gitlab_release): python module to check if a commit message has gitlab references in the footer\r\n    \r\n    #4\r\n\r\ncommit d2d4ac0afa123eb161916735b999b470a30e273e\r\nAuthor: Jon\r\nDate:   Sun Aug 8 14:47:49 2021 +0930\r\n\r\n    build(.gitignore): ignore python build files\r\n    \r\n    !4\r\n\r\ncommit d929c1d3b01fe68764029e6a6a13a620871ad1b4\r\nMerge: cc2f23b 35edb7c\r\nAuthor: Jon\r\nDate:   Sat Aug 7 07:53:17 2021 +0000\r\n\r\n    Merge branch 'changelog-footer' into 'development'\r\n    \r\n    feat(changelog): Add commit footer to Changelog\r\n    \r\n    See merge request nofusscomputing/projects/gitlab-ci!3\r\n\r\ncommit 35edb7cfc59e2d147bdb5cb5d03710ec747073ae\r\nAuthor: Jon\r\nDate:   Sat Aug 7 17:14:48 2021 +0930\r\n\r\n    docs(changelog): Updated changelog to new layout\r\n    \r\n    Changelog now adds issue and merge request references from the commit footer line.\r\n    \r\n    !3 #3\r\n\r\ncommit 8699c41219d70e6f41f42dc7f2c1bcf542b3f723\r\nAuthor: Jon\r\nDate:   Sat Aug 7 16:14:10 2021 +0930\r\n\r\n    feat(gitlab_release): Add commit footer to changelog\r\n    \r\n    !1 #3\r\n\r\ncommit cc2f23b091925659c03196b69456f4033b460294\r\nMerge: eb5cc8a 5f273ce\r\nAuthor: Jon\r\nDate:   Sat Aug 7 05:31:59 2021 +0000\r\n\r\n    Merge branch 'fix-releases' into 'development'\r\n    \r\n    fix(gitlab_releases): version increment workflow from RC-release -\u003e full-release\r\n    \r\n    See merge request nofusscomputing/projects/gitlab-ci!2\r\n\r\ncommit 5f273ce23a331eaf11623207ec4aba8b856c14f0\r\nAuthor: Jon\r\nDate:   Sat Aug 7 14:56:51 2021 +0930\r\n\r\n    docs(gitlab_release): Updated docs with new instructions on version incrementing\r\n    \r\n    BREAKING CHANGE: !2\r\n\r\ncommit f76cabeeb04b028a231dc1c232862db5fcad4345\r\nAuthor: Jon\r\nDate:   Sat Aug 7 13:56:25 2021 +0930\r\n\r\n    fix(gitlab_release): Adjust release workflow\r\n    \r\n    Previous release workflow only allowed version increment of RC on development brnach.\r\n    \r\n    adjust to the following workflow:\r\n        master branch: automatically increment the version\r\n        development branch: option to manually increment version (RC increment only)\r\n    \r\n    !2\r\n\r\ncommit eb5cc8a0e2885a9ed16a8d1a81611aec4d5a4d31 (tag: v0.3.0rc1)\r\nAuthor: NFC CI \u003cCI@nfc-gitlab\u003e\r\nDate:   Wed Aug 4 03:23:08 2021 +0000\r\n\r\n    build(version): bump version 0.3.0rc0 → 0.3.0rc1\r\n\r\n```\r\n\r\n\u003c/details\u003e\r\n\r\n## Steps to reproduce\r\n1. `git clone https://gitlab.com/nofusscomputing/projects/gitlab-ci.git`\r\n\r\n2. git checkout development\r\n3. `git fetch --tags`\r\n4. delete all tags after tag `v0.3.0rc1`\r\n5. `git reset f455eb2e278eb3fd7f9dde693587393ea2783cff --hard`\r\n6. run commands to bump version\r\n\r\n``` bash\r\n$ git reset f455eb2e278eb3fd7f9dde693587393ea2783cff --hard\r\nHEAD is now at f455eb2 Merge branch 'style-readme' into 'development'\r\n\r\n(dev_env) i$ cz -n cz_nfc bump --prerelease rc --dry-run\r\nbuild(version): bump version 0.3.0rc1 → 0.3.0rc2\r\ntag to create: v0.3.0rc2\r\nincrement detected: None\r\n\r\n(dev_env) $ cz -n cz_nfc bump --dry-run\r\nbuild(version): bump version 0.3.0rc1 → 0.3.0\r\ntag to create: v0.3.0\r\nincrement detected: MINOR\r\n\r\n(dev_env) $ \r\n\r\n```\r\n\r\nAdding a commit with a `!` after the type still fails\r\n``` bash\r\n(dev_env) $ git log -2\r\ncommit 83ac9e6a88c3ba6bf4c93153f46acce10dcceb69 (HEAD -\u003e development)\r\nAuthor: Jon\r\nDate:   Sun Jan 16 12:15:46 2022 +0930\r\n\r\n    buid(test)!: Test breaking change\r\n    \r\n    text for body goes here\r\n    \r\n    the commit footer\r\n\r\ncommit f455eb2e278eb3fd7f9dde693587393ea2783cff\r\nMerge: a629e39 3360a15\r\nAuthor: Jon \r\nDate:   Thu Aug 12 03:25:10 2021 +0000\r\n\r\n    Merge branch 'style-readme' into 'development'\r\n    \r\n    style(readme): fix badge table.\r\n    \r\n    See merge request nofusscomputing/projects/gitlab-ci!7\r\n(dev_env) $ cz -n cz_nfc bump --dry-run\r\nbuild(version): bump version 0.3.0rc1 → 0.3.0\r\ntag to create: v0.3.0\r\nincrement detected: MINOR\r\n\r\n(dev_env) $ cz -n cz_nfc bump --prerelease rc --dry-run\r\nbuild(version): bump version 0.3.0rc1 → 0.3.0rc2\r\ntag to create: v0.3.0rc2\r\nincrement detected: None\r\n\r\n(dev_env) $ \r\n\r\n```\r\n\r\n\r\n## Current behavior\r\nDoes not do a `MAJOR` version increment when breaking change introduced.\r\n\r\n## Desired behavior\r\nbreaking change, should always increment  the `MAJOR` version number regardless of current version.\r\n\r\n## Environment\r\n\r\n\r\n- cz version: `commitizen version: (test machine 2.17.13) however CI uses current as of date of job. Also tested with cz-0.0.0.0.dev20200924` [CI Build Log]()\r\n\r\n- Custom Module [cz_nfc](https://gitlab.com/nofusscomputing/projects/gitlab-ci/-/tree/f455eb2e278eb3fd7f9dde693587393ea2783cff/gitlab_release/python-module/cz_nfc) (this is the version at the time of the failed version bump) however even the [Current cz_nfc module](https://gitlab.com/nofusscomputing/projects/gitlab-ci/-/tree/ccc601f641a9b07b63a160d779c5037481316e75/gitlab_release/python-module/cz_nfc) does not make a difference\r\n\r\n``` bash\r\n$ python --version\r\nPython 3.6.9\r\n\r\n```\r\npython3 -c \"import platform; print(platform.system())\"\r\n\r\n- test machine:\r\n\r\n   ``` bash\r\n   $ python -c \"import platform; print(platform.system())\"\r\n   Linux\r\n\r\n   ```\r\n\r\n- [CI Build Log #1497464492](https://gitlab.com/nofusscomputing/projects/gitlab-ci/-/jobs/1497464492)\r\n\r\n- operating system: Linux (Gitlab CI: Linux gitlab runner using docker image python 3.6)\r\n\r\n```bash\r\ncz version --report\r\n\r\n$ cz version --report\r\nusage: cz [-h] [--debug] [-n NAME]\r\n          {init,commit,c,ls,example,info,schema,bump,changelog,ch,check,version}\r\n          ...\r\ncz: error: unrecognized arguments: --report\r\n(dev_env) $ \r\n\r\n```\r\n\r\nI have reviewed the docs to ensure that I haven't done anything wrong. However to no avail.\r\n","author":{"url":"https://github.com/jon-nfc","@type":"Person","name":"jon-nfc"},"datePublished":"2022-01-16T02:51:14.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":10},"url":"https://github.com/472/commitizen/issues/472"}