René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"test: test_invalid_command[py_3.14-invalidCommand] fails on Python 3.14.5 due to argparse quoting change","articleBody":"## Description\n\nThe `tests/test_cli.py::test_invalid_command[py_3.14-invalidCommand]` test started failing on Python 3.14.5 (released [May 10, 2026](https://www.python.org/downloads/release/python-3145/)) because CPython restored quoting of choices in argparse error messages:\n\n\u003e [gh-130750](https://github.com/python/cpython/issues/130750): Restore quoting of choices in [argparse](https://docs.python.org/3.14/library/argparse.html#module-argparse) error messages for improved clarity and consistency with documentation.\n\u003e -- [3.14.5 changelog](https://docs.python.org/3.14/whatsnew/changelog.html#python-3-14-5-final)\n\n| Python | argparse \"invalid choice\" format |\n| --- | --- |\n| 3.10, 3.11 | `(choose from 'init', 'commit', ...)` (quoted) |\n| 3.12 | mixed |\n| 3.13, 3.14.0–3.14.4 | `(choose from init, commit, ...)` (unquoted) |\n| 3.14.5+ | `(choose from 'init', 'commit', ...)` (quoted, restored) |\n\nThe checked-in fixture `tests/test_cli/test_invalid_command_py_3_14_invalidCommand_.txt` was generated against 3.14.4 (unquoted), so it no longer matches.\n\n## Reproduction\n\n```bash\nuv run pytest tests/test_cli.py::test_invalid_command\n```\n\nMaster's last successful CI run was on 2026-05-09 (commit `1eb8cde6`) when the GitHub-hosted runner still had Python 3.14.4; runs on or after 2026-05-11 fail with the diff below.\n\n## Observed failure\n\n```\nFAILED tests/test_cli.py::test_invalid_command[py_3.14-invalidCommand] - AssertionError: FILES DIFFER\n-cz: error: argument {...}: invalid choice: 'invalidCommand' (choose from init, commit, ...)\n+cz: error: argument {...}: invalid choice: 'invalidCommand' (choose from 'init', 'commit', ...)\n```\n\nFull log: https://github.com/commitizen-tools/commitizen/actions/runs/25649120897/job/75283769681\n\n## Scope\n\nOnly the **1** `test_invalid_command_py_3_14_invalidCommand_.txt` fixture is affected by gh-130750 (the companion `--invalid-arg` case uses the metavar, not the choice list). The other 60+ Python-version-keyed fixtures (`test_command_shows_description_when_use_help_option_py_3_*_*.txt`, `test_no_argv_py_3_*_.txt`) capture argparse **help text**, which is unaffected by this change.\n\n## Suggested fix (short-term)\n\n**Skip the affected `test_invalid_command` parametrization on Python ≥ 3.14.5** until upstream stabilizes:\n\n```python\n@pytest.mark.parametrize(\n    \"arg\",\n    [\n        \"--invalid-arg\",\n        pytest.param(\n            \"invalidCommand\",\n            marks=pytest.mark.skipif(\n                (3, 14, 5) \u003c= sys.version_info \u003c (3, 15),\n                reason=(\n                    \"argparse error format changed in Python 3.14.5 (gh-130750); \"\n                    \"fixture matches 3.14.0-4 unquoted format\"\n                ),\n            ),\n        ),\n    ],\n)\n```\n\nSurfaced while working on #1846; this skip unblocks CI without changing PR scope. Implemented in #1991.\n\n## Future enhancement (still open after #1991)\n\nArgparse error output has churned across Python patch releases (3.10/3.11 quoted → 3.13/3.14.0–4 unquoted → 3.14.5 quoted). A more durable approach worth considering once the codebase is more stable:\n\n**Normalize argparse error output before `file_regression.check()`** — e.g., strip surrounding quotes around `choose from` items, or replace the variable parts with placeholders:\n\n```python\ndef _normalize_argparse_error(text: str) -\u003e str:\n    # Collapse \"'init', 'commit'\" and \"init, commit\" to a single canonical form\n    text = re.sub(\n        r\"\\(choose from [^)]+\\)\",\n        \"(choose from \u003cCHOICES\u003e)\",\n        text,\n    )\n    return text\n\n# Usage:\nfile_regression.check(_normalize_argparse_error(err), extension=\".txt\")\n```\n\nThat would let us delete the per-Python-version fixtures for `test_invalid_command[invalidCommand]` and stop chasing argparse formatting changes. **#1991 only implements the short-term skip; this enhancement is still open.**","author":{"url":"https://github.com/bearomorphism","@type":"Person","name":"bearomorphism"},"datePublished":"2026-05-11T03:50:36.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/1990/commitizen/issues/1990"}