Title: Consider excluding pure typing modules from coverage (question.py) · Issue #1904 · commitizen-tools/commitizen · GitHub
Open Graph Title: Consider excluding pure typing modules from coverage (question.py) · Issue #1904 · commitizen-tools/commitizen
X Title: Consider excluding pure typing modules from coverage (question.py) · Issue #1904 · commitizen-tools/commitizen
Description: Description Context commitizen/question.py is mostly a typing module. It defines question-related structures using TypedDict, Literal, unions, and callable type hints. Question Should we exclude this file from coverage? Steps to reproduc...
Open Graph Description: Description Context commitizen/question.py is mostly a typing module. It defines question-related structures using TypedDict, Literal, unions, and callable type hints. Question Should we exclude th...
X Description: Description Context commitizen/question.py is mostly a typing module. It defines question-related structures using TypedDict, Literal, unions, and callable type hints. Question Should we exclude th...
Opengraph URL: https://github.com/commitizen-tools/commitizen/issues/1904
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Consider excluding pure typing modules from coverage (question.py)","articleBody":"### Description\n\n## Context\n\n`commitizen/question.py` is mostly a typing module. It defines question-related structures using TypedDict, Literal, unions, and callable type hints.\n\n## Question\n\nShould we exclude this file from coverage?\n\n### Steps to reproduce\n\n`uv run poe cover`\n\n### Current behavior\n\n```\nName Stmts Miss Cover Missing\n------------------------------------------------------------------------------------------\ncommitizen/question.py 7 7 0% 1-41\n```\n\n### Desired behavior\n\nMy view:\n\nI lean toward excluding `commitizen/question.py` from coverage, since its value is mostly in static typing rather than runtime behavior.\n\nWe can add `commitizen/question.py` to the coverage omit list in `pyproject.toml`.\n\n\n### Screenshots\n\n_No response_\n\n### Environment\n\nCommitizen Version: 4.13.9\nPython Version: 3.14.3 (main, Feb 3 2026, 15:32:20) [Clang 15.0.0 (clang-1500.1.0.2.5)]\nOperating System: Darwin","author":{"url":"https://github.com/ttw225","@type":"Person","name":"ttw225"},"datePublished":"2026-03-19T06:40:23.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/1904/commitizen/issues/1904"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:871cef69-67ca-239e-348a-af1084d6a536 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E9C6:322E35:455E37:5D9720:6A4EB860 |
| html-safe-nonce | 5e04191606358952dddebfab6777593b9f8c6f2f782837843621ce9901e55895 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUM2OjMyMkUzNTo0NTVFMzc6NUQ5NzIwOjZBNEVCODYwIiwidmlzaXRvcl9pZCI6Ijg3MDMxMjk1NTIwODYyODQzODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4a1693590620de7b246d39bdb1c1478c3188a9b5411bed6c5518068080aa111e |
| hovercard-subject-tag | issue:4099679982 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/commitizen-tools/commitizen/1904/issue_layout |
| twitter:image | https://opengraph.githubassets.com/dd3cc6b1ef26db78bbb84c586038d0a3f9867c17bfc658dc989b9f60cb911322/commitizen-tools/commitizen/issues/1904 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dd3cc6b1ef26db78bbb84c586038d0a3f9867c17bfc658dc989b9f60cb911322/commitizen-tools/commitizen/issues/1904 |
| og:image:alt | Description Context commitizen/question.py is mostly a typing module. It defines question-related structures using TypedDict, Literal, unions, and callable type hints. Question Should we exclude th... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ttw225 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-preview |
| go-import | github.com/commitizen-tools/commitizen git https://github.com/commitizen-tools/commitizen.git |
| octolytics-dimension-user_id | 62252524 |
| octolytics-dimension-user_login | commitizen-tools |
| octolytics-dimension-repository_id | 106127589 |
| octolytics-dimension-repository_nwo | commitizen-tools/commitizen |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 106127589 |
| octolytics-dimension-repository_network_root_nwo | commitizen-tools/commitizen |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width