Title: `_valid_command_argument` · Issue #1498 · commitizen-tools/commitizen · GitHub
Open Graph Title: `_valid_command_argument` · Issue #1498 · commitizen-tools/commitizen
X Title: `_valid_command_argument` · Issue #1498 · commitizen-tools/commitizen
Description: Description I just think it's not a good design to validate and reassign things in a function. The function name itself is confusing. commitizen/commitizen/commands/check.py Lines 51 to 62 in 47beadc def _valid_command_argument(self): nu...
Open Graph Description: Description I just think it's not a good design to validate and reassign things in a function. The function name itself is confusing. commitizen/commitizen/commands/check.py Lines 51 to 62 in 47bea...
X Description: Description I just think it's not a good design to validate and reassign things in a function. The function name itself is confusing. commitizen/commitizen/commands/check.py Lines 51 to 62 in 4...
Opengraph URL: https://github.com/commitizen-tools/commitizen/issues/1498
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`_valid_command_argument`","articleBody":"### Description\n\nI just think it's not a good design to validate and reassign things in a function. The function name itself is confusing.\n\nhttps://github.com/commitizen-tools/commitizen/blob/47beadc563d8272b64f88ddbf3e9a37351b8f535/commitizen/commands/check.py#L51-L62\n\n### Possible Solution\n\n_No response_\n\n### Additional context\n\n_No response_\n\n### Additional context\n\n_No response_","author":{"url":"https://github.com/bearomorphism","@type":"Person","name":"bearomorphism"},"datePublished":"2025-06-03T11:42:09.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/1498/commitizen/issues/1498"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:9c43fe5d-7f5a-c1db-517a-35c36e173396 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9CE8:1FFDFF:20FE5B6:2D5694B:6A4F3CF2 |
| html-safe-nonce | 8dafcfb65929b96fc8a415d7dfbb149c7e4797781b9aa0a6d8ad436cc109a2ad |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0U4OjFGRkRGRjoyMEZFNUI2OjJENTY5NEI6NkE0RjNDRjIiLCJ2aXNpdG9yX2lkIjoiODIzMDkyNzQ3MzAzNTkxODU3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9e6feb90bec9bccba90f1520f781abe0e2c8079bc1efa01b501cd3ded80d1f47 |
| hovercard-subject-tag | issue:3113618609 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/commitizen-tools/commitizen/1498/issue_layout |
| twitter:image | https://opengraph.githubassets.com/bcff9f5e22b7f739081fedc20b5d1f5fe9bef8ba112b5cdb299a29105734221d/commitizen-tools/commitizen/issues/1498 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bcff9f5e22b7f739081fedc20b5d1f5fe9bef8ba112b5cdb299a29105734221d/commitizen-tools/commitizen/issues/1498 |
| og:image:alt | Description I just think it's not a good design to validate and reassign things in a function. The function name itself is confusing. commitizen/commitizen/commands/check.py Lines 51 to 62 in 47bea... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bearomorphism |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| go-import | github.com/commitizen-tools/commitizen git https://github.com/commitizen-tools/commitizen.git |
| octolytics-dimension-user_id | 62252524 |
| octolytics-dimension-user_login | commitizen-tools |
| octolytics-dimension-repository_id | 106127589 |
| octolytics-dimension-repository_nwo | commitizen-tools/commitizen |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 106127589 |
| octolytics-dimension-repository_network_root_nwo | commitizen-tools/commitizen |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width