Title: Use named capture group in bump_pattern to enable stricter check · Issue #129 · commitizen-tools/commitizen · GitHub
Open Graph Title: Use named capture group in bump_pattern to enable stricter check · Issue #129 · commitizen-tools/commitizen
X Title: Use named capture group in bump_pattern to enable stricter check · Issue #129 · commitizen-tools/commitizen
Description: Goal make regular expression pattern stricter so that we won't accidentally match things we don't need Description In commitizen/cz/conventional_commits/conventional_commits.py#L33 on command-changelog branch, I use named capture group s...
Open Graph Description: Goal make regular expression pattern stricter so that we won't accidentally match things we don't need Description In commitizen/cz/conventional_commits/conventional_commits.py#L33 on command-chang...
X Description: Goal make regular expression pattern stricter so that we won't accidentally match things we don't need Description In commitizen/cz/conventional_commits/conventional_commits.py#L33 on comma...
Opengraph URL: https://github.com/commitizen-tools/commitizen/issues/129
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Use named capture group in bump_pattern to enable stricter check","articleBody":"**Goal**\r\nmake regular expression pattern stricter so that we won't accidentally match things we don't need\r\n\r\n**Description**\r\nIn [commitizen/cz/conventional_commits/conventional_commits.py#L33](https://github.com/Woile/commitizen/blob/command-changelog/commitizen/cz/conventional_commits/conventional_commits.py#L33) on `command-changelog` branch, I use named capture group so that we could use a stricter regular expression like `.*\\n\\nBREAKING CHANGE`. The benefit of it is that we don't have to break the whole commit message into lines like [commitizem/bump.py#L31](https://github.com/Woile/commitizen/blob/v1.16.0/commitizen/bump.py#L31). It can also avoid bump or generate changelog based on commit message like `fix --- it does not follow the rule but still match the pattern`.\r\nAnother thought on this topic is that we probably merge the `bump_map` and `bump_pattern` into one some data class to store `name`(e.g., `break`), `pattern`(e.g., `.*\\n\\nBREAKING CHANGE`), `behavior`(e.g., `PATCH`).","author":{"url":"https://github.com/Lee-W","@type":"Person","name":"Lee-W"},"datePublished":"2020-01-29T04:28:27.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":11},"url":"https://github.com/129/commitizen/issues/129"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:539e9301-35f2-cdf5-7894-d4db38af65dd |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DE14:242157:79EBA1A:9E6B99A:6975B006 |
| html-safe-nonce | 67edfe4c54454c3f9fe59b2a198d68e0dc12ac0f1c9854571dea87d270507e3f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTE0OjI0MjE1Nzo3OUVCQTFBOjlFNkI5OUE6Njk3NUIwMDYiLCJ2aXNpdG9yX2lkIjoiODgzODE2OTgwNDk2Mzk1MDU5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8c6b72a3fef32711e973ba76e56b48cd77f3eaba698060f0a58a9ed972dff53b |
| hovercard-subject-tag | issue:556628545 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/commitizen-tools/commitizen/129/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b189c6e47b06e23d725dd29f99cee37d1206c2db96318c9e27ae40b693b21df6/commitizen-tools/commitizen/issues/129 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b189c6e47b06e23d725dd29f99cee37d1206c2db96318c9e27ae40b693b21df6/commitizen-tools/commitizen/issues/129 |
| og:image:alt | Goal make regular expression pattern stricter so that we won't accidentally match things we don't need Description In commitizen/cz/conventional_commits/conventional_commits.py#L33 on command-chang... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Lee-W |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f |
| turbo-cache-control | no-preview |
| go-import | github.com/commitizen-tools/commitizen git https://github.com/commitizen-tools/commitizen.git |
| octolytics-dimension-user_id | 62252524 |
| octolytics-dimension-user_login | commitizen-tools |
| octolytics-dimension-repository_id | 106127589 |
| octolytics-dimension-repository_nwo | commitizen-tools/commitizen |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 106127589 |
| octolytics-dimension-repository_network_root_nwo | commitizen-tools/commitizen |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 488b30e96dfd057fbbe44c6665ccbc030b729dde |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width