René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Fails in hook mode when package is a subdirectory of git repo","articleBody":"### Scenario:\r\n\r\nEverything Node.JS lives within a subfolder e.g myGitRepo/source/package.json:\r\n```\r\n  \"devDependencies\": {\r\n    \"commitizen\": \"^4.0.3\",\r\n    \"cz-conventional-changelog\": \"^3.0.2\",\r\n    \"husky\": \"^3.0.9\"\r\n  },\r\n  \"config\": {\r\n    \"commitizen\": {\r\n      \"path\": \"cz-conventional-changelog\"\r\n    }\r\n  },\r\n  \"husky\": {\r\n    \"hooks\": {\r\n      \"prepare-commit-msg\": \"exec \u003c /dev/tty \u0026\u0026 npx git cz --hook || true\"\r\n    }\r\n  }\r\n```\r\n\r\nOverriding `config.commitizen.path` to the plain npm module name `cz-conventional-changelog` (as per #469) is sufficient to get `npx git cz` working, BUT...\r\n\r\n### Problem:\r\n\r\nTrying to use the husky hook (which is from the README) will throw:\r\n```\r\nmyGitRepo/source $ git commit\r\n# (Prompting works fine, but then...)\r\nError: ENOENT: no such file or directory, open '/myCoolParentFolder/myGitRepo/source/.git/COMMIT_EDITMSG\r\n```\r\n\r\nNote that it's always taking the package.json folder, not the current working directory e.g:\r\n```\r\nmyGitRepo/source/packages $ git commit\r\n# (Also prompts fine, but tries to write to same wrong .git folder...)\r\nError: ENOENT: no such file or directory, open '/myCoolParentFolder/myGitRepo/source/.git/COMMIT_EDITMSG\r\n```\r\n\r\nIt doesn't seem to be possible to override via environment variables (e.g. by messing with `GIT_DIR` in the husky hook statement like they do [here](https://github.com/typicode/husky/issues/364) or [here](https://github.com/typicode/husky/issues/584)), because [cli/strategies/git-cz.js](https://github.com/commitizen/cz-cli/blob/master/src/cli/strategies/git-cz.js) explicitly calls `commitizen.commit` with `repoPath = process.cwd()`:\r\n\r\n```\r\n  commit(sh, inquirer, process.cwd(), prompter, {\r\n      args: parsedGitCzArgs,\r\n      disableAppendPaths: true,\r\n      emitData: true,\r\n      quiet: false,\r\n      retryLastCommit,\r\n      hookMode\r\n    }, function (error) {\r\n      if (error) {\r\n        throw error;\r\n      }\r\n    });\r\n```\r\n\r\n...and [git/commit.js](https://github.com/commitizen/cz-cli/blob/master/src/git/commit.js) uses that repoPath to store the captured message:\r\n```\r\nconst commitFilePath = path.join(repoPath, '/.git/COMMIT_EDITMSG');\r\n```\r\n\r\nThis issue only affects running in hook mode, because in standard `git cz` we just pass the message through as an argument to a spawned git process, which manages to figure out that it's in a subfolder of a repository.\r\n\r\n### Fix Investigation:\r\n\r\nI had a look around to try and figure what a fix might look like, but I don't really understand why `cliPath` and `repoPath` are tracked as separate variables when the CLI strategy seems to just force `repoPath` to the package root?","author":{"url":"https://github.com/athewsey","@type":"Person","name":"athewsey"},"datePublished":"2019-10-22T04:27:21.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/683/cz-cli/issues/683"}