| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:55e71879-3fd9-65f0-9c11-7af35745ee32 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8B54:BA8B4:113B808:16C00B4:6981992D |
| html-safe-nonce | f0579334a98ee5fe6518bac13043483e00ed3d0a9115229f38c043218775398a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjU0OkJBOEI0OjExM0I4MDg6MTZDMDBCNDo2OTgxOTkyRCIsInZpc2l0b3JfaWQiOiI3MjA5MDAzMzQyODIxOTU1ODg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 433a417dd0cbf742dcafc47fc5ce25576dd5150d56ae9bfae41c219c6d702e83 |
| hovercard-subject-tag | pull_request:467104964 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/commitdev/zero-aws-eks-stack/61/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1c39a80c6f4b3ac50141ec7e596e3d159f4b9173b4e0f5ea2d8b8bcb4f585aa0/commitdev/zero-aws-eks-stack/pull/61 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1c39a80c6f4b3ac50141ec7e596e3d159f4b9173b4e0f5ea2d8b8bcb4f585aa0/commitdev/zero-aws-eks-stack/pull/61 |
| og:image:alt | create a new bucket using the root domain name.
fix domain tag delimiter.
closes #59
related to commitdev/zero#222 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dtoki |
| hostname | github.com |
| expected-hostname | github.com |
| None | e137814e266030874fd2c86863529d0622b13889eeda04148c57654b6ea84ad6 |
| turbo-cache-control | no-preview |
| go-import | github.com/commitdev/zero-aws-eks-stack git https://github.com/commitdev/zero-aws-eks-stack.git |
| octolytics-dimension-user_id | 44272088 |
| octolytics-dimension-user_login | commitdev |
| octolytics-dimension-repository_id | 247773730 |
| octolytics-dimension-repository_nwo | commitdev/zero-aws-eks-stack |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 247773730 |
| octolytics-dimension-repository_network_root_nwo | commitdev/zero-aws-eks-stack |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd58d68a7813bbec9c91422c8c35f4af33832d70 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/commitdev/zero-aws-eks-stack/pull/61#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcommitdev%2Fzero-aws-eks-stack%2Fpull%2F61 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcommitdev%2Fzero-aws-eks-stack%2Fpull%2F61 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=commitdev%2Fzero-aws-eks-stack |
| Reload | https://github.com/commitdev/zero-aws-eks-stack/pull/61 |
| Reload | https://github.com/commitdev/zero-aws-eks-stack/pull/61 |
| Reload | https://github.com/commitdev/zero-aws-eks-stack/pull/61 |
|
commitdev
| https://github.com/commitdev |
| zero-aws-eks-stack | https://github.com/commitdev/zero-aws-eks-stack |
|
Notifications
| https://github.com/login?return_to=%2Fcommitdev%2Fzero-aws-eks-stack |
|
Fork
9
| https://github.com/login?return_to=%2Fcommitdev%2Fzero-aws-eks-stack |
|
Star
16
| https://github.com/login?return_to=%2Fcommitdev%2Fzero-aws-eks-stack |
|
Code
| https://github.com/commitdev/zero-aws-eks-stack |
|
Issues
13
| https://github.com/commitdev/zero-aws-eks-stack/issues |
|
Pull requests
17
| https://github.com/commitdev/zero-aws-eks-stack/pulls |
|
Actions
| https://github.com/commitdev/zero-aws-eks-stack/actions |
|
Security
0
| https://github.com/commitdev/zero-aws-eks-stack/security |
|
Insights
| https://github.com/commitdev/zero-aws-eks-stack/pulse |
|
Code
| https://github.com/commitdev/zero-aws-eks-stack |
|
Issues
| https://github.com/commitdev/zero-aws-eks-stack/issues |
|
Pull requests
| https://github.com/commitdev/zero-aws-eks-stack/pulls |
|
Actions
| https://github.com/commitdev/zero-aws-eks-stack/actions |
|
Security
| https://github.com/commitdev/zero-aws-eks-stack/security |
|
Insights
| https://github.com/commitdev/zero-aws-eks-stack/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fcommitdev%2Fzero-aws-eks-stack%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fcommitdev%2Fzero-aws-eks-stack%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/commitdev/zero-aws-eks-stack/pull/61#issue-comment-box |
| dtoki | https://github.com/dtoki |
| master | https://github.com/commitdev/zero-aws-eks-stack/tree/master |
| 222-zero-landing-page | https://github.com/commitdev/zero-aws-eks-stack/tree/222-zero-landing-page |
|
Zero landing page [zero-222]
| https://github.com/commitdev/zero-aws-eks-stack/pull/61#top |
| dtoki | https://github.com/dtoki |
| master | https://github.com/commitdev/zero-aws-eks-stack/tree/master |
| 222-zero-landing-page | https://github.com/commitdev/zero-aws-eks-stack/tree/222-zero-landing-page |
|
Conversation
1
| https://github.com/commitdev/zero-aws-eks-stack/pull/61 |
|
Commits
3
| https://github.com/commitdev/zero-aws-eks-stack/pull/61/commits |
|
Checks
0
| https://github.com/commitdev/zero-aws-eks-stack/pull/61/checks |
|
Files changed
| https://github.com/commitdev/zero-aws-eks-stack/pull/61/files |
| Please reload this page | https://github.com/commitdev/zero-aws-eks-stack/pull/61 |
| https://github.co/hiddenchars |
| https://github.com/commitdev/zero-aws-eks-stack/pull/{{ revealButtonHref }} |
|
| https://github.com/dtoki |
| dtoki | https://github.com/dtoki |
| Aug 13, 2020 | https://github.com/commitdev/zero-aws-eks-stack/pull/61#issue-678096272 |
| Please reload this page | https://github.com/commitdev/zero-aws-eks-stack/pull/61 |
| #59 | https://github.com/commitdev/zero-aws-eks-stack/issues/59 |
| commitdev/zero#222 | https://github.com/commitdev/zero/issues/222 |
| Please reload this page | https://github.com/commitdev/zero-aws-eks-stack/pull/61 |
| dtoki | https://github.com/dtoki |
| August 11, 2020 10:08 | https://github.com/commitdev/zero-aws-eks-stack/pull/61#commits-pushed-47abc82 |
|
| https://github.com/dtoki |
| add root domain to s3 buckets | https://github.com/commitdev/zero-aws-eks-stack/pull/61/commits/47abc825392bd6747a8a61169d6c5ef978a5b216 |
| 47abc82 | https://github.com/commitdev/zero-aws-eks-stack/pull/61/commits/47abc825392bd6747a8a61169d6c5ef978a5b216 |
|
| https://github.com/dtoki |
| fix domain tag naming validation error | https://github.com/commitdev/zero-aws-eks-stack/pull/61/commits/59f8c6b15b3afd8bceba929b05b412cd6fa21ea5 |
| 59f8c6b | https://github.com/commitdev/zero-aws-eks-stack/pull/61/commits/59f8c6b15b3afd8bceba929b05b412cd6fa21ea5 |
| https://github.com/dtoki |
| dtoki | https://github.com/dtoki |
| davidcheung | https://github.com/davidcheung |
| August 13, 2020 02:16 | https://github.com/commitdev/zero-aws-eks-stack/pull/61#event-3650115481 |
| https://github.com/dtoki |
| dtoki | https://github.com/dtoki |
| Aug 13, 2020 | https://github.com/commitdev/zero-aws-eks-stack/pull/61#event-3650120555 |
| https://github.com/dtoki |
| dtoki | https://github.com/dtoki |
| bmonkman | https://github.com/bmonkman |
| August 13, 2020 02:25 | https://github.com/commitdev/zero-aws-eks-stack/pull/61#event-3650131661 |
| https://github.com/bmonkman |
| bmonkman | https://github.com/bmonkman |
|
Aug 13, 2020
| https://github.com/commitdev/zero-aws-eks-stack/pull/61#pullrequestreview-467021804 |
|
View reviewed changes
| https://github.com/commitdev/zero-aws-eks-stack/pull/61/files/59f8c6b15b3afd8bceba929b05b412cd6fa21ea5 |
| templates/terraform/modules/s3_hosting/main.tf | https://github.com/commitdev/zero-aws-eks-stack/pull/61/files/59f8c6b15b3afd8bceba929b05b412cd6fa21ea5#diff-cf16c77d2153f551f1086b2f75e85063f7d1ad72ba8f2e464a36ae7dd042ace4 |
| bmonkman | https://github.com/bmonkman |
| Aug 13, 2020 | https://github.com/commitdev/zero-aws-eks-stack/pull/61#discussion_r470157145 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/commitdev/zero-aws-eks-stack/pull/61 |
|
| https://github.com/dtoki |
| fixup! | https://github.com/commitdev/zero-aws-eks-stack/pull/61/commits/f39867fbffac2f9ab036d0bbf1297078b69b2339 |
| f39867f | https://github.com/commitdev/zero-aws-eks-stack/pull/61/commits/f39867fbffac2f9ab036d0bbf1297078b69b2339 |
| https://github.com/bmonkman |
| bmonkman | https://github.com/bmonkman |
|
Aug 13, 2020
| https://github.com/commitdev/zero-aws-eks-stack/pull/61#pullrequestreview-467043984 |
|
View reviewed changes
| https://github.com/commitdev/zero-aws-eks-stack/pull/61/files/f39867fbffac2f9ab036d0bbf1297078b69b2339 |
| https://github.com/dtoki |
| dtoki | https://github.com/dtoki |
| Aug 13, 2020 | https://github.com/commitdev/zero-aws-eks-stack/pull/61#event-3653889478 |
| https://github.com/dtoki |
| dtoki | https://github.com/dtoki |
| 9ac4676 | https://github.com/commitdev/zero-aws-eks-stack/commit/9ac46760115ff68754a25b34dd971ff7cbd49306 |
| Aug 18, 2020 | https://github.com/commitdev/zero-aws-eks-stack/pull/61#event-3667291036 |
| https://github.com/dtoki |
| dtoki | https://github.com/dtoki |
| August 18, 2020 17:01 | https://github.com/commitdev/zero-aws-eks-stack/pull/61#event-3667292096 |
| bmonkman | https://github.com/bmonkman |
|
Oct 10, 2020
| https://github.com/commitdev/zero-aws-eks-stack/pull/61#ref-commit-8932ca8 |
|
| https://github.com/dtoki |
| Zero landing page [zero-222] ( | https://github.com/commitdev/zero-aws-eks-stack/commit/8932ca89677a9420ace217954976fa5ea86b8748 |
| #61 | https://github.com/commitdev/zero-aws-eks-stack/pull/61 |
| ) | https://github.com/commitdev/zero-aws-eks-stack/commit/8932ca89677a9420ace217954976fa5ea86b8748 |
| 8932ca8 | https://github.com/commitdev/zero-aws-eks-stack/commit/8932ca89677a9420ace217954976fa5ea86b8748 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcommitdev%2Fzero-aws-eks-stack%2Fpull%2F61 |
|
| https://github.com/davidcheung |
|
davidcheung
| https://github.com/davidcheung |
|
| https://github.com/bmonkman |
|
bmonkman
| https://github.com/bmonkman |
|
| https://github.com/commitdev/zero-aws-eks-stack/pull/61/files/f39867fbffac2f9ab036d0bbf1297078b69b2339 |
|
Aws certificate manager domains; tags validation.
| https://github.com/commitdev/zero-aws-eks-stack/issues/59 |
| Please reload this page | https://github.com/commitdev/zero-aws-eks-stack/pull/61 |
|
| https://github.com/dtoki |
|
| https://github.com/bmonkman |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |