René's URL Explorer Experiment


Title: fix(cli): await trailing progress-log writes before settling download by EhabY · Pull Request #1122 · coder/vscode-coder · GitHub

Open Graph Title: fix(cli): await trailing progress-log writes before settling download by EhabY · Pull Request #1122 · coder/vscode-coder

X Title: fix(cli): await trailing progress-log writes before settling download by EhabY · Pull Request #1122 · coder/vscode-coder

Description: Open any Coder workspace in VS Code with a single click. - fix(cli): await trailing progress-log writes before settling download by EhabY · Pull Request #1122 · coder/vscode-coder

Open Graph Description: Fixes #1120 Root cause CliManager.download() settled its promise on a progressWrite captured by value at the moment the read stream closed. A chunk write still in flight at that point was never awa...

X Description: Fixes #1120 Root cause CliManager.download() settled its promise on a progressWrite captured by value at the moment the read stream closed. A chunk write still in flight at that point was never awa...

Opengraph URL: https://github.com/coder/vscode-coder/pull/1122

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:32bea6a8-0952-1e56-e998-87dc230a3ab5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9410:A3C75:42792:5333C:6B00F18E
html-safe-nonce8fa8bfed29372226972af67bc732731b3c8091099811411d9c7a0c0daa64d4d0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDEwOkEzQzc1OjQyNzkyOjUzMzNDOjZCMDBGMThFIiwidmlzaXRvcl9pZCI6IjM5MDE5ODE0MjgwNDg1MjM2NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac848fb56199fd445b1152eb1876a753952ebe06f1faab7b862b17438b1880ee35
hovercard-subject-tagpull_request:4591670376
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/vscode-coder/1122/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5b7c8707f2e3c427da6149e431e074ff1bc95a7058ffcea1adefb0dc6a66ffac/coder/vscode-coder/pull/1122
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5b7c8707f2e3c427da6149e431e074ff1bc95a7058ffcea1adefb0dc6a66ffac/coder/vscode-coder/pull/1122
og:image:altFixes #1120 Root cause CliManager.download() settled its promise on a progressWrite captured by value at the moment the read stream closed. A chunk write still in flight at that point was never awa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameEhabY
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/coder/vscode-coder git https://github.com/coder/vscode-coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id582550891
octolytics-dimension-repository_nwocoder/vscode-coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id582550891
octolytics-dimension-repository_network_root_nwocoder/vscode-coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/vscode-coder/pull/1122#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fvscode-coder%2Fpull%2F1122
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fvscode-coder%2Fpull%2F1122
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fvscode-coder
Reloadhttps://github.com/coder/vscode-coder/pull/1122
Reloadhttps://github.com/coder/vscode-coder/pull/1122
Reloadhttps://github.com/coder/vscode-coder/pull/1122
coderhttps://github.com/coder
vscode-coderhttps://github.com/coder/vscode-coder
Codehttps://github.com/coder/vscode-coder
Issues23 (23)https://github.com/coder/vscode-coder/issues
Pull requests5 (5)https://github.com/coder/vscode-coder/pulls
Actionshttps://github.com/coder/vscode-coder/actions
Projectshttps://github.com/coder/vscode-coder/projects
Security and quality8 (8)https://github.com/coder/vscode-coder/security
Insightshttps://github.com/coder/vscode-coder/insights
https://github.com/coder/vscode-coder
EhabYhttps://github.com/EhabY
mainhttps://github.com/coder/vscode-coder/tree/main
fix/cli-download-trailing-progress-write-racehttps://github.com/coder/vscode-coder/tree/fix/cli-download-trailing-progress-write-race
Conversationhttps://github.com/coder/vscode-coder/pull/1122
Commits1 (1)https://github.com/coder/vscode-coder/pull/1122/commits
Checkshttps://github.com/coder/vscode-coder/pull/1122/checks
Files changedhttps://github.com/coder/vscode-coder/pull/1122/files
fix(cli): await trailing progress-log writes before settling downloadhttps://github.com/coder/vscode-coder/pull/1122#top
EhabYhttps://github.com/EhabY
mainhttps://github.com/coder/vscode-coder/tree/main
fix/cli-download-trailing-progress-write-racehttps://github.com/coder/vscode-coder/tree/fix/cli-download-trailing-progress-write-race
https://github.com/EhabY
EhabYhttps://github.com/EhabY
Sep 21, 2026https://github.com/coder/vscode-coder/pull/1122#issue-5527206684
Please reload this pagehttps://github.com/coder/vscode-coder/pull/1122
#1120https://github.com/coder/vscode-coder/issues/1120
Please reload this pagehttps://github.com/coder/vscode-coder/pull/1122
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
EhabYhttps://github.com/EhabY
Sep 21, 2026https://github.com/coder/vscode-coder/pull/1122#event-31528894083
https://github.com/EhabY
EhabYhttps://github.com/EhabY
force-pushedhttps://github.com/coder/vscode-coder/compare/a5fcadf00621de0001d0212d21579e423270adce..a051b0bc310848d4efa5044ed71811099940ceac
a5fcadfhttps://github.com/coder/vscode-coder/commit/a5fcadf00621de0001d0212d21579e423270adce
a051b0bhttps://github.com/coder/vscode-coder/commit/a051b0bc310848d4efa5044ed71811099940ceac
Compare https://github.com/coder/vscode-coder/compare/a5fcadf00621de0001d0212d21579e423270adce..a051b0bc310848d4efa5044ed71811099940ceac
September 21, 2026 14:12https://github.com/coder/vscode-coder/pull/1122#event-31534280258
https://github.com/EhabY
EhabYhttps://github.com/EhabY
aqandrewhttps://github.com/aqandrew
September 21, 2026 15:28https://github.com/coder/vscode-coder/pull/1122#event-31539484139
https://github.com/aqandrew
aqandrewhttps://github.com/aqandrew
Sep 22, 2026 https://github.com/coder/vscode-coder/pull/1122#pullrequestreview-5283838165
View reviewed changes https://github.com/coder/vscode-coder/pull/1122/files
aqandrewhttps://github.com/aqandrew
https://github.com/coder/vscode-coder/pull/1122#pullrequestreview-5283838165
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/vscode-coder/pull/1122
test/unit/core/cliManagerHarness.tshttps://github.com/coder/vscode-coder/pull/1122/files#diff-92f327300a1617f67e5ac3a32e2d333e4e9f19b30ab17165905fb4983f250721
Please reload this pagehttps://github.com/coder/vscode-coder/pull/1122
https://github.com/EhabY
fix(cli): await trailing progress-log writes before settling downloadhttps://github.com/coder/vscode-coder/pull/1122/commits/1b498fea29e6a04fdd5f026440bd44ad3df6b11a
1b498fehttps://github.com/coder/vscode-coder/pull/1122/commits/1b498fea29e6a04fdd5f026440bd44ad3df6b11a
https://github.com/EhabY
EhabYhttps://github.com/EhabY
force-pushedhttps://github.com/coder/vscode-coder/compare/a051b0bc310848d4efa5044ed71811099940ceac..1b498fea29e6a04fdd5f026440bd44ad3df6b11a
a051b0bhttps://github.com/coder/vscode-coder/commit/a051b0bc310848d4efa5044ed71811099940ceac
1b498fehttps://github.com/coder/vscode-coder/commit/1b498fea29e6a04fdd5f026440bd44ad3df6b11a
Compare https://github.com/coder/vscode-coder/compare/a051b0bc310848d4efa5044ed71811099940ceac..1b498fea29e6a04fdd5f026440bd44ad3df6b11a
September 23, 2026 09:39https://github.com/coder/vscode-coder/pull/1122#event-31665272829
https://github.com/EhabY
EhabYhttps://github.com/EhabY
6c4976chttps://github.com/coder/vscode-coder/commit/6c4976c666eac895d90a5fc1d06edea163788144
Sep 23, 2026https://github.com/coder/vscode-coder/pull/1122#event-31665493453
Please reload this pagehttps://github.com/coder/vscode-coder/pull/1122
https://github.com/EhabY
EhabYhttps://github.com/EhabY
September 23, 2026 09:43https://github.com/coder/vscode-coder/pull/1122#event-31665496247
https://github.com/EhabY
EhabYhttps://github.com/EhabY
Sep 23, 2026 https://github.com/coder/vscode-coder/pull/1122#ref-pullrequest-5556226174
chore: release v1.16.4 #1126 https://github.com/coder/vscode-coder/pull/1126
https://github.co/hiddenchars
https://github.com/coder/vscode-coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fvscode-coder%2Fpull%2F1122
https://github.com/aqandrew
aqandrew https://github.com/aqandrew
https://github.com/coder/vscode-coder/pull/1122/files/a051b0bc310848d4efa5044ed71811099940ceac
Please reload this pagehttps://github.com/coder/vscode-coder/pull/1122
https://github.com/EhabY
EhabY https://github.com/EhabY
Flaky test: concurrent CLI redownload times out waiting for the progress log to go away https://github.com/coder/vscode-coder/issues/1120
Please reload this pagehttps://github.com/coder/vscode-coder/pull/1122
https://github.com/EhabY
https://github.com/aqandrew
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.