| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:35a764aa-53c6-d66b-0f60-984480dce05d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 89A0:26ECEB:2FE3709:3CE7CB4:6B01B310 |
| html-safe-nonce | eb2b7efe4a721cd69d7ea5570f439710484c8b2bc1621827c216cfdfc1763dcc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUEwOjI2RUNFQjoyRkUzNzA5OjNDRTdDQjQ6NkIwMUIzMTAiLCJ2aXNpdG9yX2lkIjoiNDQyMzkyNjEzODk4OTAzMjIwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6117aaa3450e9c545ec49a4b54d000bb236f155d8ba727b7d12755b4710f1dd9 |
| hovercard-subject-tag | pull_request:5366806748 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/ssh/8/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/335149d28603bc817a7161e0be36754c32b32f0ed4697e71ae83d181e478532d/coder/ssh/pull/8 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/335149d28603bc817a7161e0be36754c32b32f0ed4697e71ae83d181e478532d/coder/ssh/pull/8 |
| og:image:alt | The server keep-alive had two gaps that let a silent client keep its connection open forever:
On timeout it closed only the session channel, so the connection and its context stayed open. Anything... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | EhabY |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/ssh git https://github.com/coder/ssh.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 523686136 |
| octolytics-dimension-repository_nwo | coder/ssh |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 69914159 |
| octolytics-dimension-repository_parent_nwo | gliderlabs/ssh |
| octolytics-dimension-repository_network_root_id | 69914159 |
| octolytics-dimension-repository_network_root_nwo | gliderlabs/ssh |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/ssh/pull/8#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fssh%2Fpull%2F8 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fssh%2Fpull%2F8 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fssh |
| Reload | https://github.com/coder/ssh/pull/8 |
| Reload | https://github.com/coder/ssh/pull/8 |
| Reload | https://github.com/coder/ssh/pull/8 |
| coder | https://github.com/coder |
| ssh | https://github.com/coder/ssh |
| Code | https://github.com/coder/ssh |
| Pull requests2 (2) | https://github.com/coder/ssh/pulls |
| Actions | https://github.com/coder/ssh/actions |
| Projects | https://github.com/coder/ssh/projects |
| Security and quality | https://github.com/coder/ssh/security |
| Insights | https://github.com/coder/ssh/insights |
| https://github.com/coder/ssh |
| EhabY | https://github.com/EhabY |
| coder:master | https://github.com/coder/ssh/tree/master |
| EhabY:fix/keepalive-timeout-close-connection | https://github.com/EhabY/ssh/tree/fix/keepalive-timeout-close-connection |
| Conversation | https://github.com/coder/ssh/pull/8 |
| Commits5 (5) | https://github.com/coder/ssh/pull/8/commits |
| Checks | https://github.com/coder/ssh/pull/8/checks |
| Files changed | https://github.com/coder/ssh/pull/8/files |
| fix: close the connection when keep-alives stop and allow per-connection settings | https://github.com/coder/ssh/pull/8#top |
| EhabY | https://github.com/EhabY |
| coder:master | https://github.com/coder/ssh/tree/master |
| EhabY:fix/keepalive-timeout-close-connection | https://github.com/EhabY/ssh/tree/fix/keepalive-timeout-close-connection |
|
| https://github.com/EhabY |
| EhabY | https://github.com/EhabY |
| Nov 17, 2026 | https://github.com/coder/ssh/pull/8#issue-6456254890 |
| Please reload this page | https://github.com/coder/ssh/pull/8 |
| coder/coder#32353 | https://github.com/coder/coder/pull/32353 |
| coder/coder#32521 | https://github.com/coder/coder/pull/32521 |
| coder/coder#32444 | https://github.com/coder/coder/pull/32444 |
| @EhabY | https://github.com/EhabY |
| Please reload this page | https://github.com/coder/ssh/pull/8 |
|
| https://github.com/EhabY |
| fix: close the connection when keep-alive replies stop | https://github.com/coder/ssh/pull/8/commits/5a52fe5e5cfa26214baf98f058c26bb891da4a47 |
| 5a52fe5 | https://github.com/coder/ssh/pull/8/commits/5a52fe5e5cfa26214baf98f058c26bb891da4a47 |
| https://github.com/EhabY |
| EhabY | https://github.com/EhabY |
|
Nov 19, 2026
| https://github.com/coder/ssh/pull/8#ref-pullrequest-6489333639 |
|
feat: close silent ssh connections and let clients shorten the keep-alive
coder/coder#32444
| https://github.com/coder/coder/pull/32444 |
| https://github.com/ethanndickson |
| ethanndickson | https://github.com/ethanndickson |
|
Nov 20, 2026
| https://github.com/coder/ssh/pull/8#pullrequestreview-5986147197 |
|
View reviewed changes
| https://github.com/coder/ssh/pull/8/files/5a52fe5e5cfa26214baf98f058c26bb891da4a47 |
| session.go | https://github.com/coder/ssh/pull/8/files/5a52fe5e5cfa26214baf98f058c26bb891da4a47#diff-3d4a6b7d54b5107bc5694b7a06383f9ec4c68f9abe43ba0942f5d970f3a8ccac |
| Please reload this page | https://github.com/coder/ssh/pull/8 |
| session.go | https://github.com/coder/ssh/pull/8/files/5a52fe5e5cfa26214baf98f058c26bb891da4a47#diff-3d4a6b7d54b5107bc5694b7a06383f9ec4c68f9abe43ba0942f5d970f3a8ccac |
| ethanndickson | https://github.com/ethanndickson |
| Nov 20, 2026 | https://github.com/coder/ssh/pull/8#discussion_r4637399689 |
| Please reload this page | https://github.com/coder/ssh/pull/8 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/ssh/pull/8 |
| EhabY | https://github.com/EhabY |
| Nov 20, 2026 | https://github.com/coder/ssh/pull/8#discussion_r4641044706 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 4cd8209 | https://github.com/coder/ssh/commit/4cd8209c613497778470750b15b8b01eddbf93ab |
| Please reload this page | https://github.com/coder/ssh/pull/8 |
|
| https://github.com/EhabY |
| fix: run keep-alives per connection instead of per session | https://github.com/coder/ssh/pull/8/commits/4cd8209c613497778470750b15b8b01eddbf93ab |
| 4cd8209 | https://github.com/coder/ssh/pull/8/commits/4cd8209c613497778470750b15b8b01eddbf93ab |
| https://github.com/EhabY |
| EhabY | https://github.com/EhabY |
| Nov 20, 2026 | https://github.com/coder/ssh/pull/8#event-36754534176 |
| https://github.com/EhabY |
| EhabY | https://github.com/EhabY |
|
Nov 20, 2026
| https://github.com/coder/ssh/pull/8#ref-pullrequest-6455877594 |
|
fix(agent/agentssh): report ssh disconnect when the connection closes
coder/coder#32353
| https://github.com/coder/coder/pull/32353 |
| https://github.com/EhabY |
| EhabY | https://github.com/EhabY |
| November 20, 2026 09:59 | https://github.com/coder/ssh/pull/8#event-36755557882 |
| https://github.com/EhabY |
| EhabY | https://github.com/EhabY |
| ethanndickson | https://github.com/ethanndickson |
| November 20, 2026 10:00 | https://github.com/coder/ssh/pull/8#event-36755680164 |
| EhabY | https://github.com/EhabY |
| November 20, 2026 13:06 | https://github.com/coder/ssh/pull/8#commits-pushed-5097330 |
|
| https://github.com/EhabY |
| fix: require both keep-alive settings in HandleConn | https://github.com/coder/ssh/pull/8/commits/5097330a02d16eb6866e47841114bf7501ad4421 |
| 5097330 | https://github.com/coder/ssh/pull/8/commits/5097330a02d16eb6866e47841114bf7501ad4421 |
|
| https://github.com/EhabY |
| fix: match OpenSSH keep-alive count and read ctx before starting the … | https://github.com/coder/ssh/pull/8/commits/274d0893f7e6a12a5ae789be828e47dc6b9926b5 |
| 274d089 | https://github.com/coder/ssh/pull/8/commits/274d0893f7e6a12a5ae789be828e47dc6b9926b5 |
|
| https://github.com/EhabY |
| feat: add per-connection SetClientAlive and TimedOut to SessionKeepAlive | https://github.com/coder/ssh/pull/8/commits/56f3dfcf4f9a2b9a181c585672f1426b69ba18b1 |
| 56f3dfc | https://github.com/coder/ssh/pull/8/commits/56f3dfcf4f9a2b9a181c585672f1426b69ba18b1 |
| https://github.com/EhabY |
| EhabY | https://github.com/EhabY |
|
Nov 20, 2026
| https://github.com/coder/ssh/pull/8#ref-pullrequest-6510185877 |
|
fix(agent/agentssh): close silent ssh connections and report a network error
coder/coder#32521
| https://github.com/coder/coder/pull/32521 |
| https://github.com/EhabY |
| EhabY | https://github.com/EhabY |
| Nov 20, 2026 | https://github.com/coder/ssh/pull/8#event-36761514462 |
| EhabY | https://github.com/EhabY |
|
Nov 20, 2026
| https://github.com/coder/ssh/pull/8#ref-commit-3be8358 |
|
| https://github.com/EhabY |
| feat(agent/agentssh): close silent ssh connections and let clients sh… | https://github.com/coder/coder/commit/3be8358122ef4b1c494da26e3413fd1369f9eb4a |
| 3be8358 | https://github.com/coder/coder/commit/3be8358122ef4b1c494da26e3413fd1369f9eb4a |
| coder/ssh#8 | https://github.com/coder/ssh/pull/8 |
| EhabY | https://github.com/EhabY |
|
Nov 20, 2026
| https://github.com/coder/ssh/pull/8#ref-commit-29b28ad |
|
| https://github.com/EhabY |
| feat: close silent ssh connections and let clients shorten the keep-a… | https://github.com/coder/coder/commit/29b28ad44b8edc94a89dade8a4ec219e5ba7f875 |
| 29b28ad | https://github.com/coder/coder/commit/29b28ad44b8edc94a89dade8a4ec219e5ba7f875 |
| coder/ssh#8 | https://github.com/coder/ssh/pull/8 |
| https://github.co/hiddenchars |
| https://github.com/coder/ssh/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fssh%2Fpull%2F8 |
|
| https://github.com/ethanndickson |
|
ethanndickson
| https://github.com/ethanndickson |
| Please reload this page | https://github.com/coder/ssh/pull/8 |
| Please reload this page | https://github.com/coder/ssh/pull/8 |
|
| https://github.com/EhabY |
|
| https://github.com/ethanndickson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |