René's URL Explorer Experiment


Title: fix: close the connection when keep-alives stop and allow per-connection settings by EhabY · Pull Request #8 · coder/ssh · GitHub

Open Graph Title: fix: close the connection when keep-alives stop and allow per-connection settings by EhabY · Pull Request #8 · coder/ssh

X Title: fix: close the connection when keep-alives stop and allow per-connection settings by EhabY · Pull Request #8 · coder/ssh

Description: Easy SSH servers in Golang. Contribute to coder/ssh development by creating an account on GitHub.

Open Graph Description: The server keep-alive had two gaps that let a silent client keep its connection open forever: On timeout it closed only the session channel, so the connection and its context stayed open. Anything...

X Description: The server keep-alive had two gaps that let a silent client keep its connection open forever: On timeout it closed only the session channel, so the connection and its context stayed open. Anything...

Opengraph URL: https://github.com/coder/ssh/pull/8

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:35a764aa-53c6-d66b-0f60-984480dce05d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id89A0:26ECEB:2FE3709:3CE7CB4:6B01B310
html-safe-nonceeb2b7efe4a721cd69d7ea5570f439710484c8b2bc1621827c216cfdfc1763dcc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUEwOjI2RUNFQjoyRkUzNzA5OjNDRTdDQjQ6NkIwMUIzMTAiLCJ2aXNpdG9yX2lkIjoiNDQyMzkyNjEzODk4OTAzMjIwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6117aaa3450e9c545ec49a4b54d000bb236f155d8ba727b7d12755b4710f1dd9
hovercard-subject-tagpull_request:5366806748
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/ssh/8/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/335149d28603bc817a7161e0be36754c32b32f0ed4697e71ae83d181e478532d/coder/ssh/pull/8
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/335149d28603bc817a7161e0be36754c32b32f0ed4697e71ae83d181e478532d/coder/ssh/pull/8
og:image:altThe server keep-alive had two gaps that let a silent client keep its connection open forever: On timeout it closed only the session channel, so the connection and its context stayed open. Anything...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameEhabY
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/ssh git https://github.com/coder/ssh.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id523686136
octolytics-dimension-repository_nwocoder/ssh
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id69914159
octolytics-dimension-repository_parent_nwogliderlabs/ssh
octolytics-dimension-repository_network_root_id69914159
octolytics-dimension-repository_network_root_nwogliderlabs/ssh
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/ssh/pull/8#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fssh%2Fpull%2F8
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fssh%2Fpull%2F8
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fssh
Reloadhttps://github.com/coder/ssh/pull/8
Reloadhttps://github.com/coder/ssh/pull/8
Reloadhttps://github.com/coder/ssh/pull/8
coderhttps://github.com/coder
sshhttps://github.com/coder/ssh
Codehttps://github.com/coder/ssh
Pull requests2 (2)https://github.com/coder/ssh/pulls
Actionshttps://github.com/coder/ssh/actions
Projectshttps://github.com/coder/ssh/projects
Security and qualityhttps://github.com/coder/ssh/security
Insightshttps://github.com/coder/ssh/insights
https://github.com/coder/ssh
EhabYhttps://github.com/EhabY
coder:masterhttps://github.com/coder/ssh/tree/master
EhabY:fix/keepalive-timeout-close-connectionhttps://github.com/EhabY/ssh/tree/fix/keepalive-timeout-close-connection
Conversationhttps://github.com/coder/ssh/pull/8
Commits5 (5)https://github.com/coder/ssh/pull/8/commits
Checkshttps://github.com/coder/ssh/pull/8/checks
Files changedhttps://github.com/coder/ssh/pull/8/files
fix: close the connection when keep-alives stop and allow per-connection settingshttps://github.com/coder/ssh/pull/8#top
EhabYhttps://github.com/EhabY
coder:masterhttps://github.com/coder/ssh/tree/master
EhabY:fix/keepalive-timeout-close-connectionhttps://github.com/EhabY/ssh/tree/fix/keepalive-timeout-close-connection
https://github.com/EhabY
EhabYhttps://github.com/EhabY
Nov 17, 2026https://github.com/coder/ssh/pull/8#issue-6456254890
Please reload this pagehttps://github.com/coder/ssh/pull/8
coder/coder#32353https://github.com/coder/coder/pull/32353
coder/coder#32521https://github.com/coder/coder/pull/32521
coder/coder#32444https://github.com/coder/coder/pull/32444
@EhabYhttps://github.com/EhabY
Please reload this pagehttps://github.com/coder/ssh/pull/8
https://github.com/EhabY
fix: close the connection when keep-alive replies stophttps://github.com/coder/ssh/pull/8/commits/5a52fe5e5cfa26214baf98f058c26bb891da4a47
5a52fe5https://github.com/coder/ssh/pull/8/commits/5a52fe5e5cfa26214baf98f058c26bb891da4a47
https://github.com/EhabY
EhabYhttps://github.com/EhabY
Nov 19, 2026 https://github.com/coder/ssh/pull/8#ref-pullrequest-6489333639
feat: close silent ssh connections and let clients shorten the keep-alive coder/coder#32444 https://github.com/coder/coder/pull/32444
https://github.com/ethanndickson
ethanndicksonhttps://github.com/ethanndickson
Nov 20, 2026 https://github.com/coder/ssh/pull/8#pullrequestreview-5986147197
View reviewed changes https://github.com/coder/ssh/pull/8/files/5a52fe5e5cfa26214baf98f058c26bb891da4a47
session.gohttps://github.com/coder/ssh/pull/8/files/5a52fe5e5cfa26214baf98f058c26bb891da4a47#diff-3d4a6b7d54b5107bc5694b7a06383f9ec4c68f9abe43ba0942f5d970f3a8ccac
Please reload this pagehttps://github.com/coder/ssh/pull/8
session.gohttps://github.com/coder/ssh/pull/8/files/5a52fe5e5cfa26214baf98f058c26bb891da4a47#diff-3d4a6b7d54b5107bc5694b7a06383f9ec4c68f9abe43ba0942f5d970f3a8ccac
ethanndicksonhttps://github.com/ethanndickson
Nov 20, 2026https://github.com/coder/ssh/pull/8#discussion_r4637399689
Please reload this pagehttps://github.com/coder/ssh/pull/8
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/ssh/pull/8
EhabYhttps://github.com/EhabY
Nov 20, 2026https://github.com/coder/ssh/pull/8#discussion_r4641044706
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
4cd8209https://github.com/coder/ssh/commit/4cd8209c613497778470750b15b8b01eddbf93ab
Please reload this pagehttps://github.com/coder/ssh/pull/8
https://github.com/EhabY
fix: run keep-alives per connection instead of per sessionhttps://github.com/coder/ssh/pull/8/commits/4cd8209c613497778470750b15b8b01eddbf93ab
4cd8209https://github.com/coder/ssh/pull/8/commits/4cd8209c613497778470750b15b8b01eddbf93ab
https://github.com/EhabY
EhabYhttps://github.com/EhabY
Nov 20, 2026https://github.com/coder/ssh/pull/8#event-36754534176
https://github.com/EhabY
EhabYhttps://github.com/EhabY
Nov 20, 2026 https://github.com/coder/ssh/pull/8#ref-pullrequest-6455877594
fix(agent/agentssh): report ssh disconnect when the connection closes coder/coder#32353 https://github.com/coder/coder/pull/32353
https://github.com/EhabY
EhabYhttps://github.com/EhabY
November 20, 2026 09:59https://github.com/coder/ssh/pull/8#event-36755557882
https://github.com/EhabY
EhabYhttps://github.com/EhabY
ethanndicksonhttps://github.com/ethanndickson
November 20, 2026 10:00https://github.com/coder/ssh/pull/8#event-36755680164
EhabYhttps://github.com/EhabY
November 20, 2026 13:06https://github.com/coder/ssh/pull/8#commits-pushed-5097330
https://github.com/EhabY
fix: require both keep-alive settings in HandleConnhttps://github.com/coder/ssh/pull/8/commits/5097330a02d16eb6866e47841114bf7501ad4421
5097330https://github.com/coder/ssh/pull/8/commits/5097330a02d16eb6866e47841114bf7501ad4421
https://github.com/EhabY
fix: match OpenSSH keep-alive count and read ctx before starting the …https://github.com/coder/ssh/pull/8/commits/274d0893f7e6a12a5ae789be828e47dc6b9926b5
274d089https://github.com/coder/ssh/pull/8/commits/274d0893f7e6a12a5ae789be828e47dc6b9926b5
https://github.com/EhabY
feat: add per-connection SetClientAlive and TimedOut to SessionKeepAlivehttps://github.com/coder/ssh/pull/8/commits/56f3dfcf4f9a2b9a181c585672f1426b69ba18b1
56f3dfchttps://github.com/coder/ssh/pull/8/commits/56f3dfcf4f9a2b9a181c585672f1426b69ba18b1
https://github.com/EhabY
EhabYhttps://github.com/EhabY
Nov 20, 2026 https://github.com/coder/ssh/pull/8#ref-pullrequest-6510185877
fix(agent/agentssh): close silent ssh connections and report a network error coder/coder#32521 https://github.com/coder/coder/pull/32521
https://github.com/EhabY
EhabYhttps://github.com/EhabY
Nov 20, 2026https://github.com/coder/ssh/pull/8#event-36761514462
EhabYhttps://github.com/EhabY
Nov 20, 2026 https://github.com/coder/ssh/pull/8#ref-commit-3be8358
https://github.com/EhabY
feat(agent/agentssh): close silent ssh connections and let clients sh…https://github.com/coder/coder/commit/3be8358122ef4b1c494da26e3413fd1369f9eb4a
3be8358https://github.com/coder/coder/commit/3be8358122ef4b1c494da26e3413fd1369f9eb4a
coder/ssh#8https://github.com/coder/ssh/pull/8
EhabYhttps://github.com/EhabY
Nov 20, 2026 https://github.com/coder/ssh/pull/8#ref-commit-29b28ad
https://github.com/EhabY
feat: close silent ssh connections and let clients shorten the keep-a…https://github.com/coder/coder/commit/29b28ad44b8edc94a89dade8a4ec219e5ba7f875
29b28adhttps://github.com/coder/coder/commit/29b28ad44b8edc94a89dade8a4ec219e5ba7f875
coder/ssh#8https://github.com/coder/ssh/pull/8
https://github.co/hiddenchars
https://github.com/coder/ssh/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fssh%2Fpull%2F8
https://github.com/ethanndickson
ethanndickson https://github.com/ethanndickson
Please reload this pagehttps://github.com/coder/ssh/pull/8
Please reload this pagehttps://github.com/coder/ssh/pull/8
https://github.com/EhabY
https://github.com/ethanndickson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.