René's URL Explorer Experiment


Title: fix: synchronize test logs to prevent `t.Log` race condition by coadler · Pull Request #146 · coder/slog · GitHub

Open Graph Title: fix: synchronize test logs to prevent `t.Log` race condition by coadler · Pull Request #146 · coder/slog

X Title: fix: synchronize test logs to prevent `t.Log` race condition by coadler · Pull Request #146 · coder/slog

Description: Minimal structured logging library for Go. Contribute to coder/slog development by creating an account on GitHub.

Open Graph Description: If (*testing.T).Log is called concurrently of a test exiting, it's picked up by the race detector. This adds logic to allow slogtest to detect when a test has exited, and ensure it doesn't ...

X Description: If (*testing.T).Log is called concurrently of a test exiting, it's picked up by the race detector. This adds logic to allow slogtest to detect when a test has exited, and ensure it doesn&am...

Opengraph URL: https://github.com/coder/slog/pull/146

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d04265a4-6f8e-105b-53d1-eda2cd14d64a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB9BE:3C21B:257BFF9:2FDCAC4:6B017E44
html-safe-nonce2d0fbceb974ed2f0b201b2feb2cfb00a23a1fa81dd5f7afa840ff153918b9b04
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUJFOjNDMjFCOjI1N0JGRjk6MkZEQ0FDNDo2QjAxN0U0NCIsInZpc2l0b3JfaWQiOiI3MTIxODM4MDM4MTM2NzQ5NjM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacaceff11d941d276140c04d478e2fd3d907ad1c07c8089955bfc452db2c6535eb
hovercard-subject-tagpull_request:947451661
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/slog/146/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c37bf58fd5cb9506087838b034ebcb937fa667f37f914d6cba88ba1f896605dc/coder/slog/pull/146
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c37bf58fd5cb9506087838b034ebcb937fa667f37f914d6cba88ba1f896605dc/coder/slog/pull/146
og:image:altIf (*testing.T).Log is called concurrently of a test exiting, it's picked up by the race detector. This adds logic to allow slogtest to detect when a test has exited, and ensure it doesn't ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecoadler
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/slog git https://github.com/coder/slog.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id206593734
octolytics-dimension-repository_nwocoder/slog
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id206593734
octolytics-dimension-repository_network_root_nwocoder/slog
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/slog/pull/146#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fslog%2Fpull%2F146
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fslog%2Fpull%2F146
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fslog
Reloadhttps://github.com/coder/slog/pull/146
Reloadhttps://github.com/coder/slog/pull/146
Reloadhttps://github.com/coder/slog/pull/146
coderhttps://github.com/coder
sloghttps://github.com/coder/slog
Codehttps://github.com/coder/slog
Issues6 (6)https://github.com/coder/slog/issues
Pull requests5 (5)https://github.com/coder/slog/pulls
Actionshttps://github.com/coder/slog/actions
Security and qualityhttps://github.com/coder/slog/security
Insightshttps://github.com/coder/slog/insights
https://github.com/coder/slog
coadlerhttps://github.com/coadler
mainhttps://github.com/coder/slog/tree/main
colin/sync-test-logshttps://github.com/coder/slog/tree/colin/sync-test-logs
Conversationhttps://github.com/coder/slog/pull/146
Commits4 (4)https://github.com/coder/slog/pull/146/commits
Checkshttps://github.com/coder/slog/pull/146/checks
Files changedhttps://github.com/coder/slog/pull/146/files
fix: synchronize test logs to prevent t.Log race conditionhttps://github.com/coder/slog/pull/146#top
coadlerhttps://github.com/coadler
mainhttps://github.com/coder/slog/tree/main
colin/sync-test-logshttps://github.com/coder/slog/tree/colin/sync-test-logs
https://github.com/coadler
coadlerhttps://github.com/coadler
May 25, 2022https://github.com/coder/slog/pull/146#issue-1248627803
Please reload this pagehttps://github.com/coder/slog/pull/146
https://github.com/coadler
fix: synchronize test logs to prevent t.Log race conditionhttps://github.com/coder/slog/pull/146/commits/3570253f9a968c6b6c2b057149dde2e3c10f0aa2
3570253https://github.com/coder/slog/pull/146/commits/3570253f9a968c6b6c2b057149dde2e3c10f0aa2
https://github.com/coadler
coadlerhttps://github.com/coadler
dwahlerhttps://github.com/dwahler
kylecarbshttps://github.com/kylecarbs
May 25, 2022 19:42https://github.com/coder/slog/pull/146#event-6680641251
https://github.com/coadler
coadlerhttps://github.com/coadler
May 25, 2022https://github.com/coder/slog/pull/146#event-6680641290
https://github.com/coveralls
coverallshttps://github.com/coveralls
May 25, 2022https://github.com/coder/slog/pull/146#issuecomment-1137781297
Please reload this pagehttps://github.com/coder/slog/pull/146
Build a64d7100c48aad81449acb051c4d324c4c2336c5-PR-https://coveralls.io/builds/49457850
sloggers/slogtest/t.gohttps://coveralls.io/builds/49457850/source?filename=sloggers%2Fslogtest%2Ft.go#L42
https://coveralls.io/builds/49457850
Build 047b2a21fd5366e616609840b26761300b8d84c5https://coveralls.io/builds/48806750
Coverallshttps://coveralls.io
Please reload this pagehttps://github.com/coder/slog/pull/146
coadlerhttps://github.com/coadler
May 25, 2022 14:48https://github.com/coder/slog/pull/146#commits-pushed-d38b4c3
https://github.com/coadler
add skip testhttps://github.com/coder/slog/pull/146/commits/d38b4c3e1f65539e9d6a97490460a22d39a91f23
d38b4c3https://github.com/coder/slog/pull/146/commits/d38b4c3e1f65539e9d6a97490460a22d39a91f23
https://github.com/coadler
fixup! add skip testhttps://github.com/coder/slog/pull/146/commits/7bcb1b3fbf65d439b89756176ce5d903dfa4ba66
7bcb1b3https://github.com/coder/slog/pull/146/commits/7bcb1b3fbf65d439b89756176ce5d903dfa4ba66
https://github.com/dwahler
dwahlerhttps://github.com/dwahler
May 25, 2022 https://github.com/coder/slog/pull/146#pullrequestreview-985386615
View reviewed changes https://github.com/coder/slog/pull/146/files/7bcb1b3fbf65d439b89756176ce5d903dfa4ba66
dwahlerhttps://github.com/dwahler
https://github.com/coder/slog/pull/146#pullrequestreview-985386615
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/slog/pull/146
sloggers/slogtest/t.gohttps://github.com/coder/slog/pull/146/files/d38b4c3e1f65539e9d6a97490460a22d39a91f23#diff-ac288a1a47616e8fb57f43f0a0a5508d0aad9aedaa11fcc9cd56390d11c03837
Please reload this pagehttps://github.com/coder/slog/pull/146
https://github.com/coadler
david commenthttps://github.com/coder/slog/pull/146/commits/87c0b3d29110c7b35c51c8157508f1aae2e74012
87c0b3dhttps://github.com/coder/slog/pull/146/commits/87c0b3d29110c7b35c51c8157508f1aae2e74012
https://github.com/coadler
coadlerhttps://github.com/coadler
18dce5chttps://github.com/coder/slog/commit/18dce5c2cd5f311781610661c14b9f3a681bb550
May 25, 2022https://github.com/coder/slog/pull/146#event-6680748942
https://github.com/coadler
coadlerhttps://github.com/coadler
May 25, 2022 20:01https://github.com/coder/slog/pull/146#event-6680749051
https://github.com/coadler
coadlerhttps://github.com/coadler
May 25, 2022 https://github.com/coder/slog/pull/146#ref-pullrequest-1248511923
fix: race panic in test/go/postgres coder/coder#1752 https://github.com/coder/coder/pull/1752
https://github.co/hiddenchars
https://github.com/coder/slog/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fslog%2Fpull%2F146
https://github.com/kylecarbs
kylecarbs https://github.com/kylecarbs
https://github.com/dwahler
dwahler https://github.com/dwahler
https://github.com/coder/slog/pull/146/files/7bcb1b3fbf65d439b89756176ce5d903dfa4ba66
Please reload this pagehttps://github.com/coder/slog/pull/146
https://github.com/coadler
coadler https://github.com/coadler
Please reload this pagehttps://github.com/coder/slog/pull/146
https://github.com/coadler
https://github.com/coveralls
https://github.com/dwahler
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.