René's URL Explorer Experiment


Title: refactor: Improve handshake resiliency of peer by kylecarbs · Pull Request #95 · coder/coder · GitHub

Open Graph Title: refactor: Improve handshake resiliency of peer by kylecarbs · Pull Request #95 · coder/coder

X Title: refactor: Improve handshake resiliency of peer by kylecarbs · Pull Request #95 · coder/coder

Description: We were depending on the close mutex to properly report connection state. This ensures the RTC connection is properly closed before returning.

Open Graph Description: We were depending on the close mutex to properly report connection state. This ensures the RTC connection is properly closed before returning.

X Description: We were depending on the close mutex to properly report connection state. This ensures the RTC connection is properly closed before returning.

Opengraph URL: https://github.com/coder/coder/pull/95

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:318cebce-3987-04a3-d7d2-aaca01aafd41
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF92:17FB7:1725E0A:1D4C1C1:6B017401
html-safe-nonce2952ea4c9ff936de7b260c4c4e0a80cc6cfcb2b2643e2310ee114cd9cf2a9c1d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjkyOjE3RkI3OjE3MjVFMEE6MUQ0QzFDMTo2QjAxNzQwMSIsInZpc2l0b3JfaWQiOiIxMzQzOTI4ODAzODE4MzA0NTEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1bbe810d6b9024edccb7b62ec2a1e8e4a446515fa4ca55afaf118055ecd78715
hovercard-subject-tagpull_request:835256934
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/coder/pull/95/files
twitter:imagehttps://avatars.githubusercontent.com/u/7122116?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7122116?s=400&v=4
og:image:altWe were depending on the close mutex to properly report connection state. This ensures the RTC connection is properly closed before returning.
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/coder/coder/pull/95/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F95%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F95%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/95/files
Reloadhttps://github.com/coder/coder/pull/95/files
Reloadhttps://github.com/coder/coder/pull/95/files
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose
kylecarbshttps://github.com/kylecarbs
mainhttps://github.com/coder/coder/tree/main
peerloghttps://github.com/coder/coder/tree/peerlog
Conversation 6 https://github.com/coder/coder/pull/95
Commits 23 https://github.com/coder/coder/pull/95/commits
Checks 0 https://github.com/coder/coder/pull/95/checks
Files changed https://github.com/coder/coder/pull/95/files
Please reload this pagehttps://github.com/coder/coder/pull/95/files
refactor: Improve handshake resiliency of peer https://github.com/coder/coder/pull/95/files#top
Show all changes 23 commits https://github.com/coder/coder/pull/95/files
bf2f59f fix: Synchronize peer logging with a channel kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/bf2f59fdae7747598dfbbb745abf0da04cf455c5
a8fe659 Merge branch 'main' into peerlog kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/a8fe659e6f0b5d51f62b3473e82712c1de5ec149
aad88e0 Disable pion logging kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/aad88e057bb17a1518f68646ca1780c6c3e20b33
59751f4 Remove buffer kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/59751f4ee83c5760f2528d2db99086956ffa3a00
107eb96 Try ICE servers kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/107eb968a7de74b76096d1815afc0179ce04c01e
86cb3d4 Remove flushed kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/86cb3d4c427543514b703b27d3736767dd561552
90d26f2 Add diagram explaining handshake kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/90d26f2a22d338b74a0ab590725c04baf429bba3
a5bd7e4 Fix candidate accept ordering kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/a5bd7e42539410f4a9e17caec627d208267bd908
6528cdf Add debug logging to peerbroker kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/6528cdff34617d9c284a0c455fae6f8ba99a5fb0
b6003c7 Fix send ordering kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/b6003c78c1b6c2bedb933e0507952dac7d3438d9
7445f12 Lock adding ICE candidate kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/7445f12b54510af27b845bd46995f3a6405ec892
e155e31 Add test for negotiating out of order kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/e155e31bacf1de6ce30561eb3d53ad3c52e34777
65f378c Reduce connection to a single negotiation channel kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/65f378cba4b676066866ad9191babb8d90f99be5
700afe4 Improve test times by pre-installing Terraform kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/700afe4c3d0c629fff98793a7bdf0cc848a02e3e
7eccb81 Lock remote session description being applied kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/7eccb81c6304b36168b3b78979bcbab8e73cc6d5
679e4aa Organize conn kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/679e4aa798ea168a04aa68a9355a2bc68b1d3e53
f20ce9d Revert to multi-channel setup kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/f20ce9ddaac1f433520a116df406eedd11880fca
09d8442 Properly close ICE gatherer kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/09d84424558b3aa5ccf66d39d4dbab8a0f34a05f
1facda9 Improve comments kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/1facda93d0ed82166fbe022621c57bcd1e407507
f58a980 Try removing buffered candidates kylecarbs Jan 30, 2022 https://github.com/coder/coder/pull/95/commits/f58a9808acde2f5e2f8384ce9c4f2714f7d6abcb
b294481 Buffer local and remote messages kylecarbs Jan 31, 2022 https://github.com/coder/coder/pull/95/commits/b29448176981c6b7a2eea72765e4eb81c618d23c
65c58c3 Log dTLS transport state kylecarbs Jan 31, 2022 https://github.com/coder/coder/pull/95/commits/65c58c375ff879329ff98e4686853d24c8b4b2bc
cd775ab Add pion logging kylecarbs Jan 31, 2022 https://github.com/coder/coder/pull/95/commits/cd775abfbd347992ef1e64d12883cbaa939d72c7
Clear filters https://github.com/coder/coder/pull/95/files
Please reload this pagehttps://github.com/coder/coder/pull/95/files
Please reload this pagehttps://github.com/coder/coder/pull/95/files
coder.yaml https://github.com/coder/coder/pull/95/files#diff-6dcdf3df1cd2eecaa1fed0d1347d68e56fe0a949b8689fddcf91ebf255d268ac
userpassword_test.go https://github.com/coder/coder/pull/95/files#diff-8dbab4520fdc4ffcbcd7e5126ca821328fb6a96a389985ad8682ffb3c3361716
migrate_test.go https://github.com/coder/coder/pull/95/files#diff-3d6070e75e455548d92512432118d837c55af68e469f1c2b4f865b410ff45abe
postgres_test.go https://github.com/coder/coder/pull/95/files#diff-67bd2d15f1c2eef6248e9a284e8fcdef1114d6b20762185345e549815c7ef921
go.mod https://github.com/coder/coder/pull/95/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
go.sum https://github.com/coder/coder/pull/95/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63
channel.go https://github.com/coder/coder/pull/95/files#diff-e05b55fdf628140891035293a023189e484854757503a5e383021ea3d4f919ec
conn.go https://github.com/coder/coder/pull/95/files#diff-05d8aea94ee183741805b2e04fa2b86a382e96ad856506b65cf068c674da53a3
conn_test.go https://github.com/coder/coder/pull/95/files#diff-3418f04f2cad2c0020e8aba4dffc42fa5d2f93570a4ddce68e1814d56c0a03f5
dial.go https://github.com/coder/coder/pull/95/files#diff-6ef3d9cf7f3245d172442f19b83dcf9698b1e43c94d1c88b6b552d20da76186b
dial_test.go https://github.com/coder/coder/pull/95/files#diff-d57b2c44f1f1e3bb2fc4b78c76f2a465f37ac7501d2f3e93fb446a484e38dd55
listen.go https://github.com/coder/coder/pull/95/files#diff-24045b036beedbf5dab1968c6db6f016a6a5522c01570c04900b5423b8e9cf31
peerbroker.proto https://github.com/coder/coder/pull/95/files#diff-54d1552d46ebea7fadfea62fdd08bfafcc8bc2c53236ee4a1cd20bce3772153c
provision_test.go https://github.com/coder/coder/pull/95/files#diff-6aaeba79524eb5d5d45e6e286961f19afc9f21d6a791349ec1d08eb8438a8c37
https://github.com/coder/coder/blob/main/CODEOWNERS#L33
.github/workflows/coder.yamlhttps://github.com/coder/coder/pull/95/files#diff-6dcdf3df1cd2eecaa1fed0d1347d68e56fe0a949b8689fddcf91ebf255d268ac
View file https://github.com/coder/coder/blob/cd775abfbd347992ef1e64d12883cbaa939d72c7/.github/workflows/coder.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/95/{{ revealButtonHref }}
https://github.com/coder/coder/pull/95/files#diff-6dcdf3df1cd2eecaa1fed0d1347d68e56fe0a949b8689fddcf91ebf255d268ac
https://github.com/coder/coder/pull/95/files#diff-6dcdf3df1cd2eecaa1fed0d1347d68e56fe0a949b8689fddcf91ebf255d268ac
coderd/userpassword/userpassword_test.gohttps://github.com/coder/coder/pull/95/files#diff-8dbab4520fdc4ffcbcd7e5126ca821328fb6a96a389985ad8682ffb3c3361716
View file https://github.com/coder/coder/blob/cd775abfbd347992ef1e64d12883cbaa939d72c7/coderd/userpassword/userpassword_test.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/95/{{ revealButtonHref }}
https://github.com/coder/coder/pull/95/files#diff-8dbab4520fdc4ffcbcd7e5126ca821328fb6a96a389985ad8682ffb3c3361716
database/migrate_test.gohttps://github.com/coder/coder/pull/95/files#diff-3d6070e75e455548d92512432118d837c55af68e469f1c2b4f865b410ff45abe
View file https://github.com/coder/coder/blob/cd775abfbd347992ef1e64d12883cbaa939d72c7/database/migrate_test.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/95/{{ revealButtonHref }}
https://github.com/coder/coder/pull/95/files#diff-3d6070e75e455548d92512432118d837c55af68e469f1c2b4f865b410ff45abe
https://github.com/coder/coder/pull/95/files#diff-3d6070e75e455548d92512432118d837c55af68e469f1c2b4f865b410ff45abe
database/postgres/postgres_test.gohttps://github.com/coder/coder/pull/95/files#diff-67bd2d15f1c2eef6248e9a284e8fcdef1114d6b20762185345e549815c7ef921
View file https://github.com/coder/coder/blob/cd775abfbd347992ef1e64d12883cbaa939d72c7/database/postgres/postgres_test.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/95/{{ revealButtonHref }}
https://github.com/coder/coder/pull/95/files#diff-67bd2d15f1c2eef6248e9a284e8fcdef1114d6b20762185345e549815c7ef921
https://github.com/coder/coder/pull/95/files#diff-67bd2d15f1c2eef6248e9a284e8fcdef1114d6b20762185345e549815c7ef921
go.modhttps://github.com/coder/coder/pull/95/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
View file https://github.com/coder/coder/blob/cd775abfbd347992ef1e64d12883cbaa939d72c7/go.mod
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/95/{{ revealButtonHref }}
https://github.com/coder/coder/pull/95/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
https://github.com/coder/coder/pull/95/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
https://github.com/coder/coder/pull/95/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
https://github.com/coder/coder/pull/95/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
go.sumhttps://github.com/coder/coder/pull/95/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63
View file https://github.com/coder/coder/blob/cd775abfbd347992ef1e64d12883cbaa939d72c7/go.sum
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/95/{{ revealButtonHref }}
https://github.com/coder/coder/pull/95/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63
https://github.com/coder/coder/pull/95/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63
https://github.com/coder/coder/pull/95/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63
https://github.com/coder/coder/pull/95/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63
peer/channel.gohttps://github.com/coder/coder/pull/95/files#diff-e05b55fdf628140891035293a023189e484854757503a5e383021ea3d4f919ec
View file https://github.com/coder/coder/blob/cd775abfbd347992ef1e64d12883cbaa939d72c7/peer/channel.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/95/{{ revealButtonHref }}
https://github.com/coder/coder/pull/95/files#diff-e05b55fdf628140891035293a023189e484854757503a5e383021ea3d4f919ec
https://github.com/coder/coder/pull/95/files#diff-e05b55fdf628140891035293a023189e484854757503a5e383021ea3d4f919ec
Please reload this pagehttps://github.com/coder/coder/pull/95/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.