| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:318cebce-3987-04a3-d7d2-aaca01aafd41 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CF92:17FB7:1725E0A:1D4C1C1:6B017401 |
| html-safe-nonce | 2952ea4c9ff936de7b260c4c4e0a80cc6cfcb2b2643e2310ee114cd9cf2a9c1d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjkyOjE3RkI3OjE3MjVFMEE6MUQ0QzFDMTo2QjAxNzQwMSIsInZpc2l0b3JfaWQiOiIxMzQzOTI4ODAzODE4MzA0NTEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1bbe810d6b9024edccb7b62ec2a1e8e4a446515fa4ca55afaf118055ecd78715 |
| hovercard-subject-tag | pull_request:835256934 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/coder/coder/pull/95/files |
| twitter:image | https://avatars.githubusercontent.com/u/7122116?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/7122116?s=400&v=4 |
| og:image:alt | We were depending on the close mutex to properly
report connection state. This ensures the RTC
connection is properly closed before returning. |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/coder/coder/pull/95/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F95%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F95%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/95/files |
| Reload | https://github.com/coder/coder/pull/95/files |
| Reload | https://github.com/coder/coder/pull/95/files |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose |
| kylecarbs | https://github.com/kylecarbs |
| main | https://github.com/coder/coder/tree/main |
| peerlog | https://github.com/coder/coder/tree/peerlog |
|
Conversation
6
| https://github.com/coder/coder/pull/95 |
|
Commits
23
| https://github.com/coder/coder/pull/95/commits |
|
Checks
0
| https://github.com/coder/coder/pull/95/checks |
|
Files changed
| https://github.com/coder/coder/pull/95/files |
| Please reload this page | https://github.com/coder/coder/pull/95/files |
|
refactor: Improve handshake resiliency of peer
| https://github.com/coder/coder/pull/95/files#top |
|
Show all changes
23 commits
| https://github.com/coder/coder/pull/95/files |
|
bf2f59f
fix: Synchronize peer logging with a channel
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/bf2f59fdae7747598dfbbb745abf0da04cf455c5 |
|
a8fe659
Merge branch 'main' into peerlog
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/a8fe659e6f0b5d51f62b3473e82712c1de5ec149 |
|
aad88e0
Disable pion logging
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/aad88e057bb17a1518f68646ca1780c6c3e20b33 |
|
59751f4
Remove buffer
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/59751f4ee83c5760f2528d2db99086956ffa3a00 |
|
107eb96
Try ICE servers
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/107eb968a7de74b76096d1815afc0179ce04c01e |
|
86cb3d4
Remove flushed
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/86cb3d4c427543514b703b27d3736767dd561552 |
|
90d26f2
Add diagram explaining handshake
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/90d26f2a22d338b74a0ab590725c04baf429bba3 |
|
a5bd7e4
Fix candidate accept ordering
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/a5bd7e42539410f4a9e17caec627d208267bd908 |
|
6528cdf
Add debug logging to peerbroker
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/6528cdff34617d9c284a0c455fae6f8ba99a5fb0 |
|
b6003c7
Fix send ordering
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/b6003c78c1b6c2bedb933e0507952dac7d3438d9 |
|
7445f12
Lock adding ICE candidate
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/7445f12b54510af27b845bd46995f3a6405ec892 |
|
e155e31
Add test for negotiating out of order
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/e155e31bacf1de6ce30561eb3d53ad3c52e34777 |
|
65f378c
Reduce connection to a single negotiation channel
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/65f378cba4b676066866ad9191babb8d90f99be5 |
|
700afe4
Improve test times by pre-installing Terraform
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/700afe4c3d0c629fff98793a7bdf0cc848a02e3e |
|
7eccb81
Lock remote session description being applied
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/7eccb81c6304b36168b3b78979bcbab8e73cc6d5 |
|
679e4aa
Organize conn
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/679e4aa798ea168a04aa68a9355a2bc68b1d3e53 |
|
f20ce9d
Revert to multi-channel setup
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/f20ce9ddaac1f433520a116df406eedd11880fca |
|
09d8442
Properly close ICE gatherer
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/09d84424558b3aa5ccf66d39d4dbab8a0f34a05f |
|
1facda9
Improve comments
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/1facda93d0ed82166fbe022621c57bcd1e407507 |
|
f58a980
Try removing buffered candidates
kylecarbs Jan 30, 2022
| https://github.com/coder/coder/pull/95/commits/f58a9808acde2f5e2f8384ce9c4f2714f7d6abcb |
|
b294481
Buffer local and remote messages
kylecarbs Jan 31, 2022
| https://github.com/coder/coder/pull/95/commits/b29448176981c6b7a2eea72765e4eb81c618d23c |
|
65c58c3
Log dTLS transport state
kylecarbs Jan 31, 2022
| https://github.com/coder/coder/pull/95/commits/65c58c375ff879329ff98e4686853d24c8b4b2bc |
|
cd775ab
Add pion logging
kylecarbs Jan 31, 2022
| https://github.com/coder/coder/pull/95/commits/cd775abfbd347992ef1e64d12883cbaa939d72c7 |
|
Clear filters
| https://github.com/coder/coder/pull/95/files |
| Please reload this page | https://github.com/coder/coder/pull/95/files |
| Please reload this page | https://github.com/coder/coder/pull/95/files |
|
coder.yaml
| https://github.com/coder/coder/pull/95/files#diff-6dcdf3df1cd2eecaa1fed0d1347d68e56fe0a949b8689fddcf91ebf255d268ac |
|
userpassword_test.go
| https://github.com/coder/coder/pull/95/files#diff-8dbab4520fdc4ffcbcd7e5126ca821328fb6a96a389985ad8682ffb3c3361716 |
|
migrate_test.go
| https://github.com/coder/coder/pull/95/files#diff-3d6070e75e455548d92512432118d837c55af68e469f1c2b4f865b410ff45abe |
|
postgres_test.go
| https://github.com/coder/coder/pull/95/files#diff-67bd2d15f1c2eef6248e9a284e8fcdef1114d6b20762185345e549815c7ef921 |
|
go.mod
| https://github.com/coder/coder/pull/95/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6 |
|
go.sum
| https://github.com/coder/coder/pull/95/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63 |
|
channel.go
| https://github.com/coder/coder/pull/95/files#diff-e05b55fdf628140891035293a023189e484854757503a5e383021ea3d4f919ec |
|
conn.go
| https://github.com/coder/coder/pull/95/files#diff-05d8aea94ee183741805b2e04fa2b86a382e96ad856506b65cf068c674da53a3 |
|
conn_test.go
| https://github.com/coder/coder/pull/95/files#diff-3418f04f2cad2c0020e8aba4dffc42fa5d2f93570a4ddce68e1814d56c0a03f5 |
|
dial.go
| https://github.com/coder/coder/pull/95/files#diff-6ef3d9cf7f3245d172442f19b83dcf9698b1e43c94d1c88b6b552d20da76186b |
|
dial_test.go
| https://github.com/coder/coder/pull/95/files#diff-d57b2c44f1f1e3bb2fc4b78c76f2a465f37ac7501d2f3e93fb446a484e38dd55 |
|
listen.go
| https://github.com/coder/coder/pull/95/files#diff-24045b036beedbf5dab1968c6db6f016a6a5522c01570c04900b5423b8e9cf31 |
|
peerbroker.proto
| https://github.com/coder/coder/pull/95/files#diff-54d1552d46ebea7fadfea62fdd08bfafcc8bc2c53236ee4a1cd20bce3772153c |
|
provision_test.go
| https://github.com/coder/coder/pull/95/files#diff-6aaeba79524eb5d5d45e6e286961f19afc9f21d6a791349ec1d08eb8438a8c37 |
|
| https://github.com/coder/coder/blob/main/CODEOWNERS#L33 |
| .github/workflows/coder.yaml | https://github.com/coder/coder/pull/95/files#diff-6dcdf3df1cd2eecaa1fed0d1347d68e56fe0a949b8689fddcf91ebf255d268ac |
|
View file
| https://github.com/coder/coder/blob/cd775abfbd347992ef1e64d12883cbaa939d72c7/.github/workflows/coder.yaml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/95/{{ revealButtonHref }} |
|
| https://github.com/coder/coder/pull/95/files#diff-6dcdf3df1cd2eecaa1fed0d1347d68e56fe0a949b8689fddcf91ebf255d268ac |
|
| https://github.com/coder/coder/pull/95/files#diff-6dcdf3df1cd2eecaa1fed0d1347d68e56fe0a949b8689fddcf91ebf255d268ac |
| coderd/userpassword/userpassword_test.go | https://github.com/coder/coder/pull/95/files#diff-8dbab4520fdc4ffcbcd7e5126ca821328fb6a96a389985ad8682ffb3c3361716 |
|
View file
| https://github.com/coder/coder/blob/cd775abfbd347992ef1e64d12883cbaa939d72c7/coderd/userpassword/userpassword_test.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/95/{{ revealButtonHref }} |
|
| https://github.com/coder/coder/pull/95/files#diff-8dbab4520fdc4ffcbcd7e5126ca821328fb6a96a389985ad8682ffb3c3361716 |
| database/migrate_test.go | https://github.com/coder/coder/pull/95/files#diff-3d6070e75e455548d92512432118d837c55af68e469f1c2b4f865b410ff45abe |
|
View file
| https://github.com/coder/coder/blob/cd775abfbd347992ef1e64d12883cbaa939d72c7/database/migrate_test.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/95/{{ revealButtonHref }} |
|
| https://github.com/coder/coder/pull/95/files#diff-3d6070e75e455548d92512432118d837c55af68e469f1c2b4f865b410ff45abe |
|
| https://github.com/coder/coder/pull/95/files#diff-3d6070e75e455548d92512432118d837c55af68e469f1c2b4f865b410ff45abe |
| database/postgres/postgres_test.go | https://github.com/coder/coder/pull/95/files#diff-67bd2d15f1c2eef6248e9a284e8fcdef1114d6b20762185345e549815c7ef921 |
|
View file
| https://github.com/coder/coder/blob/cd775abfbd347992ef1e64d12883cbaa939d72c7/database/postgres/postgres_test.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/95/{{ revealButtonHref }} |
|
| https://github.com/coder/coder/pull/95/files#diff-67bd2d15f1c2eef6248e9a284e8fcdef1114d6b20762185345e549815c7ef921 |
|
| https://github.com/coder/coder/pull/95/files#diff-67bd2d15f1c2eef6248e9a284e8fcdef1114d6b20762185345e549815c7ef921 |
| go.mod | https://github.com/coder/coder/pull/95/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6 |
|
View file
| https://github.com/coder/coder/blob/cd775abfbd347992ef1e64d12883cbaa939d72c7/go.mod |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/95/{{ revealButtonHref }} |
|
| https://github.com/coder/coder/pull/95/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6 |
|
| https://github.com/coder/coder/pull/95/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6 |
|
| https://github.com/coder/coder/pull/95/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6 |
|
| https://github.com/coder/coder/pull/95/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6 |
| go.sum | https://github.com/coder/coder/pull/95/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63 |
|
View file
| https://github.com/coder/coder/blob/cd775abfbd347992ef1e64d12883cbaa939d72c7/go.sum |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/95/{{ revealButtonHref }} |
|
| https://github.com/coder/coder/pull/95/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63 |
|
| https://github.com/coder/coder/pull/95/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63 |
|
| https://github.com/coder/coder/pull/95/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63 |
|
| https://github.com/coder/coder/pull/95/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63 |
| peer/channel.go | https://github.com/coder/coder/pull/95/files#diff-e05b55fdf628140891035293a023189e484854757503a5e383021ea3d4f919ec |
|
View file
| https://github.com/coder/coder/blob/cd775abfbd347992ef1e64d12883cbaa939d72c7/peer/channel.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/95/{{ revealButtonHref }} |
|
| https://github.com/coder/coder/pull/95/files#diff-e05b55fdf628140891035293a023189e484854757503a5e383021ea3d4f919ec |
|
| https://github.com/coder/coder/pull/95/files#diff-e05b55fdf628140891035293a023189e484854757503a5e383021ea3d4f919ec |
| Please reload this page | https://github.com/coder/coder/pull/95/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |