| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c0664585-8f31-61fc-66a4-6e1272df2c92 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D2D6:3A4875:28B355B:3645C8A:6B01B5E5 |
| html-safe-nonce | 6e1f091e96c53b2258f9e8cf9ab41a7f5e7385b8c99dc6f15b30d60d9faef518 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkQ2OjNBNDg3NToyOEIzNTVCOjM2NDVDOEE6NkIwMUI1RTUiLCJ2aXNpdG9yX2lkIjoiNDg4MjgwNTI0MjM3MjE0MjU2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6d3242347536ad404f1ffdfd9ae682b95a0e73b55855b0b70c826dedad593956 |
| hovercard-subject-tag | pull_request:1420762566 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/coder/coder/pull/8317/files |
| twitter:image | https://avatars.githubusercontent.com/u/4949514?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4949514?s=400&v=4 |
| og:image:alt | This attempts to address the test flakes reported in #4942 -- sadly, the runner logs have expired and are no longer available so I've done a best-effort fix here.
(breaking?) Protects Logger a... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/coder/coder/pull/8317/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F8317%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F8317%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/8317/files |
| Reload | https://github.com/coder/coder/pull/8317/files |
| Reload | https://github.com/coder/coder/pull/8317/files |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose |
| johnstcn | https://github.com/johnstcn |
| main | https://github.com/coder/coder/tree/main |
| cj/scaletest-createworkspaces-flake | https://github.com/coder/coder/tree/cj/scaletest-createworkspaces-flake |
|
Conversation
16
| https://github.com/coder/coder/pull/8317 |
|
Commits
16
| https://github.com/coder/coder/pull/8317/commits |
|
Checks
0
| https://github.com/coder/coder/pull/8317/checks |
|
Files changed
| https://github.com/coder/coder/pull/8317/files |
| Please reload this page | https://github.com/coder/coder/pull/8317/files |
|
fix(cli)!: protect client Logger and refactor cli scaletest tests
| https://github.com/coder/coder/pull/8317/files#top |
|
Show all changes
16 commits
| https://github.com/coder/coder/pull/8317/files |
|
8f07b9b
fix data race in scaletest_test
johnstcn Jul 4, 2023
| https://github.com/coder/coder/pull/8317/commits/8f07b9b541690fa9f64044bc46b4f37cbda797e3 |
|
b0b55f9
add TODO
johnstcn Jul 4, 2023
| https://github.com/coder/coder/pull/8317/commits/b0b55f925155bd5d52390ed6a72be2d451ec6f14 |
|
f863a83
fillet cli scaletest createworkspaces test, bulk up tests in scaletes…
johnstcn Jul 5, 2023
| https://github.com/coder/coder/pull/8317/commits/f863a8336b0678f71aa032777a7dc278deaefeaf |
|
b3d1c6e
make fmt
johnstcn Jul 5, 2023
| https://github.com/coder/coder/pull/8317/commits/b3d1c6e8869687db0787ac68194d90ba5ef1f52e |
|
9fb7479
appease the linter
johnstcn Jul 5, 2023
| https://github.com/coder/coder/pull/8317/commits/9fb747955f85d49149d0cf2e2618cf6c3fcebb69 |
|
a7f7e10
wait for template version before creating template
johnstcn Jul 5, 2023
| https://github.com/coder/coder/pull/8317/commits/a7f7e1088cb55e3ec042744d4eb82ea187cb4b66 |
|
b511f16
unskip scaletest/workspacebuild tests
johnstcn Jul 5, 2023
| https://github.com/coder/coder/pull/8317/commits/b511f16bc48e3db2db200c4349b04d9b36369956 |
|
f45f938
add IgnoreErrors option to agent loggers
johnstcn Jul 5, 2023
| https://github.com/coder/coder/pull/8317/commits/f45f938555a2bc1d90aa9e05f218af633ef104ac |
|
86c553c
coderd: TestDeploymentStats: make test slightly less time-sensitive
johnstcn Jul 5, 2023
| https://github.com/coder/coder/pull/8317/commits/86c553c619aba01c9a913510ee1164a7c16cb830 |
|
d38b6c8
fix potential race in test cleanup
johnstcn Jul 5, 2023
| https://github.com/coder/coder/pull/8317/commits/d38b6c8693534ea22cd9c98d25d39343214491a6 |
|
543a8f1
address comments re: RaceEnabled
johnstcn Jul 5, 2023
| https://github.com/coder/coder/pull/8317/commits/543a8f16d1b88ebf9f09597d9b0b43282ae3f413 |
|
a51dba7
fixup! address comments re: RaceEnabled
johnstcn Jul 5, 2023
| https://github.com/coder/coder/pull/8317/commits/a51dba73149f8f2b0d2a3282ae5f2b3bf5bfb81d |
|
aaf3829
Merge remote-tracking branch 'origin/main' into cj/scaletest-createwo…
johnstcn Jul 5, 2023
| https://github.com/coder/coder/pull/8317/commits/aaf3829f9e25ef405d4cece2bd82c0ab9c170c05 |
|
2bcd712
client: make it clear what fields mu protects
johnstcn Jul 5, 2023
| https://github.com/coder/coder/pull/8317/commits/2bcd7128be4e67fcb82a56de7a3cb4a076f93573 |
|
61dc5f9
make cleanup nicer
johnstcn Jul 5, 2023
| https://github.com/coder/coder/pull/8317/commits/61dc5f9e957b2b55d9c3369355510066d6ee132c |
|
efeac86
Merge remote-tracking branch 'origin/main' into cj/scaletest-createwo…
johnstcn Jul 6, 2023
| https://github.com/coder/coder/pull/8317/commits/efeac8688c2ea54872c087238766fd2c2b86f36c |
|
Clear filters
| https://github.com/coder/coder/pull/8317/files |
| Please reload this page | https://github.com/coder/coder/pull/8317/files |
| Please reload this page | https://github.com/coder/coder/pull/8317/files |
|
agent.go
| https://github.com/coder/coder/pull/8317/files#diff-f79a293a9987904ac41f4ad561b263b381e7ee002d2b46b5fed0a2b0e349d589 |
|
root.go
| https://github.com/coder/coder/pull/8317/files#diff-f95036fc6ff63eb5fcf251353f47b191fa8a2d927d37eacbb51e47e74e5f71f4 |
|
scaletest_test.go
| https://github.com/coder/coder/pull/8317/files#diff-c018665f988df1be52d552cb7b1c5a742c9163735c04aded3a93d123a7589ff1 |
|
ssh.go
| https://github.com/coder/coder/pull/8317/files#diff-e288cc849ca774d47294f4f6c71c4ec171f6e0b15491e7220a0144dbfc1a43bc |
|
ssh_test.go
| https://github.com/coder/coder/pull/8317/files#diff-2caee0e73c6bfeed4632d116a45feccdbdb7a4dfd21a7b7aad510cf087873c9e |
|
deployment_test.go
| https://github.com/coder/coder/pull/8317/files#diff-42f3059660c07ba7a0dfd0fde8c83b6e56b730654c57a4c063b36ec59a894e62 |
|
agentsdk.go
| https://github.com/coder/coder/pull/8317/files#diff-4fcb60bf1885858aa2ee3af38f90a99bd81018144ca884f6e8477e6ba408c611 |
|
client.go
| https://github.com/coder/coder/pull/8317/files#diff-64a48277adf9f0d069a419bbb8ecbe9ba8e38cc43b95fa21d16a750cf194cd88 |
|
client_internal_test.go
| https://github.com/coder/coder/pull/8317/files#diff-6749055bc31510f5fe59cb5f8c11745397bf6b468a6d883d58cfa96a8f163e8a |
|
appearance_test.go
| https://github.com/coder/coder/pull/8317/files#diff-9f9be03147dcec29da2fdb550fdb5752c04642d29828541c66f3f58a14e3f553 |
|
run.go
| https://github.com/coder/coder/pull/8317/files#diff-4cd5f2a12b9372ba14a1f99a0356b273b064b3c4c327cf054896ea6698d6fff4 |
|
run.go
| https://github.com/coder/coder/pull/8317/files#diff-f905dba685aa86cf93813e0e4f2e181d1b8f5cd7b415988f61a169a9c1a69507 |
|
run_test.go
| https://github.com/coder/coder/pull/8317/files#diff-3385f865f44e9b8dfd382ea1136d3edad81765c491eb66f481247c571b9bcb90 |
|
run.go
| https://github.com/coder/coder/pull/8317/files#diff-c00c52e3921de6c79477a1e16c73a7ac300ac688e04af8462dca7f4c3083e26e |
|
run.go
| https://github.com/coder/coder/pull/8317/files#diff-adcfa4b8d4ca85b71116c1dc87cbb6013247498cc4ed92ad41b2968b5f49d8a2 |
|
run_test.go
| https://github.com/coder/coder/pull/8317/files#diff-8f8db92be387cfddc547c988406572a188d12430772238c8d4410a8f84e23560 |
|
run.go
| https://github.com/coder/coder/pull/8317/files#diff-d07b0b9975412333d2648255be91b633b4c73837798ba635d9c7d529e888fcfc |
|
race.go
| https://github.com/coder/coder/pull/8317/files#diff-42dc17e3a3e48cb59c0e0555082fd4394df42531424555b7aad55fa02144b5a5 |
|
race_off.go
| https://github.com/coder/coder/pull/8317/files#diff-802b840c77776f12308077ed9c3733a7d0dccaf851e57a0d4362e72ed0296a58 |
|
race_on.go
| https://github.com/coder/coder/pull/8317/files#diff-4fa948d1f5ebe8b87f71bb8fc34bde485ae7f8b1c83bc2136664e6b57351e869 |
| cli/agent.go | https://github.com/coder/coder/pull/8317/files#diff-f79a293a9987904ac41f4ad561b263b381e7ee002d2b46b5fed0a2b0e349d589 |
|
View file
| https://github.com/coder/coder/blob/efeac8688c2ea54872c087238766fd2c2b86f36c/cli/agent.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/8317/{{ revealButtonHref }} |
|
| https://github.com/coder/coder/pull/8317/files#diff-f79a293a9987904ac41f4ad561b263b381e7ee002d2b46b5fed0a2b0e349d589 |
|
| https://github.com/coder/coder/pull/8317/files#diff-f79a293a9987904ac41f4ad561b263b381e7ee002d2b46b5fed0a2b0e349d589 |
| cli/root.go | https://github.com/coder/coder/pull/8317/files#diff-f95036fc6ff63eb5fcf251353f47b191fa8a2d927d37eacbb51e47e74e5f71f4 |
|
View file
| https://github.com/coder/coder/blob/efeac8688c2ea54872c087238766fd2c2b86f36c/cli/root.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/8317/{{ revealButtonHref }} |
|
| https://github.com/coder/coder/pull/8317/files#diff-f95036fc6ff63eb5fcf251353f47b191fa8a2d927d37eacbb51e47e74e5f71f4 |
|
| https://github.com/coder/coder/pull/8317/files#diff-f95036fc6ff63eb5fcf251353f47b191fa8a2d927d37eacbb51e47e74e5f71f4 |
| cli/scaletest_test.go | https://github.com/coder/coder/pull/8317/files#diff-c018665f988df1be52d552cb7b1c5a742c9163735c04aded3a93d123a7589ff1 |
|
View file
| https://github.com/coder/coder/blob/efeac8688c2ea54872c087238766fd2c2b86f36c/cli/scaletest_test.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/8317/{{ revealButtonHref }} |
|
| https://github.com/coder/coder/pull/8317/files#diff-c018665f988df1be52d552cb7b1c5a742c9163735c04aded3a93d123a7589ff1 |
| johnstcn | https://github.com/johnstcn |
| Jul 5, 2023 | https://github.com/coder/coder/pull/8317/files#r1252842835 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/8317/files |
|
| https://github.com/coder/coder/pull/8317/files#diff-c018665f988df1be52d552cb7b1c5a742c9163735c04aded3a93d123a7589ff1 |
| cli/ssh.go | https://github.com/coder/coder/pull/8317/files#diff-e288cc849ca774d47294f4f6c71c4ec171f6e0b15491e7220a0144dbfc1a43bc |
|
View file
| https://github.com/coder/coder/blob/efeac8688c2ea54872c087238766fd2c2b86f36c/cli/ssh.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/8317/{{ revealButtonHref }} |
|
| https://github.com/coder/coder/pull/8317/files#diff-e288cc849ca774d47294f4f6c71c4ec171f6e0b15491e7220a0144dbfc1a43bc |
|
| https://github.com/coder/coder/pull/8317/files#diff-e288cc849ca774d47294f4f6c71c4ec171f6e0b15491e7220a0144dbfc1a43bc |
| cli/ssh_test.go | https://github.com/coder/coder/pull/8317/files#diff-2caee0e73c6bfeed4632d116a45feccdbdb7a4dfd21a7b7aad510cf087873c9e |
|
View file
| https://github.com/coder/coder/blob/efeac8688c2ea54872c087238766fd2c2b86f36c/cli/ssh_test.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/8317/{{ revealButtonHref }} |
|
| https://github.com/coder/coder/pull/8317/files#diff-2caee0e73c6bfeed4632d116a45feccdbdb7a4dfd21a7b7aad510cf087873c9e |
|
| https://github.com/coder/coder/pull/8317/files#diff-2caee0e73c6bfeed4632d116a45feccdbdb7a4dfd21a7b7aad510cf087873c9e |
| coderd/deployment_test.go | https://github.com/coder/coder/pull/8317/files#diff-42f3059660c07ba7a0dfd0fde8c83b6e56b730654c57a4c063b36ec59a894e62 |
|
View file
| https://github.com/coder/coder/blob/efeac8688c2ea54872c087238766fd2c2b86f36c/coderd/deployment_test.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/8317/{{ revealButtonHref }} |
|
| https://github.com/coder/coder/pull/8317/files#diff-42f3059660c07ba7a0dfd0fde8c83b6e56b730654c57a4c063b36ec59a894e62 |
|
| https://github.com/coder/coder/pull/8317/files#diff-42f3059660c07ba7a0dfd0fde8c83b6e56b730654c57a4c063b36ec59a894e62 |
|
| https://github.com/coder/coder/pull/8317/files#diff-42f3059660c07ba7a0dfd0fde8c83b6e56b730654c57a4c063b36ec59a894e62 |
| codersdk/agentsdk/agentsdk.go | https://github.com/coder/coder/pull/8317/files#diff-4fcb60bf1885858aa2ee3af38f90a99bd81018144ca884f6e8477e6ba408c611 |
|
View file
| https://github.com/coder/coder/blob/efeac8688c2ea54872c087238766fd2c2b86f36c/codersdk/agentsdk/agentsdk.go |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/8317/{{ revealButtonHref }} |
|
| https://github.com/coder/coder/pull/8317/files#diff-4fcb60bf1885858aa2ee3af38f90a99bd81018144ca884f6e8477e6ba408c611 |
|
| https://github.com/coder/coder/pull/8317/files#diff-4fcb60bf1885858aa2ee3af38f90a99bd81018144ca884f6e8477e6ba408c611 |
|
| https://github.com/coder/coder/pull/8317/files#diff-4fcb60bf1885858aa2ee3af38f90a99bd81018144ca884f6e8477e6ba408c611 |
| Please reload this page | https://github.com/coder/coder/pull/8317/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |