René's URL Explorer Experiment


Title: fix(cli)!: protect client Logger and refactor cli scaletest tests by johnstcn · Pull Request #8317 · coder/coder · GitHub

Open Graph Title: fix(cli)!: protect client Logger and refactor cli scaletest tests by johnstcn · Pull Request #8317 · coder/coder

X Title: fix(cli)!: protect client Logger and refactor cli scaletest tests by johnstcn · Pull Request #8317 · coder/coder

Description: Secure environments for developers and their agents - fix(cli)!: protect client Logger and refactor cli scaletest tests by johnstcn · Pull Request #8317 · coder/coder

Open Graph Description: This attempts to address the test flakes reported in #4942 -- sadly, the runner logs have expired and are no longer available so I've done a best-effort fix here. (breaking?) Protects Logger a...

X Description: This attempts to address the test flakes reported in #4942 -- sadly, the runner logs have expired and are no longer available so I've done a best-effort fix here. (breaking?) Protects Logg...

Opengraph URL: https://github.com/coder/coder/pull/8317

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:b6b19719-4328-1334-530d-0fef78290692
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB368:1D20B7:230A753:2C6DE08:6B01B5FF
html-safe-nonce5312c8888601d52583243407d325c54de44a18dcec1139e7d60a4f3d6380c83e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzY4OjFEMjBCNzoyMzBBNzUzOjJDNkRFMDg6NkIwMUI1RkYiLCJ2aXNpdG9yX2lkIjoiMzMxMjA0ODExOTI1MTg0MjU1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac230ed44e4324e793d1a01f4c2979b3a7ec073143fa4b6222a673fb09ea976ecc
hovercard-subject-tagpull_request:1420762566
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/coder/pull/8317/commits
twitter:imagehttps://opengraph.githubassets.com/be39301c3e59eb564edb63e0b49d52f58f862d83596f5b934e193e1b9f62668c/coder/coder/pull/8317
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/be39301c3e59eb564edb63e0b49d52f58f862d83596f5b934e193e1b9f62668c/coder/coder/pull/8317
og:image:altThis attempts to address the test flakes reported in #4942 -- sadly, the runner logs have expired and are no longer available so I've done a best-effort fix here. (breaking?) Protects Logger a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejohnstcn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/8317/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F8317%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F8317%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/8317/commits
Reloadhttps://github.com/coder/coder/pull/8317/commits
Reloadhttps://github.com/coder/coder/pull/8317/commits
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
johnstcnhttps://github.com/johnstcn
mainhttps://github.com/coder/coder/tree/main
cj/scaletest-createworkspaces-flakehttps://github.com/coder/coder/tree/cj/scaletest-createworkspaces-flake
Conversationhttps://github.com/coder/coder/pull/8317
Commits16 (16)https://github.com/coder/coder/pull/8317/commits
Checkshttps://github.com/coder/coder/pull/8317/checks
Files changedhttps://github.com/coder/coder/pull/8317/files
fix(cli)!: protect client Logger and refactor cli scaletest testshttps://github.com/coder/coder/pull/8317/commits#top
johnstcnhttps://github.com/johnstcn
mainhttps://github.com/coder/coder/tree/main
cj/scaletest-createworkspaces-flakehttps://github.com/coder/coder/tree/cj/scaletest-createworkspaces-flake
fix data race in scaletest_testhttps://github.com/coder/coder/pull/8317/commits/8f07b9b541690fa9f64044bc46b4f37cbda797e3
https://github.com/johnstcn
johnstcnhttps://github.com/coder/coder/commits?author=johnstcn
8f07b9bhttps://github.com/coder/coder/pull/8317/commits/8f07b9b541690fa9f64044bc46b4f37cbda797e3
https://github.com/coder/coder/tree/8f07b9b541690fa9f64044bc46b4f37cbda797e3
add TODOhttps://github.com/coder/coder/pull/8317/commits/b0b55f925155bd5d52390ed6a72be2d451ec6f14
https://github.com/johnstcn
johnstcnhttps://github.com/coder/coder/commits?author=johnstcn
b0b55f9https://github.com/coder/coder/pull/8317/commits/b0b55f925155bd5d52390ed6a72be2d451ec6f14
https://github.com/coder/coder/tree/b0b55f925155bd5d52390ed6a72be2d451ec6f14
fillet cli scaletest createworkspaces test, bulk up tests in scaletest insteadhttps://github.com/coder/coder/pull/8317/commits/f863a8336b0678f71aa032777a7dc278deaefeaf
https://github.com/johnstcn
johnstcnhttps://github.com/coder/coder/commits?author=johnstcn
f863a83https://github.com/coder/coder/pull/8317/commits/f863a8336b0678f71aa032777a7dc278deaefeaf
https://github.com/coder/coder/tree/f863a8336b0678f71aa032777a7dc278deaefeaf
make fmthttps://github.com/coder/coder/pull/8317/commits/b3d1c6e8869687db0787ac68194d90ba5ef1f52e
https://github.com/johnstcn
johnstcnhttps://github.com/coder/coder/commits?author=johnstcn
b3d1c6ehttps://github.com/coder/coder/pull/8317/commits/b3d1c6e8869687db0787ac68194d90ba5ef1f52e
https://github.com/coder/coder/tree/b3d1c6e8869687db0787ac68194d90ba5ef1f52e
appease the linterhttps://github.com/coder/coder/pull/8317/commits/9fb747955f85d49149d0cf2e2618cf6c3fcebb69
https://github.com/johnstcn
johnstcnhttps://github.com/coder/coder/commits?author=johnstcn
9fb7479https://github.com/coder/coder/pull/8317/commits/9fb747955f85d49149d0cf2e2618cf6c3fcebb69
https://github.com/coder/coder/tree/9fb747955f85d49149d0cf2e2618cf6c3fcebb69
wait for template version before creating templatehttps://github.com/coder/coder/pull/8317/commits/a7f7e1088cb55e3ec042744d4eb82ea187cb4b66
https://github.com/johnstcn
johnstcnhttps://github.com/coder/coder/commits?author=johnstcn
a7f7e10https://github.com/coder/coder/pull/8317/commits/a7f7e1088cb55e3ec042744d4eb82ea187cb4b66
https://github.com/coder/coder/tree/a7f7e1088cb55e3ec042744d4eb82ea187cb4b66
unskip scaletest/workspacebuild testshttps://github.com/coder/coder/pull/8317/commits/b511f16bc48e3db2db200c4349b04d9b36369956
https://github.com/johnstcn
johnstcnhttps://github.com/coder/coder/commits?author=johnstcn
b511f16https://github.com/coder/coder/pull/8317/commits/b511f16bc48e3db2db200c4349b04d9b36369956
https://github.com/coder/coder/tree/b511f16bc48e3db2db200c4349b04d9b36369956
add IgnoreErrors option to agent loggershttps://github.com/coder/coder/pull/8317/commits/f45f938555a2bc1d90aa9e05f218af633ef104ac
https://github.com/johnstcn
johnstcnhttps://github.com/coder/coder/commits?author=johnstcn
f45f938https://github.com/coder/coder/pull/8317/commits/f45f938555a2bc1d90aa9e05f218af633ef104ac
https://github.com/coder/coder/tree/f45f938555a2bc1d90aa9e05f218af633ef104ac
coderd: TestDeploymentStats: make test slightly less time-sensitivehttps://github.com/coder/coder/pull/8317/commits/86c553c619aba01c9a913510ee1164a7c16cb830
https://github.com/johnstcn
johnstcnhttps://github.com/coder/coder/commits?author=johnstcn
86c553chttps://github.com/coder/coder/pull/8317/commits/86c553c619aba01c9a913510ee1164a7c16cb830
https://github.com/coder/coder/tree/86c553c619aba01c9a913510ee1164a7c16cb830
fix potential race in test cleanuphttps://github.com/coder/coder/pull/8317/commits/d38b6c8693534ea22cd9c98d25d39343214491a6
https://github.com/johnstcn
johnstcnhttps://github.com/coder/coder/commits?author=johnstcn
d38b6c8https://github.com/coder/coder/pull/8317/commits/d38b6c8693534ea22cd9c98d25d39343214491a6
https://github.com/coder/coder/tree/d38b6c8693534ea22cd9c98d25d39343214491a6
address comments re: RaceEnabledhttps://github.com/coder/coder/pull/8317/commits/543a8f16d1b88ebf9f09597d9b0b43282ae3f413
https://github.com/johnstcn
johnstcnhttps://github.com/coder/coder/commits?author=johnstcn
543a8f1https://github.com/coder/coder/pull/8317/commits/543a8f16d1b88ebf9f09597d9b0b43282ae3f413
https://github.com/coder/coder/tree/543a8f16d1b88ebf9f09597d9b0b43282ae3f413
fixup! address comments re: RaceEnabledhttps://github.com/coder/coder/pull/8317/commits/a51dba73149f8f2b0d2a3282ae5f2b3bf5bfb81d
https://github.com/johnstcn
johnstcnhttps://github.com/coder/coder/commits?author=johnstcn
a51dba7https://github.com/coder/coder/pull/8317/commits/a51dba73149f8f2b0d2a3282ae5f2b3bf5bfb81d
https://github.com/coder/coder/tree/a51dba73149f8f2b0d2a3282ae5f2b3bf5bfb81d
Merge remote-tracking branch 'origin/main' into cj/scaletest-createworkspaces-flakehttps://github.com/coder/coder/pull/8317/commits/aaf3829f9e25ef405d4cece2bd82c0ab9c170c05
https://github.com/johnstcn
johnstcnhttps://github.com/coder/coder/commits?author=johnstcn
aaf3829https://github.com/coder/coder/pull/8317/commits/aaf3829f9e25ef405d4cece2bd82c0ab9c170c05
https://github.com/coder/coder/tree/aaf3829f9e25ef405d4cece2bd82c0ab9c170c05
client: make it clear what fields mu protectshttps://github.com/coder/coder/pull/8317/commits/2bcd7128be4e67fcb82a56de7a3cb4a076f93573
https://github.com/johnstcn
johnstcnhttps://github.com/coder/coder/commits?author=johnstcn
2bcd712https://github.com/coder/coder/pull/8317/commits/2bcd7128be4e67fcb82a56de7a3cb4a076f93573
https://github.com/coder/coder/tree/2bcd7128be4e67fcb82a56de7a3cb4a076f93573
make cleanup nicerhttps://github.com/coder/coder/pull/8317/commits/61dc5f9e957b2b55d9c3369355510066d6ee132c
https://github.com/johnstcn
johnstcnhttps://github.com/coder/coder/commits?author=johnstcn
61dc5f9https://github.com/coder/coder/pull/8317/commits/61dc5f9e957b2b55d9c3369355510066d6ee132c
https://github.com/coder/coder/tree/61dc5f9e957b2b55d9c3369355510066d6ee132c
Merge remote-tracking branch 'origin/main' into cj/scaletest-createworkspaces-flakehttps://github.com/coder/coder/pull/8317/commits/efeac8688c2ea54872c087238766fd2c2b86f36c
https://github.com/johnstcn
johnstcnhttps://github.com/coder/coder/commits?author=johnstcn
efeac86https://github.com/coder/coder/pull/8317/commits/efeac8688c2ea54872c087238766fd2c2b86f36c
https://github.com/coder/coder/tree/efeac8688c2ea54872c087238766fd2c2b86f36c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.