René's URL Explorer Experiment


Title: fix: strip CORS headers from applications by code-asher · Pull Request #8057 · coder/coder · GitHub

Open Graph Title: fix: strip CORS headers from applications by code-asher · Pull Request #8057 · coder/coder

X Title: fix: strip CORS headers from applications by code-asher · Pull Request #8057 · coder/coder

Description: Secure environments for developers and their agents - fix: strip CORS headers from applications by code-asher · Pull Request #8057 · coder/coder

Open Graph Description: This is a followup to #7688 The problem is that if applications send their own CORS headers the headers get doubled up (not overwritten) and browsers do not like multiple values for the allowed ori...

X Description: This is a followup to #7688 The problem is that if applications send their own CORS headers the headers get doubled up (not overwritten) and browsers do not like multiple values for the allowed ori...

Opengraph URL: https://github.com/coder/coder/pull/8057

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9852c2b6-84f4-2f41-2ac8-fc5b9ca58f43
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD986:3C21B:2101A0D:2A23B29:6B01632F
html-safe-nonce266f178953dd44b0b0c9be675629d8685f28b6a8f4ab32a32ab6cb6d4745bf61
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTg2OjNDMjFCOjIxMDFBMEQ6MkEyM0IyOTo2QjAxNjMyRiIsInZpc2l0b3JfaWQiOiI0NDcxODA3NDY1MTk2OTcwNzk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2f25bdcedf97ecfc2009197759341f04f1371d95a37a4bbe6665f5fafd7f6c0b
hovercard-subject-tagpull_request:1394741199
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/8057/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ab046b8570c3d24a817ba9ad83671a93d6ec7275f078b77a0f9792f519cbd81d/coder/coder/pull/8057
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ab046b8570c3d24a817ba9ad83671a93d6ec7275f078b77a0f9792f519cbd81d/coder/coder/pull/8057
og:image:altThis is a followup to #7688 The problem is that if applications send their own CORS headers the headers get doubled up (not overwritten) and browsers do not like multiple values for the allowed ori...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecode-asher
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/8057#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F8057
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F8057
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/8057
Reloadhttps://github.com/coder/coder/pull/8057
Reloadhttps://github.com/coder/coder/pull/8057
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
code-asherhttps://github.com/code-asher
mainhttps://github.com/coder/coder/tree/main
asher/override-corshttps://github.com/coder/coder/tree/asher/override-cors
Conversationhttps://github.com/coder/coder/pull/8057
Commits1 (1)https://github.com/coder/coder/pull/8057/commits
Checkshttps://github.com/coder/coder/pull/8057/checks
Files changedhttps://github.com/coder/coder/pull/8057/files
fix: strip CORS headers from applicationshttps://github.com/coder/coder/pull/8057#top
code-asherhttps://github.com/code-asher
mainhttps://github.com/coder/coder/tree/main
asher/override-corshttps://github.com/coder/coder/tree/asher/override-cors
https://github.com/code-asher
code-asherhttps://github.com/code-asher
Jun 15, 2023https://github.com/coder/coder/pull/8057#issue-1759521661
Please reload this pagehttps://github.com/coder/coder/pull/8057
#7688https://github.com/coder/coder/pull/7688
#8010https://github.com/coder/coder/issues/8010
Please reload this pagehttps://github.com/coder/coder/pull/8057
https://github.com/code-asher
code-asherhttps://github.com/code-asher
Jun 15, 2023https://github.com/coder/coder/pull/8057#event-9544797884
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
code-asherhttps://github.com/code-asher
Jun 15, 2023https://github.com/coder/coder/pull/8057#event-9544797910
https://github.com/code-asher
code-asherhttps://github.com/code-asher
force-pushedhttps://github.com/coder/coder/compare/e84d992f8a38e10678d7ea83d692c883c169398b..9aa2e850b9d43ef3b8f1d4286513d8d9a8a076fc
e84d992https://github.com/coder/coder/commit/e84d992f8a38e10678d7ea83d692c883c169398b
9aa2e85https://github.com/coder/coder/commit/9aa2e850b9d43ef3b8f1d4286513d8d9a8a076fc
Compare https://github.com/coder/coder/compare/e84d992f8a38e10678d7ea83d692c883c169398b..9aa2e850b9d43ef3b8f1d4286513d8d9a8a076fc
June 16, 2023 00:54https://github.com/coder/coder/pull/8057#event-9546014054
https://github.com/code-asher
code-asherhttps://github.com/code-asher
Jun 16, 2023 https://github.com/coder/coder/pull/8057#pullrequestreview-1482577193
View reviewed changes https://github.com/coder/coder/pull/8057/files
coderd/workspaceapps/apptest/apptest.gohttps://github.com/coder/coder/pull/8057/files#diff-1af050eb2ed65aa911762014a1b35d4805b600ab141e057c3caca6ae0ef7ed6d
code-asherhttps://github.com/code-asher
Jun 16, 2023https://github.com/coder/coder/pull/8057#discussion_r1231672292
Please reload this pagehttps://github.com/coder/coder/pull/8057
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/coder/coder/actions/runs/5284785388/jobs/9562577501https://github.com/coder/coder/actions/runs/5284785388/jobs/9562577501
https://github.com/coder/coder/actions/runs/5284691553/jobs/9562383538https://github.com/coder/coder/actions/runs/5284691553/jobs/9562383538
Please reload this pagehttps://github.com/coder/coder/pull/8057
Emyrkhttps://github.com/Emyrk
Jun 20, 2023https://github.com/coder/coder/pull/8057#discussion_r1235514769
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/8057
code-asherhttps://github.com/code-asher
Jun 20, 2023https://github.com/coder/coder/pull/8057#discussion_r1235533150
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/8057
https://github.com/code-asher
code-asherhttps://github.com/code-asher
June 16, 2023 01:21https://github.com/coder/coder/pull/8057#event-9546188675
https://github.com/code-asher
code-asherhttps://github.com/code-asher
Emyrkhttps://github.com/Emyrk
June 16, 2023 01:21https://github.com/coder/coder/pull/8057#event-9546189065
https://github.com/bpmct
bpmcthttps://github.com/bpmct
Jun 16, 2023 https://github.com/coder/coder/pull/8057#pullrequestreview-1484378482
View reviewed changes https://github.com/coder/coder/pull/8057/files
bpmcthttps://github.com/bpmct
https://github.com/coder/coder/pull/8057#pullrequestreview-1484378482
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
herehttps://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#simple_requests
Please reload this pagehttps://github.com/coder/coder/pull/8057
https://github.com/code-asher
code-asherhttps://github.com/code-asher
Jun 20, 2023https://github.com/coder/coder/pull/8057#issuecomment-1599062256
herehttps://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#simple_requests
https://github.com/coder/coder/pull/8057/files#diff-fee7817d909d710ad6c6a59e4a5fc65ea0b7608949e74c45e3465b1f51e5cc99R127-R132https://github.com/coder/coder/pull/8057/files#diff-fee7817d909d710ad6c6a59e4a5fc65ea0b7608949e74c45e3465b1f51e5cc99R127-R132
Please reload this pagehttps://github.com/coder/coder/pull/8057
https://github.com/code-asher
Strip CORS headers from applicationshttps://github.com/coder/coder/pull/8057/commits/4fabc549c6e6238903f261a432310939ee5ef487
4fabc54https://github.com/coder/coder/pull/8057/commits/4fabc549c6e6238903f261a432310939ee5ef487
https://github.com/code-asher
code-asherhttps://github.com/code-asher
force-pushedhttps://github.com/coder/coder/compare/9aa2e850b9d43ef3b8f1d4286513d8d9a8a076fc..4fabc549c6e6238903f261a432310939ee5ef487
9aa2e85https://github.com/coder/coder/commit/9aa2e850b9d43ef3b8f1d4286513d8d9a8a076fc
4fabc54https://github.com/coder/coder/commit/4fabc549c6e6238903f261a432310939ee5ef487
Compare https://github.com/coder/coder/compare/9aa2e850b9d43ef3b8f1d4286513d8d9a8a076fc..4fabc549c6e6238903f261a432310939ee5ef487
June 20, 2023 15:54https://github.com/coder/coder/pull/8057#event-9581445426
https://github.com/Emyrk
Emyrkhttps://github.com/Emyrk
Jun 20, 2023 https://github.com/coder/coder/pull/8057#pullrequestreview-1488540847
View reviewed changes https://github.com/coder/coder/pull/8057/files/4fabc549c6e6238903f261a432310939ee5ef487
Emyrkhttps://github.com/Emyrk
https://github.com/coder/coder/pull/8057#pullrequestreview-1488540847
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/8057
coderd/workspaceapps/proxy.gohttps://github.com/coder/coder/pull/8057/files/4fabc549c6e6238903f261a432310939ee5ef487#diff-8db7601b3eb4753c0d7cbea21538f61fdfe56c6d3d278b2b34da9a9ede9d064f
Emyrkhttps://github.com/Emyrk
Jun 20, 2023https://github.com/coder/coder/pull/8057#discussion_r1235510968
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/8057
code-asherhttps://github.com/code-asher
Jun 20, 2023https://github.com/coder/coder/pull/8057#discussion_r1235534445
Please reload this pagehttps://github.com/coder/coder/pull/8057
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/8057
coderd/workspaceapps/apptest/apptest.gohttps://github.com/coder/coder/pull/8057/files#diff-1af050eb2ed65aa911762014a1b35d4805b600ab141e057c3caca6ae0ef7ed6d
Emyrkhttps://github.com/Emyrk
Jun 20, 2023https://github.com/coder/coder/pull/8057#discussion_r1235514769
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/8057
https://github.com/bpmct
bpmcthttps://github.com/bpmct
Jun 21, 2023https://github.com/coder/coder/pull/8057#issuecomment-1601552947
herehttps://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#simple_requests
https://github.com/coder/coder/pull/8057/files#diff-fee7817d909d710ad6c6a59e4a5fc65ea0b7608949e74c45e3465b1f51e5cc99R127-R132https://github.com/coder/coder/pull/8057/files#diff-fee7817d909d710ad6c6a59e4a5fc65ea0b7608949e74c45e3465b1f51e5cc99R127-R132
Please reload this pagehttps://github.com/coder/coder/pull/8057
https://github.com/code-asher
code-asherhttps://github.com/code-asher
96f9e61https://github.com/coder/coder/commit/96f9e61ca141bf8ac2156b67faa2ce7642b15874
Jun 21, 2023https://github.com/coder/coder/pull/8057#event-9599720337
https://github.com/code-asher
code-asherhttps://github.com/code-asher
June 21, 2023 21:41https://github.com/coder/coder/pull/8057#event-9599720473
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 21, 2023https://github.com/coder/coder/pull/8057#event-9599722432
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F8057
https://github.com/bpmct
bpmct https://github.com/bpmct
https://github.com/coder/coder/pull/8057/files/9aa2e850b9d43ef3b8f1d4286513d8d9a8a076fc
https://github.com/Emyrk
Emyrk https://github.com/Emyrk
https://github.com/coder/coder/pull/8057/files/4fabc549c6e6238903f261a432310939ee5ef487
Please reload this pagehttps://github.com/coder/coder/pull/8057
https://github.com/code-asher
code-asher https://github.com/code-asher
Handle case where application sends conflicting CORS headers https://github.com/coder/coder/issues/8010
Please reload this pagehttps://github.com/coder/coder/pull/8057
https://github.com/code-asher
https://github.com/bpmct
https://github.com/Emyrk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.