| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9852c2b6-84f4-2f41-2ac8-fc5b9ca58f43 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D986:3C21B:2101A0D:2A23B29:6B01632F |
| html-safe-nonce | 266f178953dd44b0b0c9be675629d8685f28b6a8f4ab32a32ab6cb6d4745bf61 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTg2OjNDMjFCOjIxMDFBMEQ6MkEyM0IyOTo2QjAxNjMyRiIsInZpc2l0b3JfaWQiOiI0NDcxODA3NDY1MTk2OTcwNzk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2f25bdcedf97ecfc2009197759341f04f1371d95a37a4bbe6665f5fafd7f6c0b |
| hovercard-subject-tag | pull_request:1394741199 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/8057/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ab046b8570c3d24a817ba9ad83671a93d6ec7275f078b77a0f9792f519cbd81d/coder/coder/pull/8057 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ab046b8570c3d24a817ba9ad83671a93d6ec7275f078b77a0f9792f519cbd81d/coder/coder/pull/8057 |
| og:image:alt | This is a followup to #7688
The problem is that if applications send their own CORS headers the headers get doubled up (not overwritten) and browsers do not like multiple values for the allowed ori... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | code-asher |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/8057#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F8057 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F8057 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/8057 |
| Reload | https://github.com/coder/coder/pull/8057 |
| Reload | https://github.com/coder/coder/pull/8057 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| code-asher | https://github.com/code-asher |
| main | https://github.com/coder/coder/tree/main |
| asher/override-cors | https://github.com/coder/coder/tree/asher/override-cors |
| Conversation | https://github.com/coder/coder/pull/8057 |
| Commits1 (1) | https://github.com/coder/coder/pull/8057/commits |
| Checks | https://github.com/coder/coder/pull/8057/checks |
| Files changed | https://github.com/coder/coder/pull/8057/files |
| fix: strip CORS headers from applications | https://github.com/coder/coder/pull/8057#top |
| code-asher | https://github.com/code-asher |
| main | https://github.com/coder/coder/tree/main |
| asher/override-cors | https://github.com/coder/coder/tree/asher/override-cors |
|
| https://github.com/code-asher |
| code-asher | https://github.com/code-asher |
| Jun 15, 2023 | https://github.com/coder/coder/pull/8057#issue-1759521661 |
| Please reload this page | https://github.com/coder/coder/pull/8057 |
| #7688 | https://github.com/coder/coder/pull/7688 |
| #8010 | https://github.com/coder/coder/issues/8010 |
| Please reload this page | https://github.com/coder/coder/pull/8057 |
| https://github.com/code-asher |
| code-asher | https://github.com/code-asher |
| Jun 15, 2023 | https://github.com/coder/coder/pull/8057#event-9544797884 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| code-asher | https://github.com/code-asher |
| Jun 15, 2023 | https://github.com/coder/coder/pull/8057#event-9544797910 |
| https://github.com/code-asher |
| code-asher | https://github.com/code-asher |
| force-pushed | https://github.com/coder/coder/compare/e84d992f8a38e10678d7ea83d692c883c169398b..9aa2e850b9d43ef3b8f1d4286513d8d9a8a076fc |
| e84d992 | https://github.com/coder/coder/commit/e84d992f8a38e10678d7ea83d692c883c169398b |
| 9aa2e85 | https://github.com/coder/coder/commit/9aa2e850b9d43ef3b8f1d4286513d8d9a8a076fc |
|
Compare
| https://github.com/coder/coder/compare/e84d992f8a38e10678d7ea83d692c883c169398b..9aa2e850b9d43ef3b8f1d4286513d8d9a8a076fc |
| June 16, 2023 00:54 | https://github.com/coder/coder/pull/8057#event-9546014054 |
| https://github.com/code-asher |
| code-asher | https://github.com/code-asher |
|
Jun 16, 2023
| https://github.com/coder/coder/pull/8057#pullrequestreview-1482577193 |
|
View reviewed changes
| https://github.com/coder/coder/pull/8057/files |
| coderd/workspaceapps/apptest/apptest.go | https://github.com/coder/coder/pull/8057/files#diff-1af050eb2ed65aa911762014a1b35d4805b600ab141e057c3caca6ae0ef7ed6d |
| code-asher | https://github.com/code-asher |
| Jun 16, 2023 | https://github.com/coder/coder/pull/8057#discussion_r1231672292 |
| Please reload this page | https://github.com/coder/coder/pull/8057 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/coder/coder/actions/runs/5284785388/jobs/9562577501 | https://github.com/coder/coder/actions/runs/5284785388/jobs/9562577501 |
| https://github.com/coder/coder/actions/runs/5284691553/jobs/9562383538 | https://github.com/coder/coder/actions/runs/5284691553/jobs/9562383538 |
| Please reload this page | https://github.com/coder/coder/pull/8057 |
| Emyrk | https://github.com/Emyrk |
| Jun 20, 2023 | https://github.com/coder/coder/pull/8057#discussion_r1235514769 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/8057 |
| code-asher | https://github.com/code-asher |
| Jun 20, 2023 | https://github.com/coder/coder/pull/8057#discussion_r1235533150 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/8057 |
| https://github.com/code-asher |
| code-asher | https://github.com/code-asher |
| June 16, 2023 01:21 | https://github.com/coder/coder/pull/8057#event-9546188675 |
| https://github.com/code-asher |
| code-asher | https://github.com/code-asher |
| Emyrk | https://github.com/Emyrk |
| June 16, 2023 01:21 | https://github.com/coder/coder/pull/8057#event-9546189065 |
| https://github.com/bpmct |
| bpmct | https://github.com/bpmct |
|
Jun 16, 2023
| https://github.com/coder/coder/pull/8057#pullrequestreview-1484378482 |
|
View reviewed changes
| https://github.com/coder/coder/pull/8057/files |
| bpmct | https://github.com/bpmct |
| https://github.com/coder/coder/pull/8057#pullrequestreview-1484378482 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| here | https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#simple_requests |
| Please reload this page | https://github.com/coder/coder/pull/8057 |
| https://github.com/code-asher |
| code-asher | https://github.com/code-asher |
| Jun 20, 2023 | https://github.com/coder/coder/pull/8057#issuecomment-1599062256 |
| here | https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#simple_requests |
| https://github.com/coder/coder/pull/8057/files#diff-fee7817d909d710ad6c6a59e4a5fc65ea0b7608949e74c45e3465b1f51e5cc99R127-R132 | https://github.com/coder/coder/pull/8057/files#diff-fee7817d909d710ad6c6a59e4a5fc65ea0b7608949e74c45e3465b1f51e5cc99R127-R132 |
| Please reload this page | https://github.com/coder/coder/pull/8057 |
|
| https://github.com/code-asher |
| Strip CORS headers from applications | https://github.com/coder/coder/pull/8057/commits/4fabc549c6e6238903f261a432310939ee5ef487 |
| 4fabc54 | https://github.com/coder/coder/pull/8057/commits/4fabc549c6e6238903f261a432310939ee5ef487 |
| https://github.com/code-asher |
| code-asher | https://github.com/code-asher |
| force-pushed | https://github.com/coder/coder/compare/9aa2e850b9d43ef3b8f1d4286513d8d9a8a076fc..4fabc549c6e6238903f261a432310939ee5ef487 |
| 9aa2e85 | https://github.com/coder/coder/commit/9aa2e850b9d43ef3b8f1d4286513d8d9a8a076fc |
| 4fabc54 | https://github.com/coder/coder/commit/4fabc549c6e6238903f261a432310939ee5ef487 |
|
Compare
| https://github.com/coder/coder/compare/9aa2e850b9d43ef3b8f1d4286513d8d9a8a076fc..4fabc549c6e6238903f261a432310939ee5ef487 |
| June 20, 2023 15:54 | https://github.com/coder/coder/pull/8057#event-9581445426 |
| https://github.com/Emyrk |
| Emyrk | https://github.com/Emyrk |
|
Jun 20, 2023
| https://github.com/coder/coder/pull/8057#pullrequestreview-1488540847 |
|
View reviewed changes
| https://github.com/coder/coder/pull/8057/files/4fabc549c6e6238903f261a432310939ee5ef487 |
| Emyrk | https://github.com/Emyrk |
| https://github.com/coder/coder/pull/8057#pullrequestreview-1488540847 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/8057 |
| coderd/workspaceapps/proxy.go | https://github.com/coder/coder/pull/8057/files/4fabc549c6e6238903f261a432310939ee5ef487#diff-8db7601b3eb4753c0d7cbea21538f61fdfe56c6d3d278b2b34da9a9ede9d064f |
| Emyrk | https://github.com/Emyrk |
| Jun 20, 2023 | https://github.com/coder/coder/pull/8057#discussion_r1235510968 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/8057 |
| code-asher | https://github.com/code-asher |
| Jun 20, 2023 | https://github.com/coder/coder/pull/8057#discussion_r1235534445 |
| Please reload this page | https://github.com/coder/coder/pull/8057 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/8057 |
| coderd/workspaceapps/apptest/apptest.go | https://github.com/coder/coder/pull/8057/files#diff-1af050eb2ed65aa911762014a1b35d4805b600ab141e057c3caca6ae0ef7ed6d |
| Emyrk | https://github.com/Emyrk |
| Jun 20, 2023 | https://github.com/coder/coder/pull/8057#discussion_r1235514769 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/8057 |
| https://github.com/bpmct |
| bpmct | https://github.com/bpmct |
| Jun 21, 2023 | https://github.com/coder/coder/pull/8057#issuecomment-1601552947 |
| here | https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#simple_requests |
| https://github.com/coder/coder/pull/8057/files#diff-fee7817d909d710ad6c6a59e4a5fc65ea0b7608949e74c45e3465b1f51e5cc99R127-R132 | https://github.com/coder/coder/pull/8057/files#diff-fee7817d909d710ad6c6a59e4a5fc65ea0b7608949e74c45e3465b1f51e5cc99R127-R132 |
| Please reload this page | https://github.com/coder/coder/pull/8057 |
| https://github.com/code-asher |
| code-asher | https://github.com/code-asher |
| 96f9e61 | https://github.com/coder/coder/commit/96f9e61ca141bf8ac2156b67faa2ce7642b15874 |
| Jun 21, 2023 | https://github.com/coder/coder/pull/8057#event-9599720337 |
| https://github.com/code-asher |
| code-asher | https://github.com/code-asher |
| June 21, 2023 21:41 | https://github.com/coder/coder/pull/8057#event-9599720473 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Jun 21, 2023 | https://github.com/coder/coder/pull/8057#event-9599722432 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F8057 |
|
| https://github.com/bpmct |
|
bpmct
| https://github.com/bpmct |
|
| https://github.com/coder/coder/pull/8057/files/9aa2e850b9d43ef3b8f1d4286513d8d9a8a076fc |
|
| https://github.com/Emyrk |
|
Emyrk
| https://github.com/Emyrk |
|
| https://github.com/coder/coder/pull/8057/files/4fabc549c6e6238903f261a432310939ee5ef487 |
| Please reload this page | https://github.com/coder/coder/pull/8057 |
|
| https://github.com/code-asher |
|
code-asher
| https://github.com/code-asher |
|
Handle case where application sends conflicting CORS headers
| https://github.com/coder/coder/issues/8010 |
| Please reload this page | https://github.com/coder/coder/pull/8057 |
|
| https://github.com/code-asher |
|
| https://github.com/bpmct |
|
| https://github.com/Emyrk |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |