René's URL Explorer Experiment


Title: refactor(agent): Move SSH server into agentssh package by mafredri · Pull Request #7004 · coder/coder · GitHub

Open Graph Title: refactor(agent): Move SSH server into agentssh package by mafredri · Pull Request #7004 · coder/coder

X Title: refactor(agent): Move SSH server into agentssh package by mafredri · Pull Request #7004 · coder/coder

Description: Secure environments for developers and their agents - refactor(agent): Move SSH server into agentssh package by mafredri · Pull Request #7004 · coder/coder

Open Graph Description: This PR refactors the coder agent SSH server into a separate package, agentssh. The motivation is to break out functionality of the agent into a more bite-sized package as well as contain complexit...

X Description: This PR refactors the coder agent SSH server into a separate package, agentssh. The motivation is to break out functionality of the agent into a more bite-sized package as well as contain complexit...

Opengraph URL: https://github.com/coder/coder/pull/7004

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:00b20c60-dd32-87b1-f194-308add8ea29a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCB82:24A0A:202EEFF:28A896E:6B019F18
html-safe-nonce20625e894680b86d9344f70c86acd0da861d0a2eb91c49523b676b2c52f90e2b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjgyOjI0QTBBOjIwMkVFRkY6MjhBODk2RTo2QjAxOUYxOCIsInZpc2l0b3JfaWQiOiIyMjk1NDAzNjc2Mzg0MjA2NjE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc5e7ac76e0094bb7f570c5fda91f13eb80e7b535cb8f79b050cc85bb739fe1b2
hovercard-subject-tagpull_request:1301791473
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/7004/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/95c169ee17e86c66212e1707f63a80a7886c56aa29e13a61f1ce5f5ce4e24040/coder/coder/pull/7004
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/95c169ee17e86c66212e1707f63a80a7886c56aa29e13a61f1ce5f5ce4e24040/coder/coder/pull/7004
og:image:altThis PR refactors the coder agent SSH server into a separate package, agentssh. The motivation is to break out functionality of the agent into a more bite-sized package as well as contain complexit...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemafredri
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/7004#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F7004
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F7004
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/7004
Reloadhttps://github.com/coder/coder/pull/7004
Reloadhttps://github.com/coder/coder/pull/7004
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/refactor-agent-sshdhttps://github.com/coder/coder/tree/mafredri/refactor-agent-sshd
Conversationhttps://github.com/coder/coder/pull/7004
Commits8 (8)https://github.com/coder/coder/pull/7004/commits
Checkshttps://github.com/coder/coder/pull/7004/checks
Files changedhttps://github.com/coder/coder/pull/7004/files
refactor(agent): Move SSH server into agentssh packagehttps://github.com/coder/coder/pull/7004#top
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/refactor-agent-sshdhttps://github.com/coder/coder/tree/mafredri/refactor-agent-sshd
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Apr 4, 2023https://github.com/coder/coder/pull/7004#issue-1654023020
#6177https://github.com/coder/coder/issues/6177
#6177https://github.com/coder/coder/issues/6177
Please reload this pagehttps://github.com/coder/coder/pull/7004
https://github.com/mafredri
refactor(agent): Move SSH server into agentssh packagehttps://github.com/coder/coder/pull/7004/commits/37adb622eb7519b4cd275c0f2658bf2df96423d6
37adb62https://github.com/coder/coder/pull/7004/commits/37adb622eb7519b4cd275c0f2658bf2df96423d6
#6177https://github.com/coder/coder/issues/6177
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
mafredrihttps://github.com/mafredri
Apr 4, 2023https://github.com/coder/coder/pull/7004#event-8925369268
mafredrihttps://github.com/mafredri
April 4, 2023 14:46https://github.com/coder/coder/pull/7004#commits-pushed-d5f7a4e
https://github.com/mafredri
Rename receivershttps://github.com/coder/coder/pull/7004/commits/d5f7a4e4f8705bfc67d02f9b137b1f0622ec6e34
d5f7a4ehttps://github.com/coder/coder/pull/7004/commits/d5f7a4e4f8705bfc67d02f9b137b1f0622ec6e34
https://github.com/mafredri
Remove unused contexthttps://github.com/coder/coder/pull/7004/commits/3ea3e707ce40f3d9a4c4be0481e748484607f55d
3ea3e70https://github.com/coder/coder/pull/7004/commits/3ea3e707ce40f3d9a4c4be0481e748484607f55d
https://github.com/mafredri
Use s loggerhttps://github.com/coder/coder/pull/7004/commits/126813f029765d9bf6606d7cbcaee40a40ad845f
126813fhttps://github.com/coder/coder/pull/7004/commits/126813f029765d9bf6606d7cbcaee40a40ad845f
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Apr 4, 2023https://github.com/coder/coder/pull/7004#issuecomment-1496128442
Please reload this pagehttps://github.com/coder/coder/pull/7004
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Apr 4, 2023 https://github.com/coder/coder/pull/7004#pullrequestreview-1371202996
View reviewed changes https://github.com/coder/coder/pull/7004/files/126813f029765d9bf6606d7cbcaee40a40ad845f
agent/agentssh/agentssh.gohttps://github.com/coder/coder/pull/7004/files/126813f029765d9bf6606d7cbcaee40a40ad845f#diff-e2fb60d4b313fc2ad42c37ce065c0c880e04615b339a843e14892338d0bb4396
mafredrihttps://github.com/mafredri
Apr 4, 2023https://github.com/coder/coder/pull/7004#discussion_r1157394214
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/7004
https://github.com/mafredri
Rename unused arg _https://github.com/coder/coder/pull/7004/commits/667d038fe262d3bd21e827569f3534f242cfe9b0
667d038https://github.com/coder/coder/pull/7004/commits/667d038fe262d3bd21e827569f3534f242cfe9b0
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Apr 4, 2023 https://github.com/coder/coder/pull/7004#ref-pullrequest-1654313287
fix: Guard against conn leak after server close coder/ssh#1 https://github.com/coder/ssh/pull/1
https://github.com/mafredri
mafredrihttps://github.com/mafredri
April 4, 2023 18:03https://github.com/coder/coder/pull/7004#event-8927338376
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Apr 4, 2023https://github.com/coder/coder/pull/7004#issuecomment-1496385287
Please reload this pagehttps://github.com/coder/coder/pull/7004
coder/ssh#1https://github.com/coder/ssh/pull/1
Please reload this pagehttps://github.com/coder/coder/pull/7004
https://github.com/mafredri
mafredrihttps://github.com/mafredri
deansheatherhttps://github.com/deansheather
kylecarbshttps://github.com/kylecarbs
April 4, 2023 18:04https://github.com/coder/coder/pull/7004#event-8927350971
https://github.com/deansheather
deansheatherhttps://github.com/deansheather
Apr 5, 2023 https://github.com/coder/coder/pull/7004#pullrequestreview-1373744071
View reviewed changes https://github.com/coder/coder/pull/7004/files/667d038fe262d3bd21e827569f3534f242cfe9b0
deansheatherhttps://github.com/deansheather
https://github.com/coder/coder/pull/7004#pullrequestreview-1373744071
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/7004
agent/agentssh/agentssh.gohttps://github.com/coder/coder/pull/7004/files/667d038fe262d3bd21e827569f3534f242cfe9b0#diff-e2fb60d4b313fc2ad42c37ce065c0c880e04615b339a843e14892338d0bb4396
Please reload this pagehttps://github.com/coder/coder/pull/7004
agent/agentssh/agentssh.gohttps://github.com/coder/coder/pull/7004/files/667d038fe262d3bd21e827569f3534f242cfe9b0#diff-e2fb60d4b313fc2ad42c37ce065c0c880e04615b339a843e14892338d0bb4396
deansheatherhttps://github.com/deansheather
Apr 5, 2023https://github.com/coder/coder/pull/7004#discussion_r1159061015
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/7004
mafredrihttps://github.com/mafredri
Apr 6, 2023https://github.com/coder/coder/pull/7004#discussion_r1159534439
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#6177https://github.com/coder/coder/issues/6177
Please reload this pagehttps://github.com/coder/coder/pull/7004
agent/agentssh/bicopy.gohttps://github.com/coder/coder/pull/7004/files/667d038fe262d3bd21e827569f3534f242cfe9b0#diff-c3126aac78e4af6c52818b698e44a25b5c3bc038a81aff6779ee3ed9ba8d271c
Please reload this pagehttps://github.com/coder/coder/pull/7004
agent/agentssh/agentssh_test.gohttps://github.com/coder/coder/pull/7004/files/667d038fe262d3bd21e827569f3534f242cfe9b0#diff-5dc1411a84ebf7fcbc20350f2d9b44dd0391978f285eacc929ff1e377ff589ec
Please reload this pagehttps://github.com/coder/coder/pull/7004
mafredrihttps://github.com/mafredri
April 6, 2023 09:50https://github.com/coder/coder/pull/7004#commits-pushed-94d7593
https://github.com/mafredri
Address PR feedbackhttps://github.com/coder/coder/pull/7004/commits/94d759396ad87cb386f54917ea51cc56e4a6fe0f
94d7593https://github.com/coder/coder/pull/7004/commits/94d759396ad87cb386f54917ea51cc56e4a6fe0f
https://github.com/mafredri
Merge branch 'main' into mafredri/refactor-agent-sshdhttps://github.com/coder/coder/pull/7004/commits/e71ba853b2b40beb16550dc3a7b2c88fa87b43d2
e71ba85https://github.com/coder/coder/pull/7004/commits/e71ba853b2b40beb16550dc3a7b2c88fa87b43d2
https://github.com/mafredri
mafredrihttps://github.com/mafredri
deansheatherhttps://github.com/deansheather
April 6, 2023 09:57https://github.com/coder/coder/pull/7004#event-8943953896
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Apr 6, 2023https://github.com/coder/coder/pull/7004#issuecomment-1498929525
@deansheatherhttps://github.com/deansheather
coder/ssh#1https://github.com/coder/ssh/pull/1
Please reload this pagehttps://github.com/coder/coder/pull/7004
https://github.com/mafredri
Improve handling of serve/closehttps://github.com/coder/coder/pull/7004/commits/ed63a2bcf048d0fc178908ff06743c4abd823fd0
ed63a2bhttps://github.com/coder/coder/pull/7004/commits/ed63a2bcf048d0fc178908ff06743c4abd823fd0
https://github.com/mafredri
mafredrihttps://github.com/mafredri
force-pushedhttps://github.com/coder/coder/compare/b768d35dcc5b8320dbda35f35a2a93ccf5ad2318..ed63a2bcf048d0fc178908ff06743c4abd823fd0
b768d35https://github.com/coder/coder/commit/b768d35dcc5b8320dbda35f35a2a93ccf5ad2318
ed63a2bhttps://github.com/coder/coder/commit/ed63a2bcf048d0fc178908ff06743c4abd823fd0
Compare https://github.com/coder/coder/compare/b768d35dcc5b8320dbda35f35a2a93ccf5ad2318..ed63a2bcf048d0fc178908ff06743c4abd823fd0
April 6, 2023 11:41https://github.com/coder/coder/pull/7004#event-8945049091
feat(agentssh): Gracefully close SSH sessions on Close #7027 https://github.com/coder/coder/pull/7027
Refactor coder agent SSH server for better process and connection control #6177 https://github.com/coder/coder/issues/6177
https://github.com/deansheather
deansheatherhttps://github.com/deansheather
Apr 6, 2023 https://github.com/coder/coder/pull/7004#pullrequestreview-1374929903
View reviewed changes https://github.com/coder/coder/pull/7004/files/ed63a2bcf048d0fc178908ff06743c4abd823fd0
agent/agentssh/agentssh.gohttps://github.com/coder/coder/pull/7004/files/ed63a2bcf048d0fc178908ff06743c4abd823fd0#diff-e2fb60d4b313fc2ad42c37ce065c0c880e04615b339a843e14892338d0bb4396
deansheatherhttps://github.com/deansheather
Apr 6, 2023https://github.com/coder/coder/pull/7004#discussion_r1159841679
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/7004
mafredrihttps://github.com/mafredri
Apr 6, 2023https://github.com/coder/coder/pull/7004#discussion_r1159852520
Please reload this pagehttps://github.com/coder/coder/pull/7004
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/7004
deansheatherhttps://github.com/deansheather
Apr 6, 2023https://github.com/coder/coder/pull/7004#discussion_r1159859957
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/7004
mafredrihttps://github.com/mafredri
Apr 6, 2023https://github.com/coder/coder/pull/7004#discussion_r1159862974
Please reload this pagehttps://github.com/coder/coder/pull/7004
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/7004
deansheatherhttps://github.com/deansheather
Apr 6, 2023https://github.com/coder/coder/pull/7004#discussion_r1159864152
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/7004
deansheatherhttps://github.com/deansheather
Apr 6, 2023https://github.com/coder/coder/pull/7004#discussion_r1159864920
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/7004
mafredrihttps://github.com/mafredri
Apr 6, 2023https://github.com/coder/coder/pull/7004#discussion_r1159866776
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/7004
deansheatherhttps://github.com/deansheather
Apr 6, 2023https://github.com/coder/coder/pull/7004#discussion_r1159869999
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/7004
https://github.com/deansheather
deansheatherhttps://github.com/deansheather
Apr 6, 2023 https://github.com/coder/coder/pull/7004#pullrequestreview-1374934273
View reviewed changes https://github.com/coder/coder/pull/7004/files/ed63a2bcf048d0fc178908ff06743c4abd823fd0
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
Apr 6, 2023 https://github.com/coder/coder/pull/7004#pullrequestreview-1375207964
View reviewed changes https://github.com/coder/coder/pull/7004/files/ed63a2bcf048d0fc178908ff06743c4abd823fd0
https://github.com/mafredri
mafredrihttps://github.com/mafredri
0224426https://github.com/coder/coder/commit/0224426e5bb4d6d42ca093045f84e31015217fb8
Apr 6, 2023https://github.com/coder/coder/pull/7004#event-8947861440
https://github.com/mafredri
mafredrihttps://github.com/mafredri
April 6, 2023 16:39https://github.com/coder/coder/pull/7004#event-8947861688
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 6, 2023https://github.com/coder/coder/pull/7004#event-8947863527
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F7004
https://github.com/deansheather
deansheather https://github.com/deansheather
https://github.com/coder/coder/pull/7004/files/ed63a2bcf048d0fc178908ff06743c4abd823fd0
https://github.com/kylecarbs
kylecarbs https://github.com/kylecarbs
https://github.com/coder/coder/pull/7004/files/ed63a2bcf048d0fc178908ff06743c4abd823fd0
Please reload this pagehttps://github.com/coder/coder/pull/7004
https://github.com/mafredri
mafredri https://github.com/mafredri
Please reload this pagehttps://github.com/coder/coder/pull/7004
https://github.com/mafredri
https://github.com/kylecarbs
https://github.com/deansheather
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.