René's URL Explorer Experiment


Title: fix(agent): Allow signal propagation when running as PID 1 by mafredri · Pull Request #6141 · coder/coder · GitHub

Open Graph Title: fix(agent): Allow signal propagation when running as PID 1 by mafredri · Pull Request #6141 · coder/coder

X Title: fix(agent): Allow signal propagation when running as PID 1 by mafredri · Pull Request #6141 · coder/coder

Description: Secure environments for developers and their agents - fix(agent): Allow signal propagation when running as PID 1 by mafredri · Pull Request #6141 · coder/coder

Open Graph Description: When the agent was running as PID 1 and performing it's reaping duties, Docker ended up killing it immediately on stop instead of gracefully as one would hope. This adds some signal propagation...

X Description: When the agent was running as PID 1 and performing it's reaping duties, Docker ended up killing it immediately on stop instead of gracefully as one would hope. This adds some signal propaga...

Opengraph URL: https://github.com/coder/coder/pull/6141

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f97487cb-d5db-7a81-151c-cb9e95565543
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id98C6:FC5BE:25759E2:31BBFBD:6B019F26
html-safe-nonce5f4118ba968e8b18bdb5c2b735e7f1efe09d425774d2ea2428a50c6bb2a0a443
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEM2OkZDNUJFOjI1NzU5RTI6MzFCQkZCRDo2QjAxOUYyNiIsInZpc2l0b3JfaWQiOiI1NzcyODg3NDc0NDUxODgxNzY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca5b4fdde07090abb7c37d73bfbaf098a2d2c16ae9a9ae512776d120025d1389b
hovercard-subject-tagpull_request:1235594497
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/6141/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c37aac63a36464c609fed8be823e59f814c7dd9649182cd962c8854b1cccb230/coder/coder/pull/6141
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c37aac63a36464c609fed8be823e59f814c7dd9649182cd962c8854b1cccb230/coder/coder/pull/6141
og:image:altWhen the agent was running as PID 1 and performing it's reaping duties, Docker ended up killing it immediately on stop instead of gracefully as one would hope. This adds some signal propagation...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemafredri
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/6141#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F6141
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F6141
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/6141
Reloadhttps://github.com/coder/coder/pull/6141
Reloadhttps://github.com/coder/coder/pull/6141
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/fix-pid1-signalshttps://github.com/coder/coder/tree/mafredri/fix-pid1-signals
Conversationhttps://github.com/coder/coder/pull/6141
Commits2 (2)https://github.com/coder/coder/pull/6141/commits
Checkshttps://github.com/coder/coder/pull/6141/checks
Files changedhttps://github.com/coder/coder/pull/6141/files
fix(agent): Allow signal propagation when running as PID 1https://github.com/coder/coder/pull/6141#top
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/fix-pid1-signalshttps://github.com/coder/coder/tree/mafredri/fix-pid1-signals
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Feb 9, 2023https://github.com/coder/coder/pull/6141#issue-1578437769
Please reload this pagehttps://github.com/coder/coder/pull/6141
https://github.com/mafredri
fix(agent): Allow signal propagation when agent running as PID 1https://github.com/coder/coder/pull/6141/commits/89e07ab889bba85ec61ac2d46169eb45ca90c410
89e07abhttps://github.com/coder/coder/pull/6141/commits/89e07ab889bba85ec61ac2d46169eb45ca90c410
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Feb 9, 2023https://github.com/coder/coder/pull/6141#event-8482815012
https://github.com/mafredri
mafredrihttps://github.com/mafredri
kylecarbshttps://github.com/kylecarbs
mtojekhttps://github.com/mtojek
sreyahttps://github.com/sreya
February 9, 2023 19:04https://github.com/coder/coder/pull/6141#event-8482816593
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
Feb 9, 2023 https://github.com/coder/coder/pull/6141#pullrequestreview-1291829092
View reviewed changes https://github.com/coder/coder/pull/6141/files/89e07ab889bba85ec61ac2d46169eb45ca90c410
kylecarbshttps://github.com/kylecarbs
https://github.com/coder/coder/pull/6141#pullrequestreview-1291829092
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/6141
https://github.com/mafredri
Ignore test in CIhttps://github.com/coder/coder/pull/6141/commits/541668684470cf2d13edc9cf24c6dd6ff660232d
5416686https://github.com/coder/coder/pull/6141/commits/541668684470cf2d13edc9cf24c6dd6ff660232d
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Feb 9, 2023https://github.com/coder/coder/pull/6141#event-8483379092
https://github.com/mafredri
mafredrihttps://github.com/mafredri
6f3f7f2https://github.com/coder/coder/commit/6f3f7f293722bec1e0719fecce3ca50b60ecd3cb
Feb 9, 2023https://github.com/coder/coder/pull/6141#event-8483819692
https://github.com/mafredri
mafredrihttps://github.com/mafredri
February 9, 2023 21:07https://github.com/coder/coder/pull/6141#event-8483819925
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Feb 9, 2023https://github.com/coder/coder/pull/6141#event-8483821879
https://github.com/mtojek
mtojekhttps://github.com/mtojek
Feb 10, 2023 https://github.com/coder/coder/pull/6141#pullrequestreview-1292647959
View reviewed changes https://github.com/coder/coder/pull/6141/files/541668684470cf2d13edc9cf24c6dd6ff660232d
mtojekhttps://github.com/mtojek
https://github.com/coder/coder/pull/6141#pullrequestreview-1292647959
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/6141
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F6141
https://github.com/mtojek
mtojek https://github.com/mtojek
https://github.com/coder/coder/pull/6141/files/541668684470cf2d13edc9cf24c6dd6ff660232d
https://github.com/kylecarbs
kylecarbs https://github.com/kylecarbs
https://github.com/coder/coder/pull/6141/files/89e07ab889bba85ec61ac2d46169eb45ca90c410
https://github.com/sreya
sreya https://github.com/sreya
Please reload this pagehttps://github.com/coder/coder/pull/6141
https://github.com/mafredri
mafredri https://github.com/mafredri
Please reload this pagehttps://github.com/coder/coder/pull/6141
https://github.com/mafredri
https://github.com/kylecarbs
https://github.com/mtojek
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.