René's URL Explorer Experiment


Title: feat: Validate workspace build parameters by mtojek · Pull Request #5807 · coder/coder · GitHub

Open Graph Title: feat: Validate workspace build parameters by mtojek · Pull Request #5807 · coder/coder

X Title: feat: Validate workspace build parameters by mtojek · Pull Request #5807 · coder/coder

Description: Secure environments for developers and their agents - feat: Validate workspace build parameters by mtojek · Pull Request #5807 · coder/coder

Open Graph Description: Related: #5574 This PR enables coder_parameter validation on different levels: CLI, API and Terraform. Changes: feat: validate rich parameters passed via CLI feat: add validation_error column to u...

X Description: Related: #5574 This PR enables coder_parameter validation on different levels: CLI, API and Terraform. Changes: feat: validate rich parameters passed via CLI feat: add validation_error column to u...

Opengraph URL: https://github.com/coder/coder/pull/5807

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7f44b5a9-09dd-ea95-68a5-52a17f6089ea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9308:3CBB3E:20BE166:29C63EF:6B01B726
html-safe-nonce75dd4c56483d779e4717d696cfa9ba1338dfacbb2490bc15e07328b1044a7a02
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzA4OjNDQkIzRToyMEJFMTY2OjI5QzYzRUY6NkIwMUI3MjYiLCJ2aXNpdG9yX2lkIjoiNjQ0MjU1MTgzNDU3NzA1NzU3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac47d347c5e8cc578bc6be429e3ad36f1bfce4259f6267333169a9769ea7548d7b
hovercard-subject-tagpull_request:1211444163
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/5807/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5a2284c11ca530ec28468bd509ab47907d84d005a84a956630f2dc3f3068af5c/coder/coder/pull/5807
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5a2284c11ca530ec28468bd509ab47907d84d005a84a956630f2dc3f3068af5c/coder/coder/pull/5807
og:image:altRelated: #5574 This PR enables coder_parameter validation on different levels: CLI, API and Terraform. Changes: feat: validate rich parameters passed via CLI feat: add validation_error column to u...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemtojek
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/5807#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F5807
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F5807
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/5807
Reloadhttps://github.com/coder/coder/pull/5807
Reloadhttps://github.com/coder/coder/pull/5807
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
mtojekhttps://github.com/mtojek
coder:mainhttps://github.com/coder/coder/tree/main
mtojek:5574-validation-ruleshttps://github.com/mtojek/coder/tree/5574-validation-rules
Conversationhttps://github.com/coder/coder/pull/5807
Commits38 (38)https://github.com/coder/coder/pull/5807/commits
Checkshttps://github.com/coder/coder/pull/5807/checks
Files changedhttps://github.com/coder/coder/pull/5807/files
feat: Validate workspace build parametershttps://github.com/coder/coder/pull/5807#top
mtojekhttps://github.com/mtojek
coder:mainhttps://github.com/coder/coder/tree/main
mtojek:5574-validation-ruleshttps://github.com/mtojek/coder/tree/5574-validation-rules
https://github.com/mtojek
mtojekhttps://github.com/mtojek
Jan 20, 2023https://github.com/coder/coder/pull/5807#issue-1550739971
Please reload this pagehttps://github.com/coder/coder/pull/5807
#5574https://github.com/coder/coder/issues/5574
Please reload this pagehttps://github.com/coder/coder/pull/5807
mtojekhttps://github.com/mtojek
January 18, 2023 11:42https://github.com/coder/coder/pull/5807#commits-pushed-df9ddf3
https://github.com/mtojek
WIPhttps://github.com/coder/coder/pull/5807/commits/df9ddf38c299b17d5bfda3d120efcf28dacc22f7
df9ddf3https://github.com/coder/coder/pull/5807/commits/df9ddf38c299b17d5bfda3d120efcf28dacc22f7
https://github.com/mtojek
WIPhttps://github.com/coder/coder/pull/5807/commits/e8e2e5328bbed8c38538190de6af150543f703fa
e8e2e53https://github.com/coder/coder/pull/5807/commits/e8e2e5328bbed8c38538190de6af150543f703fa
https://github.com/mtojek
CLI: handle workspace build parametershttps://github.com/coder/coder/pull/5807/commits/cfe5521603bfbbee3dda4991cecce80957dbffa3
cfe5521https://github.com/coder/coder/pull/5807/commits/cfe5521603bfbbee3dda4991cecce80957dbffa3
https://github.com/mtojek
fix: golintcihttps://github.com/coder/coder/pull/5807/commits/74315b22b9f7b5e550956889fa978517fdf38e30
74315b2https://github.com/coder/coder/pull/5807/commits/74315b22b9f7b5e550956889fa978517fdf38e30
https://github.com/mtojek
Fix: dry runhttps://github.com/coder/coder/pull/5807/commits/90b5e357a5762be324c94c3d99610a793671b6a5
90b5e35https://github.com/coder/coder/pull/5807/commits/90b5e357a5762be324c94c3d99610a793671b6a5
https://github.com/mtojek
fixhttps://github.com/coder/coder/pull/5807/commits/34db76e58422158e18dac5e274519b9f7bd6c3a4
34db76ehttps://github.com/coder/coder/pull/5807/commits/34db76e58422158e18dac5e274519b9f7bd6c3a4
https://github.com/mtojek
CLI: is mutablehttps://github.com/coder/coder/pull/5807/commits/a78f798b9c542ea2176a8076f7b60192612ae411
a78f798https://github.com/coder/coder/pull/5807/commits/a78f798b9c542ea2176a8076f7b60192612ae411
https://github.com/mtojek
coderd: mutablehttps://github.com/coder/coder/pull/5807/commits/7e6ddca14bc169533cde9386ac2bb712df22ec5e
7e6ddcahttps://github.com/coder/coder/pull/5807/commits/7e6ddca14bc169533cde9386ac2bb712df22ec5e
https://github.com/mtojek
fix: golancihttps://github.com/coder/coder/pull/5807/commits/b55e40281ed38e5b1e122f4fdfd5b94e03c987f3
b55e402https://github.com/coder/coder/pull/5807/commits/b55e40281ed38e5b1e122f4fdfd5b94e03c987f3
https://github.com/mtojek
fix: richParameterFilehttps://github.com/coder/coder/pull/5807/commits/f6dee95a8c0cff8cc4b8fe1e8bcb97796d03f93e
f6dee95https://github.com/coder/coder/pull/5807/commits/f6dee95a8c0cff8cc4b8fe1e8bcb97796d03f93e
https://github.com/mtojek
CLI: create unit testshttps://github.com/coder/coder/pull/5807/commits/f46cf48f9635e65a49ea4426cc74e3b38d143066
f46cf48https://github.com/coder/coder/pull/5807/commits/f46cf48f9635e65a49ea4426cc74e3b38d143066
https://github.com/mtojek
CLI: update testhttps://github.com/coder/coder/pull/5807/commits/40a4aa03eb584d7eeb94b5f74a0c36bf87b7f10a
40a4aa0https://github.com/coder/coder/pull/5807/commits/40a4aa03eb584d7eeb94b5f74a0c36bf87b7f10a
https://github.com/mtojek
Fixhttps://github.com/coder/coder/pull/5807/commits/1af7b9a78faaa6959f64f35dee8212a003192263
1af7b9ahttps://github.com/coder/coder/pull/5807/commits/1af7b9a78faaa6959f64f35dee8212a003192263
https://github.com/mtojek
Merge branch 'main' into 5574-cli-add-template-version-parametershttps://github.com/coder/coder/pull/5807/commits/d20626aea22c46dfc73e04e0ce6c123e079857fe
d20626ahttps://github.com/coder/coder/pull/5807/commits/d20626aea22c46dfc73e04e0ce6c123e079857fe
https://github.com/mtojek
fix: orderhttps://github.com/coder/coder/pull/5807/commits/8c989ee3adac6578bb28a910805f4ce0d0a51d93
8c989eehttps://github.com/coder/coder/pull/5807/commits/8c989ee3adac6578bb28a910805f4ce0d0a51d93
https://github.com/mtojek
fixhttps://github.com/coder/coder/pull/5807/commits/6dbd044f5a7c628c50d5b4b9773eff4db918d631
6dbd044https://github.com/coder/coder/pull/5807/commits/6dbd044f5a7c628c50d5b4b9773eff4db918d631
https://github.com/mtojek
feat: Validate workspace build parametershttps://github.com/coder/coder/pull/5807/commits/125d8616de78cfec6b3973e31453815f517d3c21
125d861https://github.com/coder/coder/pull/5807/commits/125d8616de78cfec6b3973e31453815f517d3c21
https://github.com/mtojek
mtojekhttps://github.com/mtojek
Jan 20, 2023https://github.com/coder/coder/pull/5807#event-8320829069
https://github.com/mtojek
mtojekhttps://github.com/mtojek
Jan 20, 2023 https://github.com/coder/coder/pull/5807#ref-issue-1519384712
Rich parameters #5574 https://github.com/coder/coder/issues/5574
mtojekhttps://github.com/mtojek
January 20, 2023 15:27https://github.com/coder/coder/pull/5807#commits-pushed-e278cc0
https://github.com/mtojek
Validator testshttps://github.com/coder/coder/pull/5807/commits/e278cc03debd62e5317edc688b4ee7fa6a39f0d2
e278cc0https://github.com/coder/coder/pull/5807/commits/e278cc03debd62e5317edc688b4ee7fa6a39f0d2
https://github.com/mtojek
WIP validationhttps://github.com/coder/coder/pull/5807/commits/b6c3cde6dd6b623cf59c4109651883e6fbc5103c
b6c3cdehttps://github.com/coder/coder/pull/5807/commits/b6c3cde6dd6b623cf59c4109651883e6fbc5103c
https://github.com/mtojek
Column: validation errorhttps://github.com/coder/coder/pull/5807/commits/5d6c54704be0e8823c5651bcca9830f51a1308cf
5d6c547https://github.com/coder/coder/pull/5807/commits/5d6c54704be0e8823c5651bcca9830f51a1308cf
https://github.com/mtojek
fixhttps://github.com/coder/coder/pull/5807/commits/f655603d5ea2b9a07bde0b5644a72476c3b2e13c
f655603https://github.com/coder/coder/pull/5807/commits/f655603d5ea2b9a07bde0b5644a72476c3b2e13c
https://github.com/mtojek
Merge branch 'main' into 5574-validation-ruleshttps://github.com/coder/coder/pull/5807/commits/178477120ced409e2b671c640be7d1cebe0a1208
1784771https://github.com/coder/coder/pull/5807/commits/178477120ced409e2b671c640be7d1cebe0a1208
https://github.com/mtojek
mergehttps://github.com/coder/coder/pull/5807/commits/f35ec025f317a79e27b72181fe651eab77c8bc36
f35ec02https://github.com/coder/coder/pull/5807/commits/f35ec025f317a79e27b72181fe651eab77c8bc36
https://github.com/mtojek
Fixhttps://github.com/coder/coder/pull/5807/commits/cfb1d4b10bba9945b579647f6c0cb827bb5fd94a
cfb1d4bhttps://github.com/coder/coder/pull/5807/commits/cfb1d4b10bba9945b579647f6c0cb827bb5fd94a
https://github.com/mtojek
fixhttps://github.com/coder/coder/pull/5807/commits/fc3e03942dbf07e1ccead2ff61b5be5a1fc97c78
fc3e039https://github.com/coder/coder/pull/5807/commits/fc3e03942dbf07e1ccead2ff61b5be5a1fc97c78
https://github.com/mtojek
fix: default nullhttps://github.com/coder/coder/pull/5807/commits/ebddd3cab86bed246d63719e41162f891323b063
ebddd3chttps://github.com/coder/coder/pull/5807/commits/ebddd3cab86bed246d63719e41162f891323b063
https://github.com/mtojek
Merge branch 'main' into 5574-validation-ruleshttps://github.com/coder/coder/pull/5807/commits/967edfc5c542fb6ac92e0bcd0a4862597dc7d076
967edfchttps://github.com/coder/coder/pull/5807/commits/967edfc5c542fb6ac92e0bcd0a4862597dc7d076
https://github.com/mtojek
CLI validationhttps://github.com/coder/coder/pull/5807/commits/cfd033037b820da039dcef993552d4ae3a2f5811
cfd0330https://github.com/coder/coder/pull/5807/commits/cfd033037b820da039dcef993552d4ae3a2f5811
mtojekhttps://github.com/mtojek
January 23, 2023 16:34https://github.com/coder/coder/pull/5807#commits-pushed-83ddace
https://github.com/mtojek
fmthttps://github.com/coder/coder/pull/5807/commits/83ddace3ea579e628ac4563b62b9b576a8cf0dc5
83ddacehttps://github.com/coder/coder/pull/5807/commits/83ddace3ea579e628ac4563b62b9b576a8cf0dc5
https://github.com/mtojek
fix: defaulthttps://github.com/coder/coder/pull/5807/commits/2e7c5f496d968a425f2068fa1b1846d488bd32f3
2e7c5f4https://github.com/coder/coder/pull/5807/commits/2e7c5f496d968a425f2068fa1b1846d488bd32f3
https://github.com/mtojek
Fixhttps://github.com/coder/coder/pull/5807/commits/f317891462a153c9abdcbc133a00b165bdde44c1
f317891https://github.com/coder/coder/pull/5807/commits/f317891462a153c9abdcbc133a00b165bdde44c1
https://github.com/mtojek
Pull new version of terraform-provider-coderhttps://github.com/coder/coder/pull/5807/commits/695680e29d2c59365a88353dbe3eb2ad38dabd9a
695680ehttps://github.com/coder/coder/pull/5807/commits/695680e29d2c59365a88353dbe3eb2ad38dabd9a
https://github.com/mtojek
go modhttps://github.com/coder/coder/pull/5807/commits/1e5b776c058120c9660b38dd74ca3c1647ee04fe
1e5b776https://github.com/coder/coder/pull/5807/commits/1e5b776c058120c9660b38dd74ca3c1647ee04fe
https://github.com/mtojek
CLIhttps://github.com/coder/coder/pull/5807/commits/fb0ee7396796a9b7504fe626683e8624875a05f3
fb0ee73https://github.com/coder/coder/pull/5807/commits/fb0ee7396796a9b7504fe626683e8624875a05f3
https://github.com/mtojek
Fixhttps://github.com/coder/coder/pull/5807/commits/0b426b86a6d3fa30f0123c2782b51a55d402ed1d
0b426b8https://github.com/coder/coder/pull/5807/commits/0b426b86a6d3fa30f0123c2782b51a55d402ed1d
https://github.com/mtojek
TestCreateValidateRichParametershttps://github.com/coder/coder/pull/5807/commits/d347b6889c9dadf91a686e22bd783d81002acf29
d347b68https://github.com/coder/coder/pull/5807/commits/d347b6889c9dadf91a686e22bd783d81002acf29
https://github.com/mtojek
CLI testshttps://github.com/coder/coder/pull/5807/commits/228d80665d395e67847f0c165942cd3784ac243e
228d806https://github.com/coder/coder/pull/5807/commits/228d80665d395e67847f0c165942cd3784ac243e
https://github.com/mtojek
Merge branch 'main' into 5574-validation-ruleshttps://github.com/coder/coder/pull/5807/commits/8c5bc6b475bae004b910017868a8e5161e888951
8c5bc6bhttps://github.com/coder/coder/pull/5807/commits/8c5bc6b475bae004b910017868a8e5161e888951
https://github.com/mtojek
mtojekhttps://github.com/mtojek
January 24, 2023 12:48https://github.com/coder/coder/pull/5807#event-8343907958
https://github.com/mtojek
mtojekhttps://github.com/mtojek
kylecarbshttps://github.com/kylecarbs
January 24, 2023 12:48https://github.com/coder/coder/pull/5807#event-8343907965
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
Jan 24, 2023 https://github.com/coder/coder/pull/5807#pullrequestreview-1267486100
View reviewed changes https://github.com/coder/coder/pull/5807/files/8c5bc6b475bae004b910017868a8e5161e888951
kylecarbshttps://github.com/kylecarbs
https://github.com/coder/coder/pull/5807#pullrequestreview-1267486100
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/5807
https://github.com/mtojek
mtojekhttps://github.com/mtojek
26c6952https://github.com/coder/coder/commit/26c69525d1ffd015d2d9c6b0b0b92de20f3dcaaa
Jan 24, 2023https://github.com/coder/coder/pull/5807#event-8344221012
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 24, 2023https://github.com/coder/coder/pull/5807#event-8344223723
https://github.com/bpmct
bpmcthttps://github.com/bpmct
Rich Parameters GAhttps://github.com/coder/coder/milestone/11
Feb 28, 2023https://github.com/coder/coder/pull/5807#event-8628326519
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F5807
https://github.com/kylecarbs
kylecarbs https://github.com/kylecarbs
https://github.com/coder/coder/pull/5807/files/8c5bc6b475bae004b910017868a8e5161e888951
Please reload this pagehttps://github.com/coder/coder/pull/5807
https://github.com/mtojek
mtojek https://github.com/mtojek
Rich Parameters GA https://github.com/coder/coder/milestone/11
Please reload this pagehttps://github.com/coder/coder/pull/5807
https://github.com/mtojek
https://github.com/kylecarbs
https://github.com/bpmct
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.