René's URL Explorer Experiment


Title: fix: do not skip properties on creating templates by mtojek · Pull Request #5060 · coder/coder · GitHub

Open Graph Title: fix: do not skip properties on creating templates by mtojek · Pull Request #5060 · coder/coder

X Title: fix: do not skip properties on creating templates by mtojek · Pull Request #5060 · coder/coder

Description: Secure environments for developers and their agents - fix: do not skip properties on creating templates by mtojek · Pull Request #5060 · coder/coder

Open Graph Description: While working on #3321 I found that POST /templates rejects properties, even though the API contract expects it. This PR fixes the behavior.

X Description: While working on #3321 I found that POST /templates rejects properties, even though the API contract expects it. This PR fixes the behavior.

Opengraph URL: https://github.com/coder/coder/pull/5060

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e78f66b2-e7a9-b068-2fef-b59684ee42eb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA78C:DA744:257A5DB:327616E:6B01B1C7
html-safe-nonceb4259ba154379d6bc4fe9560d4a975d94763dc1a3bb83bd5cf0f2680e9d0e269
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzhDOkRBNzQ0OjI1N0E1REI6MzI3NjE2RTo2QjAxQjFDNyIsInZpc2l0b3JfaWQiOiIxMTE2NzczOTA2MjkyNzgxNTExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2ab9bbfdbb058e5c6885447fbaf5fe6c7f67b3399dbd20859417221856b9cee3
hovercard-subject-tagpull_request:1121167206
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/5060/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5fc0ed0e90f088780e52986043d0785e8bba95dd4a2944552990c56ff728d010/coder/coder/pull/5060
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5fc0ed0e90f088780e52986043d0785e8bba95dd4a2944552990c56ff728d010/coder/coder/pull/5060
og:image:altWhile working on #3321 I found that POST /templates rejects properties, even though the API contract expects it. This PR fixes the behavior.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemtojek
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/5060#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F5060
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F5060
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/5060
Reloadhttps://github.com/coder/coder/pull/5060
Reloadhttps://github.com/coder/coder/pull/5060
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
mtojekhttps://github.com/mtojek
coder:mainhttps://github.com/coder/coder/tree/main
mtojek:3321-template-space-chttps://github.com/mtojek/coder/tree/3321-template-space-c
Conversationhttps://github.com/coder/coder/pull/5060
Commits2 (2)https://github.com/coder/coder/pull/5060/commits
Checkshttps://github.com/coder/coder/pull/5060/checks
Files changedhttps://github.com/coder/coder/pull/5060/files
fix: do not skip properties on creating templateshttps://github.com/coder/coder/pull/5060#top
mtojekhttps://github.com/mtojek
coder:mainhttps://github.com/coder/coder/tree/main
mtojek:3321-template-space-chttps://github.com/mtojek/coder/tree/3321-template-space-c
https://github.com/mtojek
mtojekhttps://github.com/mtojek
Nov 14, 2022https://github.com/coder/coder/pull/5060#issue-1447839786
#3321https://github.com/coder/coder/issues/3321
API contracthttps://github.com/coder/coder/blob/main/codersdk/organizations.go#L50
Please reload this pagehttps://github.com/coder/coder/pull/5060
mtojekhttps://github.com/mtojek
November 14, 2022 11:22https://github.com/coder/coder/pull/5060#commits-pushed-d7a7b81
https://github.com/mtojek
fix: do not skip properties while creating templateshttps://github.com/coder/coder/pull/5060/commits/d7a7b81ddf9ffff704d7161fb31096e305a7e4d6
d7a7b81https://github.com/coder/coder/pull/5060/commits/d7a7b81ddf9ffff704d7161fb31096e305a7e4d6
https://github.com/mtojek
test: empty edithttps://github.com/coder/coder/pull/5060/commits/a9109c232501f32b1db515d4d88dd94968c6fde7
a9109c2https://github.com/coder/coder/pull/5060/commits/a9109c232501f32b1db515d4d88dd94968c6fde7
https://github.com/mtojek
mtojekhttps://github.com/mtojek
Nov 14, 2022https://github.com/coder/coder/pull/5060#event-7802920292
https://github.com/mtojek
mtojekhttps://github.com/mtojek
Nov 14, 2022 https://github.com/coder/coder/pull/5060#pullrequestreview-1178864174
View reviewed changes https://github.com/coder/coder/pull/5060/files/a9109c232501f32b1db515d4d88dd94968c6fde7
cli/templateedit_test.gohttps://github.com/coder/coder/pull/5060/files/a9109c232501f32b1db515d4d88dd94968c6fde7#diff-087e6c191c7c8e24258dae57dfe0c1c23b094fd24f2936dd11497d378ead311a
mtojekhttps://github.com/mtojek
Nov 14, 2022https://github.com/coder/coder/pull/5060#discussion_r1021361289
Please reload this pagehttps://github.com/coder/coder/pull/5060
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/5060
mafredrihttps://github.com/mafredri
Nov 14, 2022https://github.com/coder/coder/pull/5060#discussion_r1021577688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
coder/coderd/templates.gohttps://github.com/coder/coder/blob/4b3d211e004ec5e4a3b30f98ca3c3e8ec687168a/coderd/templates.go#L481-L496
4b3d211https://github.com/coder/coder/commit/4b3d211e004ec5e4a3b30f98ca3c3e8ec687168a
Please reload this pagehttps://github.com/coder/coder/pull/5060
mtojekhttps://github.com/mtojek
Nov 14, 2022https://github.com/coder/coder/pull/5060#discussion_r1021613936
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#5066https://github.com/coder/coder/issues/5066
Please reload this pagehttps://github.com/coder/coder/pull/5060
https://github.com/mtojek
mtojekhttps://github.com/mtojek
November 14, 2022 11:13https://github.com/coder/coder/pull/5060#event-7803035521
https://github.com/mtojek
mtojekhttps://github.com/mtojek
November 14, 2022 11:13https://github.com/coder/coder/pull/5060#event-7803036669
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Nov 14, 2022 https://github.com/coder/coder/pull/5060#pullrequestreview-1179163760
View reviewed changes https://github.com/coder/coder/pull/5060/files/a9109c232501f32b1db515d4d88dd94968c6fde7
cli/templateedit_test.gohttps://github.com/coder/coder/pull/5060/files/a9109c232501f32b1db515d4d88dd94968c6fde7#diff-087e6c191c7c8e24258dae57dfe0c1c23b094fd24f2936dd11497d378ead311a
mafredrihttps://github.com/mafredri
Nov 14, 2022https://github.com/coder/coder/pull/5060#discussion_r1021577688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
coder/coderd/templates.gohttps://github.com/coder/coder/blob/4b3d211e004ec5e4a3b30f98ca3c3e8ec687168a/coderd/templates.go#L481-L496
4b3d211https://github.com/coder/coder/commit/4b3d211e004ec5e4a3b30f98ca3c3e8ec687168a
Please reload this pagehttps://github.com/coder/coder/pull/5060
https://github.com/mtojek
mtojekhttps://github.com/mtojek
Nov 14, 2022 https://github.com/coder/coder/pull/5060#ref-issue-1448179474
bug: template settings and inconsistent API behavior ("empty field" vs "delete request") #5066 https://github.com/coder/coder/issues/5066
https://github.com/mtojek
mtojekhttps://github.com/mtojek
cf5d48bhttps://github.com/coder/coder/commit/cf5d48bb5a452c6ca278828d387238e61216d2bf
Nov 14, 2022https://github.com/coder/coder/pull/5060#event-7804818144
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 14, 2022https://github.com/coder/coder/pull/5060#event-7804821199
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F5060
https://github.com/mafredri
mafredri https://github.com/mafredri
https://github.com/coder/coder/pull/5060/files/a9109c232501f32b1db515d4d88dd94968c6fde7
Please reload this pagehttps://github.com/coder/coder/pull/5060
https://github.com/mtojek
mtojek https://github.com/mtojek
Please reload this pagehttps://github.com/coder/coder/pull/5060
https://github.com/mtojek
https://github.com/mafredri
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.