René's URL Explorer Experiment


Title: fix: ensure deleting workspace creates audit log by Kira-Pilot · Pull Request #4537 · coder/coder · GitHub

Open Graph Title: fix: ensure deleting workspace creates audit log by Kira-Pilot · Pull Request #4537 · coder/coder

X Title: fix: ensure deleting workspace creates audit log by Kira-Pilot · Pull Request #4537 · coder/coder

Description: Secure environments for developers and their agents - fix: ensure deleting workspace creates audit log by Kira-Pilot · Pull Request #4537 · coder/coder

Open Graph Description: partially fixes #4316 We weren't create Audit Log entries when deleting a workspace. Now we are:

X Description: partially fixes #4316 We weren't create Audit Log entries when deleting a workspace. Now we are:

Opengraph URL: https://github.com/coder/coder/pull/4537

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:942fc8b3-0823-5dcc-94ec-3255503b4f38
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idADB4:2E3FEE:2CCA6C8:38B9EC0:6B01B1C1
html-safe-noncedd1cb5401a75f74eab86c3b8ea0108f62d947bfbe056401e786ce2f0ca5230fd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREI0OjJFM0ZFRToyQ0NBNkM4OjM4QjlFQzA6NkIwMUIxQzEiLCJ2aXNpdG9yX2lkIjoiMjMzMDU1MzU0NzAwMDc1NDYyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac45de3d9d94cbc45185481d60222abfc5d71b636ea9a662c29794287c8208470c
hovercard-subject-tagpull_request:1086491837
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/4537/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/43678af28cb2ebd34f42203475b39c0f7eb9d7af9b3b46412edbd2a6d1541aeb/coder/coder/pull/4537
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/43678af28cb2ebd34f42203475b39c0f7eb9d7af9b3b46412edbd2a6d1541aeb/coder/coder/pull/4537
og:image:altpartially fixes #4316 We weren't create Audit Log entries when deleting a workspace. Now we are:
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameKira-Pilot
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/4537#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F4537
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F4537
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/4537
Reloadhttps://github.com/coder/coder/pull/4537
Reloadhttps://github.com/coder/coder/pull/4537
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
Kira-Pilothttps://github.com/Kira-Pilot
mainhttps://github.com/coder/coder/tree/main
audit-log-delete-workspace/kira-pilothttps://github.com/coder/coder/tree/audit-log-delete-workspace/kira-pilot
Conversationhttps://github.com/coder/coder/pull/4537
Commits5 (5)https://github.com/coder/coder/pull/4537/commits
Checkshttps://github.com/coder/coder/pull/4537/checks
Files changedhttps://github.com/coder/coder/pull/4537/files
fix: ensure deleting workspace creates audit loghttps://github.com/coder/coder/pull/4537#top
Kira-Pilothttps://github.com/Kira-Pilot
mainhttps://github.com/coder/coder/tree/main
audit-log-delete-workspace/kira-pilothttps://github.com/coder/coder/tree/audit-log-delete-workspace/kira-pilot
https://github.com/Kira-Pilot
Kira-Pilothttps://github.com/Kira-Pilot
Oct 13, 2022https://github.com/coder/coder/pull/4537#issue-1408253668
#4316https://github.com/coder/coder/issues/4316
https://user-images.githubusercontent.com/19142439/195678167-3b9cda70-1393-4561-9516-6fa211e73cd3.png
Please reload this pagehttps://github.com/coder/coder/pull/4537
Kira-Pilothttps://github.com/Kira-Pilot
October 13, 2022 18:31https://github.com/coder/coder/pull/4537#commits-pushed-b8998dd
https://github.com/Kira-Pilot
fix: ensure deleting workspace creates audit loghttps://github.com/coder/coder/pull/4537/commits/b8998dd01baec0783a70cd8579fbe534f96254bf
b8998ddhttps://github.com/coder/coder/pull/4537/commits/b8998dd01baec0783a70cd8579fbe534f96254bf
https://github.com/Kira-Pilot
getting rid of commentshttps://github.com/coder/coder/pull/4537/commits/94f32563eb900a950b65e12afc5ff75c46ee728b
94f3256https://github.com/coder/coder/pull/4537/commits/94f32563eb900a950b65e12afc5ff75c46ee728b
https://github.com/Kira-Pilot
remove whitespacehttps://github.com/coder/coder/pull/4537/commits/76f8d6f48218733232299a73aa90b22e6a87cad4
76f8d6fhttps://github.com/coder/coder/pull/4537/commits/76f8d6f48218733232299a73aa90b22e6a87cad4
https://github.com/Kira-Pilot
Kira-Pilothttps://github.com/Kira-Pilot
coadlerhttps://github.com/coadler
October 13, 2022 18:35https://github.com/coder/coder/pull/4537#event-7584054269
https://github.com/Kira-Pilot
Kira-Pilothttps://github.com/Kira-Pilot
Oct 13, 2022 https://github.com/coder/coder/pull/4537#pullrequestreview-1141317661
View reviewed changes https://github.com/coder/coder/pull/4537/files/94f32563eb900a950b65e12afc5ff75c46ee728b
coderd/workspacebuilds.gohttps://github.com/coder/coder/pull/4537/files/94f32563eb900a950b65e12afc5ff75c46ee728b#diff-798ff0da9c879a2067b17793a37b78dc954c7055bea94df7a3c4e6356eb04fab
Please reload this pagehttps://github.com/coder/coder/pull/4537
https://github.com/Kira-Pilot
pushing failing testhttps://github.com/coder/coder/pull/4537/commits/3065cacc11ac17faaed2206ce1a4f5f4da4ca442
3065cachttps://github.com/coder/coder/pull/4537/commits/3065cacc11ac17faaed2206ce1a4f5f4da4ca442
https://github.com/coadler
coadlerhttps://github.com/coadler
Oct 13, 2022 https://github.com/coder/coder/pull/4537#pullrequestreview-1141476169
View reviewed changes https://github.com/coder/coder/pull/4537/files/3065cacc11ac17faaed2206ce1a4f5f4da4ca442
coderd/workspacebuilds_test.gohttps://github.com/coder/coder/pull/4537/files/3065cacc11ac17faaed2206ce1a4f5f4da4ca442#diff-81081239b93aaa61eb8d180a5f9870fda8f0ab5cb4c6727d9d1636aa933e597b
Please reload this pagehttps://github.com/coder/coder/pull/4537
https://github.com/Kira-Pilot
fixed testhttps://github.com/coder/coder/pull/4537/commits/aea2e73c10387a0fe887e708705624ece718207f
aea2e73https://github.com/coder/coder/pull/4537/commits/aea2e73c10387a0fe887e708705624ece718207f
https://github.com/coadler
coadlerhttps://github.com/coadler
Oct 13, 2022 https://github.com/coder/coder/pull/4537#pullrequestreview-1141593435
View reviewed changes https://github.com/coder/coder/pull/4537/files/aea2e73c10387a0fe887e708705624ece718207f
https://github.com/Kira-Pilot
Kira-Pilothttps://github.com/Kira-Pilot
bf0aca3https://github.com/coder/coder/commit/bf0aca35fa0b8ae1aba85edc8deec322948661db
Oct 14, 2022https://github.com/coder/coder/pull/4537#event-7590592173
https://github.com/Kira-Pilot
Kira-Pilothttps://github.com/Kira-Pilot
October 14, 2022 13:47https://github.com/coder/coder/pull/4537#event-7590592326
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 14, 2022https://github.com/coder/coder/pull/4537#event-7590594103
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F4537
https://github.com/coadler
coadler https://github.com/coadler
https://github.com/coder/coder/pull/4537/files/aea2e73c10387a0fe887e708705624ece718207f
Please reload this pagehttps://github.com/coder/coder/pull/4537
audit: I deleted a workspace but the audit logs did not record it. https://github.com/coder/coder/issues/4316
Please reload this pagehttps://github.com/coder/coder/pull/4537
https://github.com/Kira-Pilot
https://github.com/coadler
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.