René's URL Explorer Experiment


Title: fix: Allow terraform provisions to be gracefully cancelled by mafredri · Pull Request #3526 · coder/coder · GitHub

Open Graph Title: fix: Allow terraform provisions to be gracefully cancelled by mafredri · Pull Request #3526 · coder/coder

X Title: fix: Allow terraform provisions to be gracefully cancelled by mafredri · Pull Request #3526 · coder/coder

Description: Secure environments for developers and their agents - fix: Allow terraform provisions to be gracefully cancelled by mafredri · Pull Request #3526 · coder/coder

Open Graph Description: This change allows terraform commands to be gracefully cancelled on Unix-like platforms by signaling interrupt on provision cancellation. One implementation detail to note is that we do not necessa...

X Description: This change allows terraform commands to be gracefully cancelled on Unix-like platforms by signaling interrupt on provision cancellation. One implementation detail to note is that we do not necessa...

Opengraph URL: https://github.com/coder/coder/pull/3526

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9c2a4fd8-9d4a-9458-5bd3-469b011f3755
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE47E:3A73AA:1A517DE:214F724:6B018914
html-safe-nonce6760c8363000ccb54421be7581c737f3d2e8dfae09419b2e1708bb3c078e98e0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDdFOjNBNzNBQToxQTUxN0RFOjIxNEY3MjQ6NkIwMTg5MTQiLCJ2aXNpdG9yX2lkIjoiMjg0NDUzNTc2OTgwNDAwNDA0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfe78ede2f2ebd5509b63d9d58542b22d0f7fdb845767f7ff83ac16f6c7263949
hovercard-subject-tagpull_request:1027731948
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/3526/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ee79ceaab1a72e3697246297451de28c1370a5474db158ce7fbba0c79c065ac0/coder/coder/pull/3526
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ee79ceaab1a72e3697246297451de28c1370a5474db158ce7fbba0c79c065ac0/coder/coder/pull/3526
og:image:altThis change allows terraform commands to be gracefully cancelled on Unix-like platforms by signaling interrupt on provision cancellation. One implementation detail to note is that we do not necessa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemafredri
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/3526#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3526
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3526
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/3526
Reloadhttps://github.com/coder/coder/pull/3526
Reloadhttps://github.com/coder/coder/pull/3526
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/fix-terraform-cancellationhttps://github.com/coder/coder/tree/mafredri/fix-terraform-cancellation
Conversationhttps://github.com/coder/coder/pull/3526
Commits14 (14)https://github.com/coder/coder/pull/3526/commits
Checkshttps://github.com/coder/coder/pull/3526/checks
Files changedhttps://github.com/coder/coder/pull/3526/files
fix: Allow terraform provisions to be gracefully cancelledhttps://github.com/coder/coder/pull/3526#top
mafredrihttps://github.com/mafredri
mainhttps://github.com/coder/coder/tree/main
mafredri/fix-terraform-cancellationhttps://github.com/coder/coder/tree/mafredri/fix-terraform-cancellation
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Aug 16, 2022https://github.com/coder/coder/pull/3526#issue-1340477833
Please reload this pagehttps://github.com/coder/coder/pull/3526
#2683https://github.com/coder/coder/issues/2683
Please reload this pagehttps://github.com/coder/coder/pull/3526
https://github.com/mafredri
fix: Allow terraform provisions to be gracefully cancelledhttps://github.com/coder/coder/pull/3526/commits/fd47d05975a0a30a16c37afc106c64f7f5690a3d
fd47d05https://github.com/coder/coder/pull/3526/commits/fd47d05975a0a30a16c37afc106c64f7f5690a3d
#2683https://github.com/coder/coder/issues/2683
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Aug 16, 2022https://github.com/coder/coder/pull/3526#event-7198005927
https://github.com/mafredri
mafredrihttps://github.com/mafredri
kylecarbshttps://github.com/kylecarbs
spikecurtishttps://github.com/spikecurtis
August 16, 2022 14:50https://github.com/coder/coder/pull/3526#event-7198006035
mafredrihttps://github.com/mafredri
August 16, 2022 17:58https://github.com/coder/coder/pull/3526#commits-pushed-72f723e
https://github.com/mafredri
Cleanuphttps://github.com/coder/coder/pull/3526/commits/72f723e7a21ef02f3413e55750edda15e479d51d
72f723ehttps://github.com/coder/coder/pull/3526/commits/72f723e7a21ef02f3413e55750edda15e479d51d
https://github.com/mafredri
Revert protoc version bumpshttps://github.com/coder/coder/pull/3526/commits/00c774630105e2b956a3614bb7ca7a97f938b92e
00c7746https://github.com/coder/coder/pull/3526/commits/00c774630105e2b956a3614bb7ca7a97f938b92e
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
Aug 16, 2022https://github.com/coder/coder/pull/3526#issuecomment-1216760193
Please reload this pagehttps://github.com/coder/coder/pull/3526
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Aug 16, 2022https://github.com/coder/coder/pull/3526#issuecomment-1216768131
Please reload this pagehttps://github.com/coder/coder/pull/3526
Please reload this pagehttps://github.com/coder/coder/pull/3526
mafredrihttps://github.com/mafredri
August 16, 2022 18:12https://github.com/coder/coder/pull/3526#commits-pushed-7df45e1
https://github.com/mafredri
fix: Remove unused import from Windowshttps://github.com/coder/coder/pull/3526/commits/7df45e12e5ca819c0385a5c79e457bfc057411d0
7df45e1https://github.com/coder/coder/pull/3526/commits/7df45e12e5ca819c0385a5c79e457bfc057411d0
https://github.com/mafredri
fix: Add build tagshttps://github.com/coder/coder/pull/3526/commits/211b7f9f179671878611a2d0c15300b632135c16
211b7f9https://github.com/coder/coder/pull/3526/commits/211b7f9f179671878611a2d0c15300b632135c16
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
Aug 16, 2022 https://github.com/coder/coder/pull/3526#pullrequestreview-1074398630
View reviewed changes https://github.com/coder/coder/pull/3526/files/211b7f9f179671878611a2d0c15300b632135c16
kylecarbshttps://github.com/kylecarbs
https://github.com/coder/coder/pull/3526#pullrequestreview-1074398630
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3526
provisioner/terraform/executor_unix.gohttps://github.com/coder/coder/pull/3526/files/211b7f9f179671878611a2d0c15300b632135c16#diff-e1c8f06adf3d0b1ace26c91450141435345084426e9d58bbfc18e8ec8c7745c1
Please reload this pagehttps://github.com/coder/coder/pull/3526
provisioner/terraform/provision.gohttps://github.com/coder/coder/pull/3526/files/211b7f9f179671878611a2d0c15300b632135c16#diff-dca5a09c8a826c7364d136c1eedf2e33534b9ec33da1cfe008f2d7ff669f95bf
Please reload this pagehttps://github.com/coder/coder/pull/3526
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Aug 16, 2022https://github.com/coder/coder/pull/3526#issuecomment-1216882033
Please reload this pagehttps://github.com/coder/coder/pull/3526
Please reload this pagehttps://github.com/coder/coder/pull/3526
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
Aug 16, 2022 https://github.com/coder/coder/pull/3526#pullrequestreview-1074450718
View reviewed changes https://github.com/coder/coder/pull/3526/files/211b7f9f179671878611a2d0c15300b632135c16
mafredrihttps://github.com/mafredri
August 16, 2022 19:58https://github.com/coder/coder/pull/3526#commits-pushed-3121f6a
https://github.com/mafredri
fix: Amend PR commentshttps://github.com/coder/coder/pull/3526/commits/3121f6ac57360f6712967c5f5920bc1b72789f2a
3121f6ahttps://github.com/coder/coder/pull/3526/commits/3121f6ac57360f6712967c5f5920bc1b72789f2a
https://github.com/mafredri
chore: Revert proto changeshttps://github.com/coder/coder/pull/3526/commits/27fe6f0f84cf551237128c3ae0a919154c288712
27fe6f0https://github.com/coder/coder/pull/3526/commits/27fe6f0f84cf551237128c3ae0a919154c288712
https://github.com/mafredri
chore: Revert newline in protohttps://github.com/coder/coder/pull/3526/commits/1d7f825236560caea4aeae98d0952a901e0d42b8
1d7f825https://github.com/coder/coder/pull/3526/commits/1d7f825236560caea4aeae98d0952a901e0d42b8
https://github.com/mafredri
fix: Remove incorrect minimumTerraformVersion variablehttps://github.com/coder/coder/pull/3526/commits/5cbb7123fd8eff04b4eacfccf49fc35f4a6ac10d
5cbb712https://github.com/coder/coder/pull/3526/commits/5cbb7123fd8eff04b4eacfccf49fc35f4a6ac10d
https://github.com/mafredri
fix: Add ExitTimeout to terraform.ServeOptionshttps://github.com/coder/coder/pull/3526/commits/3e4005ad10853c35fb7d127f91f3c874b90d8685
3e4005ahttps://github.com/coder/coder/pull/3526/commits/3e4005ad10853c35fb7d127f91f3c874b90d8685
https://github.com/mafredri
fix: Add test for interrupt/cancellationhttps://github.com/coder/coder/pull/3526/commits/685c58326192076bc7213c38f7b36cb8f2777083
685c583https://github.com/coder/coder/pull/3526/commits/685c58326192076bc7213c38f7b36cb8f2777083
https://github.com/mafredri
Allow init to return provision complete responsehttps://github.com/coder/coder/pull/3526/commits/3303ee1a7ba1887029ca6ee966af8a6bc249d961
3303ee1https://github.com/coder/coder/pull/3526/commits/3303ee1a7ba1887029ca6ee966af8a6bc249d961
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Aug 17, 2022 https://github.com/coder/coder/pull/3526#pullrequestreview-1075655536
View reviewed changes https://github.com/coder/coder/pull/3526/files/3303ee1a7ba1887029ca6ee966af8a6bc249d961
provisioner/terraform/provision.gohttps://github.com/coder/coder/pull/3526/files/3303ee1a7ba1887029ca6ee966af8a6bc249d961#diff-dca5a09c8a826c7364d136c1eedf2e33534b9ec33da1cfe008f2d7ff669f95bf
mafredrihttps://github.com/mafredri
Aug 17, 2022https://github.com/coder/coder/pull/3526#discussion_r947883583
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@kylecarbshttps://github.com/kylecarbs
Please reload this pagehttps://github.com/coder/coder/pull/3526
kylecarbshttps://github.com/kylecarbs
Aug 17, 2022https://github.com/coder/coder/pull/3526#discussion_r948355135
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3526
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Aug 17, 2022https://github.com/coder/coder/pull/3526#issuecomment-1217961502
Please reload this pagehttps://github.com/coder/coder/pull/3526
mafredrihttps://github.com/mafredri
August 17, 2022 15:46https://github.com/coder/coder/pull/3526#commits-pushed-db41a65
https://github.com/mafredri
Add testdata scripthttps://github.com/coder/coder/pull/3526/commits/db41a6518ca16086abc5c8ab5dcae7fd69a15fbb
db41a65https://github.com/coder/coder/pull/3526/commits/db41a6518ca16086abc5c8ab5dcae7fd69a15fbb
https://github.com/mafredri
Remove superfluous requirehttps://github.com/coder/coder/pull/3526/commits/80a4912e9e9426a62929a870daa2d6fc573d4377
80a4912https://github.com/coder/coder/pull/3526/commits/80a4912e9e9426a62929a870daa2d6fc573d4377
https://github.com/mafredri
mafredrihttps://github.com/mafredri
f142345https://github.com/coder/coder/commit/f1423450bda74ba1e5258bc11a09c3bf61e2ee89
Aug 18, 2022https://github.com/coder/coder/pull/3526#event-7214712948
https://github.com/mafredri
mafredrihttps://github.com/mafredri
August 18, 2022 14:03https://github.com/coder/coder/pull/3526#event-7214713047
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Aug 18, 2022 https://github.com/coder/coder/pull/3526#ref-issue-1285748126
Workspace goes to failed state and cannot be started, stopped or deleted after cancel-start->stop->start actions #2683 https://github.com/coder/coder/issues/2683
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
Aug 24, 2022 https://github.com/coder/coder/pull/3526#ref-issue-1267912329
What to do when workspace is state-bricked? #2256 https://github.com/coder/coder/issues/2256
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3526
https://github.com/kylecarbs
kylecarbs https://github.com/kylecarbs
https://github.com/coder/coder/pull/3526/files/3303ee1a7ba1887029ca6ee966af8a6bc249d961
https://github.com/spikecurtis
spikecurtis https://github.com/spikecurtis
Please reload this pagehttps://github.com/coder/coder/pull/3526
https://github.com/mafredri
mafredri https://github.com/mafredri
Please reload this pagehttps://github.com/coder/coder/pull/3526
https://github.com/mafredri
https://github.com/kylecarbs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.