| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9c2a4fd8-9d4a-9458-5bd3-469b011f3755 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E47E:3A73AA:1A517DE:214F724:6B018914 |
| html-safe-nonce | 6760c8363000ccb54421be7581c737f3d2e8dfae09419b2e1708bb3c078e98e0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDdFOjNBNzNBQToxQTUxN0RFOjIxNEY3MjQ6NkIwMTg5MTQiLCJ2aXNpdG9yX2lkIjoiMjg0NDUzNTc2OTgwNDAwNDA0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | fe78ede2f2ebd5509b63d9d58542b22d0f7fdb845767f7ff83ac16f6c7263949 |
| hovercard-subject-tag | pull_request:1027731948 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/3526/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ee79ceaab1a72e3697246297451de28c1370a5474db158ce7fbba0c79c065ac0/coder/coder/pull/3526 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ee79ceaab1a72e3697246297451de28c1370a5474db158ce7fbba0c79c065ac0/coder/coder/pull/3526 |
| og:image:alt | This change allows terraform commands to be gracefully cancelled on
Unix-like platforms by signaling interrupt on provision cancellation.
One implementation detail to note is that we do not necessa... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mafredri |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/3526#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3526 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3526 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/3526 |
| Reload | https://github.com/coder/coder/pull/3526 |
| Reload | https://github.com/coder/coder/pull/3526 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| mafredri | https://github.com/mafredri |
| main | https://github.com/coder/coder/tree/main |
| mafredri/fix-terraform-cancellation | https://github.com/coder/coder/tree/mafredri/fix-terraform-cancellation |
| Conversation | https://github.com/coder/coder/pull/3526 |
| Commits14 (14) | https://github.com/coder/coder/pull/3526/commits |
| Checks | https://github.com/coder/coder/pull/3526/checks |
| Files changed | https://github.com/coder/coder/pull/3526/files |
| fix: Allow terraform provisions to be gracefully cancelled | https://github.com/coder/coder/pull/3526#top |
| mafredri | https://github.com/mafredri |
| main | https://github.com/coder/coder/tree/main |
| mafredri/fix-terraform-cancellation | https://github.com/coder/coder/tree/mafredri/fix-terraform-cancellation |
|
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Aug 16, 2022 | https://github.com/coder/coder/pull/3526#issue-1340477833 |
| Please reload this page | https://github.com/coder/coder/pull/3526 |
| #2683 | https://github.com/coder/coder/issues/2683 |
| Please reload this page | https://github.com/coder/coder/pull/3526 |
|
| https://github.com/mafredri |
| fix: Allow terraform provisions to be gracefully cancelled | https://github.com/coder/coder/pull/3526/commits/fd47d05975a0a30a16c37afc106c64f7f5690a3d |
| fd47d05 | https://github.com/coder/coder/pull/3526/commits/fd47d05975a0a30a16c37afc106c64f7f5690a3d |
| #2683 | https://github.com/coder/coder/issues/2683 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Aug 16, 2022 | https://github.com/coder/coder/pull/3526#event-7198005927 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| kylecarbs | https://github.com/kylecarbs |
| spikecurtis | https://github.com/spikecurtis |
| August 16, 2022 14:50 | https://github.com/coder/coder/pull/3526#event-7198006035 |
| mafredri | https://github.com/mafredri |
| August 16, 2022 17:58 | https://github.com/coder/coder/pull/3526#commits-pushed-72f723e |
|
| https://github.com/mafredri |
| Cleanup | https://github.com/coder/coder/pull/3526/commits/72f723e7a21ef02f3413e55750edda15e479d51d |
| 72f723e | https://github.com/coder/coder/pull/3526/commits/72f723e7a21ef02f3413e55750edda15e479d51d |
|
| https://github.com/mafredri |
| Revert protoc version bumps | https://github.com/coder/coder/pull/3526/commits/00c774630105e2b956a3614bb7ca7a97f938b92e |
| 00c7746 | https://github.com/coder/coder/pull/3526/commits/00c774630105e2b956a3614bb7ca7a97f938b92e |
| https://github.com/kylecarbs |
| kylecarbs | https://github.com/kylecarbs |
| Aug 16, 2022 | https://github.com/coder/coder/pull/3526#issuecomment-1216760193 |
| Please reload this page | https://github.com/coder/coder/pull/3526 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Aug 16, 2022 | https://github.com/coder/coder/pull/3526#issuecomment-1216768131 |
| Please reload this page | https://github.com/coder/coder/pull/3526 |
| Please reload this page | https://github.com/coder/coder/pull/3526 |
| mafredri | https://github.com/mafredri |
| August 16, 2022 18:12 | https://github.com/coder/coder/pull/3526#commits-pushed-7df45e1 |
|
| https://github.com/mafredri |
| fix: Remove unused import from Windows | https://github.com/coder/coder/pull/3526/commits/7df45e12e5ca819c0385a5c79e457bfc057411d0 |
| 7df45e1 | https://github.com/coder/coder/pull/3526/commits/7df45e12e5ca819c0385a5c79e457bfc057411d0 |
|
| https://github.com/mafredri |
| fix: Add build tags | https://github.com/coder/coder/pull/3526/commits/211b7f9f179671878611a2d0c15300b632135c16 |
| 211b7f9 | https://github.com/coder/coder/pull/3526/commits/211b7f9f179671878611a2d0c15300b632135c16 |
| https://github.com/kylecarbs |
| kylecarbs | https://github.com/kylecarbs |
|
Aug 16, 2022
| https://github.com/coder/coder/pull/3526#pullrequestreview-1074398630 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3526/files/211b7f9f179671878611a2d0c15300b632135c16 |
| kylecarbs | https://github.com/kylecarbs |
| https://github.com/coder/coder/pull/3526#pullrequestreview-1074398630 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3526 |
| provisioner/terraform/executor_unix.go | https://github.com/coder/coder/pull/3526/files/211b7f9f179671878611a2d0c15300b632135c16#diff-e1c8f06adf3d0b1ace26c91450141435345084426e9d58bbfc18e8ec8c7745c1 |
| Please reload this page | https://github.com/coder/coder/pull/3526 |
| provisioner/terraform/provision.go | https://github.com/coder/coder/pull/3526/files/211b7f9f179671878611a2d0c15300b632135c16#diff-dca5a09c8a826c7364d136c1eedf2e33534b9ec33da1cfe008f2d7ff669f95bf |
| Please reload this page | https://github.com/coder/coder/pull/3526 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Aug 16, 2022 | https://github.com/coder/coder/pull/3526#issuecomment-1216882033 |
| Please reload this page | https://github.com/coder/coder/pull/3526 |
| Please reload this page | https://github.com/coder/coder/pull/3526 |
| https://github.com/kylecarbs |
| kylecarbs | https://github.com/kylecarbs |
|
Aug 16, 2022
| https://github.com/coder/coder/pull/3526#pullrequestreview-1074450718 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3526/files/211b7f9f179671878611a2d0c15300b632135c16 |
| mafredri | https://github.com/mafredri |
| August 16, 2022 19:58 | https://github.com/coder/coder/pull/3526#commits-pushed-3121f6a |
|
| https://github.com/mafredri |
| fix: Amend PR comments | https://github.com/coder/coder/pull/3526/commits/3121f6ac57360f6712967c5f5920bc1b72789f2a |
| 3121f6a | https://github.com/coder/coder/pull/3526/commits/3121f6ac57360f6712967c5f5920bc1b72789f2a |
|
| https://github.com/mafredri |
| chore: Revert proto changes | https://github.com/coder/coder/pull/3526/commits/27fe6f0f84cf551237128c3ae0a919154c288712 |
| 27fe6f0 | https://github.com/coder/coder/pull/3526/commits/27fe6f0f84cf551237128c3ae0a919154c288712 |
|
| https://github.com/mafredri |
| chore: Revert newline in proto | https://github.com/coder/coder/pull/3526/commits/1d7f825236560caea4aeae98d0952a901e0d42b8 |
| 1d7f825 | https://github.com/coder/coder/pull/3526/commits/1d7f825236560caea4aeae98d0952a901e0d42b8 |
|
| https://github.com/mafredri |
| fix: Remove incorrect minimumTerraformVersion variable | https://github.com/coder/coder/pull/3526/commits/5cbb7123fd8eff04b4eacfccf49fc35f4a6ac10d |
| 5cbb712 | https://github.com/coder/coder/pull/3526/commits/5cbb7123fd8eff04b4eacfccf49fc35f4a6ac10d |
|
| https://github.com/mafredri |
| fix: Add ExitTimeout to terraform.ServeOptions | https://github.com/coder/coder/pull/3526/commits/3e4005ad10853c35fb7d127f91f3c874b90d8685 |
| 3e4005a | https://github.com/coder/coder/pull/3526/commits/3e4005ad10853c35fb7d127f91f3c874b90d8685 |
|
| https://github.com/mafredri |
| fix: Add test for interrupt/cancellation | https://github.com/coder/coder/pull/3526/commits/685c58326192076bc7213c38f7b36cb8f2777083 |
| 685c583 | https://github.com/coder/coder/pull/3526/commits/685c58326192076bc7213c38f7b36cb8f2777083 |
|
| https://github.com/mafredri |
| Allow init to return provision complete response | https://github.com/coder/coder/pull/3526/commits/3303ee1a7ba1887029ca6ee966af8a6bc249d961 |
| 3303ee1 | https://github.com/coder/coder/pull/3526/commits/3303ee1a7ba1887029ca6ee966af8a6bc249d961 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
|
Aug 17, 2022
| https://github.com/coder/coder/pull/3526#pullrequestreview-1075655536 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3526/files/3303ee1a7ba1887029ca6ee966af8a6bc249d961 |
| provisioner/terraform/provision.go | https://github.com/coder/coder/pull/3526/files/3303ee1a7ba1887029ca6ee966af8a6bc249d961#diff-dca5a09c8a826c7364d136c1eedf2e33534b9ec33da1cfe008f2d7ff669f95bf |
| mafredri | https://github.com/mafredri |
| Aug 17, 2022 | https://github.com/coder/coder/pull/3526#discussion_r947883583 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @kylecarbs | https://github.com/kylecarbs |
| Please reload this page | https://github.com/coder/coder/pull/3526 |
| kylecarbs | https://github.com/kylecarbs |
| Aug 17, 2022 | https://github.com/coder/coder/pull/3526#discussion_r948355135 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3526 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Aug 17, 2022 | https://github.com/coder/coder/pull/3526#issuecomment-1217961502 |
| Please reload this page | https://github.com/coder/coder/pull/3526 |
| mafredri | https://github.com/mafredri |
| August 17, 2022 15:46 | https://github.com/coder/coder/pull/3526#commits-pushed-db41a65 |
|
| https://github.com/mafredri |
| Add testdata script | https://github.com/coder/coder/pull/3526/commits/db41a6518ca16086abc5c8ab5dcae7fd69a15fbb |
| db41a65 | https://github.com/coder/coder/pull/3526/commits/db41a6518ca16086abc5c8ab5dcae7fd69a15fbb |
|
| https://github.com/mafredri |
| Remove superfluous require | https://github.com/coder/coder/pull/3526/commits/80a4912e9e9426a62929a870daa2d6fc573d4377 |
| 80a4912 | https://github.com/coder/coder/pull/3526/commits/80a4912e9e9426a62929a870daa2d6fc573d4377 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| f142345 | https://github.com/coder/coder/commit/f1423450bda74ba1e5258bc11a09c3bf61e2ee89 |
| Aug 18, 2022 | https://github.com/coder/coder/pull/3526#event-7214712948 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| August 18, 2022 14:03 | https://github.com/coder/coder/pull/3526#event-7214713047 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
|
Aug 18, 2022
| https://github.com/coder/coder/pull/3526#ref-issue-1285748126 |
|
Workspace goes to failed state and cannot be started, stopped or deleted after cancel-start->stop->start actions
#2683
| https://github.com/coder/coder/issues/2683 |
| https://github.com/kylecarbs |
| kylecarbs | https://github.com/kylecarbs |
|
Aug 24, 2022
| https://github.com/coder/coder/pull/3526#ref-issue-1267912329 |
|
What to do when workspace is state-bricked?
#2256
| https://github.com/coder/coder/issues/2256 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3526 |
|
| https://github.com/kylecarbs |
|
kylecarbs
| https://github.com/kylecarbs |
|
| https://github.com/coder/coder/pull/3526/files/3303ee1a7ba1887029ca6ee966af8a6bc249d961 |
|
| https://github.com/spikecurtis |
|
spikecurtis
| https://github.com/spikecurtis |
| Please reload this page | https://github.com/coder/coder/pull/3526 |
|
| https://github.com/mafredri |
|
mafredri
| https://github.com/mafredri |
| Please reload this page | https://github.com/coder/coder/pull/3526 |
|
| https://github.com/mafredri |
|
| https://github.com/kylecarbs |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |