| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:52eca15c-15d8-4500-7964-2dd66aea858f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EA18:17FB7:17FC32D:1E5C7DC:6B01790A |
| html-safe-nonce | 56c1718704c7b1206b8480ef0bcea7d979b634095959705232d539eeaee44af3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTE4OjE3RkI3OjE3RkMzMkQ6MUU1QzdEQzo2QjAxNzkwQSIsInZpc2l0b3JfaWQiOiIyNjI0ODAyNTA4MDY4OTc2OTA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1d45453abe9a009a7ee2af7f1d65ff19288b56fd624602beb99e128b829bd7cd |
| hovercard-subject-tag | pull_request:1009652069 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/3246/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2f8b2091a7ff1e57c9d3d62a6e81533ddc6be1a684bde890645e4b0c316e72e0/coder/coder/pull/3246 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2f8b2091a7ff1e57c9d3d62a6e81533ddc6be1a684bde890645e4b0c316e72e0/coder/coder/pull/3246 |
| og:image:alt | This commit improves the coder server shutdown procedure so that all
triggers for shutdown do so in a graceful way without skipping any
steps.
We also improve cancellation and shutdown of services ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mafredri |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/3246#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3246 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3246 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/3246 |
| Reload | https://github.com/coder/coder/pull/3246 |
| Reload | https://github.com/coder/coder/pull/3246 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| mafredri | https://github.com/mafredri |
| main | https://github.com/coder/coder/tree/main |
| mafredri/coder-server-shutdown-improvements | https://github.com/coder/coder/tree/mafredri/coder-server-shutdown-improvements |
| Conversation | https://github.com/coder/coder/pull/3246 |
| Commits5 (5) | https://github.com/coder/coder/pull/3246/commits |
| Checks | https://github.com/coder/coder/pull/3246/checks |
| Files changed | https://github.com/coder/coder/pull/3246/files |
| fix: Improve coder server shutdown procedure | https://github.com/coder/coder/pull/3246#top |
| mafredri | https://github.com/mafredri |
| main | https://github.com/coder/coder/tree/main |
| mafredri/coder-server-shutdown-improvements | https://github.com/coder/coder/tree/mafredri/coder-server-shutdown-improvements |
|
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Jul 27, 2022 | https://github.com/coder/coder/pull/3246#issue-1319549518 |
| #3245 | https://github.com/coder/coder/issues/3245 |
| hashicorp/hc-install#68 | https://github.com/hashicorp/hc-install/pull/68 |
| Please reload this page | https://github.com/coder/coder/pull/3246 |
|
| https://github.com/mafredri |
| fix: Improve coder server shutdown procedure | https://github.com/coder/coder/pull/3246/commits/c6108ec930fdc9d29ff7566312a2e402da8767a8 |
| c6108ec | https://github.com/coder/coder/pull/3246/commits/c6108ec930fdc9d29ff7566312a2e402da8767a8 |
| #3245 | https://github.com/coder/coder/issues/3245 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| Jul 27, 2022 | https://github.com/coder/coder/pull/3246#event-7072894656 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| July 27, 2022 13:14 | https://github.com/coder/coder/pull/3246#event-7072894741 |
|
| https://github.com/mafredri |
| fix: Commit the test fixes | https://github.com/coder/coder/pull/3246/commits/e30c335ac9500281d342e8e967cd036f21a7f913 |
| e30c335 | https://github.com/coder/coder/pull/3246/commits/e30c335ac9500281d342e8e967cd036f21a7f913 |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
|
Jul 27, 2022
| https://github.com/coder/coder/pull/3246#pullrequestreview-1052489684 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3246/files/e30c335ac9500281d342e8e967cd036f21a7f913 |
| cli/server.go | https://github.com/coder/coder/pull/3246/files/c6108ec930fdc9d29ff7566312a2e402da8767a8#diff-9eaf2cc14b6524865ff24229bdeddfefc132e366ebdf33971774f68570dfb949 |
| johnstcn | https://github.com/johnstcn |
| Jul 27, 2022 | https://github.com/coder/coder/pull/3246#discussion_r931051492 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3246 |
| cli/server.go | https://github.com/coder/coder/pull/3246/files/c6108ec930fdc9d29ff7566312a2e402da8767a8#diff-9eaf2cc14b6524865ff24229bdeddfefc132e366ebdf33971774f68570dfb949 |
| johnstcn | https://github.com/johnstcn |
| Jul 27, 2022 | https://github.com/coder/coder/pull/3246#discussion_r931055450 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3246 |
| mafredri | https://github.com/mafredri |
| Jul 27, 2022 | https://github.com/coder/coder/pull/3246#discussion_r931064579 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3246 |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
|
Jul 27, 2022
| https://github.com/coder/coder/pull/3246#pullrequestreview-1052509411 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3246/files/e30c335ac9500281d342e8e967cd036f21a7f913 |
| mafredri | https://github.com/mafredri |
| July 27, 2022 16:32 | https://github.com/coder/coder/pull/3246#commits-pushed-7e0b74a |
|
| https://github.com/mafredri |
| fix: Devtunnel doesn't return error, just closes the channel | https://github.com/coder/coder/pull/3246/commits/7e0b74af706174c958391fd0773ed626cbf549df |
| 7e0b74a | https://github.com/coder/coder/pull/3246/commits/7e0b74af706174c958391fd0773ed626cbf549df |
|
| https://github.com/mafredri |
| fix: Only close provisionerd listener when created in Serve | https://github.com/coder/coder/pull/3246/commits/23c86b5130559b21ad5f0eeef67b4aabb1461fb5 |
| 23c86b5 | https://github.com/coder/coder/pull/3246/commits/23c86b5130559b21ad5f0eeef67b4aabb1461fb5 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
|
Jul 27, 2022
| https://github.com/coder/coder/pull/3246#pullrequestreview-1052541002 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3246/files/23c86b5130559b21ad5f0eeef67b4aabb1461fb5 |
| cli/server.go | https://github.com/coder/coder/pull/3246/files/23c86b5130559b21ad5f0eeef67b4aabb1461fb5#diff-9eaf2cc14b6524865ff24229bdeddfefc132e366ebdf33971774f68570dfb949 |
| mafredri | https://github.com/mafredri |
| Jul 27, 2022 | https://github.com/coder/coder/pull/3246#discussion_r931086617 |
| Please reload this page | https://github.com/coder/coder/pull/3246 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3246 |
| https://github.com/kylecarbs |
| kylecarbs | https://github.com/kylecarbs |
|
Jul 27, 2022
| https://github.com/coder/coder/pull/3246#pullrequestreview-1052541995 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3246/files/23c86b5130559b21ad5f0eeef67b4aabb1461fb5 |
| kylecarbs | https://github.com/kylecarbs |
| https://github.com/coder/coder/pull/3246#pullrequestreview-1052541995 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3246 |
|
| https://github.com/mafredri |
| fix: Handle closed ticker in lifecycle executor | https://github.com/coder/coder/pull/3246/commits/1e062bbd29cdb6313821690ac639b7303dc30611 |
| 1e062bb | https://github.com/coder/coder/pull/3246/commits/1e062bbd29cdb6313821690ac639b7303dc30611 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| d27076c | https://github.com/coder/coder/commit/d27076cac7d32b41a3ae2e15ceac667a23e2b801 |
| Jul 27, 2022 | https://github.com/coder/coder/pull/3246#event-7073984368 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
| July 27, 2022 15:21 | https://github.com/coder/coder/pull/3246#event-7073984480 |
| https://github.com/ThomasK33 |
| ThomasK33 | https://github.com/ThomasK33 |
|
Nov 13, 2026
| https://github.com/coder/coder/pull/3246#ref-pullrequest-6363646828 |
|
fix(coderd/telemetry): give the reporter its own HTTP transport
#32160
| https://github.com/coder/coder/pull/32160 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3246 |
|
| https://github.com/johnstcn |
|
johnstcn
| https://github.com/johnstcn |
|
| https://github.com/coder/coder/pull/3246/files/e30c335ac9500281d342e8e967cd036f21a7f913 |
|
| https://github.com/kylecarbs |
|
kylecarbs
| https://github.com/kylecarbs |
|
| https://github.com/coder/coder/pull/3246/files/23c86b5130559b21ad5f0eeef67b4aabb1461fb5 |
| Please reload this page | https://github.com/coder/coder/pull/3246 |
|
| https://github.com/mafredri |
|
mafredri
| https://github.com/mafredri |
|
Refactor coder server shutdown procedure and allow TestServer tests to pass goleaks detection
| https://github.com/coder/coder/issues/3245 |
| Please reload this page | https://github.com/coder/coder/pull/3246 |
|
| https://github.com/mafredri |
|
| https://github.com/johnstcn |
|
| https://github.com/kylecarbs |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |