René's URL Explorer Experiment


Title: fix: handle all auth API errors by AbhineetJain · Pull Request #3241 · coder/coder · GitHub

Open Graph Title: fix: handle all auth API errors by AbhineetJain · Pull Request #3241 · coder/coder

X Title: fix: handle all auth API errors by AbhineetJain · Pull Request #3241 · coder/coder

Description: Building on #3190, this PR handles all the remaining auth API errors: getUser Will handle in a separate PR checkPermissions getSSHKey regenerateSSHKey Subtasks display the relevant errors using the ErrorSummary component. add more stories for Sign in form. fix unit tests for SSH Key page. add stories for SSH Key page. Makes more progress towards #3088. Leaves handling getUserError now. Screenshots getSSHKey regenerateSSHKey

Open Graph Description: Building on #3190, this PR handles all the remaining auth API errors: getUser Will handle in a separate PR checkPermissions getSSHKey regenerateSSHKey Subtasks display the relevant errors using...

X Description: Building on #3190, this PR handles all the remaining auth API errors: getUser Will handle in a separate PR checkPermissions getSSHKey regenerateSSHKey Subtasks display the relevant errors using...

Opengraph URL: https://github.com/coder/coder/pull/3241

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:166f15eb-929e-001e-3d11-2bca9362a341
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8FEC:154D88:20DE7A5:2A04711:6B01B688
html-safe-nonce341f585f728efd45f75eed7334de89dc1bc95360fd6246cdb20e17a270c2d0b3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RkVDOjE1NEQ4ODoyMERFN0E1OjJBMDQ3MTE6NkIwMUI2ODgiLCJ2aXNpdG9yX2lkIjoiNjk4MDkyMTc0OTI3MDUwMzc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9507068d1e4af7a1a28ae163da899b768990036a4d18821f40112fc2d820099a
hovercard-subject-tagpull_request:1009061267
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/coder/pull/3241/files
twitter:imagehttps://avatars.githubusercontent.com/u/7511231?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7511231?s=400&v=4
og:image:altBuilding on #3190, this PR handles all the remaining auth API errors: getUser Will handle in a separate PR checkPermissions getSSHKey regenerateSSHKey Subtasks display the relevant errors using...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/coder/coder/pull/3241/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3241%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3241%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/3241/files
Reloadhttps://github.com/coder/coder/pull/3241/files
Reloadhttps://github.com/coder/coder/pull/3241/files
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcoder%2Fcoder%2Fissues%2Fnew%2Fchoose
AbhineetJainhttps://github.com/AbhineetJain
mainhttps://github.com/coder/coder/tree/main
abhineetjain/auth-service-unused-errorshttps://github.com/coder/coder/tree/abhineetjain/auth-service-unused-errors
Conversation 14 https://github.com/coder/coder/pull/3241
Commits 7 https://github.com/coder/coder/pull/3241/commits
Checks 0 https://github.com/coder/coder/pull/3241/checks
Files changed https://github.com/coder/coder/pull/3241/files
Please reload this pagehttps://github.com/coder/coder/pull/3241/files
fix: handle all auth API errors https://github.com/coder/coder/pull/3241/files#top
Show all changes 7 commits https://github.com/coder/coder/pull/3241/files
6ae13b1 fix: show errors on SSH Key page AbhineetJain Jul 26, 2022 https://github.com/coder/coder/pull/3241/commits/6ae13b12f12ee54e93e3af64002f1fcf7c5efd79
c37b4ec handle all auth api errors AbhineetJain Jul 26, 2022 https://github.com/coder/coder/pull/3241/commits/c37b4ece6d679fa8daae315b52f8d899c756db4e
865c1c5 add stories, refactor code AbhineetJain Jul 28, 2022 https://github.com/coder/coder/pull/3241/commits/865c1c50d33f1e7ad9edefd51b1d7dca45c78687
c41fb43 Merge branch 'main' into abhineetjain/auth-service-unused-errors AbhineetJain Jul 28, 2022 https://github.com/coder/coder/pull/3241/commits/c41fb43cf5b12e9c578a07cd4b80d7783b108f2d
3ce260a remove getUserError AbhineetJain Jul 28, 2022 https://github.com/coder/coder/pull/3241/commits/3ce260ac8b06920c7d22eeed163c72cb351c2cb3
dadce4b Merge branch 'main' into abhineetjain/auth-service-unused-errors AbhineetJain Jul 28, 2022 https://github.com/coder/coder/pull/3241/commits/dadce4b2f2954aa0ebc902f704a466754c26ef35
3dbd3f3 use makeMockApiError helper AbhineetJain Jul 28, 2022 https://github.com/coder/coder/pull/3241/commits/3dbd3f34c9b48e7ceee466bdd25352f057609f13
Clear filters https://github.com/coder/coder/pull/3241/files
Please reload this pagehttps://github.com/coder/coder/pull/3241/files
Please reload this pagehttps://github.com/coder/coder/pull/3241/files
SignInForm.stories.tsx https://github.com/coder/coder/pull/3241/files#diff-dc3ea09b75d450717263a7d3469267d6385267317525ec28087f7308e2e7ed5c
SignInForm.tsx https://github.com/coder/coder/pull/3241/files#diff-2581fc5a75919683bb7cb53c67372a7be22e60d9d57f80d523daadb7dda3b475
LoginPage.test.tsx https://github.com/coder/coder/pull/3241/files#diff-8919e53da91911dd074e42fff2db2ad82e77ac76c1b74c581b87d6f91b3ca81b
LoginPage.tsx https://github.com/coder/coder/pull/3241/files#diff-be2f52ca6309a5b06781700a9eaed19bab0ee295fff02523ad9346d7352bfe42
SSHKeysPage.test.tsx https://github.com/coder/coder/pull/3241/files#diff-4d87b17cc7b74b0a29110f34e6d915d2c93471e2651329130be6a44fa9ed8e42
SSHKeysPage.tsx https://github.com/coder/coder/pull/3241/files#diff-28718cb8e0d21af1db2540d9f68e588f41f8284c7ef2bd9ab72417f9742ff349
SSHKeysPageView.stories.tsx https://github.com/coder/coder/pull/3241/files#diff-561ac09abbe1d087ab402660de60b61d0c90697794c7c5cf297b07278a27f15a
SSHKeysPageView.tsx https://github.com/coder/coder/pull/3241/files#diff-bd22b90dc37e9670aef8835667e84426e97571e28e5b956cc183ac09c6a57a44
authXService.ts https://github.com/coder/coder/pull/3241/files#diff-b0657ae21106bafcf956bdd0ff5b4b0aa547390c48f8ac500102688f3f19e933
site/src/components/SignInForm/SignInForm.stories.tsxhttps://github.com/coder/coder/pull/3241/files#diff-dc3ea09b75d450717263a7d3469267d6385267317525ec28087f7308e2e7ed5c
View file https://github.com/coder/coder/blob/3dbd3f34c9b48e7ceee466bdd25352f057609f13/site/src/components/SignInForm/SignInForm.stories.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/3241/{{ revealButtonHref }}
https://github.com/coder/coder/pull/3241/files#diff-dc3ea09b75d450717263a7d3469267d6385267317525ec28087f7308e2e7ed5c
https://github.com/coder/coder/pull/3241/files#diff-dc3ea09b75d450717263a7d3469267d6385267317525ec28087f7308e2e7ed5c
https://github.com/coder/coder/pull/3241/files#diff-dc3ea09b75d450717263a7d3469267d6385267317525ec28087f7308e2e7ed5c
site/src/components/SignInForm/SignInForm.tsxhttps://github.com/coder/coder/pull/3241/files#diff-2581fc5a75919683bb7cb53c67372a7be22e60d9d57f80d523daadb7dda3b475
View file https://github.com/coder/coder/blob/3dbd3f34c9b48e7ceee466bdd25352f057609f13/site/src/components/SignInForm/SignInForm.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/3241/{{ revealButtonHref }}
https://github.com/coder/coder/pull/3241/files#diff-2581fc5a75919683bb7cb53c67372a7be22e60d9d57f80d523daadb7dda3b475
https://github.com/coder/coder/pull/3241/files#diff-2581fc5a75919683bb7cb53c67372a7be22e60d9d57f80d523daadb7dda3b475
https://github.com/coder/coder/pull/3241/files#diff-2581fc5a75919683bb7cb53c67372a7be22e60d9d57f80d523daadb7dda3b475
https://github.com/coder/coder/pull/3241/files#diff-2581fc5a75919683bb7cb53c67372a7be22e60d9d57f80d523daadb7dda3b475
https://github.com/coder/coder/pull/3241/files#diff-2581fc5a75919683bb7cb53c67372a7be22e60d9d57f80d523daadb7dda3b475
https://github.com/coder/coder/pull/3241/files#diff-2581fc5a75919683bb7cb53c67372a7be22e60d9d57f80d523daadb7dda3b475
site/src/pages/LoginPage/LoginPage.test.tsxhttps://github.com/coder/coder/pull/3241/files#diff-8919e53da91911dd074e42fff2db2ad82e77ac76c1b74c581b87d6f91b3ca81b
View file https://github.com/coder/coder/blob/3dbd3f34c9b48e7ceee466bdd25352f057609f13/site/src/pages/LoginPage/LoginPage.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/3241/{{ revealButtonHref }}
https://github.com/coder/coder/pull/3241/files#diff-8919e53da91911dd074e42fff2db2ad82e77ac76c1b74c581b87d6f91b3ca81b
https://github.com/coder/coder/pull/3241/files#diff-8919e53da91911dd074e42fff2db2ad82e77ac76c1b74c581b87d6f91b3ca81b
https://github.com/coder/coder/pull/3241/files#diff-8919e53da91911dd074e42fff2db2ad82e77ac76c1b74c581b87d6f91b3ca81b
site/src/pages/LoginPage/LoginPage.tsxhttps://github.com/coder/coder/pull/3241/files#diff-be2f52ca6309a5b06781700a9eaed19bab0ee295fff02523ad9346d7352bfe42
View file https://github.com/coder/coder/blob/3dbd3f34c9b48e7ceee466bdd25352f057609f13/site/src/pages/LoginPage/LoginPage.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/3241/{{ revealButtonHref }}
https://github.com/coder/coder/pull/3241/files#diff-be2f52ca6309a5b06781700a9eaed19bab0ee295fff02523ad9346d7352bfe42
https://github.com/coder/coder/pull/3241/files#diff-be2f52ca6309a5b06781700a9eaed19bab0ee295fff02523ad9346d7352bfe42
presleyphttps://github.com/presleyp
Jul 27, 2022https://github.com/coder/coder/pull/3241/files#r931117237
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3241/files
https://github.com/coder/coder/pull/3241/files#diff-be2f52ca6309a5b06781700a9eaed19bab0ee295fff02523ad9346d7352bfe42
site/src/pages/UserSettingsPage/SSHKeysPage/SSHKeysPage.test.tsxhttps://github.com/coder/coder/pull/3241/files#diff-4d87b17cc7b74b0a29110f34e6d915d2c93471e2651329130be6a44fa9ed8e42
View file https://github.com/coder/coder/blob/3dbd3f34c9b48e7ceee466bdd25352f057609f13/site/src/pages/UserSettingsPage/SSHKeysPage/SSHKeysPage.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/3241/{{ revealButtonHref }}
https://github.com/coder/coder/pull/3241/files#diff-4d87b17cc7b74b0a29110f34e6d915d2c93471e2651329130be6a44fa9ed8e42
https://github.com/coder/coder/pull/3241/files#diff-4d87b17cc7b74b0a29110f34e6d915d2c93471e2651329130be6a44fa9ed8e42
https://github.com/coder/coder/pull/3241/files#diff-4d87b17cc7b74b0a29110f34e6d915d2c93471e2651329130be6a44fa9ed8e42
https://github.com/coder/coder/pull/3241/files#diff-4d87b17cc7b74b0a29110f34e6d915d2c93471e2651329130be6a44fa9ed8e42
https://github.com/coder/coder/pull/3241/files#diff-4d87b17cc7b74b0a29110f34e6d915d2c93471e2651329130be6a44fa9ed8e42
https://github.com/coder/coder/pull/3241/files#diff-4d87b17cc7b74b0a29110f34e6d915d2c93471e2651329130be6a44fa9ed8e42
site/src/pages/UserSettingsPage/SSHKeysPage/SSHKeysPage.tsxhttps://github.com/coder/coder/pull/3241/files#diff-28718cb8e0d21af1db2540d9f68e588f41f8284c7ef2bd9ab72417f9742ff349
View file https://github.com/coder/coder/blob/3dbd3f34c9b48e7ceee466bdd25352f057609f13/site/src/pages/UserSettingsPage/SSHKeysPage/SSHKeysPage.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/3241/{{ revealButtonHref }}
https://github.com/coder/coder/pull/3241/files#diff-28718cb8e0d21af1db2540d9f68e588f41f8284c7ef2bd9ab72417f9742ff349
Please reload this pagehttps://github.com/coder/coder/pull/3241/files
https://github.com/coder/coder/pull/3241/files#diff-28718cb8e0d21af1db2540d9f68e588f41f8284c7ef2bd9ab72417f9742ff349
site/src/pages/UserSettingsPage/SSHKeysPage/SSHKeysPageView.stories.tsxhttps://github.com/coder/coder/pull/3241/files#diff-561ac09abbe1d087ab402660de60b61d0c90697794c7c5cf297b07278a27f15a
View file https://github.com/coder/coder/blob/3dbd3f34c9b48e7ceee466bdd25352f057609f13/site/src/pages/UserSettingsPage/SSHKeysPage/SSHKeysPageView.stories.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/coder/coder/pull/3241/{{ revealButtonHref }}
Please reload this pagehttps://github.com/coder/coder/pull/3241/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.