René's URL Explorer Experiment


Title: fix(agent/agentssh): report ssh disconnect when the connection closes by EhabY · Pull Request #32353 · coder/coder · GitHub

Open Graph Title: fix(agent/agentssh): report ssh disconnect when the connection closes by EhabY · Pull Request #32353 · coder/coder

X Title: fix(agent/agentssh): report ssh disconnect when the connection closes by EhabY · Pull Request #32353 · coder/coder

Description: Secure environments for developers and their agents - fix(agent/agentssh): report ssh disconnect when the connection closes by EhabY · Pull Request #32353 · coder/coder

Open Graph Description: Non-PTY SSH sessions (ssh -T, used by VS Code Remote-SSH and other editors) keep their process running after the client leaves, matching OpenSSH (#18519). The disconnect was only reported when that...

X Description: Non-PTY SSH sessions (ssh -T, used by VS Code Remote-SSH and other editors) keep their process running after the client leaves, matching OpenSSH (#18519). The disconnect was only reported when that...

Opengraph URL: https://github.com/coder/coder/pull/32353

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:58b4ddba-6294-e557-c639-dc9f297dad27
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD08:14F601:304CFA7:3D46676:6B01AE80
html-safe-nonce7f303e5e2fd27f09d85568349401559cc51b18999e0e29f98328dc95beb59882
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDA4OjE0RjYwMTozMDRDRkE3OjNENDY2NzY6NkIwMUFFODAiLCJ2aXNpdG9yX2lkIjoiODE5NDI4MzIzMjk4NDkzNjA2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc6a0b14eef5c815e6b1b697d01710c8a7c14052fed72a0e0c2446034becc526f
hovercard-subject-tagpull_request:5366485610
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/32353/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2cb1e879e36654f921c78c0bb254a91f20173ac8c35e80cf9e1faf0ef40345c5/coder/coder/pull/32353
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2cb1e879e36654f921c78c0bb254a91f20173ac8c35e80cf9e1faf0ef40345c5/coder/coder/pull/32353
og:image:altNon-PTY SSH sessions (ssh -T, used by VS Code Remote-SSH and other editors) keep their process running after the client leaves, matching OpenSSH (#18519). The disconnect was only reported when that...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameEhabY
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/32353#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F32353
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F32353
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/32353
Reloadhttps://github.com/coder/coder/pull/32353
Reloadhttps://github.com/coder/coder/pull/32353
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
EhabYhttps://github.com/EhabY
mainhttps://github.com/coder/coder/tree/main
fix/agentssh-report-disconnect-on-closehttps://github.com/coder/coder/tree/fix/agentssh-report-disconnect-on-close
Conversationhttps://github.com/coder/coder/pull/32353
Commits2 (2)https://github.com/coder/coder/pull/32353/commits
Checkshttps://github.com/coder/coder/pull/32353/checks
Files changedhttps://github.com/coder/coder/pull/32353/files
fix(agent/agentssh): report ssh disconnect when the connection closeshttps://github.com/coder/coder/pull/32353#top
EhabYhttps://github.com/EhabY
mainhttps://github.com/coder/coder/tree/main
fix/agentssh-report-disconnect-on-closehttps://github.com/coder/coder/tree/fix/agentssh-report-disconnect-on-close
https://github.com/EhabY
EhabYhttps://github.com/EhabY
Nov 17, 2026https://github.com/coder/coder/pull/32353#issue-6455877594
Please reload this pagehttps://github.com/coder/coder/pull/32353
#18519https://github.com/coder/coder/issues/18519
coder/ssh#8https://github.com/coder/ssh/pull/8
VS Code Desktop connection drops shortly after reconnecting #18519https://github.com/coder/coder/issues/18519
@EhabYhttps://github.com/EhabY
Please reload this pagehttps://github.com/coder/coder/pull/32353
https://github.com/EhabY
fix(agent/agentssh): report ssh disconnect when the connection closeshttps://github.com/coder/coder/pull/32353/commits/187b39c73037ee069b29923490a4a4bd4a0e68e1
187b39chttps://github.com/coder/coder/pull/32353/commits/187b39c73037ee069b29923490a4a4bd4a0e68e1
https://github.com/EhabY
EhabYhttps://github.com/EhabY
November 17, 2026 22:56https://github.com/coder/coder/pull/32353#event-36465180830
GitHub Actionshttps://github.com/apps/github-actions
https://github.com/EhabY
EhabYhttps://github.com/EhabY
November 17, 2026 22:56https://github.com/coder/coder/pull/32353#event-36465180890
GitHub Actionshttps://github.com/apps/github-actions
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
EhabYhttps://github.com/EhabY
Nov 17, 2026https://github.com/coder/coder/pull/32353#event-36465194084
fix: close the connection when keep-alives stop and allow per-connection settings coder/ssh#8 https://github.com/coder/ssh/pull/8
feat: close silent ssh connections and let clients shorten the keep-alive #32444 https://github.com/coder/coder/pull/32444
https://github.com/EhabY
EhabYhttps://github.com/EhabY
stack #32445https://github.com/coder/coder/stack/32445
November 19, 2026 12:37https://github.com/coder/coder/pull/32353#event-36649283526
https://github.com/EhabY
EhabYhttps://github.com/EhabY
November 19, 2026 12:43https://github.com/coder/coder/pull/32353#event-36649837410
https://github.com/EhabY
EhabYhttps://github.com/EhabY
deployedhttps://github.com/coder/coder/actions/runs/44526590443/job/135568683386
November 19, 2026 12:43https://github.com/coder/coder/pull/32353#event-36649846579
GitHub Actionshttps://github.com/apps/github-actions
https://github.com/ethanndickson
ethanndicksonhttps://github.com/ethanndickson
Nov 20, 2026 https://github.com/coder/coder/pull/32353#pullrequestreview-5986248172
View reviewed changes https://github.com/coder/coder/pull/32353/files/187b39c73037ee069b29923490a4a4bd4a0e68e1
agent/agentssh/agentssh.gohttps://github.com/coder/coder/pull/32353/files/187b39c73037ee069b29923490a4a4bd4a0e68e1#diff-e2fb60d4b313fc2ad42c37ce065c0c880e04615b339a843e14892338d0bb4396
Please reload this pagehttps://github.com/coder/coder/pull/32353
https://github.com/ethanndickson
ethanndicksonhttps://github.com/ethanndickson
Nov 20, 2026 https://github.com/coder/coder/pull/32353#pullrequestreview-5986251012
View reviewed changes https://github.com/coder/coder/pull/32353/files/187b39c73037ee069b29923490a4a4bd4a0e68e1
ethanndicksonhttps://github.com/ethanndickson
https://github.com/coder/coder/pull/32353#pullrequestreview-5986251012
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/32353
https://github.com/EhabY
refactor(agent/agentssh): report the disconnect with sync.Oncehttps://github.com/coder/coder/pull/32353/commits/28e96184a311f14a8e23a899cd3d2f08dde71c0a
28e9618https://github.com/coder/coder/pull/32353/commits/28e96184a311f14a8e23a899cd3d2f08dde71c0a
https://github.com/EhabY
EhabYhttps://github.com/EhabY
deployedhttps://github.com/coder/coder/actions/runs/44711360098/job/136203589884
November 20, 2026 09:30https://github.com/coder/coder/pull/32353#event-36753135559
GitHub Actionshttps://github.com/apps/github-actions
https://github.com/EhabY
EhabYhttps://github.com/EhabY
deployedhttps://github.com/coder/coder/actions/runs/44713712317/job/136211612667
November 20, 2026 09:47https://github.com/coder/coder/pull/32353#event-36754563559
GitHub Actionshttps://github.com/apps/github-actions
https://github.com/EhabY
EhabYhttps://github.com/EhabY
deployedhttps://github.com/coder/coder/actions/runs/44713726147/job/136211734777
November 20, 2026 09:47https://github.com/coder/coder/pull/32353#event-36754585021
GitHub Actionshttps://github.com/apps/github-actions
https://github.com/apps/linear-code
linear-codehttps://github.com/apps/linear-code
Nov 20, 2026https://github.com/coder/coder/pull/32353#issuecomment-7036631798
VSC-57https://linear.app/codercom/issue/VSC-57
Please reload this pagehttps://github.com/coder/coder/pull/32353
https://github.com/EhabY
EhabYhttps://github.com/EhabY
5d5d8b1https://github.com/coder/coder/commit/5d5d8b1723885ec67f1a14adb32bbab5868391d9
Nov 20, 2026https://github.com/coder/coder/pull/32353#event-36756001097
Please reload this pagehttps://github.com/coder/coder/pull/32353
https://github.com/EhabY
EhabYhttps://github.com/EhabY
November 20, 2026 10:04https://github.com/coder/coder/pull/32353#event-36756004554
https://github.com/EhabY
EhabYhttps://github.com/EhabY
had a problem deployinghttps://github.com/coder/coder/actions/runs/44716121291/job/136219867094
November 20, 2026 10:04https://github.com/coder/coder/pull/32353#event-36756009161
GitHub Actionshttps://github.com/apps/github-actions
https://github.com/EhabY
EhabYhttps://github.com/EhabY
deployedhttps://github.com/coder/coder/actions/runs/44716121384/job/136219868673
November 20, 2026 10:04https://github.com/coder/coder/pull/32353#event-36756009518
GitHub Actionshttps://github.com/apps/github-actions
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 20, 2026https://github.com/coder/coder/pull/32353#event-36756020182
Deployedhttps://github.com/coder/coder/actions/runs/44716121291/job/136219867094
EhabYhttps://github.com/EhabY
cleanup #274https://github.com/coder/coder/actions/runs/44716121291
Deployedhttps://github.com/coder/coder/actions/runs/44716121384/job/136219868673
EhabYhttps://github.com/EhabY
cla #260792https://github.com/coder/coder/actions/runs/44716121384
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F32353
https://github.com/ethanndickson
ethanndickson https://github.com/ethanndickson
https://github.com/coder/coder/pull/32353/files/187b39c73037ee069b29923490a4a4bd4a0e68e1
Please reload this pagehttps://github.com/coder/coder/pull/32353
https://github.com/EhabY
EhabY https://github.com/EhabY
Please reload this pagehttps://github.com/coder/coder/pull/32353
https://github.com/EhabY
https://github.com/ethanndickson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.