| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:174c7c60-0df3-3095-c259-4e6f16545f9b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D37C:1FE434:403944:54DBDF:6B019606 |
| html-safe-nonce | d6906cd5c60cb265a40afc99993fd0ac9510bacc84c5f6119fe755f3910f5aa6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzdDOjFGRTQzNDo0MDM5NDQ6NTREQkRGOjZCMDE5NjA2IiwidmlzaXRvcl9pZCI6IjE2NDQ3OTgxNTk1OTgxMTU5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8e4129e9e9eaf80a544ce7dd0b440995be06415cac25a25dc8bdd69807d1ab2c |
| hovercard-subject-tag | pull_request:1007878954 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/3192/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f20f5ddf2dc996a40c7faec506cabf6c1cf0b2060a80d465399201c9463e9669/coder/coder/pull/3192 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f20f5ddf2dc996a40c7faec506cabf6c1cf0b2060a80d465399201c9463e9669/coder/coder/pull/3192 |
| og:image:alt | Related to #3125 - JetBrains use the exit code of commands they run over SSH for logic, so it is important that we report them correctly. They also request a TTY so they can send interrupt signal... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | spikecurtis |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/coder git https://github.com/coder/coder.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 440752086 |
| octolytics-dimension-repository_nwo | coder/coder |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 440752086 |
| octolytics-dimension-repository_network_root_nwo | coder/coder |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/coder/pull/3192#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3192 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3192 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder |
| Reload | https://github.com/coder/coder/pull/3192 |
| Reload | https://github.com/coder/coder/pull/3192 |
| Reload | https://github.com/coder/coder/pull/3192 |
| coder | https://github.com/coder |
| coder | https://github.com/coder/coder |
| Code | https://github.com/coder/coder |
| Issues320 (320) | https://github.com/coder/coder/issues |
| Pull requests470 (470) | https://github.com/coder/coder/pulls |
| Discussions | https://github.com/coder/coder/discussions |
| Actions | https://github.com/coder/coder/actions |
| Projects | https://github.com/coder/coder/projects |
| Security and quality49 (49) | https://github.com/coder/coder/security |
| Insights | https://github.com/coder/coder/insights |
| https://github.com/coder/coder |
| spikecurtis | https://github.com/spikecurtis |
| main | https://github.com/coder/coder/tree/main |
| spike/3125_ssh_tty_exit_code | https://github.com/coder/coder/tree/spike/3125_ssh_tty_exit_code |
| Conversation | https://github.com/coder/coder/pull/3192 |
| Commits4 (4) | https://github.com/coder/coder/pull/3192/commits |
| Checks | https://github.com/coder/coder/pull/3192/checks |
| Files changed | https://github.com/coder/coder/pull/3192/files |
| Return proper exit code on ssh with TTY | https://github.com/coder/coder/pull/3192#top |
| spikecurtis | https://github.com/spikecurtis |
| main | https://github.com/coder/coder/tree/main |
| spike/3125_ssh_tty_exit_code | https://github.com/coder/coder/tree/spike/3125_ssh_tty_exit_code |
|
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| Jul 25, 2022 | https://github.com/coder/coder/pull/3192#issue-1317494591 |
| #3125 | https://github.com/coder/coder/issues/3125 |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| July 25, 2022 23:28 | https://github.com/coder/coder/pull/3192#event-7060464735 |
| https://github.com/johnstcn |
| johnstcn | https://github.com/johnstcn |
|
Jul 26, 2022
| https://github.com/coder/coder/pull/3192#pullrequestreview-1050604222 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3192/files |
| pty/start.go | https://github.com/coder/coder/pull/3192/files#diff-34e00b4bfd5b13963c945bc452779806c64e06361d5123c9538bec7d154cb93a |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
| pty/pty_other.go | https://github.com/coder/coder/pull/3192/files#diff-69466d76c921c4cf0c520fc3727240a84068a8406cd474c1846cd7c4f119d57c |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
| pty/start_other.go | https://github.com/coder/coder/pull/3192/files#diff-ff93b72d8d9c118b9cb6e8098f85c5477716037d96c5ba2ab31100824ef97679 |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
| https://github.com/mafredri |
| mafredri | https://github.com/mafredri |
|
Jul 26, 2022
| https://github.com/coder/coder/pull/3192#pullrequestreview-1050612951 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3192/files |
| pty/pty_other.go | https://github.com/coder/coder/pull/3192/files#diff-69466d76c921c4cf0c520fc3727240a84068a8406cd474c1846cd7c4f119d57c |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
| pty/pty.go | https://github.com/coder/coder/pull/3192/files#diff-5415eec43b82f22f20272f3329a526ff64658f5beb6dc4259088adf08492fdd1 |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
| agent/agent.go | https://github.com/coder/coder/pull/3192/files#diff-62b6ad581fe3a3059ae8c85ef0f31dde4092bfdecfa7d6857c470bcacaa8cc8b |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
| agent/agent.go | https://github.com/coder/coder/pull/3192/files#diff-62b6ad581fe3a3059ae8c85ef0f31dde4092bfdecfa7d6857c470bcacaa8cc8b |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| July 26, 2022 17:22 | https://github.com/coder/coder/pull/3192#event-7066861041 |
| https://github.com/kylecarbs |
| kylecarbs | https://github.com/kylecarbs |
|
Jul 26, 2022
| https://github.com/coder/coder/pull/3192#pullrequestreview-1050201233 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3192/files |
| agent/agent.go | https://github.com/coder/coder/pull/3192/files#diff-62b6ad581fe3a3059ae8c85ef0f31dde4092bfdecfa7d6857c470bcacaa8cc8b |
| kylecarbs | https://github.com/kylecarbs |
| Jul 25, 2022 | https://github.com/coder/coder/pull/3192#discussion_r929397993 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
| agent/agent.go | https://github.com/coder/coder/pull/3192/files#diff-62b6ad581fe3a3059ae8c85ef0f31dde4092bfdecfa7d6857c470bcacaa8cc8b |
| kylecarbs | https://github.com/kylecarbs |
| Jul 25, 2022 | https://github.com/coder/coder/pull/3192#discussion_r929398260 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
| https://github.com/kylecarbs |
| kylecarbs | https://github.com/kylecarbs |
|
Jul 26, 2022
| https://github.com/coder/coder/pull/3192#pullrequestreview-1051415540 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3192/files |
| pty/pty_other.go | https://github.com/coder/coder/pull/3192/files#diff-69466d76c921c4cf0c520fc3727240a84068a8406cd474c1846cd7c4f119d57c |
| kylecarbs | https://github.com/kylecarbs |
| Jul 26, 2022 | https://github.com/coder/coder/pull/3192#discussion_r930269901 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
| spikecurtis | https://github.com/spikecurtis |
| Jul 26, 2022 | https://github.com/coder/coder/pull/3192#discussion_r930278290 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
| kylecarbs | https://github.com/kylecarbs |
| Jul 27, 2022 | https://github.com/coder/coder/pull/3192#discussion_r931205638 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
| spikecurtis | https://github.com/spikecurtis |
| Jul 27, 2022 | https://github.com/coder/coder/pull/3192#discussion_r931207959 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
|
| https://github.com/spikecurtis |
| Return proper exit code on ssh with TTY | https://github.com/coder/coder/pull/3192/commits/b60d811e39bd48d4fe3910efc28d0e6d6cd8cfbe |
| b60d811 | https://github.com/coder/coder/pull/3192/commits/b60d811e39bd48d4fe3910efc28d0e6d6cd8cfbe |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| force-pushed | https://github.com/coder/coder/compare/b4ba237d1a7bcf8875034b7fbd61d5225f2b7fe2..b60d811e39bd48d4fe3910efc28d0e6d6cd8cfbe |
| b4ba237 | https://github.com/coder/coder/commit/b4ba237d1a7bcf8875034b7fbd61d5225f2b7fe2 |
| b60d811 | https://github.com/coder/coder/commit/b60d811e39bd48d4fe3910efc28d0e6d6cd8cfbe |
|
Compare
| https://github.com/coder/coder/compare/b4ba237d1a7bcf8875034b7fbd61d5225f2b7fe2..b60d811e39bd48d4fe3910efc28d0e6d6cd8cfbe |
| July 27, 2022 17:35 | https://github.com/coder/coder/pull/3192#event-7074931415 |
| spikecurtis | https://github.com/spikecurtis |
| July 27, 2022 10:57 | https://github.com/coder/coder/pull/3192#commits-pushed-ca93544 |
|
| https://github.com/spikecurtis |
| Fix Windows tests | https://github.com/coder/coder/pull/3192/commits/ca93544ec7cf76b0bb521d08a625e31bb34f406d |
| ca93544 | https://github.com/coder/coder/pull/3192/commits/ca93544ec7cf76b0bb521d08a625e31bb34f406d |
|
| https://github.com/spikecurtis |
| Fix windows tests | https://github.com/coder/coder/pull/3192/commits/c378faabbcff70cd710fce65472176e69c550756 |
| c378faa | https://github.com/coder/coder/pull/3192/commits/c378faabbcff70cd710fce65472176e69c550756 |
|
| https://github.com/spikecurtis |
| Check for nonzero exit code on kill | https://github.com/coder/coder/pull/3192/commits/ee781bd115a95b75ac5e624723f406bddf9b32ea |
| ee781bd | https://github.com/coder/coder/pull/3192/commits/ee781bd115a95b75ac5e624723f406bddf9b32ea |
| https://github.com/kylecarbs |
| kylecarbs | https://github.com/kylecarbs |
|
Jul 27, 2022
| https://github.com/coder/coder/pull/3192#pullrequestreview-1053073404 |
|
View reviewed changes
| https://github.com/coder/coder/pull/3192/files/ee781bd115a95b75ac5e624723f406bddf9b32ea |
| pty/pty.go | https://github.com/coder/coder/pull/3192/files/c378faabbcff70cd710fce65472176e69c550756#diff-5415eec43b82f22f20272f3329a526ff64658f5beb6dc4259088adf08492fdd1 |
| kylecarbs | https://github.com/kylecarbs |
| Jul 27, 2022 | https://github.com/coder/coder/pull/3192#discussion_r931472594 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| 36ffdce | https://github.com/coder/coder/commit/36ffdce0656fbb40af79c313b1c790baef68fb47 |
| Jul 27, 2022 | https://github.com/coder/coder/pull/3192#event-7075985384 |
| https://github.com/spikecurtis |
| spikecurtis | https://github.com/spikecurtis |
| July 27, 2022 19:23 | https://github.com/coder/coder/pull/3192#event-7075985525 |
|
Explain pty Process abstraction
#3254
| https://github.com/coder/coder/pull/3254 |
|
JetBrains Gateway 2022.2 RC doesn't work with Coder SSH
#3125
| https://github.com/coder/coder/issues/3125 |
| https://github.co/hiddenchars |
| https://github.com/coder/coder/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3192 |
|
| https://github.com/mafredri |
|
mafredri
| https://github.com/mafredri |
|
| https://github.com/coder/coder/pull/3192/files/50a88b000932ab6ca1586f7f61da2239e33c7924 |
|
| https://github.com/johnstcn |
|
johnstcn
| https://github.com/johnstcn |
|
| https://github.com/coder/coder/pull/3192/files/50a88b000932ab6ca1586f7f61da2239e33c7924 |
|
| https://github.com/kylecarbs |
|
kylecarbs
| https://github.com/kylecarbs |
|
| https://github.com/coder/coder/pull/3192/files/ee781bd115a95b75ac5e624723f406bddf9b32ea |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
| Please reload this page | https://github.com/coder/coder/pull/3192 |
|
| https://github.com/spikecurtis |
|
| https://github.com/mafredri |
|
| https://github.com/johnstcn |
|
| https://github.com/kylecarbs |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |