René's URL Explorer Experiment


Title: Return proper exit code on ssh with TTY by spikecurtis · Pull Request #3192 · coder/coder · GitHub

Open Graph Title: Return proper exit code on ssh with TTY by spikecurtis · Pull Request #3192 · coder/coder

X Title: Return proper exit code on ssh with TTY by spikecurtis · Pull Request #3192 · coder/coder

Description: Secure environments for developers and their agents - Return proper exit code on ssh with TTY by spikecurtis · Pull Request #3192 · coder/coder

Open Graph Description: Related to #3125 - JetBrains use the exit code of commands they run over SSH for logic, so it is important that we report them correctly. They also request a TTY so they can send interrupt signal...

X Description: Related to #3125 - JetBrains use the exit code of commands they run over SSH for logic, so it is important that we report them correctly. They also request a TTY so they can send interrupt signal...

Opengraph URL: https://github.com/coder/coder/pull/3192

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:174c7c60-0df3-3095-c259-4e6f16545f9b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD37C:1FE434:403944:54DBDF:6B019606
html-safe-nonced6906cd5c60cb265a40afc99993fd0ac9510bacc84c5f6119fe755f3910f5aa6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzdDOjFGRTQzNDo0MDM5NDQ6NTREQkRGOjZCMDE5NjA2IiwidmlzaXRvcl9pZCI6IjE2NDQ3OTgxNTk1OTgxMTU5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8e4129e9e9eaf80a544ce7dd0b440995be06415cac25a25dc8bdd69807d1ab2c
hovercard-subject-tagpull_request:1007878954
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/coder/3192/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f20f5ddf2dc996a40c7faec506cabf6c1cf0b2060a80d465399201c9463e9669/coder/coder/pull/3192
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f20f5ddf2dc996a40c7faec506cabf6c1cf0b2060a80d465399201c9463e9669/coder/coder/pull/3192
og:image:altRelated to #3125 - JetBrains use the exit code of commands they run over SSH for logic, so it is important that we report them correctly. They also request a TTY so they can send interrupt signal...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamespikecurtis
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/coder git https://github.com/coder/coder.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id440752086
octolytics-dimension-repository_nwocoder/coder
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id440752086
octolytics-dimension-repository_network_root_nwocoder/coder
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/coder/pull/3192#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3192
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3192
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcoder
Reloadhttps://github.com/coder/coder/pull/3192
Reloadhttps://github.com/coder/coder/pull/3192
Reloadhttps://github.com/coder/coder/pull/3192
coderhttps://github.com/coder
coderhttps://github.com/coder/coder
Codehttps://github.com/coder/coder
Issues320 (320)https://github.com/coder/coder/issues
Pull requests470 (470)https://github.com/coder/coder/pulls
Discussionshttps://github.com/coder/coder/discussions
Actionshttps://github.com/coder/coder/actions
Projectshttps://github.com/coder/coder/projects
Security and quality49 (49)https://github.com/coder/coder/security
Insightshttps://github.com/coder/coder/insights
https://github.com/coder/coder
spikecurtishttps://github.com/spikecurtis
mainhttps://github.com/coder/coder/tree/main
spike/3125_ssh_tty_exit_codehttps://github.com/coder/coder/tree/spike/3125_ssh_tty_exit_code
Conversationhttps://github.com/coder/coder/pull/3192
Commits4 (4)https://github.com/coder/coder/pull/3192/commits
Checkshttps://github.com/coder/coder/pull/3192/checks
Files changedhttps://github.com/coder/coder/pull/3192/files
Return proper exit code on ssh with TTYhttps://github.com/coder/coder/pull/3192#top
spikecurtishttps://github.com/spikecurtis
mainhttps://github.com/coder/coder/tree/main
spike/3125_ssh_tty_exit_codehttps://github.com/coder/coder/tree/spike/3125_ssh_tty_exit_code
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
Jul 25, 2022https://github.com/coder/coder/pull/3192#issue-1317494591
#3125https://github.com/coder/coder/issues/3125
Please reload this pagehttps://github.com/coder/coder/pull/3192
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
July 25, 2022 23:28https://github.com/coder/coder/pull/3192#event-7060464735
https://github.com/johnstcn
johnstcnhttps://github.com/johnstcn
Jul 26, 2022 https://github.com/coder/coder/pull/3192#pullrequestreview-1050604222
View reviewed changes https://github.com/coder/coder/pull/3192/files
pty/start.gohttps://github.com/coder/coder/pull/3192/files#diff-34e00b4bfd5b13963c945bc452779806c64e06361d5123c9538bec7d154cb93a
Please reload this pagehttps://github.com/coder/coder/pull/3192
pty/pty_other.gohttps://github.com/coder/coder/pull/3192/files#diff-69466d76c921c4cf0c520fc3727240a84068a8406cd474c1846cd7c4f119d57c
Please reload this pagehttps://github.com/coder/coder/pull/3192
pty/start_other.gohttps://github.com/coder/coder/pull/3192/files#diff-ff93b72d8d9c118b9cb6e8098f85c5477716037d96c5ba2ab31100824ef97679
Please reload this pagehttps://github.com/coder/coder/pull/3192
https://github.com/mafredri
mafredrihttps://github.com/mafredri
Jul 26, 2022 https://github.com/coder/coder/pull/3192#pullrequestreview-1050612951
View reviewed changes https://github.com/coder/coder/pull/3192/files
pty/pty_other.gohttps://github.com/coder/coder/pull/3192/files#diff-69466d76c921c4cf0c520fc3727240a84068a8406cd474c1846cd7c4f119d57c
Please reload this pagehttps://github.com/coder/coder/pull/3192
pty/pty.gohttps://github.com/coder/coder/pull/3192/files#diff-5415eec43b82f22f20272f3329a526ff64658f5beb6dc4259088adf08492fdd1
Please reload this pagehttps://github.com/coder/coder/pull/3192
agent/agent.gohttps://github.com/coder/coder/pull/3192/files#diff-62b6ad581fe3a3059ae8c85ef0f31dde4092bfdecfa7d6857c470bcacaa8cc8b
Please reload this pagehttps://github.com/coder/coder/pull/3192
agent/agent.gohttps://github.com/coder/coder/pull/3192/files#diff-62b6ad581fe3a3059ae8c85ef0f31dde4092bfdecfa7d6857c470bcacaa8cc8b
Please reload this pagehttps://github.com/coder/coder/pull/3192
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
July 26, 2022 17:22https://github.com/coder/coder/pull/3192#event-7066861041
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
Jul 26, 2022 https://github.com/coder/coder/pull/3192#pullrequestreview-1050201233
View reviewed changes https://github.com/coder/coder/pull/3192/files
agent/agent.gohttps://github.com/coder/coder/pull/3192/files#diff-62b6ad581fe3a3059ae8c85ef0f31dde4092bfdecfa7d6857c470bcacaa8cc8b
kylecarbshttps://github.com/kylecarbs
Jul 25, 2022https://github.com/coder/coder/pull/3192#discussion_r929397993
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3192
agent/agent.gohttps://github.com/coder/coder/pull/3192/files#diff-62b6ad581fe3a3059ae8c85ef0f31dde4092bfdecfa7d6857c470bcacaa8cc8b
kylecarbshttps://github.com/kylecarbs
Jul 25, 2022https://github.com/coder/coder/pull/3192#discussion_r929398260
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3192
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
Jul 26, 2022 https://github.com/coder/coder/pull/3192#pullrequestreview-1051415540
View reviewed changes https://github.com/coder/coder/pull/3192/files
pty/pty_other.gohttps://github.com/coder/coder/pull/3192/files#diff-69466d76c921c4cf0c520fc3727240a84068a8406cd474c1846cd7c4f119d57c
kylecarbshttps://github.com/kylecarbs
Jul 26, 2022https://github.com/coder/coder/pull/3192#discussion_r930269901
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3192
spikecurtishttps://github.com/spikecurtis
Jul 26, 2022https://github.com/coder/coder/pull/3192#discussion_r930278290
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3192
kylecarbshttps://github.com/kylecarbs
Jul 27, 2022https://github.com/coder/coder/pull/3192#discussion_r931205638
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3192
spikecurtishttps://github.com/spikecurtis
Jul 27, 2022https://github.com/coder/coder/pull/3192#discussion_r931207959
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3192
https://github.com/spikecurtis
Return proper exit code on ssh with TTYhttps://github.com/coder/coder/pull/3192/commits/b60d811e39bd48d4fe3910efc28d0e6d6cd8cfbe
b60d811https://github.com/coder/coder/pull/3192/commits/b60d811e39bd48d4fe3910efc28d0e6d6cd8cfbe
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
force-pushedhttps://github.com/coder/coder/compare/b4ba237d1a7bcf8875034b7fbd61d5225f2b7fe2..b60d811e39bd48d4fe3910efc28d0e6d6cd8cfbe
b4ba237https://github.com/coder/coder/commit/b4ba237d1a7bcf8875034b7fbd61d5225f2b7fe2
b60d811https://github.com/coder/coder/commit/b60d811e39bd48d4fe3910efc28d0e6d6cd8cfbe
Compare https://github.com/coder/coder/compare/b4ba237d1a7bcf8875034b7fbd61d5225f2b7fe2..b60d811e39bd48d4fe3910efc28d0e6d6cd8cfbe
July 27, 2022 17:35https://github.com/coder/coder/pull/3192#event-7074931415
spikecurtishttps://github.com/spikecurtis
July 27, 2022 10:57https://github.com/coder/coder/pull/3192#commits-pushed-ca93544
https://github.com/spikecurtis
Fix Windows testshttps://github.com/coder/coder/pull/3192/commits/ca93544ec7cf76b0bb521d08a625e31bb34f406d
ca93544https://github.com/coder/coder/pull/3192/commits/ca93544ec7cf76b0bb521d08a625e31bb34f406d
https://github.com/spikecurtis
Fix windows testshttps://github.com/coder/coder/pull/3192/commits/c378faabbcff70cd710fce65472176e69c550756
c378faahttps://github.com/coder/coder/pull/3192/commits/c378faabbcff70cd710fce65472176e69c550756
https://github.com/spikecurtis
Check for nonzero exit code on killhttps://github.com/coder/coder/pull/3192/commits/ee781bd115a95b75ac5e624723f406bddf9b32ea
ee781bdhttps://github.com/coder/coder/pull/3192/commits/ee781bd115a95b75ac5e624723f406bddf9b32ea
https://github.com/kylecarbs
kylecarbshttps://github.com/kylecarbs
Jul 27, 2022 https://github.com/coder/coder/pull/3192#pullrequestreview-1053073404
View reviewed changes https://github.com/coder/coder/pull/3192/files/ee781bd115a95b75ac5e624723f406bddf9b32ea
pty/pty.gohttps://github.com/coder/coder/pull/3192/files/c378faabbcff70cd710fce65472176e69c550756#diff-5415eec43b82f22f20272f3329a526ff64658f5beb6dc4259088adf08492fdd1
kylecarbshttps://github.com/kylecarbs
Jul 27, 2022https://github.com/coder/coder/pull/3192#discussion_r931472594
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/coder/pull/3192
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
36ffdcehttps://github.com/coder/coder/commit/36ffdce0656fbb40af79c313b1c790baef68fb47
Jul 27, 2022https://github.com/coder/coder/pull/3192#event-7075985384
https://github.com/spikecurtis
spikecurtishttps://github.com/spikecurtis
July 27, 2022 19:23https://github.com/coder/coder/pull/3192#event-7075985525
Explain pty Process abstraction #3254 https://github.com/coder/coder/pull/3254
JetBrains Gateway 2022.2 RC doesn't work with Coder SSH #3125 https://github.com/coder/coder/issues/3125
https://github.co/hiddenchars
https://github.com/coder/coder/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcoder%2Fpull%2F3192
https://github.com/mafredri
mafredri https://github.com/mafredri
https://github.com/coder/coder/pull/3192/files/50a88b000932ab6ca1586f7f61da2239e33c7924
https://github.com/johnstcn
johnstcn https://github.com/johnstcn
https://github.com/coder/coder/pull/3192/files/50a88b000932ab6ca1586f7f61da2239e33c7924
https://github.com/kylecarbs
kylecarbs https://github.com/kylecarbs
https://github.com/coder/coder/pull/3192/files/ee781bd115a95b75ac5e624723f406bddf9b32ea
Please reload this pagehttps://github.com/coder/coder/pull/3192
Please reload this pagehttps://github.com/coder/coder/pull/3192
https://github.com/spikecurtis
https://github.com/mafredri
https://github.com/johnstcn
https://github.com/kylecarbs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.